@abaplint/core 2.102.42 → 2.102.44

package/build/abaplint.d.ts

@@ -3678,6 +3678,7 @@ export declare interface ISpaghettiScopeNode {
     };
     findClassDefinition(name: string): IClassDefinition | undefined;
     listClassDefinitions(): IClassDefinition[];
+    listInterfaceDefinitions(): IInterfaceDefinition[];
     findFormDefinition(name: string): IFormDefinition | undefined;
     listFormDefinitions(): IFormDefinition[];
     findInterfaceDefinition(name: string): IInterfaceDefinition | undefined;
@@ -5352,6 +5353,7 @@ export declare class SpaghettiScopeNode extends ScopeData implements ISpaghettiS
     findDeferred(name: string): Identifier | undefined;
     findClassDefinition(name: string): IClassDefinition | undefined;
     listClassDefinitions(): IClassDefinition[];
+    listInterfaceDefinitions(): IInterfaceDefinition[];
     findFormDefinition(name: string): IFormDefinition | undefined;
     listFormDefinitions(): IFormDefinition[];
     findInterfaceDefinition(name: string): IInterfaceDefinition | undefined;

package/build/src/abap/5_syntax/_type_utils.js

@@ -305,7 +305,8 @@ class TypeUtils {
             }
         }
         else if (source instanceof basic_1.IntegerType) {
-            if (target instanceof basic_1.StringType) {
+            if (target instanceof basic_1.StringType
+                || target instanceof basic_1.PackedType) {
                 return false;
             }
             else if (target instanceof basic_1.Integer8Type) {

package/build/src/abap/5_syntax/spaghetti_scope.js

@@ -86,6 +86,15 @@ class SpaghettiScopeNode extends ScopeData {
         }
         return ret;
     }
+    listInterfaceDefinitions() {
+        let search = this;
+        const ret = [];
+        while (search !== undefined) {
+            ret.push(...Object.values(search.getData().idefs));
+            search = search.getParent();
+        }
+        return ret;
+    }
     findFormDefinition(name) {
         let search = this;
         const upper = name.toUpperCase();

package/build/src/lsp/_lookup.js

@@ -1,6 +1,7 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.LSPLookup = void 0;
+/* eslint-disable max-len */
 const LServer = require("vscode-languageserver-types");
 const Statements = require("../abap/2_statements/statements");
 const Expressions = require("../abap/2_statements/expressions");
@@ -83,13 +84,14 @@ class LSPLookup {
             }
             return { hover: hoverValue, definition: location, implementation: location, definitionId: variable, scope: bottomScope };
         }
-        for (const c of bottomScope.listClassDefinitions()) {
+        // TODO: this can be optimized, no need to loop through all the defintions, the scope knows the name of the object?
+        for (const c of [...bottomScope.listClassDefinitions(), ...bottomScope.listInterfaceDefinitions()]) {
             for (const m of ((_a = c.getMethodDefinitions()) === null || _a === void 0 ? void 0 : _a.getAll()) || []) {
                 for (const p of ((_b = m.getParameters()) === null || _b === void 0 ? void 0 : _b.getAll()) || []) {
                     if (p.getStart().equals(cursor.token.getStart())) {
                         const found = _lsp_utils_1.LSPUtils.identiferToLocation(p);
                         return {
-                            hover: "Method Parameter, " + cursor.token.getStr(),
+                            hover: "Method Parameter: " + cursor.token.getStr().replace("!", ""),
                             definition: found,
                             definitionId: p,
                             implementation: undefined,
@@ -271,11 +273,12 @@ class LSPLookup {
         };
     }
     static findMethodDefinition(found, scope) {
-        var _a, _b, _c, _d;
+        var _a, _b, _c, _d, _e, _f, _g;
         if (scope === undefined) {
             return undefined;
         }
-        if (scope.getIdentifier().stype !== _scope_type_1.ScopeType.ClassDefinition
+        if ((scope.getIdentifier().stype !== _scope_type_1.ScopeType.ClassDefinition
+            && scope.getIdentifier().stype !== _scope_type_1.ScopeType.Interface)
             || !(found.snode.get() instanceof Statements.MethodDef)) {
             return undefined;
         }
@@ -291,8 +294,14 @@ class LSPLookup {
             || nameToken.getStart().getRow() !== found.token.getStart().getRow()) {
             return undefined;
         }
-        const def = (_d = (_c = (_b = scope.getParent()) === null || _b === void 0 ? void 0 : _b.findClassDefinition(scope.getIdentifier().sname)) === null || _c === void 0 ? void 0 : _c.getMethodDefinitions()) === null || _d === void 0 ? void 0 : _d.getByName(nameToken.getStr());
-        return def;
+        if (scope.getIdentifier().stype === _scope_type_1.ScopeType.ClassDefinition) {
+            const def = (_d = (_c = (_b = scope.getParent()) === null || _b === void 0 ? void 0 : _b.findClassDefinition(scope.getIdentifier().sname)) === null || _c === void 0 ? void 0 : _c.getMethodDefinitions()) === null || _d === void 0 ? void 0 : _d.getByName(nameToken.getStr());
+            return def;
+        }
+        else {
+            const def = (_g = (_f = (_e = scope.getParent()) === null || _e === void 0 ? void 0 : _e.findInterfaceDefinition(scope.getIdentifier().sname)) === null || _f === void 0 ? void 0 : _f.getMethodDefinitions()) === null || _g === void 0 ? void 0 : _g.getByName(nameToken.getStr());
+            return def;
+        }
     }
     static findFunctionModule(found) {
         if (!(found.snode.get() instanceof Statements.CallFunction)) {

package/build/src/registry.js

@@ -65,7 +65,7 @@ class Registry {
     }
     static abaplintVersion() {
         // magic, see build script "version.sh"
-        return "2.102.42";
+        return "2.102.44";
     }
     getDDICReferences() {
         return this.ddicReferences;

package/build/src/rules/check_subrc.js

@@ -142,7 +142,8 @@ FIND statement with MATCH COUNT is considered okay if subrc is not checked`,
             if (statement.get() instanceof _statement_1.Comment) {
                 continue;
             }
-            else if (statement.get() instanceof Statements.EndIf) {
+            else if (statement.get() instanceof Statements.EndIf
+                || statement.get() instanceof Statements.EndTestSeam) {
                 continue;
             }
             else {
@@ -169,7 +170,8 @@ FIND statement with MATCH COUNT is considered okay if subrc is not checked`,
                     return true;
                 }
             }
-            else if (statement.get() instanceof Statements.EndIf) {
+            else if (statement.get() instanceof Statements.EndIf
+                || statement.get() instanceof Statements.EndTestSeam) {
                 continue;
             }
             else {

package/build/src/rules/cloud_types.js

@@ -37,7 +37,12 @@ class CloudTypes {
     }
     run(obj) {
         if (this.reg.getConfig().getVersion() !== version_1.Version.Cloud
+            || obj instanceof Objects.ApplicationJobCatalogEntry
+            || obj instanceof Objects.ApplicationJobTemplate
             || obj instanceof Objects.AssignmentServiceToAuthorizationGroup
+            || obj instanceof Objects.ATCCheckCategory
+            || obj instanceof Objects.ATCCheckObject
+            || obj instanceof Objects.ATCCheckVariant
             || obj instanceof Objects.AuthorizationCheckField
             || obj instanceof Objects.AuthorizationObject
             || obj instanceof Objects.AuthorizationObjectExtension
@@ -45,11 +50,7 @@ class CloudTypes {
             || obj instanceof Objects.BusinessCatalog
             || obj instanceof Objects.BusinessCatalogAppAssignment
             || obj instanceof Objects.CDSMetadataExtension
-            || obj instanceof Objects.RestrictionField
             || obj instanceof Objects.Class
-            || obj instanceof Objects.OutboundService
-            || obj instanceof Objects.ApplicationJobCatalogEntry
-            || obj instanceof Objects.ApplicationJobTemplate
             || obj instanceof Objects.CommunicationScenario
             || obj instanceof Objects.DataControl
             || obj instanceof Objects.DataDefinition
@@ -61,11 +62,11 @@ class CloudTypes {
             || obj instanceof Objects.InboundService
             || obj instanceof Objects.Interface
             || obj instanceof Objects.LockObject
-            || obj instanceof Objects.ATCCheckCategory
-            || obj instanceof Objects.ATCCheckObject
-            || obj instanceof Objects.ATCCheckVariant
             || obj instanceof Objects.MessageClass
+            || obj instanceof Objects.NumberRange
+            || obj instanceof Objects.OutboundService
             || obj instanceof Objects.Package
+            || obj instanceof Objects.RestrictionField
             || obj instanceof Objects.RestrictionType
             || obj instanceof Objects.ServiceBinding
             || obj instanceof Objects.ServiceDefinition

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@abaplint/core",
-    "version": "2.102.42",
+    "version": "2.102.44",
     "description": "abaplint - Core API",
     "main": "build/src/index.js",
     "typings": "build/abaplint.d.ts",