@abaplint/core 2.102.2 → 2.102.3

package/build/src/abap/5_syntax/_procedural.js

@@ -12,6 +12,7 @@ const _typed_identifier_1 = require("../types/_typed_identifier");
 const basic_1 = require("../types/basic");
 const ddic_1 = require("../../ddic");
 const _object_oriented_1 = require("./_object_oriented");
+const _reference_1 = require("./_reference");
 class Procedural {
     constructor(reg, scope) {
         this.scope = scope;
@@ -85,7 +86,19 @@ class Procedural {
             if (param.type === undefined || param.type === "") {
                 found = new basic_1.AnyType();
             }
-            else {
+            else if (param.type.includes("=>")) {
+                // then its a type from global INTF or CLAS
+                const [clas, name] = param.type.split("=>");
+                const def = this.scope.findObjectDefinition(clas);
+                if (def) {
+                    const type = def.getTypeDefinitions().getByName(name);
+                    if (type) {
+                        this.scope.addReference(nameToken, type, _reference_1.ReferenceType.TypeReference, filename);
+                        found = type.getType();
+                    }
+                }
+            }
+            if (found === undefined) {
                 found = ddic.lookup(param.type).type;
             }
             if (param.direction === types_1.FunctionModuleParameterDirection.tables) {

package/build/src/abap/5_syntax/expressions/method_parameters.js

@@ -126,10 +126,12 @@ class MethodParameters {
         }
         for (const item of items) {
             const parameter = allImporting.find(p => p.getName().toUpperCase() === item.name);
+            const calculated = item.source.findFirstExpression(Expressions.MethodCallChain) !== undefined
+                || item.source.findFirstExpression(Expressions.ArithOperator) !== undefined;
             if (parameter === undefined) {
                 throw new Error("Method importing parameter \"" + item.name + "\" does not exist");
             }
-            else if (new _type_utils_1.TypeUtils(scope).isAssignableStrict(item.sourceType, parameter.getType()) === false) {
+            else if (new _type_utils_1.TypeUtils(scope).isAssignableStrict(item.sourceType, parameter.getType(), calculated) === false) {
                 throw new Error("Method parameter type not compatible, " + item.name);
             }
             this.requiredParameters.delete(item.name);

package/build/src/registry.js

@@ -65,7 +65,7 @@ class Registry {
     }
     static abaplintVersion() {
         // magic, see build script "version.sh"
-        return "2.102.2";
+        return "2.102.3";
     }
     getDDICReferences() {
         return this.ddicReferences;

package/build/src/rules/prefer_pragmas.js

@@ -42,6 +42,8 @@ class PreferPragmas extends _abap_rule_1.ABAPRule {
             shortDescription: `prefer pragmas over pseudo comments `,
             extendedInformation: `https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#prefer-pragmas-to-pseudo-comments`,
             tags: [_irule_1.RuleTag.SingleFile, _irule_1.RuleTag.Styleguide],
+            badExample: `DATA foo1 TYPE i. "#EC NEEDED`,
+            goodExample: `DATA foo2 TYPE i ##NEEDED.`,
         };
     }
     getConfig() {

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@abaplint/core",
-    "version": "2.102.2",
+    "version": "2.102.3",
     "description": "abaplint - Core API",
     "main": "build/src/index.js",
     "typings": "build/abaplint.d.ts",
@@ -63,7 +63,7 @@
         "typescript": "^5.1.6"
     },
     "dependencies": {
-        "fast-xml-parser": "^4.2.5",
+        "fast-xml-parser": "^4.2.6",
         "json5": "^2.2.3",
         "vscode-languageserver-types": "^3.17.3"
     }