@abaplint/core 2.102.17 → 2.102.19

package/build/abaplint.d.ts

@@ -1069,6 +1069,7 @@ declare class CloseDataset implements IStatement {
 
 declare type CodeLensSettings = {
     messageText: boolean;
+    dynamicExceptions: boolean;
 };
 
 declare class Collect implements IStatement {

package/build/src/abap/5_syntax/_type_utils.js

@@ -429,6 +429,12 @@ class TypeUtils {
             }
             return true;
         }
+        else if (target instanceof basic_1.SimpleType) {
+            if (source instanceof basic_1.ObjectReferenceType
+                || source instanceof basic_1.TableType) {
+                return false;
+            }
+        }
         return true;
     }
 }

package/build/src/abap/5_syntax/statements/class_data.js

@@ -13,6 +13,10 @@ class ClassData {
             if (found === undefined) {
                 return undefined;
             }
+            if ((found === null || found === void 0 ? void 0 : found.getType().isGeneric()) === true
+                && (found === null || found === void 0 ? void 0 : found.getType().containsVoid()) === false) {
+                throw new Error("DATA definition cannot be generic, " + found.getName());
+            }
             const meta = [...found.getMeta(), "static" /* IdentifierMeta.Static */];
             return new _typed_identifier_1.TypedIdentifier(found.getToken(), filename, found.getType(), meta, found.getValue());
         }

package/build/src/abap/5_syntax/statements/type.js

@@ -14,6 +14,10 @@ class Type {
         }
         const found = new basic_types_1.BasicTypes(filename, scope).simpleType(node, qualifiedNamePrefix);
         if (found) {
+            if ((found === null || found === void 0 ? void 0 : found.getType().isGeneric()) === true
+                && (found === null || found === void 0 ? void 0 : found.getType().containsVoid()) === false) {
+                throw new Error("TYPES definition cannot be generic, " + found.getName());
+            }
             return found;
         }
         const fallback = node.findFirstExpression(Expressions.NamespaceSimpleName);

package/build/src/lsp/code_lens.js

@@ -5,11 +5,13 @@ const LServer = require("vscode-languageserver-types");
 const _lsp_utils_1 = require("./_lsp_utils");
 const syntax_1 = require("../abap/5_syntax/syntax");
 const _abap_object_1 = require("../objects/_abap_object");
+const _reference_1 = require("../abap/5_syntax/_reference");
+const types_1 = require("../abap/types");
 class CodeLens {
     constructor(reg) {
         this.reg = reg;
     }
-    list(textDocument, settings = { messageText: true }) {
+    list(textDocument, settings = { messageText: true, dynamicExceptions: true }) {
         var _a;
         const file = _lsp_utils_1.LSPUtils.getABAPFile(this.reg, textDocument.uri);
         if (file === undefined) {
@@ -19,7 +21,7 @@ class CodeLens {
         if (obj === undefined || !(obj instanceof _abap_object_1.ABAPObject)) {
             return [];
         }
-        new syntax_1.SyntaxLogic(this.reg, obj).run();
+        const top = new syntax_1.SyntaxLogic(this.reg, obj).run().spaghetti.getTop();
         const ret = [];
         if (settings.messageText === true) {
             const list = this.reg.getMSAGReferences().listByFilename(file.getFilename());
@@ -34,10 +36,59 @@ class CodeLens {
                 }
                 ret.push({
                     range: _lsp_utils_1.LSPUtils.tokenToRange(l.token),
-                    command: LServer.Command.create(text, ""),
+                    command: LServer.Command.create(text, "")
                 });
             }
         }
+        if (settings.dynamicExceptions === true) {
+            for (const ref of this.findMethodReferences(top)) {
+                if (!(ref.resolved instanceof types_1.MethodDefinition)) {
+                    continue;
+                }
+                let text = "";
+                for (const e of ref.resolved.getRaising()) {
+                    if (this.isDynamicException(e, top)) {
+                        if (text === "") {
+                            text = "Dynamic Exceptions: ";
+                        }
+                        else {
+                            text += " & ";
+                        }
+                        text += e.toUpperCase();
+                    }
+                }
+                if (text !== "") {
+                    ret.push({
+                        range: _lsp_utils_1.LSPUtils.tokenToRange(ref.resolved.getToken()),
+                        command: LServer.Command.create(text, "")
+                    });
+                }
+            }
+        }
+        return ret;
+    }
+    isDynamicException(name, top) {
+        var _a;
+        // todo: this method only works with global exceptions?
+        let current = name;
+        while (current !== undefined) {
+            if (current.toUpperCase() === "CX_DYNAMIC_CHECK") {
+                return true;
+            }
+            current = (_a = top.findClassDefinition(current)) === null || _a === void 0 ? void 0 : _a.getSuperClass();
+        }
+        return false;
+    }
+    findMethodReferences(node) {
+        const ret = [];
+        for (const r of node.getData().references) {
+            if (r.referenceType === _reference_1.ReferenceType.MethodReference) {
+                ret.push(r);
+            }
+        }
+        for (const c of node.getChildren()) {
+            ret.push(...this.findMethodReferences(c));
+        }
         return ret;
     }
 }

package/build/src/registry.js

@@ -65,7 +65,7 @@ class Registry {
     }
     static abaplintVersion() {
         // magic, see build script "version.sh"
-        return "2.102.17";
+        return "2.102.19";
     }
     getDDICReferences() {
         return this.ddicReferences;

package/build/src/rules/function_module_recommendations.js

@@ -16,6 +16,8 @@ class FunctionModuleRecommendationsConf extends _basic_rule_config_1.BasicRuleCo
         this.recommendations = [
             { name: "CALCULATE_HASH_FOR_RAW", replace: "use CL_ABAP_HMAC or CL_ABAP_MESSAGE_DIGEST" },
             { name: "CCU_TIMESTAMP_DIFFERENCE", replace: "use CL_ABAP_TSTMP" },
+            { name: "CONVERT_DATE_TO_EXTERNAL", replace: "use CL_ABAP_DATFM" },
+            { name: "CONVERT_TIME_INPUT", replace: "use CL_ABAP_TIMEFM" },
             { name: "ECATT_CONV_XSTRING_TO_STRING", replace: "use CL_BINARY_CONVERT" },
             { name: "F4_FILENAME", replace: "use CL_GUI_FRONTEND_SERVICES" },
             { name: "FUNCTION_EXISTS", replace: "surround with try-catch CX_SY_DYN_CALL_ILLEGAL_METHOD instead" },

package/build/src/rules/select_performance.js

@@ -18,7 +18,9 @@ class SelectPerformanceConf extends _basic_rule_config_1.BasicRuleConfig {
         this.endSelect = true;
         /** Detects SELECT * */
         this.selectStar = true;
-        /** "SELECT" * is considered okay if the table is less than X columns, the table must be known to the linter */
+        /** "SELECT" * is considered okay if the table is less than X columns, the table must be known to the linter
+         * @default 10
+         */
         this.starOkayIfFewColumns = DEFAULT_COLUMNS;
     }
 }

package/build/src/rules/uncaught_exception.js

@@ -15,6 +15,11 @@ const syntax_1 = require("../abap/5_syntax/syntax");
 const _reference_1 = require("../abap/5_syntax/_reference");
 const types_1 = require("../abap/types");
 class UncaughtExceptionConf extends _basic_rule_config_1.BasicRuleConfig {
+    constructor() {
+        super(...arguments);
+        this.reportDynamic = false;
+        this.reportNoCheck = false;
+    }
 }
 exports.UncaughtExceptionConf = UncaughtExceptionConf;
 class UncaughtException extends _abap_rule_1.ABAPRule {
@@ -181,11 +186,17 @@ class UncaughtException extends _abap_rule_1.ABAPRule {
             return true;
         }
         const sup = this.globalExceptions[name.toUpperCase()];
-        if (sup === "CX_DYNAMIC_CHECK" || sup === "CX_NO_CHECK") {
+        if (sup === "CX_DYNAMIC_CHECK" && this.getConfig().reportDynamic !== true) {
+            return true;
+        }
+        if (sup === "CX_NO_CHECK" && this.getConfig().reportNoCheck !== true) {
             return true;
         }
         const lsup = this.localExceptions[name.toUpperCase()];
-        if (lsup === "CX_DYNAMIC_CHECK" || lsup === "CX_NO_CHECK") {
+        if (lsup === "CX_DYNAMIC_CHECK" && this.getConfig().reportDynamic !== true) {
+            return true;
+        }
+        if (lsup === "CX_NO_CHECK" && this.getConfig().reportNoCheck !== true) {
             return true;
         }
         return this.sinked.some(a => a.toUpperCase() === name.toUpperCase())

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@abaplint/core",
-    "version": "2.102.17",
+    "version": "2.102.19",
     "description": "abaplint - Core API",
     "main": "build/src/index.js",
     "typings": "build/abaplint.d.ts",
@@ -53,9 +53,9 @@
         "@microsoft/api-extractor": "^7.36.4",
         "@types/chai": "^4.3.5",
         "@types/mocha": "^10.0.1",
-        "@types/node": "^20.4.8",
+        "@types/node": "^20.5.0",
         "chai": "^4.3.7",
-        "eslint": "^8.46.0",
+        "eslint": "^8.47.0",
         "mocha": "^10.2.0",
         "c8": "^8.0.1",
         "source-map-support": "^0.5.21",