@abaplint/core 2.101.7 → 2.101.9

package/build/abaplint.d.ts

@@ -423,6 +423,7 @@ declare namespace BasicTypes {
         GenericObjectReferenceType,
         HexType,
         IntegerType,
+        Integer8Type,
         NumericGenericType,
         NumericType,
         ObjectReferenceType,
@@ -2131,6 +2132,7 @@ declare namespace Expressions {
         SQLAggregation,
         SQLAliasField,
         SQLArithmetics,
+        SQLArithmeticOperator,
         SQLAsName,
         SQLCase,
         SQLCDSParameters,
@@ -3331,6 +3333,14 @@ declare class Integer extends Expression {
     getRunnable(): IStatementRunnable;
 }
 
+declare class Integer8Type extends AbstractType {
+    toText(): string;
+    isGeneric(): boolean;
+    toABAP(): string;
+    containsVoid(): boolean;
+    toCDS(): string;
+}
+
 declare class IntegerType extends AbstractType {
     toText(): string;
     isGeneric(): boolean;
@@ -3627,6 +3637,7 @@ export declare interface ISpaghettiScopeNode {
         end: Position;
     };
     findClassDefinition(name: string): IClassDefinition | undefined;
+    listClassDefinitions(): IClassDefinition[];
     findFormDefinition(name: string): IFormDefinition | undefined;
     listFormDefinitions(): IFormDefinition[];
     findInterfaceDefinition(name: string): IInterfaceDefinition | undefined;
@@ -5284,6 +5295,7 @@ export declare class SpaghettiScopeNode extends ScopeData implements ISpaghettiS
     setEnd(end: Position): void;
     findDeferred(name: string): Identifier | undefined;
     findClassDefinition(name: string): IClassDefinition | undefined;
+    listClassDefinitions(): IClassDefinition[];
     findFormDefinition(name: string): IFormDefinition | undefined;
     listFormDefinitions(): IFormDefinition[];
     findInterfaceDefinition(name: string): IInterfaceDefinition | undefined;
@@ -5308,6 +5320,10 @@ declare class SQLAliasField extends Expression {
     getRunnable(): IStatementRunnable;
 }
 
+declare class SQLArithmeticOperator extends Expression {
+    getRunnable(): IStatementRunnable;
+}
+
 declare class SQLArithmetics extends Expression {
     getRunnable(): IStatementRunnable;
 }

package/build/src/abap/2_statements/expressions/index.js

@@ -169,6 +169,7 @@ __exportStar(require("./source"), exports);
 __exportStar(require("./sql_aggregation"), exports);
 __exportStar(require("./sql_alias_field"), exports);
 __exportStar(require("./sql_arithmetics"), exports);
+__exportStar(require("./sql_arithmetic_operator"), exports);
 __exportStar(require("./sql_as_name"), exports);
 __exportStar(require("./sql_case"), exports);
 __exportStar(require("./sql_cds_parameters"), exports);

package/build/src/abap/2_statements/expressions/sql_arithmetic_operator.js

@@ -0,0 +1,13 @@
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.SQLArithmeticOperator = void 0;
+const combi_1 = require("../combi");
+const tokens_1 = require("../../1_lexer/tokens");
+class SQLArithmeticOperator extends combi_1.Expression {
+    getRunnable() {
+        const operator = (0, combi_1.altPrio)((0, combi_1.tok)(tokens_1.WPlusW), (0, combi_1.tok)(tokens_1.WDashW), "*", "/");
+        return operator;
+    }
+}
+exports.SQLArithmeticOperator = SQLArithmeticOperator;
+//# sourceMappingURL=sql_arithmetic_operator.js.map

package/build/src/abap/2_statements/expressions/sql_arithmetics.js

@@ -3,12 +3,11 @@ Object.defineProperty(exports, "__esModule", { value: true });
 exports.SQLArithmetics = void 0;
 const combi_1 = require("../combi");
 const _1 = require(".");
-const tokens_1 = require("../../1_lexer/tokens");
+const sql_arithmetic_operator_1 = require("./sql_arithmetic_operator");
 class SQLArithmetics extends combi_1.Expression {
     getRunnable() {
-        const operator = (0, combi_1.altPrio)((0, combi_1.tok)(tokens_1.WPlusW), (0, combi_1.tok)(tokens_1.WDashW), "*", "/");
         const field = (0, combi_1.alt)(_1.SQLFieldName, _1.SQLFunction);
-        return (0, combi_1.seq)(field, (0, combi_1.starPrio)((0, combi_1.seq)(operator, field)));
+        return (0, combi_1.seq)(field, (0, combi_1.starPrio)((0, combi_1.seq)(sql_arithmetic_operator_1.SQLArithmeticOperator, field)));
     }
 }
 exports.SQLArithmetics = SQLArithmetics;

package/build/src/abap/2_statements/expressions/sql_field_and_value.js

@@ -2,11 +2,14 @@
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.SQLFieldAndValue = void 0;
 const combi_1 = require("../combi");
+const integer_1 = require("./integer");
+const sql_arithmetic_operator_1 = require("./sql_arithmetic_operator");
 const sql_field_name_1 = require("./sql_field_name");
 const sql_source_1 = require("./sql_source");
 class SQLFieldAndValue extends combi_1.Expression {
     getRunnable() {
-        const param = (0, combi_1.seq)(sql_field_name_1.SQLFieldName, "=", sql_source_1.SQLSource);
+        const opt1 = (0, combi_1.seq)((0, combi_1.altPrio)(integer_1.Integer, sql_field_name_1.SQLFieldName), sql_arithmetic_operator_1.SQLArithmeticOperator, sql_source_1.SQLSource);
+        const param = (0, combi_1.seq)(sql_field_name_1.SQLFieldName, "=", (0, combi_1.altPrio)(opt1, sql_source_1.SQLSource));
         return param;
     }
 }

package/build/src/abap/5_syntax/_type_utils.js

@@ -266,6 +266,11 @@ class TypeUtils {
             }
             return true;
         }
+        else if (source instanceof basic_1.Integer8Type) {
+            if (target instanceof basic_1.IntegerType || target instanceof basic_1.StringType) {
+                return false;
+            }
+        }
         return this.isAssignable(source, target);
     }
     isAssignable(source, target) {

package/build/src/abap/5_syntax/spaghetti_scope.js

@@ -77,6 +77,15 @@ class SpaghettiScopeNode extends ScopeData {
         }
         return undefined;
     }
+    listClassDefinitions() {
+        let search = this;
+        const ret = [];
+        while (search !== undefined) {
+            ret.push(...Object.values(search.getData().cdefs));
+            search = search.getParent();
+        }
+        return ret;
+    }
     findFormDefinition(name) {
         let search = this;
         const upper = name.toUpperCase();

package/build/src/abap/types/basic/index.js

@@ -29,6 +29,7 @@ __exportStar(require("./floating_point_type"), exports);
 __exportStar(require("./generic_object_reference_type"), exports);
 __exportStar(require("./hex_type"), exports);
 __exportStar(require("./integer_type"), exports);
+__exportStar(require("./integer8_type"), exports);
 __exportStar(require("./numeric_generic_type"), exports);
 __exportStar(require("./numeric_type"), exports);
 __exportStar(require("./object_reference_type"), exports);

package/build/src/abap/types/basic/integer8_type.js

@@ -0,0 +1,23 @@
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.Integer8Type = void 0;
+const _abstract_type_1 = require("./_abstract_type");
+class Integer8Type extends _abstract_type_1.AbstractType {
+    toText() {
+        return "```int8```";
+    }
+    isGeneric() {
+        return false;
+    }
+    toABAP() {
+        return "int8";
+    }
+    containsVoid() {
+        return false;
+    }
+    toCDS() {
+        return "abap.int8";
+    }
+}
+exports.Integer8Type = Integer8Type;
+//# sourceMappingURL=integer8_type.js.map

package/build/src/ddic.js

@@ -80,8 +80,9 @@ class DDIC {
             case "CSEQUENCE":
                 return new Types.CSequenceType({ qualifiedName: qualifiedName });
             case "I":
-            case "INT8": // todo, take version into account
                 return new Types.IntegerType({ qualifiedName: qualifiedName || name });
+            case "INT8": // todo, take version into account
+                return new Types.Integer8Type({ qualifiedName: qualifiedName || name });
             case "F":
                 return new Types.FloatType({ qualifiedName: qualifiedName || name });
             case "P":

package/build/src/lsp/_lookup.js

@@ -13,6 +13,7 @@ const _scope_type_1 = require("../abap/5_syntax/_scope_type");
 const types_1 = require("../abap/types");
 class LSPLookup {
     static lookup(cursor, reg, obj) {
+        var _a, _b;
         const inc = this.findInclude(cursor, reg);
         if (inc) {
             const found = this.ABAPFileResult(inc);
@@ -82,6 +83,22 @@ class LSPLookup {
             }
             return { hover: hoverValue, definition: location, implementation: location, definitionId: variable, scope: bottomScope };
         }
+        for (const c of bottomScope.listClassDefinitions()) {
+            for (const m of ((_a = c.getMethodDefinitions()) === null || _a === void 0 ? void 0 : _a.getAll()) || []) {
+                for (const p of ((_b = m.getParameters()) === null || _b === void 0 ? void 0 : _b.getAll()) || []) {
+                    if (p.getStart().equals(cursor.token.getStart())) {
+                        const found = _lsp_utils_1.LSPUtils.identiferToLocation(p);
+                        return {
+                            hover: "Method Parameter, " + cursor.token.getStr(),
+                            definition: found,
+                            definitionId: p,
+                            implementation: undefined,
+                            scope: bottomScope,
+                        };
+                    }
+                }
+            }
+        }
         const refs = this.searchReferences(bottomScope, cursor.token);
         if (refs.length > 0) {
             for (const ref of refs) {

package/build/src/lsp/rename.js

@@ -9,11 +9,13 @@ const _typed_identifier_1 = require("../abap/types/_typed_identifier");
 const types_1 = require("../abap/types");
 const references_1 = require("./references");
 const renamer_1 = require("../objects/rename/renamer");
+const definition_1 = require("./definition");
 var RenameType;
 (function (RenameType) {
     RenameType[RenameType["GlobalClass"] = 1] = "GlobalClass";
     RenameType[RenameType["Variable"] = 2] = "Variable";
     RenameType[RenameType["GlobalInterface"] = 3] = "GlobalInterface";
+    RenameType[RenameType["Method"] = 4] = "Method";
 })(RenameType = exports.RenameType || (exports.RenameType = {}));
 class Rename {
     constructor(reg) {
@@ -43,6 +45,9 @@ class Rename {
         else if ((lookup === null || lookup === void 0 ? void 0 : lookup.definitionId) instanceof types_1.InterfaceDefinition) {
             return { range, placeholder: cursor.token.getStr(), type: RenameType.GlobalInterface, file };
         }
+        else if ((lookup === null || lookup === void 0 ? void 0 : lookup.definitionId) instanceof types_1.MethodDefinition) {
+            return { range, placeholder: cursor.token.getStr(), type: RenameType.Method, file };
+        }
         return undefined;
     }
     rename(params) {
@@ -57,6 +62,8 @@ class Rename {
                 return new renamer_1.Renamer(this.reg).buildEdits("INTF", prepare.placeholder, params.newName);
             case RenameType.Variable:
                 return this.renameVariable(params);
+            case RenameType.Method:
+                return this.renameMethod(params);
             default:
                 return undefined;
         }
@@ -73,6 +80,23 @@ class Rename {
         }
         return workspace;
     }
+    renameMethod(params) {
+        var _a, _b;
+        const workspace = { documentChanges: [] };
+        const refs = new references_1.References(this.reg).references(params);
+        for (const r of refs) {
+            const doc = { uri: r.uri, version: 1 };
+            const edit = LServer.TextDocumentEdit.create(doc, [LServer.TextEdit.replace(r.range, params.newName)]);
+            (_a = workspace.documentChanges) === null || _a === void 0 ? void 0 : _a.push(edit);
+        }
+        const def = new definition_1.Definition(this.reg).find(params.textDocument, params.position);
+        if (def) {
+            const doc = { uri: params.textDocument.uri, version: 1 };
+            const edit = LServer.TextDocumentEdit.create(doc, [LServer.TextEdit.replace(def === null || def === void 0 ? void 0 : def.range, params.newName)]);
+            (_b = workspace.documentChanges) === null || _b === void 0 ? void 0 : _b.push(edit);
+        }
+        return workspace;
+    }
 }
 exports.Rename = Rename;
 //# sourceMappingURL=rename.js.map

package/build/src/registry.js

@@ -65,7 +65,7 @@ class Registry {
     }
     static abaplintVersion() {
         // magic, see build script "version.sh"
-        return "2.101.7";
+        return "2.101.9";
     }
     getDDICReferences() {
         return this.ddicReferences;

package/build/src/rules/downport.js

@@ -872,6 +872,9 @@ ${indentation}ENDIF.
 ${indentation}`);
             const fix2 = edit_helper_1.EditHelper.replaceRange(lowFile, startToken.getStart(), tableExpression.getLastToken().getEnd(), uniqueName);
             const fix = edit_helper_1.EditHelper.merge(fix2, fix1);
+            if (high.get() instanceof Statements.ElseIf) {
+                throw "downport, unable to downport table expression in ELSEIF";
+            }
             return issue_1.Issue.atToken(lowFile, high.getFirstToken(), "Outline table expression", this.getMetadata().key, this.conf.severity, fix);
         }
         return undefined;

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@abaplint/core",
-    "version": "2.101.7",
+    "version": "2.101.9",
     "description": "abaplint - Core API",
     "main": "build/src/index.js",
     "typings": "build/abaplint.d.ts",
@@ -48,14 +48,14 @@
     },
     "homepage": "https://abaplint.org",
     "devDependencies": {
-        "@microsoft/api-extractor": "^7.35.0",
+        "@microsoft/api-extractor": "^7.35.1",
         "@types/chai": "^4.3.5",
         "@types/mocha": "^10.0.1",
         "@types/node": "^20.2.5",
         "chai": "^4.3.7",
         "eslint": "^8.41.0",
         "mocha": "^10.2.0",
-        "c8": "^7.13.0",
+        "c8": "^7.14.0",
         "source-map-support": "^0.5.21",
         "ts-json-schema-generator": "^1.2.0",
         "typescript": "^5.0.4"