@abaplint/core 2.101.35 → 2.102.0

package/build/src/registry.js

@@ -65,7 +65,7 @@ class Registry {
     }
     static abaplintVersion() {
         // magic, see build script "version.sh"
-        return "2.101.35";
+        return "2.102.0";
     }
     getDDICReferences() {
         return this.ddicReferences;

package/build/src/rules/cloud_types.js

@@ -19,7 +19,7 @@ class CloudTypes {
             key: "cloud_types",
             title: "Check cloud types",
             shortDescription: `Checks that the package does not contain any object types unsupported in cloud ABAP.`,
-            tags: [_irule_1.RuleTag.SingleFile],
+            tags: [_irule_1.RuleTag.SingleFile, _irule_1.RuleTag.Syntax],
         };
     }
     getDescription(objectType) {

package/build/src/rules/function_module_recommendations.js

@@ -15,6 +15,7 @@ class FunctionModuleRecommendationsConf extends _basic_rule_config_1.BasicRuleCo
          */
         this.recommendations = [
             { name: "CALCULATE_HASH_FOR_RAW", replace: "use CL_ABAP_HMAC or CL_ABAP_MESSAGE_DIGEST" },
+            { name: "CCU_TIMESTAMP_DIFFERENCE", replace: "use CL_ABAP_TSTMP" },
             { name: "ECATT_CONV_XSTRING_TO_STRING", replace: "use CL_BINARY_CONVERT" },
             { name: "F4_FILENAME", replace: "use CL_GUI_FRONTEND_SERVICES" },
             { name: "FUNCTION_EXISTS", replace: "surround with try-catch CX_SY_DYN_CALL_ILLEGAL_METHOD instead" },

package/build/src/rules/index.js

@@ -122,6 +122,7 @@ __exportStar(require("./pragma_style"), exports);
 __exportStar(require("./prefer_corresponding"), exports);
 __exportStar(require("./prefer_inline"), exports);
 __exportStar(require("./prefer_is_not"), exports);
+__exportStar(require("./prefer_pragmas"), exports);
 __exportStar(require("./prefer_raise_exception_new"), exports);
 __exportStar(require("./prefer_returning_to_exporting"), exports);
 __exportStar(require("./prefer_xsdbool"), exports);

package/build/src/rules/prefer_pragmas.js

@@ -0,0 +1,75 @@
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.PreferPragmas = exports.PreferPragmasConf = void 0;
+const issue_1 = require("../issue");
+const _abap_rule_1 = require("./_abap_rule");
+const _basic_rule_config_1 = require("./_basic_rule_config");
+const _irule_1 = require("./_irule");
+const _statement_1 = require("../abap/2_statements/statements/_statement");
+class PreferPragmasConf extends _basic_rule_config_1.BasicRuleConfig {
+    constructor() {
+        super(...arguments);
+        this.check = [
+            {
+                pseudo: "#EC CI_SUBRC",
+                pragma: "SUBRC_OK",
+            },
+            {
+                pseudo: "#EC NEEDED",
+                pragma: "NEEDED",
+            },
+            {
+                pseudo: "#EC NOTEXT",
+                pragma: "NO_TEXT",
+            },
+            {
+                pseudo: "#EC NO_HANDLER",
+                pragma: "NO_HANDLER",
+            },
+        ];
+    }
+}
+exports.PreferPragmasConf = PreferPragmasConf;
+class PreferPragmas extends _abap_rule_1.ABAPRule {
+    constructor() {
+        super(...arguments);
+        this.conf = new PreferPragmasConf();
+    }
+    getMetadata() {
+        return {
+            key: "prefer_pragmas",
+            title: "prefer pragmas over pseudo comments ",
+            shortDescription: `prefer pragmas over pseudo comments `,
+            extendedInformation: `https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#prefer-pragmas-to-pseudo-comments`,
+            tags: [_irule_1.RuleTag.SingleFile, _irule_1.RuleTag.Styleguide],
+        };
+    }
+    getConfig() {
+        return this.conf;
+    }
+    setConfig(conf) {
+        this.conf = conf;
+    }
+    runParsed(file) {
+        const issues = [];
+        const config = this.getConfig();
+        for (const statement of file.getStatements()) {
+            if (!(statement.get() instanceof _statement_1.Comment)) {
+                continue;
+            }
+            const concat = statement.concatTokens().toUpperCase();
+            if (concat.includes("#EC") === false) {
+                continue;
+            }
+            for (const check of config.check) {
+                if (concat.includes(check.pseudo.toUpperCase())) {
+                    const message = `Prefer pragma ${check.pragma}`;
+                    issues.push(issue_1.Issue.atStatement(file, statement, message, this.getMetadata().key, this.getConfig().severity));
+                }
+            }
+        }
+        return issues;
+    }
+}
+exports.PreferPragmas = PreferPragmas;
+//# sourceMappingURL=prefer_pragmas.js.map

package/build/src/rules/unnecessary_pragma.js

@@ -33,7 +33,9 @@ class UnnecessaryPragma extends _abap_rule_1.ABAPRule {
 
 * NO_TEXT without texts
 
-* SUBRC_OK where sy-subrc is checked`,
+* SUBRC_OK where sy-subrc is checked
+
+NO_HANDLER inside macros are not checked`,
             tags: [_irule_1.RuleTag.SingleFile],
             badExample: `TRY.
     ...
@@ -164,6 +166,7 @@ ENDIF.`,
         }
         if (next
             && next.get() instanceof _statement_1.Comment
+            && !(statement.get() instanceof _statement_1.MacroContent)
             && next.concatTokens().toUpperCase().includes("#EC NO_HANDLER")) {
             return true;
         }

package/build/src/rules/unnecessary_return.js

@@ -10,7 +10,6 @@ const edit_helper_1 = require("../edit_helper");
 class UnnecessaryReturnConf extends _basic_rule_config_1.BasicRuleConfig {
 }
 exports.UnnecessaryReturnConf = UnnecessaryReturnConf;
-// todo: make this rule more intelligent, eg RETURN. ENDTRY. ENDMETHOD.
 class UnnecessaryReturn extends _abap_rule_1.ABAPRule {
     constructor() {
         super(...arguments);
@@ -44,17 +43,27 @@ ENDFORM.`,
         if (structure === undefined) {
             return [];
         }
+        const message = "Unnecessary RETURN";
         const statements = file.getStatements();
-        for (let i = 0; i < statements.length - 1; i++) {
+        for (let i = 0; i < statements.length; i++) {
             const node = statements[i];
-            const next = statements[i + 1];
-            if (node.get() instanceof Statements.Return
-                && (next.get() instanceof Statements.EndMethod
-                    || next.get() instanceof Statements.EndForm
-                    || next.get() instanceof Statements.EndFunction)) {
-                const message = "Unnecessary RETURN";
-                const fix = edit_helper_1.EditHelper.deleteStatement(file, node);
-                issues.push(issue_1.Issue.atStatement(file, node, message, this.getMetadata().key, this.getConfig().severity, fix));
+            if (!(node.get() instanceof Statements.EndMethod
+                || node.get() instanceof Statements.EndForm
+                || node.get() instanceof Statements.EndFunction)) {
+                continue;
+            }
+            const prev = statements[i - 1];
+            if (prev && prev.get() instanceof Statements.Return) {
+                const fix = edit_helper_1.EditHelper.deleteStatement(file, prev);
+                issues.push(issue_1.Issue.atStatement(file, prev, message, this.getMetadata().key, this.getConfig().severity, fix));
+            }
+            const prevprev = statements[i - 2];
+            if (prev && prevprev
+                && prevprev.get() instanceof Statements.Return
+                && (prev.get() instanceof Statements.EndIf
+                    || prev.get() instanceof Statements.EndTry)) {
+                const fix = edit_helper_1.EditHelper.deleteStatement(file, prevprev);
+                issues.push(issue_1.Issue.atStatement(file, prevprev, message, this.getMetadata().key, this.getConfig().severity, fix));
             }
         }
         return issues;

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@abaplint/core",
-    "version": "2.101.35",
+    "version": "2.102.0",
     "description": "abaplint - Core API",
     "main": "build/src/index.js",
     "typings": "build/abaplint.d.ts",
@@ -50,10 +50,10 @@
     },
     "homepage": "https://abaplint.org",
     "devDependencies": {
-        "@microsoft/api-extractor": "^7.36.1",
+        "@microsoft/api-extractor": "^7.36.2",
         "@types/chai": "^4.3.5",
         "@types/mocha": "^10.0.1",
-        "@types/node": "^20.4.1",
+        "@types/node": "^20.4.2",
         "chai": "^4.3.7",
         "eslint": "^8.44.0",
         "mocha": "^10.2.0",