@abaplint/core 2.101.33 → 2.101.35
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
package/build/src/registry.js
CHANGED
|
@@ -623,7 +623,7 @@ Make sure to test the downported code, it might not always be completely correct
|
|
|
623
623
|
const fix1 = edit_helper_1.EditHelper.replaceRange(lowFile, fieldList.getFirstToken().getStart(), fieldList.getLastToken().getEnd(), fieldName);
|
|
624
624
|
const fix2 = edit_helper_1.EditHelper.replaceRange(lowFile, into === null || into === void 0 ? void 0 : into.getFirstToken().getStart(), into === null || into === void 0 ? void 0 : into.getLastToken().getEnd(), `INTO @DATA(${uniqueName})`);
|
|
625
625
|
let fix = edit_helper_1.EditHelper.merge(fix2, fix1);
|
|
626
|
-
const fix3 = edit_helper_1.EditHelper.insertAt(lowFile, high.getLastToken().getEnd(), `\nCLEAR ${intoName}.\nIF sy-subrc = 0.\n ${intoName} = abap_true
|
|
626
|
+
const fix3 = edit_helper_1.EditHelper.insertAt(lowFile, high.getLastToken().getEnd(), `\nCLEAR ${intoName}.\nIF sy-subrc = 0.\n ${intoName} = abap_true.\nENDIF.`);
|
|
627
627
|
fix = edit_helper_1.EditHelper.merge(fix, fix3);
|
|
628
628
|
return issue_1.Issue.atToken(lowFile, low.getFirstToken(), "SQL, refactor existence check", this.getMetadata().key, this.conf.severity, fix);
|
|
629
629
|
}
|
|
@@ -2070,6 +2070,9 @@ ${indentation} output = ${uniqueName}.\n`;
|
|
|
2070
2070
|
continue;
|
|
2071
2071
|
}
|
|
2072
2072
|
const correspondingBody = s.findDirectExpression(Expressions.CorrespondingBody);
|
|
2073
|
+
if ((correspondingBody === null || correspondingBody === void 0 ? void 0 : correspondingBody.getFirstToken().getStr().toUpperCase()) === "BASE") {
|
|
2074
|
+
continue;
|
|
2075
|
+
}
|
|
2073
2076
|
const uniqueName = this.uniqueName(firstToken.getStart(), lowFile.getFilename(), highSyntax);
|
|
2074
2077
|
const indentation = " ".repeat(high.getFirstToken().getStart().getCol() - 1);
|
|
2075
2078
|
let type = this.findType(s, lowFile, highSyntax);
|
|
@@ -10,6 +10,7 @@ const edit_helper_1 = require("../edit_helper");
|
|
|
10
10
|
class UnnecessaryReturnConf extends _basic_rule_config_1.BasicRuleConfig {
|
|
11
11
|
}
|
|
12
12
|
exports.UnnecessaryReturnConf = UnnecessaryReturnConf;
|
|
13
|
+
// todo: make this rule more intelligent, eg RETURN. ENDTRY. ENDMETHOD.
|
|
13
14
|
class UnnecessaryReturn extends _abap_rule_1.ABAPRule {
|
|
14
15
|
constructor() {
|
|
15
16
|
super(...arguments);
|