@abaplint/core 2.101.32 → 2.101.34

package/build/src/registry.js

@@ -65,7 +65,7 @@ class Registry {
     }
     static abaplintVersion() {
         // magic, see build script "version.sh"
-        return "2.101.32";
+        return "2.101.34";
     }
     getDDICReferences() {
         return this.ddicReferences;

package/build/src/rules/downport.js

@@ -392,6 +392,10 @@ Make sure to test the downported code, it might not always be completely correct
         if (found) {
             return found;
         }
+        found = this.downportSelectExistence(low, high, lowFile, highSyntax);
+        if (found) {
+            return found;
+        }
         found = this.downportSQLExtras(low, high, lowFile, highSyntax);
         if (found) {
             return found;
@@ -521,6 +525,7 @@ Make sure to test the downported code, it might not always be completely correct
         return undefined;
     }
     //////////////////////////////////////////
+    /** removes @'s */
     downportSQLExtras(low, high, lowFile, highSyntax) {
         if (!(low.get() instanceof _statement_1.Unknown)) {
             return undefined;
@@ -593,6 +598,35 @@ Make sure to test the downported code, it might not always be completely correct
         }
         return undefined;
     }
+    downportSelectExistence(low, high, lowFile, highSyntax) {
+        var _a, _b, _c, _d;
+        if (!(low.get() instanceof _statement_1.Unknown)) {
+            return undefined;
+        }
+        else if (!(high.get() instanceof Statements.Select)) {
+            return undefined;
+        }
+        const fieldList = high.findFirstExpression(Expressions.SQLFieldList);
+        if ((fieldList === null || fieldList === void 0 ? void 0 : fieldList.concatTokens().toUpperCase()) !== "@ABAP_TRUE") {
+            return undefined;
+        }
+        const fieldName = (_b = (_a = high.findFirstExpression(Expressions.SQLCond)) === null || _a === void 0 ? void 0 : _a.findFirstExpression(Expressions.SQLFieldName)) === null || _b === void 0 ? void 0 : _b.concatTokens();
+        if (fieldName === undefined) {
+            return undefined;
+        }
+        const into = high.findFirstExpression(Expressions.SQLIntoStructure);
+        if (into === undefined) {
+            return undefined;
+        }
+        const intoName = (_d = (_c = into.findFirstExpression(Expressions.SQLTarget)) === null || _c === void 0 ? void 0 : _c.findFirstExpression(Expressions.Target)) === null || _d === void 0 ? void 0 : _d.concatTokens();
+        const uniqueName = this.uniqueName(high.getFirstToken().getStart(), lowFile.getFilename(), highSyntax);
+        const fix1 = edit_helper_1.EditHelper.replaceRange(lowFile, fieldList.getFirstToken().getStart(), fieldList.getLastToken().getEnd(), fieldName);
+        const fix2 = edit_helper_1.EditHelper.replaceRange(lowFile, into === null || into === void 0 ? void 0 : into.getFirstToken().getStart(), into === null || into === void 0 ? void 0 : into.getLastToken().getEnd(), `INTO @DATA(${uniqueName})`);
+        let fix = edit_helper_1.EditHelper.merge(fix2, fix1);
+        const fix3 = edit_helper_1.EditHelper.insertAt(lowFile, high.getLastToken().getEnd(), `\nCLEAR ${intoName}.\nIF sy-subrc = 0.\n  ${intoName} = abap_true.\nENDIF.`);
+        fix = edit_helper_1.EditHelper.merge(fix, fix3);
+        return issue_1.Issue.atToken(lowFile, low.getFirstToken(), "SQL, refactor existence check", this.getMetadata().key, this.conf.severity, fix);
+    }
     downportSelectInline(low, high, lowFile, highSyntax) {
         if (!(low.get() instanceof _statement_1.Unknown)) {
             return undefined;

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@abaplint/core",
-    "version": "2.101.32",
+    "version": "2.101.34",
     "description": "abaplint - Core API",
     "main": "build/src/index.js",
     "typings": "build/abaplint.d.ts",
@@ -53,7 +53,7 @@
         "@microsoft/api-extractor": "^7.36.1",
         "@types/chai": "^4.3.5",
         "@types/mocha": "^10.0.1",
-        "@types/node": "^20.4.0",
+        "@types/node": "^20.4.1",
         "chai": "^4.3.7",
         "eslint": "^8.44.0",
         "mocha": "^10.2.0",