@abaplint/core 2.101.3 → 2.101.5

package/build/src/abap/5_syntax/expressions/string_template.js

@@ -7,7 +7,6 @@ const source_1 = require("./source");
 const _type_utils_1 = require("../_type_utils");
 class StringTemplate {
     runSyntax(node, scope, filename) {
-        var _a;
         const typeUtils = new _type_utils_1.TypeUtils(scope);
         for (const templateSource of node.findAllExpressions(Expressions.StringTemplateSource)) {
             const s = templateSource.findDirectExpression(Expressions.Source);
@@ -18,9 +17,22 @@ class StringTemplate {
             else if (typeUtils.isCharLike(type) === false && typeUtils.isHexLike(type) === false) {
                 throw new Error("Not character like, " + type.constructor.name);
             }
-            for (const formatSource of ((_a = templateSource.findDirectExpression(Expressions.StringTemplateFormatting)) === null || _a === void 0 ? void 0 : _a.findAllExpressions(Expressions.Source)) || []) {
+            const format = templateSource.findDirectExpression(Expressions.StringTemplateFormatting);
+            const formatConcat = format === null || format === void 0 ? void 0 : format.concatTokens();
+            for (const formatSource of (format === null || format === void 0 ? void 0 : format.findAllExpressions(Expressions.Source)) || []) {
                 new source_1.Source().runSyntax(formatSource, scope, filename);
             }
+            if ((formatConcat === null || formatConcat === void 0 ? void 0 : formatConcat.includes("ALPHA = "))
+                && !(type instanceof basic_1.UnknownType)
+                && !(type instanceof basic_1.VoidType)
+                && !(type instanceof basic_1.StringType)
+                && !(type instanceof basic_1.CLikeType)
+                && !(type instanceof basic_1.CharacterType)
+                && !(type instanceof basic_1.NumericGenericType)
+                && !(type instanceof basic_1.NumericType)
+                && !(type instanceof basic_1.AnyType)) {
+                throw new Error("Cannot apply ALPHA to this type");
+            }
         }
         return new basic_1.StringType({ qualifiedName: "STRING" });
     }

package/build/src/abap/5_syntax/statements/raise.js

@@ -8,45 +8,50 @@ const _reference_1 = require("../_reference");
 const basic_1 = require("../../types/basic");
 const message_source_1 = require("../expressions/message_source");
 const raise_with_1 = require("../expressions/raise_with");
+const _object_oriented_1 = require("../_object_oriented");
+const method_parameters_1 = require("../expressions/method_parameters");
 class Raise {
     runSyntax(node, scope, filename) {
         // todo
-        var _a, _b, _c;
+        var _a, _b, _c, _d, _e;
+        const helper = new _object_oriented_1.ObjectOriented(scope);
+        let method;
         const classTok = (_a = node.findDirectExpression(Expressions.ClassName)) === null || _a === void 0 ? void 0 : _a.getFirstToken();
-        const classNam = classTok === null || classTok === void 0 ? void 0 : classTok.getStr();
-        if (classNam) {
-            const found = scope.existsObject(classNam);
+        const className = classTok === null || classTok === void 0 ? void 0 : classTok.getStr();
+        if (className) {
+            const found = scope.existsObject(className);
             if (found.found === true && found.id) {
                 scope.addReference(classTok, found.id, found.type, filename);
+                const def = scope.findObjectDefinition(className);
+                method = (_b = helper.searchMethodName(def, "CONSTRUCTOR")) === null || _b === void 0 ? void 0 : _b.method;
             }
-            else if (scope.getDDIC().inErrorNamespace(classNam) === false) {
-                const extra = { ooName: classNam, ooType: "Void" };
+            else if (scope.getDDIC().inErrorNamespace(className) === false) {
+                const extra = { ooName: className, ooType: "Void" };
                 scope.addReference(classTok, undefined, _reference_1.ReferenceType.ObjectOrientedVoidReference, filename, extra);
+                method = new basic_1.VoidType(className);
             }
             else {
-                throw new Error("RAISE, unknown class " + classNam);
+                throw new Error("RAISE, unknown class " + className);
             }
         }
-        let prev = "";
-        for (const c of node.getChildren()) {
-            if (c instanceof nodes_1.ExpressionNode
-                && (c.get() instanceof Expressions.SimpleSource2 || c.get() instanceof Expressions.Source)) {
-                const type = new source_1.Source().runSyntax(c, scope, filename);
-                if (prev === "EXCEPTION"
-                    && type
-                    && !(type instanceof basic_1.VoidType)
-                    && !(type instanceof basic_1.ObjectReferenceType)) {
-                    throw new Error("RAISE EXCEPTION, must be object reference, got " + type.constructor.name);
-                }
+        const c = node.findExpressionAfterToken("EXCEPTION");
+        if (c instanceof nodes_1.ExpressionNode && (c.get() instanceof Expressions.SimpleSource2 || c.get() instanceof Expressions.Source)) {
+            const type = new source_1.Source().runSyntax(c, scope, filename);
+            if (type instanceof basic_1.VoidType) {
+                method = type;
+            }
+            else if (type instanceof basic_1.ObjectReferenceType) {
+                const def = scope.findObjectDefinition(type.getIdentifierName());
+                method = (_c = helper.searchMethodName(def, "CONSTRUCTOR")) === null || _c === void 0 ? void 0 : _c.method;
+            }
+            else if (type !== undefined) {
+                throw new Error("RAISE EXCEPTION, must be object reference, got " + type.constructor.name);
             }
-            prev = c.concatTokens().toUpperCase();
         }
-        // todo, check parameters vs constructor
+        // check parameters vs constructor
         const param = node.findDirectExpression(Expressions.ParameterListS);
         if (param) {
-            for (const s of param.findAllExpressions(Expressions.Source)) {
-                new source_1.Source().runSyntax(s, scope, filename);
-            }
+            new method_parameters_1.MethodParameters().checkExporting(param, scope, method, filename, true);
         }
         for (const s of node.findDirectExpressions(Expressions.RaiseWith)) {
             new raise_with_1.RaiseWith().runSyntax(s, scope, filename);
@@ -60,8 +65,8 @@ class Raise {
         for (const s of node.findDirectExpressions(Expressions.MessageSource)) {
             new message_source_1.MessageSource().runSyntax(s, scope, filename);
         }
-        const id = (_b = node.findExpressionAfterToken("ID")) === null || _b === void 0 ? void 0 : _b.concatTokens();
-        const number = (_c = node.findDirectExpression(Expressions.MessageNumber)) === null || _c === void 0 ? void 0 : _c.concatTokens();
+        const id = (_d = node.findExpressionAfterToken("ID")) === null || _d === void 0 ? void 0 : _d.concatTokens();
+        const number = (_e = node.findDirectExpression(Expressions.MessageNumber)) === null || _e === void 0 ? void 0 : _e.concatTokens();
         if ((id === null || id === void 0 ? void 0 : id.startsWith("'")) && number) {
             const messageClass = id.substring(1, id.length - 1).toUpperCase();
             scope.getMSAGReferences().addUsing(filename, node.getFirstToken(), messageClass, number);

package/build/src/registry.js

@@ -65,7 +65,7 @@ class Registry {
     }
     static abaplintVersion() {
         // magic, see build script "version.sh"
-        return "2.101.3";
+        return "2.101.5";
     }
     getDDICReferences() {
         return this.ddicReferences;

package/build/src/rules/modify_only_own_db_tables.js

@@ -71,14 +71,18 @@ class ModifyOnlyOwnDBTables {
                     }
                     const concat = databaseTable.concatTokens().toUpperCase();
                     if (regExp.test(concat) === false) {
-                        // must contain a ReferenceType.TableVoidReference
+                        // must contain a ReferenceType.TableVoidReference or a ReferenceType.TableReference if its a dependency
                         if (spaghetti === undefined) {
                             spaghetti = new syntax_1.SyntaxLogic(this.reg, obj).run().spaghetti;
                         }
                         const start = databaseTable.getFirstToken().getStart();
                         const scope = spaghetti.lookupPosition(start, file.getFilename());
-                        const found = scope === null || scope === void 0 ? void 0 : scope.findTableVoidReference(start);
-                        if (found) {
+                        const found1 = scope === null || scope === void 0 ? void 0 : scope.findTableVoidReference(start);
+                        if (found1) {
+                            output.push(issue_1.Issue.atStatement(file, s, this.getMetadata().title, this.getMetadata().key, this.getConfig().severity));
+                        }
+                        const found2 = scope === null || scope === void 0 ? void 0 : scope.findTableReference(start);
+                        if (found2) {
                             output.push(issue_1.Issue.atStatement(file, s, this.getMetadata().title, this.getMetadata().key, this.getConfig().severity));
                         }
                     }

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@abaplint/core",
-    "version": "2.101.3",
+    "version": "2.101.5",
     "description": "abaplint - Core API",
     "main": "build/src/index.js",
     "typings": "build/abaplint.d.ts",