@abaplint/core 2.101.29 → 2.101.31

package/build/src/abap/5_syntax/_type_utils.js

@@ -297,7 +297,10 @@ class TypeUtils {
             }
         }
         else if (source instanceof basic_1.XStringType) {
-            if (target instanceof basic_1.CLikeType) {
+            if (target instanceof basic_1.CLikeType
+                || target instanceof basic_1.IntegerType
+                || target instanceof basic_1.ObjectReferenceType
+                || target instanceof basic_1.HexType) {
                 return false;
             }
         }

package/build/src/abap/5_syntax/statements/assign.js

@@ -8,22 +8,22 @@ const dynamic_1 = require("../expressions/dynamic");
 const basic_1 = require("../../types/basic");
 class Assign {
     runSyntax(node, scope, filename) {
-        var _a, _b;
-        const sources = node.findAllExpressions(Expressions.Source);
-        const firstSource = sources[0];
-        let sourceType = new source_1.Source().runSyntax(firstSource, scope, filename);
-        if (sourceType === undefined || ((_a = node.findDirectExpression(Expressions.AssignSource)) === null || _a === void 0 ? void 0 : _a.findDirectExpression(Expressions.Dynamic))) {
+        var _a, _b, _c;
+        const sources = ((_a = node.findDirectExpression(Expressions.AssignSource)) === null || _a === void 0 ? void 0 : _a.findDirectExpressions(Expressions.Source)) || [];
+        const theSource = sources[sources.length - 1];
+        let sourceType = new source_1.Source().runSyntax(theSource, scope, filename);
+        if (sourceType === undefined || ((_b = node.findDirectExpression(Expressions.AssignSource)) === null || _b === void 0 ? void 0 : _b.findDirectExpression(Expressions.Dynamic))) {
             sourceType = new basic_1.VoidType("DynamicAssign");
         }
-        for (const d of ((_b = node.findDirectExpression(Expressions.AssignSource)) === null || _b === void 0 ? void 0 : _b.findAllExpressions(Expressions.Dynamic)) || []) {
+        for (const d of ((_c = node.findDirectExpression(Expressions.AssignSource)) === null || _c === void 0 ? void 0 : _c.findAllExpressions(Expressions.Dynamic)) || []) {
             new dynamic_1.Dynamic().runSyntax(d, scope, filename);
         }
         const target = node.findDirectExpression(Expressions.FSTarget);
         if (target) {
             new fstarget_1.FSTarget().runSyntax(target, scope, filename, sourceType);
         }
-        for (const s of sources) {
-            if (s === firstSource) {
+        for (const s of node.findAllExpressions(Expressions.Source)) {
+            if (s === theSource) {
                 continue;
             }
             new source_1.Source().runSyntax(s, scope, filename);

package/build/src/registry.js

@@ -65,7 +65,7 @@ class Registry {
     }
     static abaplintVersion() {
         // magic, see build script "version.sh"
-        return "2.101.29";
+        return "2.101.31";
     }
     getDDICReferences() {
         return this.ddicReferences;

package/build/src/rules/function_module_recommendations.js

@@ -10,9 +10,11 @@ class FunctionModuleRecommendationsConf extends _basic_rule_config_1.BasicRuleCo
     constructor() {
         super(...arguments);
         /** Tuple of Function Module Name to be replaced, the recommended alternative and
-         * the version from which the recommendation is valid.*/
+         * the version from which the recommendation is valid.
+         * @uniqueItems true
+         */
         this.recommendations = [
-            { name: "CALCULATE_HASH_FOR_RAW", replace: "use CL_ABAP_HMAC" },
+            { name: "CALCULATE_HASH_FOR_RAW", replace: "use CL_ABAP_HMAC or CL_ABAP_MESSAGE_DIGEST" },
             { name: "ECATT_CONV_XSTRING_TO_STRING", replace: "use CL_BINARY_CONVERT" },
             { name: "F4_FILENAME", replace: "use CL_GUI_FRONTEND_SERVICES" },
             { name: "FUNCTION_EXISTS", replace: "surround with try-catch CX_SY_DYN_CALL_ILLEGAL_METHOD instead" },
@@ -21,10 +23,11 @@ class FunctionModuleRecommendationsConf extends _basic_rule_config_1.BasicRuleCo
             { name: "GUID_CREATE", replace: "use CL_SYSTEM_UUID" },
             { name: "IGN_TIMESTAMP_DIFFERENCE", replace: "use CL_ABAP_TSTMP" },
             { name: "IGN_TIMESTAMP_PLUSMINUS", replace: "use CL_ABAP_TSTMP" },
+            { name: "ISM_SD_GET_PRICING_CONDITIONS", replace: "use CL_PRC_RESULT_FACTORY as per note 2220005" },
             { name: "JOB_CREATE", replace: "use CL_BP_ABAP_JOB" },
             { name: "JOB_SUBMIT", replace: "use CL_BP_ABAP_JOB" },
-            { name: "POPUP_TO_DECIDE", replace: "use POPUP_TO_CONFIRM" },
             { name: "POPUP_TO_CONFIRM_STEP", replace: "use POPUP_TO_CONFIRM" },
+            { name: "POPUP_TO_DECIDE", replace: "use POPUP_TO_CONFIRM" },
             { name: "POPUP_TO_GET_VALUE", replace: "use POPUP_GET_VALUES" },
             { name: "REUSE_ALV_GRID_DISPLAY", replace: "use CL_SALV_TABLE=>FACTORY or CL_GUI_ALV_GRID" },
             { name: "ROUND", replace: "use built in function: round()" },

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@abaplint/core",
-    "version": "2.101.29",
+    "version": "2.101.31",
     "description": "abaplint - Core API",
     "main": "build/src/index.js",
     "typings": "build/abaplint.d.ts",
@@ -53,9 +53,9 @@
         "@microsoft/api-extractor": "^7.36.0",
         "@types/chai": "^4.3.5",
         "@types/mocha": "^10.0.1",
-        "@types/node": "^20.3.2",
+        "@types/node": "^20.3.3",
         "chai": "^4.3.7",
-        "eslint": "^8.43.0",
+        "eslint": "^8.44.0",
         "mocha": "^10.2.0",
         "c8": "^8.0.0",
         "source-map-support": "^0.5.21",