@abaplint/core 2.101.28 → 2.101.30

package/build/src/abap/5_syntax/_type_utils.js

@@ -245,6 +245,9 @@ class TypeUtils {
                 }
                 return source.getLength() === target.getLength();
             }
+            else if (target instanceof basic_1.XStringType) {
+                return false;
+            }
             else if (target instanceof basic_1.IntegerType) {
                 if (((_e = source.getAbstractTypeData()) === null || _e === void 0 ? void 0 : _e.derivedFromConstant) === true) {
                     return true;
@@ -294,7 +297,10 @@ class TypeUtils {
             }
         }
         else if (source instanceof basic_1.XStringType) {
-            if (target instanceof basic_1.CLikeType) {
+            if (target instanceof basic_1.CLikeType
+                || target instanceof basic_1.IntegerType
+                || target instanceof basic_1.ObjectReferenceType
+                || target instanceof basic_1.HexType) {
                 return false;
             }
         }

package/build/src/abap/5_syntax/expressions/source.js

@@ -46,6 +46,8 @@ class Source {
             switch (tok) {
                 case "(":
                 case "-":
+                case "+":
+                case "BIT":
                     break;
                 case "BOOLC":
                     {

package/build/src/abap/5_syntax/statements/assign.js

@@ -8,22 +8,22 @@ const dynamic_1 = require("../expressions/dynamic");
 const basic_1 = require("../../types/basic");
 class Assign {
     runSyntax(node, scope, filename) {
-        var _a, _b;
-        const sources = node.findAllExpressions(Expressions.Source);
-        const firstSource = sources[0];
-        let sourceType = new source_1.Source().runSyntax(firstSource, scope, filename);
-        if (sourceType === undefined || ((_a = node.findDirectExpression(Expressions.AssignSource)) === null || _a === void 0 ? void 0 : _a.findDirectExpression(Expressions.Dynamic))) {
+        var _a, _b, _c;
+        const sources = ((_a = node.findDirectExpression(Expressions.AssignSource)) === null || _a === void 0 ? void 0 : _a.findDirectExpressions(Expressions.Source)) || [];
+        const theSource = sources[sources.length - 1];
+        let sourceType = new source_1.Source().runSyntax(theSource, scope, filename);
+        if (sourceType === undefined || ((_b = node.findDirectExpression(Expressions.AssignSource)) === null || _b === void 0 ? void 0 : _b.findDirectExpression(Expressions.Dynamic))) {
             sourceType = new basic_1.VoidType("DynamicAssign");
         }
-        for (const d of ((_b = node.findDirectExpression(Expressions.AssignSource)) === null || _b === void 0 ? void 0 : _b.findAllExpressions(Expressions.Dynamic)) || []) {
+        for (const d of ((_c = node.findDirectExpression(Expressions.AssignSource)) === null || _c === void 0 ? void 0 : _c.findAllExpressions(Expressions.Dynamic)) || []) {
             new dynamic_1.Dynamic().runSyntax(d, scope, filename);
         }
         const target = node.findDirectExpression(Expressions.FSTarget);
         if (target) {
             new fstarget_1.FSTarget().runSyntax(target, scope, filename, sourceType);
         }
-        for (const s of sources) {
-            if (s === firstSource) {
+        for (const s of node.findAllExpressions(Expressions.Source)) {
+            if (s === theSource) {
                 continue;
             }
             new source_1.Source().runSyntax(s, scope, filename);

package/build/src/lsp/hover.js

@@ -30,7 +30,11 @@ class Hover {
             return { kind: LServer.MarkupKind.Markdown, value: "String Template" };
         }
         else if (found.token instanceof Tokens.Comment) {
-            return { kind: LServer.MarkupKind.Markdown, value: "Comment" };
+            let type = "Comment";
+            if (found.token.getStr().startsWith(`"!`)) {
+                type = "ABAP Doc Comment";
+            }
+            return { kind: LServer.MarkupKind.Markdown, value: type };
         }
         const lookup = _lookup_1.LSPLookup.lookup(found, this.reg, obj);
         if (lookup === null || lookup === void 0 ? void 0 : lookup.hover) {

package/build/src/registry.js

@@ -65,7 +65,7 @@ class Registry {
     }
     static abaplintVersion() {
         // magic, see build script "version.sh"
-        return "2.101.28";
+        return "2.101.30";
     }
     getDDICReferences() {
         return this.ddicReferences;

package/build/src/rules/7bit_ascii.js

@@ -19,7 +19,9 @@ class SevenBitAscii {
             shortDescription: `Only allow characters from the 7bit ASCII set.`,
             extendedInformation: `https://docs.abapopenchecks.org/checks/05/
 
-Checkes files with extension ".abap" and ".asddls"`,
+https://help.sap.com/doc/abapdocu_750_index_htm/7.50/en-US/abencharacter_set_guidl.htm
+
+Checkes files with extensions ".abap" and ".asddls"`,
             tags: [_irule_1.RuleTag.SingleFile],
         };
     }

package/build/src/rules/function_module_recommendations.js

@@ -12,7 +12,7 @@ class FunctionModuleRecommendationsConf extends _basic_rule_config_1.BasicRuleCo
         /** Tuple of Function Module Name to be replaced, the recommended alternative and
          * the version from which the recommendation is valid.*/
         this.recommendations = [
-            { name: "CALCULATE_HASH_FOR_RAW", replace: "use CL_ABAP_HMAC" },
+            { name: "CALCULATE_HASH_FOR_RAW", replace: "use CL_ABAP_HMAC or CL_ABAP_MESSAGE_DIGEST" },
             { name: "ECATT_CONV_XSTRING_TO_STRING", replace: "use CL_BINARY_CONVERT" },
             { name: "F4_FILENAME", replace: "use CL_GUI_FRONTEND_SERVICES" },
             { name: "FUNCTION_EXISTS", replace: "surround with try-catch CX_SY_DYN_CALL_ILLEGAL_METHOD instead" },
@@ -21,10 +21,11 @@ class FunctionModuleRecommendationsConf extends _basic_rule_config_1.BasicRuleCo
             { name: "GUID_CREATE", replace: "use CL_SYSTEM_UUID" },
             { name: "IGN_TIMESTAMP_DIFFERENCE", replace: "use CL_ABAP_TSTMP" },
             { name: "IGN_TIMESTAMP_PLUSMINUS", replace: "use CL_ABAP_TSTMP" },
+            { name: "ISM_SD_GET PRICING CONDITIONS", replace: "use CL_PRC_RESULT_FACTORY as per note 2220005" },
             { name: "JOB_CREATE", replace: "use CL_BP_ABAP_JOB" },
             { name: "JOB_SUBMIT", replace: "use CL_BP_ABAP_JOB" },
-            { name: "POPUP_TO_DECIDE", replace: "use POPUP_TO_CONFIRM" },
             { name: "POPUP_TO_CONFIRM_STEP", replace: "use POPUP_TO_CONFIRM" },
+            { name: "POPUP_TO_DECIDE", replace: "use POPUP_TO_CONFIRM" },
             { name: "POPUP_TO_GET_VALUE", replace: "use POPUP_GET_VALUES" },
             { name: "REUSE_ALV_GRID_DISPLAY", replace: "use CL_SALV_TABLE=>FACTORY or CL_GUI_ALV_GRID" },
             { name: "ROUND", replace: "use built in function: round()" },

package/build/src/rules/msag_consistency.js

@@ -17,7 +17,7 @@ class MSAGConsistency {
             key: "msag_consistency",
             title: "MSAG consistency check",
             shortDescription: `Checks the validity of messages in message classes`,
-            extendedInformation: `Message numbers must be 3 digits, and message text must not be empty`,
+            extendedInformation: `Message numbers must be 3 digits, message text must not be empty, no message number duplicates`,
         };
     }
     getDescription(reason) {
@@ -37,6 +37,7 @@ class MSAGConsistency {
         if (!(obj instanceof objects_1.MessageClass)) {
             return [];
         }
+        const numbers = new Set();
         for (const message of obj.getMessages()) {
             // todo, get the right positions in xml file
             if (!message.getNumber().match(/\d\d\d/)) {
@@ -51,6 +52,16 @@ class MSAGConsistency {
                 const issue = issue_1.Issue.atPosition(obj.getFiles()[0], position, text, this.getMetadata().key, this.conf.severity);
                 issues.push(issue);
             }
+            const num = message.getNumber();
+            if (numbers.has(num)) {
+                const text = "Duplicate message number " + num;
+                const position = new position_1.Position(1, 1);
+                const issue = issue_1.Issue.atPosition(obj.getFiles()[0], position, text, this.getMetadata().key, this.conf.severity);
+                issues.push(issue);
+            }
+            else {
+                numbers.add(num);
+            }
         }
         return issues;
     }

package/build/src/rules/obsolete_statement.js

@@ -128,6 +128,16 @@ POSIX REGEX: https://help.sap.com/doc/abapdocu_755_index_htm/7.55/en-US/index.ht
 OCCURENCES: check for OCCURENCES vs OCCURRENCES
 
 CLIENT SPECIFIED, from 754: https://help.sap.com/doc/abapdocu_latest_index_htm/latest/en-US/index.htm?file=abapselect_client_obsolete.htm`,
+            badExample: `REFRESH itab.
+
+COMPUTE foo = 2 + 2.
+
+MULTIPLY lv_foo BY 2.
+
+INTERFACE intf LOAD.
+
+IF foo IS SUPPLIED.
+ENDIF.`,
         };
     }
     getConfig() {

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@abaplint/core",
-    "version": "2.101.28",
+    "version": "2.101.30",
     "description": "abaplint - Core API",
     "main": "build/src/index.js",
     "typings": "build/abaplint.d.ts",
@@ -53,14 +53,14 @@
         "@microsoft/api-extractor": "^7.36.0",
         "@types/chai": "^4.3.5",
         "@types/mocha": "^10.0.1",
-        "@types/node": "^20.3.2",
+        "@types/node": "^20.3.3",
         "chai": "^4.3.7",
-        "eslint": "^8.43.0",
+        "eslint": "^8.44.0",
         "mocha": "^10.2.0",
         "c8": "^8.0.0",
         "source-map-support": "^0.5.21",
         "ts-json-schema-generator": "^1.2.0",
-        "typescript": "^5.1.5"
+        "typescript": "^5.1.6"
     },
     "dependencies": {
         "fast-xml-parser": "^4.2.5",