@abaplint/core 2.101.16 → 2.101.18

package/build/abaplint.d.ts

@@ -1311,7 +1311,7 @@ export declare class CurrentScope {
     addDeferred(token: Token | undefined): void;
     addListPrefix(identifiers: readonly TypedIdentifier[], prefix: string): void;
     addList(identifiers: readonly TypedIdentifier[]): void;
-    addReference(usage: Token | undefined, referencing: Identifier | undefined, type: ReferenceType | undefined, filename: string, extra?: IReferenceExtras): void;
+    addReference(usage: Token | undefined, referencing: Identifier | undefined, type: ReferenceType | ReferenceType[] | undefined, filename: string, extra?: IReferenceExtras): void;
     addSQLConversion(fieldName: string, message: string, token: Token): void;
     findFunctionModule(name: string | undefined): FunctionModuleDefinition | undefined;
     findObjectDefinition(name: string | undefined): IClassDefinition | IInterfaceDefinition | undefined;

package/build/src/abap/5_syntax/_current_scope.js

@@ -133,12 +133,19 @@ class CurrentScope {
         }
     }
     addReference(usage, referencing, type, filename, extra) {
-        var _a;
+        var _a, _b;
         if (usage === undefined || type === undefined) {
             return;
         }
         const position = new _identifier_1.Identifier(usage, filename);
-        (_a = this.current) === null || _a === void 0 ? void 0 : _a.getData().references.push({ position, resolved: referencing, referenceType: type, extra });
+        if (Array.isArray(type)) {
+            for (const t of type) {
+                (_a = this.current) === null || _a === void 0 ? void 0 : _a.getData().references.push({ position, resolved: referencing, referenceType: t, extra });
+            }
+        }
+        else {
+            (_b = this.current) === null || _b === void 0 ? void 0 : _b.getData().references.push({ position, resolved: referencing, referenceType: type, extra });
+        }
     }
     addSQLConversion(fieldName, message, token) {
         var _a;

package/build/src/abap/5_syntax/_type_utils.js

@@ -209,12 +209,15 @@ class TypeUtils {
         }
         return false;
     }
-    isAssignableStrict(source, target) {
+    isAssignableStrict(source, target, containsMethodCall = false) {
         var _a, _b, _c, _d, _e, _f;
         /*
             console.dir(source);
             console.dir(target);
         */
+        if (containsMethodCall) {
+            return this.isAssignable(source, target);
+        }
         if (source instanceof basic_1.CharacterType) {
             if (target instanceof basic_1.CharacterType) {
                 if (((_a = source.getAbstractTypeData()) === null || _a === void 0 ? void 0 : _a.derivedFromConstant) === true) {
@@ -253,6 +256,9 @@ class TypeUtils {
             if (target instanceof basic_1.StructureType && this.structureContainsString(target)) {
                 return false;
             }
+            else if (target instanceof basic_1.IntegerType) {
+                return false;
+            }
             else if (target instanceof basic_1.XSequenceType || target instanceof basic_1.XStringType) {
                 if (((_f = source.getAbstractTypeData()) === null || _f === void 0 ? void 0 : _f.derivedFromConstant) === true) {
                     return true;
@@ -279,6 +285,11 @@ class TypeUtils {
                 return false;
             }
         }
+        else if (source instanceof basic_1.FloatType) {
+            if (target instanceof basic_1.IntegerType) {
+                return false;
+            }
+        }
         else if (source instanceof basic_1.XStringType) {
             if (target instanceof basic_1.CLikeType) {
                 return false;

package/build/src/abap/5_syntax/expressions/attribute_chain.js

@@ -32,7 +32,9 @@ class AttributeChain {
         if (context === undefined) {
             throw new Error("Attribute or constant \"" + name + "\" not found in \"" + def.getName() + "\"");
         }
-        scope.addReference(nameToken, context, type, filename);
+        for (const t of type) {
+            scope.addReference(nameToken, context, t, filename);
+        }
         // todo, loop, handle ArrowOrDash, ComponentName, TableExpression
         return context.getType();
     }

package/build/src/abap/5_syntax/expressions/method_call_param.js

@@ -55,7 +55,7 @@ class MethodCallParam {
             if (sourceType === undefined) {
                 throw new Error("No source type determined, method source");
             }
-            else if (new _type_utils_1.TypeUtils(scope).isAssignableStrict(sourceType, targetType) === false) {
+            else if (new _type_utils_1.TypeUtils(scope).isAssignableStrict(sourceType, targetType, child.findFirstExpression(Expressions.MethodCallChain) !== undefined) === false) {
                 throw new Error("Method parameter type not compatible");
             }
         }

package/build/src/abap/5_syntax/expressions/source.js

@@ -34,7 +34,7 @@ const _typed_identifier_1 = require("../../types/_typed_identifier");
 * DATA(bar) = VALUE #( ... ).     give error, no type can be derived
 */
 class Source {
-    runSyntax(node, scope, filename, targetType) {
+    runSyntax(node, scope, filename, targetType, writeReference = false) {
         if (node === undefined) {
             return undefined;
         }
@@ -161,33 +161,41 @@ class Source {
             return undefined;
         }
         let context = new unknown_type_1.UnknownType("todo, Source type");
+        const type = [_reference_1.ReferenceType.DataReadReference];
+        if (writeReference) {
+            type.push(_reference_1.ReferenceType.DataWriteReference);
+        }
         while (children.length >= 0) {
             if (first instanceof nodes_1.ExpressionNode && first.get() instanceof Expressions.MethodCallChain) {
                 context = new method_call_chain_1.MethodCallChain().runSyntax(first, scope, filename, targetType);
             }
             else if (first instanceof nodes_1.ExpressionNode && first.get() instanceof Expressions.FieldChain) {
-                context = new field_chain_1.FieldChain().runSyntax(first, scope, filename, _reference_1.ReferenceType.DataReadReference);
+                context = new field_chain_1.FieldChain().runSyntax(first, scope, filename, type);
             }
             else if (first instanceof nodes_1.ExpressionNode && first.get() instanceof Expressions.StringTemplate) {
                 context = new string_template_1.StringTemplate().runSyntax(first, scope, filename);
             }
             else if (first instanceof nodes_1.ExpressionNode && first.get() instanceof Expressions.Source) {
-                context = new Source().runSyntax(first, scope, filename);
+                const found = new Source().runSyntax(first, scope, filename);
+                context = this.infer(context, found);
             }
             else if (first instanceof nodes_1.ExpressionNode && first.get() instanceof Expressions.Constant) {
-                context = new constant_1.Constant().runSyntax(first);
+                const found = new constant_1.Constant().runSyntax(first);
+                context = this.infer(context, found);
             }
             else if (first instanceof nodes_1.ExpressionNode && first.get() instanceof Expressions.Dereference) {
                 context = new dereference_1.Dereference().runSyntax(context);
             }
-            else if (first instanceof nodes_1.ExpressionNode && first.get() instanceof Expressions.ArrowOrDash) {
-                //        console.dir("dash");
-            }
             else if (first instanceof nodes_1.ExpressionNode && first.get() instanceof Expressions.ComponentChain) {
                 context = new component_chain_1.ComponentChain().runSyntax(context, first, scope, filename);
             }
+            else if (first instanceof nodes_1.ExpressionNode && first.get() instanceof Expressions.ArithOperator) {
+                if (first.concatTokens() === "**") {
+                    context = new basic_1.FloatType();
+                }
+            }
             else if (first instanceof nodes_1.ExpressionNode && first.get() instanceof Expressions.AttributeChain) {
-                context = new attribute_chain_1.AttributeChain().runSyntax(context, first, scope, filename, _reference_1.ReferenceType.DataReadReference);
+                context = new attribute_chain_1.AttributeChain().runSyntax(context, first, scope, filename, type);
             }
             first = children.shift();
             if (first === undefined) {
@@ -200,6 +208,14 @@ class Source {
         return context;
     }
     ////////////////////////////////
+    infer(context, found) {
+        if (context instanceof basic_1.FloatType && found instanceof basic_1.IntegerType) {
+            return context;
+        }
+        else {
+            return found;
+        }
+    }
     addIfInferred(node, scope, filename, inferredType) {
         const basic = new basic_types_1.BasicTypes(filename, scope);
         const typeExpression = node.findFirstExpression(Expressions.TypeNameOrInfer);

package/build/src/abap/5_syntax/expressions/sql_compare.js

@@ -2,6 +2,7 @@
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.SQLCompare = void 0;
 const Expressions = require("../../2_statements/expressions");
+const nodes_1 = require("../../nodes");
 const basic_1 = require("../../types/basic");
 const sql_source_1 = require("./sql_source");
 class SQLCompare {
@@ -10,7 +11,12 @@ class SQLCompare {
         let sourceType;
         let token;
         for (const s of node.findAllExpressions(Expressions.SQLSource)) {
-            token = s.getFirstToken();
+            for (const child of s.getChildren()) {
+                if (child instanceof nodes_1.ExpressionNode) {
+                    token = child.getFirstToken();
+                    break;
+                }
+            }
             sourceType = new sql_source_1.SQLSource().runSyntax(s, scope, filename);
         }
         const fieldName = (_a = node.findDirectExpression(Expressions.SQLFieldName)) === null || _a === void 0 ? void 0 : _a.concatTokens();

package/build/src/abap/5_syntax/statements/loop.js

@@ -13,19 +13,19 @@ const dynamic_1 = require("../expressions/dynamic");
 const loop_group_by_1 = require("../expressions/loop_group_by");
 class Loop {
     runSyntax(node, scope, filename) {
-        var _a;
         const loopTarget = node.findDirectExpression(Expressions.LoopTarget);
         let target = loopTarget === null || loopTarget === void 0 ? void 0 : loopTarget.findDirectExpression(Expressions.Target);
         const targetType = target ? new target_1.Target().runSyntax(target, scope, filename) : undefined;
         if (target === undefined) {
             target = node.findDirectExpression(Expressions.FSTarget);
         }
+        const write = (loopTarget === null || loopTarget === void 0 ? void 0 : loopTarget.findDirectTokenByText("ASSIGNING")) !== undefined;
         const sources = node.findDirectExpressions(Expressions.Source);
         let firstSource = node.findDirectExpression(Expressions.SimpleSource2);
         if (firstSource === undefined) {
             firstSource = sources[0];
         }
-        let sourceType = firstSource ? new source_1.Source().runSyntax(firstSource, scope, filename, targetType) : undefined;
+        let sourceType = firstSource ? new source_1.Source().runSyntax(firstSource, scope, filename, targetType, write) : undefined;
         let rowType = undefined;
         const concat = node.concatTokens().toUpperCase();
         if (sourceType === undefined) {
@@ -46,14 +46,24 @@ class Loop {
             && concat.startsWith("LOOP AT GROUP ") === false) {
             throw new Error("Loop, not a table type");
         }
+        else if (loopTarget === undefined
+            && sourceType instanceof basic_1.TableType
+            && sourceType.isWithHeader() === false) {
+            throw new Error("Loop, no header");
+        }
+        const targetConcat = loopTarget === null || loopTarget === void 0 ? void 0 : loopTarget.concatTokens().toUpperCase();
         if (sourceType instanceof basic_1.TableType) {
-            const targetConcat = (_a = node.findDirectExpression(Expressions.LoopTarget)) === null || _a === void 0 ? void 0 : _a.concatTokens().toUpperCase();
             rowType = sourceType.getRowType();
             sourceType = rowType;
             if (targetConcat === null || targetConcat === void 0 ? void 0 : targetConcat.startsWith("REFERENCE INTO ")) {
                 sourceType = new basic_1.DataReference(sourceType);
             }
         }
+        if (targetConcat
+            && targetConcat.startsWith("TRANSPORTING ")
+            && node.findDirectTokenByText("WHERE") === undefined) {
+            throw new Error("Loop, TRANSPORTING NO FIELDS only with WHERE");
+        }
         const inline = target === null || target === void 0 ? void 0 : target.findDirectExpression(Expressions.InlineData);
         if (inline) {
             new inline_data_1.InlineData().runSyntax(inline, scope, filename, sourceType);

package/build/src/registry.js

@@ -65,7 +65,7 @@ class Registry {
     }
     static abaplintVersion() {
         // magic, see build script "version.sh"
-        return "2.101.16";
+        return "2.101.18";
     }
     getDDICReferences() {
         return this.ddicReferences;

package/build/src/rules/align_parameters.js

@@ -37,7 +37,7 @@ Does not take effect on non functional method calls, use https://rules.abaplint.
 
 If parameters are on the same row, no issues are reported, see
 https://rules.abaplint.org/max_one_method_parameter_per_line/ for splitting parameters to lines`,
-            tags: [_irule_1.RuleTag.SingleFile, _irule_1.RuleTag.Whitespace, _irule_1.RuleTag.Styleguide],
+            tags: [_irule_1.RuleTag.SingleFile, _irule_1.RuleTag.Whitespace, _irule_1.RuleTag.Styleguide, _irule_1.RuleTag.Quickfix],
             badExample: `CALL FUNCTION 'FOOBAR'
   EXPORTING
     foo = 2

package/build/src/rules/unnecessary_pragma.js

@@ -9,6 +9,12 @@ const _basic_rule_config_1 = require("./_basic_rule_config");
 const _statement_1 = require("../abap/2_statements/statements/_statement");
 const _irule_1 = require("./_irule");
 class UnnecessaryPragmaConf extends _basic_rule_config_1.BasicRuleConfig {
+    constructor() {
+        super(...arguments);
+        /** Allow NO_TEXT in global CLAS and INTF definitions,
+            its added automatically by SE24 in some cases where it should not */
+        this.allowNoTextGlobal = false;
+    }
 }
 exports.UnnecessaryPragmaConf = UnnecessaryPragmaConf;
 class UnnecessaryPragma extends _abap_rule_1.ABAPRule {
@@ -58,6 +64,7 @@ ENDIF.`,
     runParsed(file) {
         const issues = [];
         let noHandler = false;
+        let globalDefinition = false;
         const statements = file.getStatements();
         for (let i = 0; i < statements.length; i++) {
             const statement = statements[i];
@@ -65,6 +72,16 @@ ENDIF.`,
             if (statement.get() instanceof Statements.EndTry) {
                 noHandler = false;
             }
+            else if (statement.get() instanceof Statements.ClassDefinition
+                || statement.get() instanceof Statements.Interface) {
+                if (statement.findDirectExpression(Expressions.ClassGlobal)) {
+                    globalDefinition = true;
+                }
+            }
+            else if (statement.get() instanceof Statements.EndClass
+                || statement.get() instanceof Statements.EndInterface) {
+                globalDefinition = false;
+            }
             else if (statement.get() instanceof _statement_1.Comment) {
                 continue;
             }
@@ -77,9 +94,16 @@ ENDIF.`,
             else {
                 noHandler = this.containsNoHandler(statement, statements[i + 1]);
             }
-            issues.push(...this.checkText(statement, file));
+            if (this.getConfig().allowNoTextGlobal === true && globalDefinition === true) {
+                // skip
+            }
+            else {
+                issues.push(...this.checkText(statement, file));
+            }
             issues.push(...this.checkNeeded(statement, file));
-            issues.push(...this.checkSubrc(statement, nextStatement, file));
+            if (globalDefinition === false) {
+                issues.push(...this.checkSubrc(statement, nextStatement, file));
+            }
         }
         return issues;
     }

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@abaplint/core",
-    "version": "2.101.16",
+    "version": "2.101.18",
     "description": "abaplint - Core API",
     "main": "build/src/index.js",
     "typings": "build/abaplint.d.ts",
@@ -53,7 +53,7 @@
         "@microsoft/api-extractor": "^7.35.2",
         "@types/chai": "^4.3.5",
         "@types/mocha": "^10.0.1",
-        "@types/node": "^20.2.5",
+        "@types/node": "^20.3.0",
         "chai": "^4.3.7",
         "eslint": "^8.42.0",
         "mocha": "^10.2.0",