@abaplint/core 2.101.15 → 2.101.16

package/build/abaplint.d.ts

@@ -441,6 +441,7 @@ declare namespace BasicTypes {
         UnknownType,
         UTCLongType,
         VoidType,
+        XGenericType,
         XSequenceType,
         XStringType
     }
@@ -6793,6 +6794,14 @@ declare class WStaticArrowW extends Token {
     static railroad(): string;
 }
 
+declare class XGenericType extends AbstractType {
+    toText(): string;
+    isGeneric(): boolean;
+    toABAP(): string;
+    containsVoid(): boolean;
+    toCDS(): string;
+}
+
 declare class XSequenceType extends AbstractType {
     toText(): string;
     isGeneric(): boolean;

package/build/src/abap/5_syntax/_type_utils.js

@@ -92,6 +92,7 @@ class TypeUtils {
         else if (type instanceof basic_1.XStringType
             || type instanceof basic_1.HexType
             || type instanceof basic_1.VoidType
+            || type instanceof basic_1.XGenericType
             || type instanceof basic_1.XSequenceType
             || type instanceof basic_1.AnyType
             || type instanceof basic_1.UnknownType) {

package/build/src/abap/5_syntax/basic_types.js

@@ -24,7 +24,7 @@ class BasicTypes {
     }
     lookupQualifiedName(name) {
         var _a;
-        // argh, todo, rewrite this entire method, more argh
+        // argh, todo, rewrite this entire method, more argh, again argh
         if (name === undefined) {
             return undefined;
         }
@@ -45,7 +45,10 @@ class BasicTypes {
                     const stru = oo.getTypeDefinitions().getByName(subTypeName);
                     const struType = stru === null || stru === void 0 ? void 0 : stru.getType();
                     if (stru && struType instanceof basic_1.StructureType) {
-                        const f = struType.getComponentByName(fieldName);
+                        let f = struType.getComponentByName(fieldName);
+                        if (split[2] && f instanceof basic_1.StructureType) {
+                            f = f.getComponentByName(split[2]);
+                        }
                         if (f) {
                             return new _typed_identifier_1.TypedIdentifier(stru.getToken(), stru.getFilename(), f);
                         }
@@ -67,7 +70,10 @@ class BasicTypes {
             if (type) {
                 const stru = type.getType();
                 if (stru instanceof basic_1.StructureType) {
-                    const f = stru.getComponentByName(fieldName);
+                    let f = stru.getComponentByName(fieldName);
+                    if (split[2] && f instanceof basic_1.StructureType) {
+                        f = f.getComponentByName(split[2]);
+                    }
                     if (f) {
                         return new _typed_identifier_1.TypedIdentifier(type.getToken(), type.getFilename(), f);
                     }

package/build/src/abap/5_syntax/expressions/method_param.js

@@ -30,6 +30,9 @@ class MethodParam {
         if (concat === "TYPE C" || concat.startsWith("TYPE C ")) {
             return new _typed_identifier_1.TypedIdentifier(name.getFirstToken(), filename, new cgeneric_type_1.CGenericType(), meta);
         }
+        else if (concat === "TYPE X" || concat.startsWith("TYPE X ")) {
+            return new _typed_identifier_1.TypedIdentifier(name.getFirstToken(), filename, new basic_1.XGenericType(), meta);
+        }
         const found = new basic_types_1.BasicTypes(filename, scope).parseType(type);
         if (found) {
             return new _typed_identifier_1.TypedIdentifier(name.getFirstToken(), filename, found, meta);

package/build/src/abap/types/basic/hex_type.js

@@ -6,7 +6,7 @@ class HexType extends _abstract_type_1.AbstractType {
     constructor(length, qualifiedName) {
         super({ qualifiedName: qualifiedName });
         if (length <= 0) {
-            throw new Error("Bad LENGTHm, Hex");
+            throw new Error("Bad LENGTH, Hex");
         }
         this.length = length;
     }

package/build/src/abap/types/basic/index.js

@@ -42,6 +42,7 @@ __exportStar(require("./time_type"), exports);
 __exportStar(require("./unknown_type"), exports);
 __exportStar(require("./utc_long_type"), exports);
 __exportStar(require("./void_type"), exports);
+__exportStar(require("./xgeneric_type"), exports);
 __exportStar(require("./xsequence_type"), exports);
 __exportStar(require("./xstring_type"), exports);
 //# sourceMappingURL=index.js.map

package/build/src/abap/types/basic/xgeneric_type.js

@@ -0,0 +1,23 @@
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.XGenericType = void 0;
+const _abstract_type_1 = require("./_abstract_type");
+class XGenericType extends _abstract_type_1.AbstractType {
+    toText() {
+        return "```x```";
+    }
+    isGeneric() {
+        return true;
+    }
+    toABAP() {
+        throw new Error("x, generic");
+    }
+    containsVoid() {
+        return false;
+    }
+    toCDS() {
+        return "abap.TODO_CGENERIC";
+    }
+}
+exports.XGenericType = XGenericType;
+//# sourceMappingURL=xgeneric_type.js.map

package/build/src/registry.js

@@ -65,7 +65,7 @@ class Registry {
     }
     static abaplintVersion() {
         // magic, see build script "version.sh"
-        return "2.101.15";
+        return "2.101.16";
     }
     getDDICReferences() {
         return this.ddicReferences;

package/build/src/rules/align_parameters.js

@@ -6,7 +6,9 @@ const Expressions = require("../abap/2_statements/expressions");
 const _abap_rule_1 = require("./_abap_rule");
 const _basic_rule_config_1 = require("./_basic_rule_config");
 const _irule_1 = require("./_irule");
+const position_1 = require("../position");
 const __1 = require("..");
+const edit_helper_1 = require("../edit_helper");
 class AlignParametersConf extends _basic_rule_config_1.BasicRuleConfig {
 }
 exports.AlignParametersConf = AlignParametersConf;
@@ -33,7 +35,8 @@ https://github.com/SAP/styleguides/blob/master/clean-abap/CleanABAP.md#align-par
 
 Does not take effect on non functional method calls, use https://rules.abaplint.org/functional_writing/
 
-Also https://rules.abaplint.org/max_one_method_parameter_per_line/ can help aligning parameter syntax`,
+If parameters are on the same row, no issues are reported, see
+https://rules.abaplint.org/max_one_method_parameter_per_line/ for splitting parameters to lines`,
             tags: [_irule_1.RuleTag.SingleFile, _irule_1.RuleTag.Whitespace, _irule_1.RuleTag.Styleguide],
             badExample: `CALL FUNCTION 'FOOBAR'
   EXPORTING
@@ -96,16 +99,28 @@ DATA(sdf) = VALUE type(
             return undefined;
         }
         let expectedEqualsColumn = 0;
+        let row = 0;
         for (const p of candidate.parameters) {
             const currentCol = p.left.getLastToken().getCol() + p.left.getLastToken().getStr().length + 1;
+            if (p.eq.getRow() === row) {
+                return undefined;
+            }
+            row = p.eq.getRow();
             if (currentCol > expectedEqualsColumn) {
                 expectedEqualsColumn = currentCol;
             }
         }
         for (const p of candidate.parameters) {
             if (p.eq.getCol() !== expectedEqualsColumn) {
+                let fix;
+                if (p.eq.getCol() < expectedEqualsColumn) {
+                    fix = edit_helper_1.EditHelper.insertAt(file, p.eq, " ".repeat(expectedEqualsColumn - p.eq.getCol()));
+                }
+                else {
+                    fix = edit_helper_1.EditHelper.deleteRange(file, new position_1.Position(p.eq.getRow(), expectedEqualsColumn), p.eq);
+                }
                 const message = "Align parameters to column " + expectedEqualsColumn;
-                return issue_1.Issue.atPosition(file, p.eq, message, this.getMetadata().key, this.getConfig().severity);
+                return issue_1.Issue.atPosition(file, p.eq, message, this.getMetadata().key, this.getConfig().severity, fix);
             }
         }
         return undefined;

package/build/src/rules/fully_type_itabs.js

@@ -45,11 +45,11 @@ DATA lt_bar TYPE STANDARD TABLE OF ty.`,
             const concat = tt.concatTokens().toUpperCase();
             if (concat.includes("TYPE TABLE OF")) {
                 const message = "Specify table type";
-                issues.push(issue_1.Issue.atStatement(file, statement, message, this.getMetadata().key, this.conf.severity));
+                issues.push(issue_1.Issue.atPosition(file, tt.getFirstToken().getStart(), message, this.getMetadata().key, this.conf.severity));
             }
             else if (concat.includes(" WITH ") === false && concat.includes(" RANGE OF ") === false) {
                 const message = "Specify table key";
-                issues.push(issue_1.Issue.atStatement(file, statement, message, this.getMetadata().key, this.conf.severity));
+                issues.push(issue_1.Issue.atPosition(file, tt.getFirstToken().getStart(), message, this.getMetadata().key, this.conf.severity));
             }
         }
         return issues;

package/build/src/rules/select_single_full_key.js

@@ -3,7 +3,6 @@ Object.defineProperty(exports, "__esModule", { value: true });
 exports.SelectSingleFullKey = exports.SelectSingleFullKeyConf = void 0;
 const issue_1 = require("../issue");
 const _basic_rule_config_1 = require("./_basic_rule_config");
-const _irule_1 = require("./_irule");
 const __1 = require("..");
 class SelectSingleFullKeyConf extends _basic_rule_config_1.BasicRuleConfig {
     constructor() {
@@ -23,7 +22,7 @@ class SelectSingleFullKey {
             shortDescription: `Detect SELECT SINGLE which are possibily not unique`,
             extendedInformation: `Table definitions must be known, ie. inside the errorNamespace`,
             pseudoComment: "EC CI_NOORDER",
-            tags: [_irule_1.RuleTag.Experimental],
+            tags: [],
         };
     }
     initialize(reg) {

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@abaplint/core",
-    "version": "2.101.15",
+    "version": "2.101.16",
     "description": "abaplint - Core API",
     "main": "build/src/index.js",
     "typings": "build/abaplint.d.ts",
@@ -50,7 +50,7 @@
     },
     "homepage": "https://abaplint.org",
     "devDependencies": {
-        "@microsoft/api-extractor": "^7.35.1",
+        "@microsoft/api-extractor": "^7.35.2",
         "@types/chai": "^4.3.5",
         "@types/mocha": "^10.0.1",
         "@types/node": "^20.2.5",