@abaplint/core 2.101.14 → 2.101.16

package/build/src/abap/5_syntax/_type_utils.js

@@ -92,6 +92,7 @@ class TypeUtils {
         else if (type instanceof basic_1.XStringType
             || type instanceof basic_1.HexType
             || type instanceof basic_1.VoidType
+            || type instanceof basic_1.XGenericType
             || type instanceof basic_1.XSequenceType
             || type instanceof basic_1.AnyType
             || type instanceof basic_1.UnknownType) {
@@ -252,7 +253,7 @@ class TypeUtils {
             if (target instanceof basic_1.StructureType && this.structureContainsString(target)) {
                 return false;
             }
-            else if (target instanceof basic_1.XSequenceType) {
+            else if (target instanceof basic_1.XSequenceType || target instanceof basic_1.XStringType) {
                 if (((_f = source.getAbstractTypeData()) === null || _f === void 0 ? void 0 : _f.derivedFromConstant) === true) {
                     return true;
                 }

package/build/src/abap/5_syntax/basic_types.js

@@ -24,7 +24,7 @@ class BasicTypes {
     }
     lookupQualifiedName(name) {
         var _a;
-        // argh, todo, rewrite this entire method, more argh
+        // argh, todo, rewrite this entire method, more argh, again argh
         if (name === undefined) {
             return undefined;
         }
@@ -45,7 +45,10 @@ class BasicTypes {
                     const stru = oo.getTypeDefinitions().getByName(subTypeName);
                     const struType = stru === null || stru === void 0 ? void 0 : stru.getType();
                     if (stru && struType instanceof basic_1.StructureType) {
-                        const f = struType.getComponentByName(fieldName);
+                        let f = struType.getComponentByName(fieldName);
+                        if (split[2] && f instanceof basic_1.StructureType) {
+                            f = f.getComponentByName(split[2]);
+                        }
                         if (f) {
                             return new _typed_identifier_1.TypedIdentifier(stru.getToken(), stru.getFilename(), f);
                         }
@@ -67,7 +70,10 @@ class BasicTypes {
             if (type) {
                 const stru = type.getType();
                 if (stru instanceof basic_1.StructureType) {
-                    const f = stru.getComponentByName(fieldName);
+                    let f = stru.getComponentByName(fieldName);
+                    if (split[2] && f instanceof basic_1.StructureType) {
+                        f = f.getComponentByName(split[2]);
+                    }
                     if (f) {
                         return new _typed_identifier_1.TypedIdentifier(type.getToken(), type.getFilename(), f);
                     }

package/build/src/abap/5_syntax/expressions/constant.js

@@ -5,8 +5,9 @@ const basic_1 = require("../../types/basic");
 const expressions_1 = require("../../2_statements/expressions");
 class Constant {
     runSyntax(node) {
+        // todo: ConcatenatedConstant is not used?
         if (node.findDirectExpression(expressions_1.Integer)) {
-            return new basic_1.IntegerType({ qualifiedName: "I" });
+            return basic_1.IntegerType.get();
         }
         else if (node.getFirstToken().getStr().startsWith("'")) {
             let len = node.getFirstToken().getStr().length - 2;
@@ -16,10 +17,10 @@ class Constant {
             return new basic_1.CharacterType(len, { derivedFromConstant: true });
         }
         else if (node.getFirstToken().getStr().startsWith("`")) {
-            return new basic_1.StringType({ qualifiedName: "STRING", derivedFromConstant: true });
+            return basic_1.StringType.get({ derivedFromConstant: true });
         }
         else {
-            return new basic_1.StringType({ qualifiedName: "STRING" });
+            return basic_1.StringType.get();
         }
     }
 }

package/build/src/abap/5_syntax/expressions/inline_loop_definition.js

@@ -43,7 +43,7 @@ class InlineLoopDefinition {
         }
         const index = node.findExpressionAfterToken("INTO");
         if (index && index.get() instanceof Expressions.TargetField) {
-            const identifier = new _typed_identifier_1.TypedIdentifier(index.getFirstToken(), filename, new basic_1.IntegerType(), ["inline" /* IdentifierMeta.InlineDefinition */]);
+            const identifier = new _typed_identifier_1.TypedIdentifier(index.getFirstToken(), filename, basic_1.IntegerType.get(), ["inline" /* IdentifierMeta.InlineDefinition */]);
             scope.addReference(index.getFirstToken(), identifier, _reference_1.ReferenceType.DataWriteReference, filename);
             scope.addIdentifier(identifier);
         }

package/build/src/abap/5_syntax/expressions/method_call_param.js

@@ -48,7 +48,7 @@ class MethodCallParam {
             else {
                 targetType = method;
             }
-            let sourceType = new basic_1.StringType();
+            let sourceType = basic_1.StringType.get();
             if (child.get() instanceof Expressions.Source) {
                 sourceType = new source_1.Source().runSyntax(child, scope, filename, targetType);
             }

package/build/src/abap/5_syntax/expressions/method_param.js

@@ -30,6 +30,9 @@ class MethodParam {
         if (concat === "TYPE C" || concat.startsWith("TYPE C ")) {
             return new _typed_identifier_1.TypedIdentifier(name.getFirstToken(), filename, new cgeneric_type_1.CGenericType(), meta);
         }
+        else if (concat === "TYPE X" || concat.startsWith("TYPE X ")) {
+            return new _typed_identifier_1.TypedIdentifier(name.getFirstToken(), filename, new basic_1.XGenericType(), meta);
+        }
         const found = new basic_types_1.BasicTypes(filename, scope).parseType(type);
         if (found) {
             return new _typed_identifier_1.TypedIdentifier(name.getFirstToken(), filename, found, meta);

package/build/src/abap/5_syntax/expressions/source.js

@@ -52,7 +52,7 @@ class Source {
                         const method = new _builtin_1.BuiltIn().searchBuiltin(tok);
                         scope.addReference(token, method, _reference_1.ReferenceType.BuiltinMethodReference, filename);
                         new cond_1.Cond().runSyntax(node.findDirectExpression(Expressions.Cond), scope, filename);
-                        return new basic_1.StringType();
+                        return basic_1.StringType.get();
                     }
                 case "XSDBOOL":
                     {
@@ -195,7 +195,7 @@ class Source {
             }
         }
         if (node.findDirectTokenByText("&&")) {
-            return new basic_1.StringType();
+            return basic_1.StringType.get();
         }
         return context;
     }

package/build/src/abap/5_syntax/expressions/string_template.js

@@ -10,7 +10,7 @@ class StringTemplate {
         const typeUtils = new _type_utils_1.TypeUtils(scope);
         for (const templateSource of node.findAllExpressions(Expressions.StringTemplateSource)) {
             const s = templateSource.findDirectExpression(Expressions.Source);
-            const type = new source_1.Source().runSyntax(s, scope, filename, new basic_1.StringType({ qualifiedName: "STRING" }));
+            const type = new source_1.Source().runSyntax(s, scope, filename, basic_1.StringType.get());
             if (type === undefined) {
                 throw new Error("No target type determined");
             }
@@ -34,7 +34,7 @@ class StringTemplate {
                 throw new Error("Cannot apply ALPHA to this type");
             }
         }
-        return new basic_1.StringType({ qualifiedName: "STRING" });
+        return basic_1.StringType.get();
     }
 }
 exports.StringTemplate = StringTemplate;

package/build/src/abap/5_syntax/statements/concatenate.js

@@ -6,19 +6,41 @@ const source_1 = require("../expressions/source");
 const target_1 = require("../expressions/target");
 const basic_1 = require("../../types/basic");
 const inline_data_1 = require("../expressions/inline_data");
+const _type_utils_1 = require("../_type_utils");
 class Concatenate {
     runSyntax(node, scope, filename) {
+        const byteMode = node.findDirectTokenByText("BYTE") !== undefined;
+        let linesMode = node.findDirectTokenByText("LINES") !== undefined;
         const target = node.findFirstExpression(Expressions.Target);
         const inline = target === null || target === void 0 ? void 0 : target.findDirectExpression(Expressions.InlineData);
         if (inline) {
-            // todo, does this give XSTRING in BYTE MODE?
-            new inline_data_1.InlineData().runSyntax(inline, scope, filename, new basic_1.StringType());
+            if (byteMode) {
+                new inline_data_1.InlineData().runSyntax(inline, scope, filename, new basic_1.XStringType());
+            }
+            else {
+                new inline_data_1.InlineData().runSyntax(inline, scope, filename, basic_1.StringType.get());
+            }
         }
         else if (target) {
-            new target_1.Target().runSyntax(target, scope, filename);
+            const type = new target_1.Target().runSyntax(target, scope, filename);
+            const compatible = byteMode ? new _type_utils_1.TypeUtils(scope).isHexLike(type) : new _type_utils_1.TypeUtils(scope).isCharLike(type);
+            if (compatible === false) {
+                throw new Error("Target type not compatible");
+            }
         }
         for (const s of node.findDirectExpressions(Expressions.Source)) {
-            new source_1.Source().runSyntax(s, scope, filename);
+            const type = new source_1.Source().runSyntax(s, scope, filename);
+            if (linesMode) {
+                if (!(type instanceof basic_1.UnknownType) && !(type instanceof basic_1.VoidType) && !(type instanceof basic_1.TableType)) {
+                    throw new Error("Source must be an internal table");
+                }
+                linesMode = false;
+                continue;
+            }
+            const compatible = byteMode ? new _type_utils_1.TypeUtils(scope).isHexLike(type) : new _type_utils_1.TypeUtils(scope).isCharLike(type);
+            if (compatible === false) {
+                throw new Error("Source type not compatible");
+            }
         }
     }
 }

package/build/src/abap/5_syntax/statements/controls.js

@@ -16,17 +16,17 @@ class Controls {
         if (node.findDirectTokenByText("TABLEVIEW") && token) {
             const cols = new basic_1.StructureType([
                 { name: "SCREEN", type: new basic_1.CharacterType(1) },
-                { name: "INDEX", type: new basic_1.IntegerType() },
+                { name: "INDEX", type: basic_1.IntegerType.get() },
                 { name: "SELECTED", type: new basic_1.CharacterType(1) },
-                { name: "VISLENGTH", type: new basic_1.IntegerType() },
+                { name: "VISLENGTH", type: basic_1.IntegerType.get() },
                 { name: "INVISIBLE", type: new basic_1.CharacterType(1) },
             ]);
             const type = new basic_1.StructureType([
                 { name: "FIXED_COLS", type: new basic_1.CharacterType(132) },
-                { name: "LINES", type: new basic_1.IntegerType() },
-                { name: "TOP_LINE", type: new basic_1.IntegerType() },
-                { name: "CURRENT_LINE", type: new basic_1.IntegerType() },
-                { name: "LEFT_COL", type: new basic_1.IntegerType() },
+                { name: "LINES", type: basic_1.IntegerType.get() },
+                { name: "TOP_LINE", type: basic_1.IntegerType.get() },
+                { name: "CURRENT_LINE", type: basic_1.IntegerType.get() },
+                { name: "LEFT_COL", type: basic_1.IntegerType.get() },
                 { name: "LINE_SEL_MODE", type: new basic_1.CharacterType(1) },
                 { name: "COL_SEL_MODE", type: new basic_1.CharacterType(1) },
                 { name: "LINE_SELECTOR", type: new basic_1.CharacterType(1) },

package/build/src/abap/5_syntax/statements/describe.js

@@ -20,7 +20,7 @@ class Describe {
         if ((linesTarget === null || linesTarget === void 0 ? void 0 : linesTarget.get()) instanceof Expressions.Target) {
             const inline = linesTarget === null || linesTarget === void 0 ? void 0 : linesTarget.findDirectExpression(Expressions.InlineData);
             if (inline) {
-                new inline_data_1.InlineData().runSyntax(inline, scope, filename, new basic_1.IntegerType());
+                new inline_data_1.InlineData().runSyntax(inline, scope, filename, basic_1.IntegerType.get());
             }
             else {
                 new target_1.Target().runSyntax(linesTarget, scope, filename);
@@ -40,7 +40,7 @@ class Describe {
         if ((lengthTarget === null || lengthTarget === void 0 ? void 0 : lengthTarget.get()) instanceof Expressions.Target) {
             const inline = lengthTarget === null || lengthTarget === void 0 ? void 0 : lengthTarget.findDirectExpression(Expressions.InlineData);
             if (inline) {
-                new inline_data_1.InlineData().runSyntax(inline, scope, filename, new basic_1.IntegerType());
+                new inline_data_1.InlineData().runSyntax(inline, scope, filename, basic_1.IntegerType.get());
             }
             else {
                 new target_1.Target().runSyntax(lengthTarget, scope, filename);
@@ -50,7 +50,7 @@ class Describe {
         if ((componentsTarget === null || componentsTarget === void 0 ? void 0 : componentsTarget.get()) instanceof Expressions.Target) {
             const inline = componentsTarget === null || componentsTarget === void 0 ? void 0 : componentsTarget.findDirectExpression(Expressions.InlineData);
             if (inline) {
-                new inline_data_1.InlineData().runSyntax(inline, scope, filename, new basic_1.IntegerType());
+                new inline_data_1.InlineData().runSyntax(inline, scope, filename, basic_1.IntegerType.get());
             }
             else {
                 new target_1.Target().runSyntax(componentsTarget, scope, filename);

package/build/src/abap/5_syntax/statements/find.js

@@ -14,13 +14,13 @@ class Find {
         const rfound = node.findExpressionAfterToken("RESULTS");
         if (rfound && rfound.get() instanceof Expressions.Target) {
             const sub = new basic_1.StructureType([
-                { name: "OFFSET", type: new basic_1.IntegerType() },
-                { name: "LENGTH", type: new basic_1.IntegerType() }
+                { name: "OFFSET", type: basic_1.IntegerType.get() },
+                { name: "LENGTH", type: basic_1.IntegerType.get() }
             ], "SUBMATCH_RESULT", "SUBMATCH_RESULT");
             const type = new basic_1.StructureType([
-                { name: "LINE", type: new basic_1.IntegerType() },
-                { name: "OFFSET", type: new basic_1.IntegerType() },
-                { name: "LENGTH", type: new basic_1.IntegerType() },
+                { name: "LINE", type: basic_1.IntegerType.get() },
+                { name: "OFFSET", type: basic_1.IntegerType.get() },
+                { name: "LENGTH", type: basic_1.IntegerType.get() },
                 { name: "SUBMATCHES", type: new basic_1.TableType(sub, { withHeader: false, keyType: basic_1.TableKeyType.default }) },
             ], "MATCH_RESULT", "MATCH_RESULT");
             if (node.concatTokens().toUpperCase().startsWith("FIND FIRST")) {
@@ -33,20 +33,20 @@ class Find {
         const ofound = node.findExpressionsAfterToken("OFFSET");
         for (const o of ofound) {
             if (o.get() instanceof Expressions.Target) {
-                this.inline(o, scope, filename, new basic_1.IntegerType());
+                this.inline(o, scope, filename, basic_1.IntegerType.get());
             }
         }
         const lfound = node.findExpressionAfterToken("LINE");
         if (lfound && lfound.get() instanceof Expressions.Target) {
-            this.inline(lfound, scope, filename, new basic_1.IntegerType());
+            this.inline(lfound, scope, filename, basic_1.IntegerType.get());
         }
         const cfound = node.findExpressionAfterToken("COUNT");
         if (cfound && cfound.get() instanceof Expressions.Target) {
-            this.inline(cfound, scope, filename, new basic_1.IntegerType());
+            this.inline(cfound, scope, filename, basic_1.IntegerType.get());
         }
         const lnfound = node.findExpressionAfterToken("LENGTH");
         if (lnfound && lnfound.get() instanceof Expressions.Target) {
-            this.inline(lnfound, scope, filename, new basic_1.IntegerType());
+            this.inline(lnfound, scope, filename, basic_1.IntegerType.get());
         }
         if (node.findDirectTokenByText("SUBMATCHES")) {
             for (const t of node.findDirectExpressions(Expressions.Target)) {
@@ -58,7 +58,7 @@ class Find {
                 }
                 const inline = t === null || t === void 0 ? void 0 : t.findDirectExpression(Expressions.InlineData);
                 if (inline) {
-                    new inline_data_1.InlineData().runSyntax(inline, scope, filename, new basic_1.StringType());
+                    new inline_data_1.InlineData().runSyntax(inline, scope, filename, basic_1.StringType.get());
                 }
                 else {
                     new target_1.Target().runSyntax(t, scope, filename);

package/build/src/abap/5_syntax/statements/get_bit.js

@@ -19,7 +19,7 @@ class GetBit {
         for (const t of node.findDirectExpressions(Expressions.Target)) {
             const inline = t === null || t === void 0 ? void 0 : t.findDirectExpression(Expressions.InlineData);
             if (inline) {
-                new inline_data_1.InlineData().runSyntax(t, scope, filename, new basic_1.IntegerType());
+                new inline_data_1.InlineData().runSyntax(t, scope, filename, basic_1.IntegerType.get());
             }
             else {
                 new target_1.Target().runSyntax(t, scope, filename);

package/build/src/abap/5_syntax/statements/get_run_time.js

@@ -10,7 +10,7 @@ class GetRunTime {
         const target = node.findDirectExpression(Expressions.Target);
         const inline = target === null || target === void 0 ? void 0 : target.findDirectExpression(Expressions.InlineData);
         if (inline) {
-            new inline_data_1.InlineData().runSyntax(inline, scope, filename, new basic_1.IntegerType());
+            new inline_data_1.InlineData().runSyntax(inline, scope, filename, basic_1.IntegerType.get());
         }
         else if (target) {
             new target_1.Target().runSyntax(target, scope, filename);

package/build/src/abap/5_syntax/statements/message.js

@@ -12,7 +12,7 @@ class Message {
         const found = node.findExpressionAfterToken("INTO");
         const inline = found === null || found === void 0 ? void 0 : found.findDirectExpression(Expressions.InlineData);
         if (inline) {
-            new inline_data_1.InlineData().runSyntax(inline, scope, filename, new basic_1.StringType());
+            new inline_data_1.InlineData().runSyntax(inline, scope, filename, basic_1.StringType.get());
         }
         else if (found) {
             new target_1.Target().runSyntax(found, scope, filename);

package/build/src/abap/5_syntax/statements/read_table.js

@@ -35,14 +35,14 @@ class ReadTable {
         const indexSource = node.findExpressionAfterToken("INDEX");
         if (indexSource) {
             const indexType = new source_1.Source().runSyntax(indexSource, scope, filename);
-            if (new _type_utils_1.TypeUtils(scope).isAssignable(indexType, new basic_1.IntegerType()) === false) {
+            if (new _type_utils_1.TypeUtils(scope).isAssignable(indexType, basic_1.IntegerType.get()) === false) {
                 throw new Error("READ TABLE, INDEX must be simple");
             }
         }
         const fromSource = node.findExpressionAfterToken("FROM");
         if (fromSource) {
             const fromType = new source_1.Source().runSyntax(fromSource, scope, filename);
-            if (new _type_utils_1.TypeUtils(scope).isAssignable(fromType, new basic_1.IntegerType()) === false) {
+            if (new _type_utils_1.TypeUtils(scope).isAssignable(fromType, basic_1.IntegerType.get()) === false) {
                 throw new Error("READ TABLE, FROM must be simple");
             }
         }

package/build/src/abap/5_syntax/statements/split.js

@@ -10,7 +10,7 @@ const _type_utils_1 = require("../_type_utils");
 class Split {
     runSyntax(node, scope, filename) {
         const intoTable = node.findTokenSequencePosition("INTO", "TABLE") !== undefined;
-        const type = intoTable ? new basic_1.TableType(new basic_1.StringType(), { withHeader: false, keyType: basic_1.TableKeyType.default }) : new basic_1.StringType();
+        const type = intoTable ? new basic_1.TableType(basic_1.StringType.get(), { withHeader: false, keyType: basic_1.TableKeyType.default }) : basic_1.StringType.get();
         for (const target of node.findAllExpressions(Expressions.Target)) {
             const inline = target.findDirectExpression(Expressions.InlineData);
             if (inline) {

package/build/src/abap/5_syntax/structures/type_enum.js

@@ -28,7 +28,7 @@ class TypeEnum {
             }
             const token = expr.getFirstToken();
             // integer is default if BASE TYPE is not specified
-            values.push(new _typed_identifier_1.TypedIdentifier(token, filename, new basic_1.IntegerType()));
+            values.push(new _typed_identifier_1.TypedIdentifier(token, filename, basic_1.IntegerType.get()));
         }
         for (const type of node.findDirectStatements(Statements.TypeEnum)) {
             const expr = type.findFirstExpression(Expressions.NamespaceSimpleName);
@@ -37,7 +37,7 @@ class TypeEnum {
             }
             const token = expr.getFirstToken();
             // integer is default if BASE TYPE is not specified
-            values.push(new _typed_identifier_1.TypedIdentifier(token, filename, new basic_1.IntegerType()));
+            values.push(new _typed_identifier_1.TypedIdentifier(token, filename, basic_1.IntegerType.get()));
         }
         const baseType = (_a = begin.findExpressionAfterToken("TYPE")) === null || _a === void 0 ? void 0 : _a.getFirstToken();
         const baseName = baseType === null || baseType === void 0 ? void 0 : baseType.getStr();

package/build/src/abap/types/basic/hex_type.js

@@ -6,7 +6,7 @@ class HexType extends _abstract_type_1.AbstractType {
     constructor(length, qualifiedName) {
         super({ qualifiedName: qualifiedName });
         if (length <= 0) {
-            throw new Error("Bad LENGTHm, Hex");
+            throw new Error("Bad LENGTH, Hex");
         }
         this.length = length;
     }

package/build/src/abap/types/basic/index.js

@@ -42,6 +42,7 @@ __exportStar(require("./time_type"), exports);
 __exportStar(require("./unknown_type"), exports);
 __exportStar(require("./utc_long_type"), exports);
 __exportStar(require("./void_type"), exports);
+__exportStar(require("./xgeneric_type"), exports);
 __exportStar(require("./xsequence_type"), exports);
 __exportStar(require("./xstring_type"), exports);
 //# sourceMappingURL=index.js.map

package/build/src/abap/types/basic/integer_type.js

@@ -3,6 +3,24 @@ Object.defineProperty(exports, "__esModule", { value: true });
 exports.IntegerType = void 0;
 const _abstract_type_1 = require("./_abstract_type");
 class IntegerType extends _abstract_type_1.AbstractType {
+    static get(input) {
+        if (input === undefined) {
+            return this.singleton;
+        }
+        return new IntegerType(input);
+    }
+    constructor(input) {
+        super(input);
+    }
+    /** fully qualified symbolic name of the type */
+    getQualifiedName() {
+        var _a;
+        const qual = (_a = this.data) === null || _a === void 0 ? void 0 : _a.qualifiedName;
+        if (qual === undefined) {
+            return "I";
+        }
+        return qual;
+    }
     toText() {
         return "```i```";
     }
@@ -20,4 +38,5 @@ class IntegerType extends _abstract_type_1.AbstractType {
     }
 }
 exports.IntegerType = IntegerType;
+IntegerType.singleton = new IntegerType();
 //# sourceMappingURL=integer_type.js.map

package/build/src/abap/types/basic/string_type.js

@@ -3,6 +3,24 @@ Object.defineProperty(exports, "__esModule", { value: true });
 exports.StringType = void 0;
 const _abstract_type_1 = require("./_abstract_type");
 class StringType extends _abstract_type_1.AbstractType {
+    static get(input) {
+        if (input === undefined) {
+            return this.singleton;
+        }
+        return new StringType(input);
+    }
+    constructor(input) {
+        super(input);
+    }
+    /** fully qualified symbolic name of the type */
+    getQualifiedName() {
+        var _a;
+        const qual = (_a = this.data) === null || _a === void 0 ? void 0 : _a.qualifiedName;
+        if (qual === undefined) {
+            return "STRING";
+        }
+        return qual;
+    }
     toText() {
         return "```string```";
     }
@@ -20,4 +38,5 @@ class StringType extends _abstract_type_1.AbstractType {
     }
 }
 exports.StringType = StringType;
+StringType.singleton = new StringType();
 //# sourceMappingURL=string_type.js.map

package/build/src/abap/types/basic/xgeneric_type.js

@@ -0,0 +1,23 @@
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.XGenericType = void 0;
+const _abstract_type_1 = require("./_abstract_type");
+class XGenericType extends _abstract_type_1.AbstractType {
+    toText() {
+        return "```x```";
+    }
+    isGeneric() {
+        return true;
+    }
+    toABAP() {
+        throw new Error("x, generic");
+    }
+    containsVoid() {
+        return false;
+    }
+    toCDS() {
+        return "abap.TODO_CGENERIC";
+    }
+}
+exports.XGenericType = XGenericType;
+//# sourceMappingURL=xgeneric_type.js.map

package/build/src/ddic.js

@@ -46,7 +46,7 @@ class DDIC {
     lookupBuiltinType(name, length, decimals, qualifiedName) {
         switch (name) {
             case "STRING":
-                return new Types.StringType({ qualifiedName: qualifiedName || name });
+                return Types.StringType.get({ qualifiedName: qualifiedName || name });
             case "XSTRING":
                 return new Types.XStringType({ qualifiedName: qualifiedName || name });
             case "D":
@@ -80,7 +80,7 @@ class DDIC {
             case "CSEQUENCE":
                 return new Types.CSequenceType({ qualifiedName: qualifiedName });
             case "I":
-                return new Types.IntegerType({ qualifiedName: qualifiedName || name });
+                return Types.IntegerType.get({ qualifiedName: qualifiedName || name });
             case "INT8": // todo, take version into account
                 return new Types.Integer8Type({ qualifiedName: qualifiedName || name });
             case "F":
@@ -370,13 +370,14 @@ class DDIC {
             case "INT1":
             case "INT2":
             case "INT4":
+                return Types.IntegerType.get({ qualifiedName: qualifiedName });
             case "INT8":
-                return new Types.IntegerType({ qualifiedName: qualifiedName });
+                return new Types.Integer8Type({ qualifiedName: qualifiedName });
             case "SSTR": // 1 <= len <= 1333
             case "SSTRING": // 1 <= len <= 1333
             case "STRG": // 256 <= len
             case "STRING": // 256 <= len
-                return new Types.StringType({ qualifiedName: qualifiedName || "STRING" });
+                return Types.StringType.get({ qualifiedName: qualifiedName });
             case "RSTR": // 256 <= len
             case "RAWSTRING": // 256 <= len
             case "GEOM_EWKB":

package/build/src/registry.js

@@ -65,7 +65,7 @@ class Registry {
     }
     static abaplintVersion() {
         // magic, see build script "version.sh"
-        return "2.101.14";
+        return "2.101.16";
     }
     getDDICReferences() {
         return this.ddicReferences;

package/build/src/rules/align_parameters.js

@@ -6,7 +6,9 @@ const Expressions = require("../abap/2_statements/expressions");
 const _abap_rule_1 = require("./_abap_rule");
 const _basic_rule_config_1 = require("./_basic_rule_config");
 const _irule_1 = require("./_irule");
+const position_1 = require("../position");
 const __1 = require("..");
+const edit_helper_1 = require("../edit_helper");
 class AlignParametersConf extends _basic_rule_config_1.BasicRuleConfig {
 }
 exports.AlignParametersConf = AlignParametersConf;
@@ -33,7 +35,8 @@ https://github.com/SAP/styleguides/blob/master/clean-abap/CleanABAP.md#align-par
 
 Does not take effect on non functional method calls, use https://rules.abaplint.org/functional_writing/
 
-Also https://rules.abaplint.org/max_one_method_parameter_per_line/ can help aligning parameter syntax`,
+If parameters are on the same row, no issues are reported, see
+https://rules.abaplint.org/max_one_method_parameter_per_line/ for splitting parameters to lines`,
             tags: [_irule_1.RuleTag.SingleFile, _irule_1.RuleTag.Whitespace, _irule_1.RuleTag.Styleguide],
             badExample: `CALL FUNCTION 'FOOBAR'
   EXPORTING
@@ -96,16 +99,28 @@ DATA(sdf) = VALUE type(
             return undefined;
         }
         let expectedEqualsColumn = 0;
+        let row = 0;
         for (const p of candidate.parameters) {
             const currentCol = p.left.getLastToken().getCol() + p.left.getLastToken().getStr().length + 1;
+            if (p.eq.getRow() === row) {
+                return undefined;
+            }
+            row = p.eq.getRow();
             if (currentCol > expectedEqualsColumn) {
                 expectedEqualsColumn = currentCol;
             }
         }
         for (const p of candidate.parameters) {
             if (p.eq.getCol() !== expectedEqualsColumn) {
+                let fix;
+                if (p.eq.getCol() < expectedEqualsColumn) {
+                    fix = edit_helper_1.EditHelper.insertAt(file, p.eq, " ".repeat(expectedEqualsColumn - p.eq.getCol()));
+                }
+                else {
+                    fix = edit_helper_1.EditHelper.deleteRange(file, new position_1.Position(p.eq.getRow(), expectedEqualsColumn), p.eq);
+                }
                 const message = "Align parameters to column " + expectedEqualsColumn;
-                return issue_1.Issue.atPosition(file, p.eq, message, this.getMetadata().key, this.getConfig().severity);
+                return issue_1.Issue.atPosition(file, p.eq, message, this.getMetadata().key, this.getConfig().severity, fix);
             }
         }
         return undefined;

package/build/src/rules/downport.js

@@ -669,6 +669,10 @@ Make sure to test the downported code, it might not always be completely correct
         else if (fieldList.concatTokens().toUpperCase() === "COUNT( * )") {
             fieldDefinition = `DATA ${name} TYPE i.`;
         }
+        else if (fieldList.concatTokens().toUpperCase() === "@ABAP_TRUE"
+            || fieldList.concatTokens().toUpperCase() === "@ABAP_FALSE") {
+            fieldDefinition = `DATA ${name} TYPE abap_bool.`;
+        }
         else if (fieldList.getChildren().length === 1 && fieldList.getChildren()[0].get() instanceof Expressions.SQLAggregation) {
             const c = fieldList.getChildren()[0];
             if (c instanceof nodes_1.ExpressionNode) {

package/build/src/rules/fully_type_itabs.js

@@ -45,11 +45,11 @@ DATA lt_bar TYPE STANDARD TABLE OF ty.`,
             const concat = tt.concatTokens().toUpperCase();
             if (concat.includes("TYPE TABLE OF")) {
                 const message = "Specify table type";
-                issues.push(issue_1.Issue.atStatement(file, statement, message, this.getMetadata().key, this.conf.severity));
+                issues.push(issue_1.Issue.atPosition(file, tt.getFirstToken().getStart(), message, this.getMetadata().key, this.conf.severity));
             }
             else if (concat.includes(" WITH ") === false && concat.includes(" RANGE OF ") === false) {
                 const message = "Specify table key";
-                issues.push(issue_1.Issue.atStatement(file, statement, message, this.getMetadata().key, this.conf.severity));
+                issues.push(issue_1.Issue.atPosition(file, tt.getFirstToken().getStart(), message, this.getMetadata().key, this.conf.severity));
             }
         }
         return issues;

package/build/src/rules/select_single_full_key.js

@@ -3,7 +3,6 @@ Object.defineProperty(exports, "__esModule", { value: true });
 exports.SelectSingleFullKey = exports.SelectSingleFullKeyConf = void 0;
 const issue_1 = require("../issue");
 const _basic_rule_config_1 = require("./_basic_rule_config");
-const _irule_1 = require("./_irule");
 const __1 = require("..");
 class SelectSingleFullKeyConf extends _basic_rule_config_1.BasicRuleConfig {
     constructor() {
@@ -23,7 +22,7 @@ class SelectSingleFullKey {
             shortDescription: `Detect SELECT SINGLE which are possibily not unique`,
             extendedInformation: `Table definitions must be known, ie. inside the errorNamespace`,
             pseudoComment: "EC CI_NOORDER",
-            tags: [_irule_1.RuleTag.Experimental],
+            tags: [],
         };
     }
     initialize(reg) {