@abaplint/core 2.101.10 → 2.101.12

package/build/src/abap/2_statements/statements/read_table.js

@@ -14,7 +14,7 @@ class ReadTable {
         const from = (0, combi_1.seq)("FROM", expressions_1.Source);
         const fields = (0, combi_1.plus)((0, combi_1.alt)((0, combi_1.seq)("INTO", (0, combi_1.failStar)()), expressions_1.FieldSub));
         const perm = (0, combi_1.per)((0, combi_1.alt)(index, key, from), expressions_1.ReadTableTarget, using, comparing, "CASTING", "TRANSPORTING ALL FIELDS", (0, combi_1.seq)("TRANSPORTING", (0, combi_1.altPrio)(expressions_1.Dynamic, fields)), "BINARY SEARCH");
-        return (0, combi_1.seq)("READ TABLE", (0, combi_1.alt)((0, combi_1.ver)(version_1.Version.v740sp02, expressions_1.Source), expressions_1.SimpleSource2), (0, combi_1.opt)(perm));
+        return (0, combi_1.seq)("READ TABLE", (0, combi_1.alt)(expressions_1.SimpleSource2, (0, combi_1.ver)(version_1.Version.v740sp02, expressions_1.Source)), (0, combi_1.opt)(perm));
     }
 }
 exports.ReadTable = ReadTable;

package/build/src/abap/5_syntax/_builtin.js

@@ -1173,7 +1173,7 @@ BuiltIn.methods = [
     {
         name: "XSTRLEN",
         mandatory: {
-            "val": new basic_1.XStringType(),
+            "val": new basic_1.XSequenceType(),
         },
         return: new basic_1.IntegerType(),
     },

package/build/src/abap/5_syntax/_type_utils.js

@@ -59,6 +59,7 @@ class TypeUtils {
             || type instanceof basic_1.UnknownType
             || type instanceof basic_1.NumericType
             || type instanceof basic_1.IntegerType
+            || type instanceof basic_1.Integer8Type
             || type instanceof basic_1.SimpleType
             || type instanceof basic_1.FloatType
             || type instanceof basic_1.FloatingPointType
@@ -208,7 +209,7 @@ class TypeUtils {
         return false;
     }
     isAssignableStrict(source, target) {
-        var _a, _b, _c, _d, _e;
+        var _a, _b, _c, _d, _e, _f;
         /*
             console.dir(source);
             console.dir(target);
@@ -247,8 +248,14 @@ class TypeUtils {
                 return false;
             }
         }
-        else if (source instanceof basic_1.StringType && target instanceof basic_1.StructureType) {
-            if (this.structureContainsString(target)) {
+        else if (source instanceof basic_1.StringType) {
+            if (target instanceof basic_1.StructureType && this.structureContainsString(target)) {
+                return false;
+            }
+            else if (target instanceof basic_1.XSequenceType) {
+                if (((_f = source.getAbstractTypeData()) === null || _f === void 0 ? void 0 : _f.derivedFromConstant) === true) {
+                    return true;
+                }
                 return false;
             }
             return true;
@@ -271,6 +278,11 @@ class TypeUtils {
                 return false;
             }
         }
+        else if (source instanceof basic_1.XStringType) {
+            if (target instanceof basic_1.CLikeType) {
+                return false;
+            }
+        }
         return this.isAssignable(source, target);
     }
     isAssignable(source, target) {

package/build/src/abap/5_syntax/expressions/constant.js

@@ -15,6 +15,9 @@ class Constant {
             }
             return new basic_1.CharacterType(len, { derivedFromConstant: true });
         }
+        else if (node.getFirstToken().getStr().startsWith("`")) {
+            return new basic_1.StringType({ qualifiedName: "STRING", derivedFromConstant: true });
+        }
         else {
             return new basic_1.StringType({ qualifiedName: "STRING" });
         }

package/build/src/abap/5_syntax/statements/get_bit.js

@@ -6,10 +6,15 @@ const source_1 = require("../expressions/source");
 const target_1 = require("../expressions/target");
 const basic_1 = require("../../types/basic");
 const inline_data_1 = require("../expressions/inline_data");
+const _type_utils_1 = require("../_type_utils");
 class GetBit {
     runSyntax(node, scope, filename) {
+        let lastType = undefined;
         for (const s of node.findDirectExpressions(Expressions.Source)) {
-            new source_1.Source().runSyntax(s, scope, filename);
+            lastType = new source_1.Source().runSyntax(s, scope, filename);
+        }
+        if (lastType && new _type_utils_1.TypeUtils(scope).isHexLike(lastType) === false) {
+            throw new Error("Input must be byte-like");
         }
         for (const t of node.findDirectExpressions(Expressions.Target)) {
             const inline = t === null || t === void 0 ? void 0 : t.findDirectExpression(Expressions.InlineData);

package/build/src/abap/5_syntax/statements/set_bit.js

@@ -4,13 +4,17 @@ exports.SetBit = void 0;
 const Expressions = require("../../2_statements/expressions");
 const source_1 = require("../expressions/source");
 const target_1 = require("../expressions/target");
+const _type_utils_1 = require("../_type_utils");
 class SetBit {
     runSyntax(node, scope, filename) {
         for (const s of node.findDirectExpressions(Expressions.Source)) {
             new source_1.Source().runSyntax(s, scope, filename);
         }
         for (const t of node.findDirectExpressions(Expressions.Target)) {
-            new target_1.Target().runSyntax(t, scope, filename);
+            const typ = new target_1.Target().runSyntax(t, scope, filename);
+            if (typ && new _type_utils_1.TypeUtils(scope).isHexLike(typ) === false) {
+                throw new Error("Input must be byte-like");
+            }
         }
     }
 }

package/build/src/registry.js

@@ -65,7 +65,7 @@ class Registry {
     }
     static abaplintVersion() {
         // magic, see build script "version.sh"
-        return "2.101.10";
+        return "2.101.12";
     }
     getDDICReferences() {
         return this.ddicReferences;

package/build/src/rules/downport.js

@@ -510,6 +510,10 @@ Make sure to test the downported code, it might not always be completely correct
         if (found) {
             return found;
         }
+        found = this.downportReadTable(high, lowFile, highSyntax);
+        if (found) {
+            return found;
+        }
         return undefined;
     }
     //////////////////////////////////////////
@@ -805,6 +809,22 @@ ${indentation}${uniqueName} = ${source.concatTokens()}.\n${indentation}`);
         }
         return undefined;
     }
+    downportReadTable(high, lowFile, highSyntax) {
+        if (!(high.get() instanceof Statements.ReadTable)) {
+            return undefined;
+        }
+        const source = high.findExpressionAfterToken("TABLE");
+        if ((source === null || source === void 0 ? void 0 : source.get()) instanceof Expressions.Source) {
+            const uniqueName = this.uniqueName(high.getFirstToken().getStart(), lowFile.getFilename(), highSyntax);
+            const indentation = " ".repeat(high.getFirstToken().getStart().getCol() - 1);
+            const firstToken = high.getFirstToken();
+            const fix1 = edit_helper_1.EditHelper.insertAt(lowFile, firstToken.getStart(), `DATA(${uniqueName}) = ${source.concatTokens()}.\n` + indentation);
+            const fix2 = edit_helper_1.EditHelper.replaceRange(lowFile, source.getFirstToken().getStart(), source.getLastToken().getEnd(), uniqueName);
+            const fix = edit_helper_1.EditHelper.merge(fix2, fix1);
+            return issue_1.Issue.atToken(lowFile, high.getFirstToken(), "Outline table source", this.getMetadata().key, this.conf.severity, fix);
+        }
+        return undefined;
+    }
     replaceInsertExpression(high, lowFile, highSyntax) {
         if (!(high.get() instanceof Statements.InsertInternal)) {
             return undefined;

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@abaplint/core",
-    "version": "2.101.10",
+    "version": "2.101.12",
     "description": "abaplint - Core API",
     "main": "build/src/index.js",
     "typings": "build/abaplint.d.ts",
@@ -53,7 +53,7 @@
         "@types/mocha": "^10.0.1",
         "@types/node": "^20.2.5",
         "chai": "^4.3.7",
-        "eslint": "^8.41.0",
+        "eslint": "^8.42.0",
         "mocha": "^10.2.0",
         "c8": "^7.14.0",
         "source-map-support": "^0.5.21",
@@ -61,7 +61,7 @@
         "typescript": "^5.1.3"
     },
     "dependencies": {
-        "fast-xml-parser": "^4.2.2",
+        "fast-xml-parser": "^4.2.3",
         "json5": "^2.2.3",
         "vscode-languageserver-types": "^3.17.3"
     }