@abaplint/core 2.100.2 → 2.100.4

package/build/src/abap/5_syntax/expressions/source.js

@@ -92,6 +92,7 @@ class Source {
                     {
                         const foundType = this.determineType(node, scope, filename, targetType);
                         new conv_body_1.ConvBody().runSyntax(node.findDirectExpression(Expressions.ConvBody), scope, filename);
+                        this.addIfInferred(node, scope, filename, foundType);
                         return foundType;
                     }
                 case "REF":

package/build/src/ddic.js

@@ -375,7 +375,7 @@ class DDIC {
             case "SSTRING": // 1 <= len <= 1333
             case "STRG": // 256 <= len
             case "STRING": // 256 <= len
-                return new Types.StringType({ qualifiedName: qualifiedName });
+                return new Types.StringType({ qualifiedName: qualifiedName || "STRING" });
             case "RSTR": // 256 <= len
             case "RAWSTRING": // 256 <= len
             case "GEOM_EWKB":

package/build/src/registry.js

@@ -65,7 +65,7 @@ class Registry {
     }
     static abaplintVersion() {
         // magic, see build script "version.sh"
-        return "2.100.2";
+        return "2.100.4";
     }
     getDDICReferences() {
         return this.ddicReferences;

package/build/src/rules/downport.js

@@ -2066,11 +2066,12 @@ ${indentation}    output = ${topTarget}.`;
                             body += indentation + structureName + "-" + b.concatTokens() + ".\n";
                         }
                         else if (b.get() instanceof Expressions.Source) {
-                            body += indentation + "APPEND " + b.concatTokens() + ` TO ${uniqueName}.\n`;
+                            // note: it wont work with APPEND for Hashed/Sorted Tables, so use INSERT,
+                            body += indentation + "INSERT " + b.concatTokens() + ` INTO TABLE ${uniqueName}.\n`;
                             skip = true;
                         }
                         else if (b.get() instanceof Expressions.ValueBodyLines) {
-                            body += indentation + "APPEND " + b.concatTokens() + ` TO ${uniqueName}.\n`;
+                            body += indentation + "INSERT " + b.concatTokens() + ` INTO TABLE ${uniqueName}.\n`;
                             skip = true;
                         }
                         else if (b.concatTokens() === ")") {
@@ -2079,7 +2080,7 @@ ${indentation}    output = ${topTarget}.`;
                                 added = true;
                             }
                             if (skip === false) {
-                                body += indentation + `APPEND ${structureName} TO ${uniqueName}.\n`;
+                                body += indentation + `INSERT ${structureName} INTO TABLE ${uniqueName}.\n`;
                             }
                         }
                         previous = b;

package/build/src/rules/empty_line_in_statement.js

@@ -27,8 +27,12 @@ class EmptyLineinStatement extends _abap_rule_1.ABAPRule {
             key: "empty_line_in_statement",
             title: "Find empty lines in statements",
             shortDescription: `Checks that statements do not contain empty lines.`,
-            extendedInformation: `https://docs.abapopenchecks.org/checks/41/`,
-            tags: [_irule_1.RuleTag.Quickfix, _irule_1.RuleTag.Whitespace, _irule_1.RuleTag.SingleFile],
+            extendedInformation: `https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#dont-obsess-with-separating-blank-lines
+
+https://docs.abapopenchecks.org/checks/41/`,
+            tags: [_irule_1.RuleTag.Quickfix, _irule_1.RuleTag.Whitespace, _irule_1.RuleTag.SingleFile, _irule_1.RuleTag.Styleguide],
+            badExample: `WRITE\n\nhello.`,
+            goodExample: `WRITE hello.`,
         };
     }
     getMessage() {

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@abaplint/core",
-    "version": "2.100.2",
+    "version": "2.100.4",
     "description": "abaplint - Core API",
     "main": "build/src/index.js",
     "typings": "build/abaplint.d.ts",
@@ -51,7 +51,7 @@
         "@microsoft/api-extractor": "^7.34.9",
         "@types/chai": "^4.3.5",
         "@types/mocha": "^10.0.1",
-        "@types/node": "^20.1.3",
+        "@types/node": "^20.2.0",
         "chai": "^4.3.7",
         "eslint": "^8.40.0",
         "mocha": "^10.2.0",