@abaplint/cli 2.99.4 → 2.99.6

package/build/cli.js

@@ -33924,7 +33924,7 @@ class CharacterType extends _abstract_type_1.AbstractType {
     constructor(length, extra) {
         super(extra);
         if (length <= 0) {
-            throw new Error("Bad LENGTH");
+            throw new Error("Bad LENGTH, Character");
         }
         this.length = length;
     }
@@ -34295,7 +34295,7 @@ class FloatingPointType extends _abstract_type_1.AbstractType {
     constructor(length, qualifiedName) {
         super({ qualifiedName: qualifiedName });
         if (length <= 0) {
-            throw new Error("Bad LENGTH");
+            throw new Error("Bad LENGTH, Floating Point");
         }
         this.length = length;
     }
@@ -34372,7 +34372,7 @@ class HexType extends _abstract_type_1.AbstractType {
     constructor(length, qualifiedName) {
         super({ qualifiedName: qualifiedName });
         if (length <= 0) {
-            throw new Error("Bad LENGTH");
+            throw new Error("Bad LENGTHm, Hex");
         }
         this.length = length;
     }
@@ -34537,7 +34537,7 @@ class NumericType extends _abstract_type_1.AbstractType {
     constructor(length, qualifiedName) {
         super({ qualifiedName: qualifiedName });
         if (length <= 0) {
-            throw new Error("Bad LENGTH");
+            throw new Error("Bad LENGTH, Numeric");
         }
         this.length = length;
     }
@@ -34624,10 +34624,10 @@ class PackedType extends _abstract_type_1.AbstractType {
     constructor(length, decimals, extra) {
         super(extra);
         if (length <= 0) {
-            throw new Error("Bad LENGTH");
+            throw new Error("Bad LENGTH, Packed");
         }
         else if (decimals < 0) {
-            throw new Error("Bad DECIMALS");
+            throw new Error("Bad DECIMALS, Packed");
         }
         this.length = length;
         this.decimals = decimals;
@@ -37739,9 +37739,10 @@ class Config {
         return new Config(JSON.stringify(config));
     }
     getEnabledRules() {
+        var _a;
         const rules = [];
         for (const rule of artifacts_rules_1.ArtifactsRules.getRules()) {
-            const ruleConfig = this.config["rules"][rule.getMetadata().key];
+            const ruleConfig = (_a = this.config["rules"]) === null || _a === void 0 ? void 0 : _a[rule.getMetadata().key];
             const ruleExists = ruleConfig !== undefined;
             if (ruleExists) {
                 if (ruleConfig === false) { // "rule": false
@@ -45096,6 +45097,7 @@ class RenameDataElement {
         changes = changes.concat(helper.renameDDICCodeReferences(obj, oldName, newName));
         changes = changes.concat(helper.renameDDICTABLReferences(obj, oldName, newName));
         changes = changes.concat(helper.renameDDICTTYPReferences(obj, oldName, newName));
+        changes = changes.concat(helper.renameDDICAUTHReferences(obj, oldName, newName));
         return {
             documentChanges: changes,
         };
@@ -45565,6 +45567,21 @@ class RenamerHelper {
         }
         return changes;
     }
+    renameDDICAUTHReferences(obj, oldName, newName) {
+        const changes = [];
+        const used = this.reg.getDDICReferences().listWhereUsed(obj);
+        for (const u of used) {
+            if (u.type !== "AUTH") {
+                continue;
+            }
+            const tabl = this.reg.getObject(u.type, u.name);
+            if (tabl === undefined) {
+                continue;
+            }
+            changes.push(...this.buildXMLFileEdits(tabl, "ROLLNAME", oldName, newName));
+        }
+        return changes;
+    }
     buildXMLFileEdits(object, xmlTag, oldName, newName) {
         const changes = [];
         const xml = object.getXMLFile();
@@ -47558,7 +47575,7 @@ class Registry {
     }
     static abaplintVersion() {
         // magic, see build script "version.sh"
-        return "2.99.4";
+        return "2.99.6";
     }
     getDDICReferences() {
         return this.references;
@@ -49847,10 +49864,12 @@ class CheckComments extends _abap_rule_1.ABAPRule {
             shortDescription: `
 Various checks for comment usage.`,
             extendedInformation: `
-* End of line comments. Comments starting with "#EC" or "##" are ignored
+Detects end of line comments. Comments starting with "#EC" or "##" are ignored
 
 https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#put-comments-before-the-statement-they-relate-to`,
             tags: [_irule_1.RuleTag.Styleguide, _irule_1.RuleTag.SingleFile],
+            badExample: `WRITE 2. " descriptive comment`,
+            goodExample: `" descriptive comment\nWRITE 2.`,
         };
     }
     getDescription(issueType) {
@@ -63721,6 +63740,10 @@ const _basic_rule_config_1 = __webpack_require__(/*! ./_basic_rule_config */ "./
 const _irule_1 = __webpack_require__(/*! ./_irule */ "./node_modules/@abaplint/core/build/src/rules/_irule.js");
 const __1 = __webpack_require__(/*! .. */ "./node_modules/@abaplint/core/build/src/index.js");
 class SelectSingleFullKeyConf extends _basic_rule_config_1.BasicRuleConfig {
+    constructor() {
+        super(...arguments);
+        this.allowPseudo = true;
+    }
 }
 exports.SelectSingleFullKeyConf = SelectSingleFullKeyConf;
 class SelectSingleFullKey {
@@ -63742,6 +63765,14 @@ class SelectSingleFullKey {
         return this;
     }
     getConfig() {
+        if (this.conf === undefined) {
+            this.conf = {
+                allowPseudo: true,
+            };
+        }
+        if (this.conf.allowPseudo === undefined) {
+            this.conf.allowPseudo = true;
+        }
         return this.conf;
     }
     setConfig(conf) {
@@ -63773,7 +63804,11 @@ class SelectSingleFullKey {
                     continue;
                 }
                 const next = statements[i + 1];
-                if ((next === null || next === void 0 ? void 0 : next.get()) instanceof __1.Comment && next.concatTokens().includes(this.getMetadata().pseudoComment + "")) {
+                if ((next === null || next === void 0 ? void 0 : next.get()) instanceof __1.Comment
+                    && next.concatTokens().includes(this.getMetadata().pseudoComment + "")) {
+                    if (this.getConfig().allowPseudo !== true) {
+                        issues.push(issue_1.Issue.atStatement(file, s, "Pseudo comment not allowed", this.getMetadata().key, this.getConfig().severity));
+                    }
                     continue;
                 }
                 const tabl = this.findReference(databaseTable.getFirstToken().getStart(), syntax.spaghetti, file);
@@ -63782,7 +63817,6 @@ class SelectSingleFullKey {
                     continue;
                 }
                 const keys = table.listKeys(this.reg);
-                //        const type = table.parseType(this.reg);
                 const cond = s.findFirstExpression(__1.Expressions.SQLCond);
                 const set = new Set();
                 for (const key of keys) {
@@ -66049,6 +66083,7 @@ ENDIF.`,
             && !(statement.get() instanceof Statements.DataEnd)
             && !(statement.get() instanceof Statements.Type)
             && !(statement.get() instanceof Statements.Form)
+            && !(statement.get() instanceof Statements.Tables)
             && !(statement.get() instanceof Statements.TypeEnd)
             && !(statement.get() instanceof Statements.Constant)
             && !(statement.get() instanceof Statements.ConstantEnd)

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@abaplint/cli",
-    "version": "2.99.4",
+    "version": "2.99.6",
     "description": "abaplint - Command Line Interface",
     "bin": {
         "abaplint": "./abaplint"
@@ -37,12 +37,12 @@
     },
     "homepage": "https://abaplint.org",
     "devDependencies": {
-        "@abaplint/core": "^2.99.4",
+        "@abaplint/core": "^2.99.6",
         "@types/chai": "^4.3.5",
         "@types/glob": "^7.2.0",
         "@types/minimist": "^1.2.2",
         "@types/mocha": "^10.0.1",
-        "@types/node": "^18.16.3",
+        "@types/node": "^20.0.0",
         "@types/progress": "^2.0.5",
         "chai": "^4.3.7",
         "chalk": "^5.2.0",
@@ -54,7 +54,7 @@
         "mocha": "^10.2.0",
         "progress": "^2.0.3",
         "typescript": "^5.0.4",
-        "webpack": "^5.81.0",
+        "webpack": "^5.82.0",
         "webpack-cli": "^5.0.2",
         "xml-js": "^1.6.11"
     },