@abaplint/cli 2.91.3 → 2.91.4

package/build/cli.js

@@ -11302,7 +11302,7 @@ eval("\r\nObject.defineProperty(exports, \"__esModule\", ({ value: true }));\r\n
 /***/ ((__unused_webpack_module, exports, __webpack_require__) => {
 
 "use strict";
-eval("\nObject.defineProperty(exports, \"__esModule\", ({ value: true }));\nexports.Registry = void 0;\nconst config_1 = __webpack_require__(/*! ./config */ \"./node_modules/@abaplint/core/build/src/config.js\");\nconst artifacts_objects_1 = __webpack_require__(/*! ./artifacts_objects */ \"./node_modules/@abaplint/core/build/src/artifacts_objects.js\");\nconst artifacts_rules_1 = __webpack_require__(/*! ./artifacts_rules */ \"./node_modules/@abaplint/core/build/src/artifacts_rules.js\");\nconst skip_logic_1 = __webpack_require__(/*! ./skip_logic */ \"./node_modules/@abaplint/core/build/src/skip_logic.js\");\nconst _abap_object_1 = __webpack_require__(/*! ./objects/_abap_object */ \"./node_modules/@abaplint/core/build/src/objects/_abap_object.js\");\nconst find_global_definitions_1 = __webpack_require__(/*! ./abap/5_syntax/global_definitions/find_global_definitions */ \"./node_modules/@abaplint/core/build/src/abap/5_syntax/global_definitions/find_global_definitions.js\");\nconst syntax_1 = __webpack_require__(/*! ./abap/5_syntax/syntax */ \"./node_modules/@abaplint/core/build/src/abap/5_syntax/syntax.js\");\nconst excludeHelper_1 = __webpack_require__(/*! ./utils/excludeHelper */ \"./node_modules/@abaplint/core/build/src/utils/excludeHelper.js\");\nconst ddic_references_1 = __webpack_require__(/*! ./ddic_references */ \"./node_modules/@abaplint/core/build/src/ddic_references.js\");\n// todo, this should really be an instance in case there are multiple Registry'ies\nclass ParsingPerformance {\n    static clear() {\n        this.results = [];\n        this.lexing = 0;\n        this.statements = 0;\n        this.structure = 0;\n    }\n    static push(obj, result) {\n        if (result.runtimeExtra) {\n            this.lexing += result.runtimeExtra.lexing;\n            this.statements += result.runtimeExtra.statements;\n            this.structure += result.runtimeExtra.structure;\n        }\n        if (result.runtime < 100) {\n            return;\n        }\n        if (this.results === undefined) {\n            this.results = [];\n        }\n        let extra = \"\";\n        if (result.runtimeExtra) {\n            extra = `\\t(lexing: ${result.runtimeExtra.lexing}ms, statements: ${result.runtimeExtra.statements}ms, structure: ${result.runtimeExtra.structure}ms)`;\n        }\n        this.results.push({\n            runtime: result.runtime,\n            extra,\n            name: obj.getType() + \" \" + obj.getName(),\n        });\n    }\n    static output() {\n        const MAX = 10;\n        this.results.sort((a, b) => { return b.runtime - a.runtime; });\n        for (let i = 0; i < MAX; i++) {\n            const row = this.results[i];\n            if (row === undefined) {\n                break;\n            }\n            process.stderr.write(`\\t${row.runtime}ms\\t${row.name} ${row.extra}\\n`);\n        }\n        process.stderr.write(`\\tTotal lexing:     ${this.lexing}ms\\n`);\n        process.stderr.write(`\\tTotal statements: ${this.statements}ms\\n`);\n        process.stderr.write(`\\tTotal structure:  ${this.structure}ms\\n`);\n    }\n}\n///////////////////////////////////////////////////////////////////////////////////////////////\nclass Registry {\n    constructor(conf) {\n        this.objects = {};\n        this.objectsByType = {};\n        /** object containing filenames of dependencies */\n        this.dependencies = {};\n        this.issues = [];\n        this.conf = conf ? conf : config_1.Config.getDefault();\n        this.references = new ddic_references_1.DDICReferences();\n    }\n    static abaplintVersion() {\n        // magic, see build script \"version.sh\"\n        return \"2.91.3\";\n    }\n    getDDICReferences() {\n        return this.references;\n    }\n    *getObjects() {\n        for (const name in this.objects) {\n            for (const type in this.objects[name]) {\n                yield this.objects[name][type];\n            }\n        }\n    }\n    *getObjectsByType(type) {\n        for (const name in this.objectsByType[type] || []) {\n            yield this.objectsByType[type][name];\n        }\n    }\n    *getFiles() {\n        for (const obj of this.getObjects()) {\n            for (const file of obj.getFiles()) {\n                yield file;\n            }\n        }\n    }\n    getFirstObject() {\n        for (const name in this.objects) {\n            for (const type in this.objects[name]) {\n                return this.objects[name][type];\n            }\n        }\n        return undefined;\n    }\n    getObjectCount(skipDependencies = true) {\n        let res = 0;\n        for (const o of this.getObjects()) {\n            if (skipDependencies === true && this.isDependency(o)) {\n                continue;\n            }\n            res = res + 1;\n        }\n        return res;\n    }\n    getFileByName(filename) {\n        const upper = filename.toUpperCase();\n        for (const o of this.getObjects()) {\n            for (const f of o.getFiles()) {\n                if (f.getFilename().toUpperCase() === upper) {\n                    return f;\n                }\n            }\n        }\n        return undefined;\n    }\n    getObject(type, name) {\n        if (type === undefined || name === undefined) {\n            return undefined;\n        }\n        const searchName = name.toUpperCase();\n        if (this.objects[searchName]) {\n            return this.objects[searchName][type];\n        }\n        return undefined;\n    }\n    getConfig() {\n        return this.conf;\n    }\n    // assumption: Config is immutable, and can only be changed via this method\n    setConfig(conf) {\n        for (const obj of this.getObjects()) {\n            obj.setDirty();\n        }\n        this.conf = conf;\n        return this;\n    }\n    inErrorNamespace(name) {\n        const reg = new RegExp(this.getConfig().getSyntaxSetttings().errorNamespace, \"i\");\n        return reg.test(name);\n    }\n    addFile(file) {\n        return this.addFiles([file]);\n    }\n    updateFile(file) {\n        const obj = this.find(file.getObjectName(), file.getObjectType());\n        obj.updateFile(file);\n        return this;\n    }\n    removeFile(file) {\n        const obj = this.find(file.getObjectName(), file.getObjectType());\n        obj.removeFile(file);\n        if (obj.getFiles().length === 0) {\n            this.references.clear(obj);\n            this.removeObject(obj);\n        }\n        return this;\n    }\n    addFiles(files) {\n        var _a;\n        const globalExclude = ((_a = this.conf.getGlobal().exclude) !== null && _a !== void 0 ? _a : [])\n            .map(pattern => new RegExp(pattern, \"i\"));\n        for (const f of files) {\n            const filename = f.getFilename();\n            const isNotAbapgitFile = filename.split(\".\").length <= 2;\n            if (isNotAbapgitFile || excludeHelper_1.ExcludeHelper.isExcluded(filename, globalExclude)) {\n                continue;\n            }\n            const found = this.findOrCreate(f.getObjectName(), f.getObjectType());\n            found.addFile(f);\n        }\n        return this;\n    }\n    addDependencies(files) {\n        for (const f of files) {\n            this.dependencies[f.getFilename().toUpperCase()] = true;\n        }\n        return this.addFiles(files);\n    }\n    addDependency(file) {\n        this.dependencies[file.getFilename().toUpperCase()] = true;\n        this.addFile(file);\n        return this;\n    }\n    isDependency(obj) {\n        const filename = obj.getFiles()[0].getFilename().toUpperCase();\n        return this.dependencies[filename] === true;\n    }\n    isFileDependency(filename) {\n        return this.dependencies[filename.toUpperCase()] === true;\n    }\n    // assumption: the file is already in the registry\n    findObjectForFile(file) {\n        const filename = file.getFilename();\n        for (const obj of this.getObjects()) {\n            for (const ofile of obj.getFiles()) {\n                if (ofile.getFilename() === filename) {\n                    return obj;\n                }\n            }\n        }\n        return undefined;\n    }\n    // todo, this will be changed to async sometime\n    findIssues(input) {\n        if (this.isDirty() === true) {\n            this.parse();\n        }\n        return this.runRules(input);\n    }\n    // todo, this will be changed to async sometime\n    findIssuesObject(iobj) {\n        if (this.isDirty() === true) {\n            this.parse();\n        }\n        return this.runRules(undefined, iobj);\n    }\n    // todo, this will be changed to async sometime\n    parse() {\n        if (this.isDirty() === false) {\n            return this;\n        }\n        ParsingPerformance.clear();\n        this.issues = [];\n        for (const o of this.getObjects()) {\n            this.parsePrivate(o);\n            this.issues.push(...o.getParsingIssues());\n        }\n        new find_global_definitions_1.FindGlobalDefinitions(this).run();\n        return this;\n    }\n    async parseAsync(input) {\n        var _a, _b;\n        if (this.isDirty() === false) {\n            return this;\n        }\n        ParsingPerformance.clear();\n        (_a = input === null || input === void 0 ? void 0 : input.progress) === null || _a === void 0 ? void 0 : _a.set(this.getObjectCount(false), \"Lexing and parsing\");\n        this.issues = [];\n        for (const o of this.getObjects()) {\n            await ((_b = input === null || input === void 0 ? void 0 : input.progress) === null || _b === void 0 ? void 0 : _b.tick(\"Lexing and parsing(\" + this.conf.getVersion() + \") - \" + o.getType() + \" \" + o.getName()));\n            this.parsePrivate(o);\n            this.issues.push(...o.getParsingIssues());\n        }\n        if ((input === null || input === void 0 ? void 0 : input.outputPerformance) === true) {\n            ParsingPerformance.output();\n        }\n        new find_global_definitions_1.FindGlobalDefinitions(this).run(input === null || input === void 0 ? void 0 : input.progress);\n        return this;\n    }\n    //////////////////////////////////////////\n    // todo, refactor, this is a mess, see where-used, a lot of the code should be in this method instead\n    parsePrivate(input) {\n        const config = this.getConfig();\n        const result = input.parse(config.getVersion(), config.getSyntaxSetttings().globalMacros, this);\n        ParsingPerformance.push(input, result);\n    }\n    isDirty() {\n        for (const o of this.getObjects()) {\n            const dirty = o.isDirty();\n            if (dirty === true) {\n                return true;\n            }\n        }\n        return false;\n    }\n    runRules(input, iobj) {\n        var _a, _b, _c, _d, _e, _f;\n        const rulePerformance = {};\n        const issues = this.issues.slice(0);\n        const objects = iobj ? [iobj] : this.getObjects();\n        const rules = this.conf.getEnabledRules();\n        const skipLogic = new skip_logic_1.SkipLogic(this);\n        (_a = input === null || input === void 0 ? void 0 : input.progress) === null || _a === void 0 ? void 0 : _a.set(iobj ? 1 : this.getObjectCount(false), \"Run Syntax\");\n        const check = [];\n        for (const obj of objects) {\n            (_b = input === null || input === void 0 ? void 0 : input.progress) === null || _b === void 0 ? void 0 : _b.tick(\"Run Syntax - \" + obj.getName());\n            if (skipLogic.skip(obj) || this.isDependency(obj)) {\n                continue;\n            }\n            if (obj instanceof _abap_object_1.ABAPObject) {\n                new syntax_1.SyntaxLogic(this, obj).run();\n            }\n            check.push(obj);\n        }\n        (_c = input === null || input === void 0 ? void 0 : input.progress) === null || _c === void 0 ? void 0 : _c.set(rules.length, \"Initialize Rules\");\n        for (const rule of rules) {\n            (_d = input === null || input === void 0 ? void 0 : input.progress) === null || _d === void 0 ? void 0 : _d.tick(\"Initialize Rules - \" + rule.getMetadata().key);\n            if (rule.initialize === undefined) {\n                throw new Error(rule.getMetadata().key + \" missing initialize method\");\n            }\n            rule.initialize(this);\n            rulePerformance[rule.getMetadata().key] = 0;\n        }\n        (_e = input === null || input === void 0 ? void 0 : input.progress) === null || _e === void 0 ? void 0 : _e.set(check.length, \"Finding Issues\");\n        for (const obj of check) {\n            (_f = input === null || input === void 0 ? void 0 : input.progress) === null || _f === void 0 ? void 0 : _f.tick(\"Finding Issues - \" + obj.getType() + \" \" + obj.getName());\n            for (const rule of rules) {\n                const before = Date.now();\n                issues.push(...rule.run(obj));\n                const runtime = Date.now() - before;\n                rulePerformance[rule.getMetadata().key] = rulePerformance[rule.getMetadata().key] + runtime;\n            }\n        }\n        if ((input === null || input === void 0 ? void 0 : input.outputPerformance) === true) {\n            const perf = [];\n            for (const p in rulePerformance) {\n                if (rulePerformance[p] > 100) { // ignore rules if it takes less than 100ms\n                    perf.push({ name: p, time: rulePerformance[p] });\n                }\n            }\n            perf.sort((a, b) => { return b.time - a.time; });\n            for (const p of perf) {\n                process.stderr.write(\"\\t\" + p.time + \"ms\\t\" + p.name + \"\\n\");\n            }\n        }\n        return this.excludeIssues(issues);\n    }\n    excludeIssues(issues) {\n        var _a;\n        const ret = issues;\n        const globalNoIssues = this.conf.getGlobal().noIssues || [];\n        const globalNoIssuesPatterns = globalNoIssues.map(x => new RegExp(x, \"i\"));\n        if (globalNoIssuesPatterns.length > 0) {\n            for (let i = ret.length - 1; i >= 0; i--) {\n                const filename = ret[i].getFilename();\n                if (excludeHelper_1.ExcludeHelper.isExcluded(filename, globalNoIssuesPatterns)) {\n                    ret.splice(i, 1);\n                }\n            }\n        }\n        // exclude issues, as now we know both the filename and issue key\n        for (const rule of artifacts_rules_1.ArtifactsRules.getRules()) {\n            const key = rule.getMetadata().key;\n            const ruleExclude = (_a = this.conf.readByKey(key, \"exclude\")) !== null && _a !== void 0 ? _a : [];\n            if (ruleExclude.length === 0) {\n                continue;\n            }\n            const ruleExcludePatterns = ruleExclude.map(x => new RegExp(x, \"i\"));\n            for (let i = ret.length - 1; i >= 0; i--) {\n                if (ret[i].getKey() !== key) {\n                    continue;\n                }\n                const filename = ret[i].getFilename();\n                if (excludeHelper_1.ExcludeHelper.isExcluded(filename, ruleExcludePatterns)) {\n                    ret.splice(i, 1);\n                }\n            }\n        }\n        return ret;\n    }\n    findOrCreate(name, type) {\n        try {\n            return this.find(name, type);\n        }\n        catch (_a) {\n            const newName = name.toUpperCase();\n            const newType = type ? type : \"UNKNOWN\";\n            const add = artifacts_objects_1.ArtifactsObjects.newObject(newName, newType);\n            if (this.objects[newName] === undefined) {\n                this.objects[newName] = {};\n            }\n            this.objects[newName][newType] = add;\n            if (this.objectsByType[newType] === undefined) {\n                this.objectsByType[newType] = {};\n            }\n            this.objectsByType[newType][newName] = add;\n            return add;\n        }\n    }\n    removeObject(remove) {\n        if (remove === undefined) {\n            return;\n        }\n        if (this.objects[remove.getName()][remove.getType()] === undefined) {\n            throw new Error(\"removeObject: object not found\");\n        }\n        if (Object.keys(this.objects[remove.getName()]).length === 1) {\n            delete this.objects[remove.getName()];\n        }\n        else {\n            delete this.objects[remove.getName()][remove.getType()];\n        }\n        if (Object.keys(this.objectsByType[remove.getType()]).length === 1) {\n            delete this.objectsByType[remove.getType()];\n        }\n        else {\n            delete this.objectsByType[remove.getType()][remove.getName()];\n        }\n    }\n    find(name, type) {\n        const searchType = type ? type : \"UNKNOWN\";\n        const searchName = name.toUpperCase();\n        if (this.objects[searchName] !== undefined\n            && this.objects[searchName][searchType]) {\n            return this.objects[searchName][searchType];\n        }\n        throw new Error(\"find: object not found, \" + type + \" \" + name);\n    }\n}\nexports.Registry = Registry;\n//# sourceMappingURL=registry.js.map\n\n//# sourceURL=webpack://@abaplint/cli/./node_modules/@abaplint/core/build/src/registry.js?");
+eval("\nObject.defineProperty(exports, \"__esModule\", ({ value: true }));\nexports.Registry = void 0;\nconst config_1 = __webpack_require__(/*! ./config */ \"./node_modules/@abaplint/core/build/src/config.js\");\nconst artifacts_objects_1 = __webpack_require__(/*! ./artifacts_objects */ \"./node_modules/@abaplint/core/build/src/artifacts_objects.js\");\nconst artifacts_rules_1 = __webpack_require__(/*! ./artifacts_rules */ \"./node_modules/@abaplint/core/build/src/artifacts_rules.js\");\nconst skip_logic_1 = __webpack_require__(/*! ./skip_logic */ \"./node_modules/@abaplint/core/build/src/skip_logic.js\");\nconst _abap_object_1 = __webpack_require__(/*! ./objects/_abap_object */ \"./node_modules/@abaplint/core/build/src/objects/_abap_object.js\");\nconst find_global_definitions_1 = __webpack_require__(/*! ./abap/5_syntax/global_definitions/find_global_definitions */ \"./node_modules/@abaplint/core/build/src/abap/5_syntax/global_definitions/find_global_definitions.js\");\nconst syntax_1 = __webpack_require__(/*! ./abap/5_syntax/syntax */ \"./node_modules/@abaplint/core/build/src/abap/5_syntax/syntax.js\");\nconst excludeHelper_1 = __webpack_require__(/*! ./utils/excludeHelper */ \"./node_modules/@abaplint/core/build/src/utils/excludeHelper.js\");\nconst ddic_references_1 = __webpack_require__(/*! ./ddic_references */ \"./node_modules/@abaplint/core/build/src/ddic_references.js\");\n// todo, this should really be an instance in case there are multiple Registry'ies\nclass ParsingPerformance {\n    static clear() {\n        this.results = [];\n        this.lexing = 0;\n        this.statements = 0;\n        this.structure = 0;\n    }\n    static push(obj, result) {\n        if (result.runtimeExtra) {\n            this.lexing += result.runtimeExtra.lexing;\n            this.statements += result.runtimeExtra.statements;\n            this.structure += result.runtimeExtra.structure;\n        }\n        if (result.runtime < 100) {\n            return;\n        }\n        if (this.results === undefined) {\n            this.results = [];\n        }\n        let extra = \"\";\n        if (result.runtimeExtra) {\n            extra = `\\t(lexing: ${result.runtimeExtra.lexing}ms, statements: ${result.runtimeExtra.statements}ms, structure: ${result.runtimeExtra.structure}ms)`;\n        }\n        this.results.push({\n            runtime: result.runtime,\n            extra,\n            name: obj.getType() + \" \" + obj.getName(),\n        });\n    }\n    static output() {\n        const MAX = 10;\n        this.results.sort((a, b) => { return b.runtime - a.runtime; });\n        for (let i = 0; i < MAX; i++) {\n            const row = this.results[i];\n            if (row === undefined) {\n                break;\n            }\n            process.stderr.write(`\\t${row.runtime}ms\\t${row.name} ${row.extra}\\n`);\n        }\n        process.stderr.write(`\\tTotal lexing:     ${this.lexing}ms\\n`);\n        process.stderr.write(`\\tTotal statements: ${this.statements}ms\\n`);\n        process.stderr.write(`\\tTotal structure:  ${this.structure}ms\\n`);\n    }\n}\n///////////////////////////////////////////////////////////////////////////////////////////////\nclass Registry {\n    constructor(conf) {\n        this.objects = {};\n        this.objectsByType = {};\n        /** object containing filenames of dependencies */\n        this.dependencies = {};\n        this.issues = [];\n        this.conf = conf ? conf : config_1.Config.getDefault();\n        this.references = new ddic_references_1.DDICReferences();\n    }\n    static abaplintVersion() {\n        // magic, see build script \"version.sh\"\n        return \"2.91.4\";\n    }\n    getDDICReferences() {\n        return this.references;\n    }\n    *getObjects() {\n        for (const name in this.objects) {\n            for (const type in this.objects[name]) {\n                yield this.objects[name][type];\n            }\n        }\n    }\n    *getObjectsByType(type) {\n        for (const name in this.objectsByType[type] || []) {\n            yield this.objectsByType[type][name];\n        }\n    }\n    *getFiles() {\n        for (const obj of this.getObjects()) {\n            for (const file of obj.getFiles()) {\n                yield file;\n            }\n        }\n    }\n    getFirstObject() {\n        for (const name in this.objects) {\n            for (const type in this.objects[name]) {\n                return this.objects[name][type];\n            }\n        }\n        return undefined;\n    }\n    getObjectCount(skipDependencies = true) {\n        let res = 0;\n        for (const o of this.getObjects()) {\n            if (skipDependencies === true && this.isDependency(o)) {\n                continue;\n            }\n            res = res + 1;\n        }\n        return res;\n    }\n    getFileByName(filename) {\n        const upper = filename.toUpperCase();\n        for (const o of this.getObjects()) {\n            for (const f of o.getFiles()) {\n                if (f.getFilename().toUpperCase() === upper) {\n                    return f;\n                }\n            }\n        }\n        return undefined;\n    }\n    getObject(type, name) {\n        if (type === undefined || name === undefined) {\n            return undefined;\n        }\n        const searchName = name.toUpperCase();\n        if (this.objects[searchName]) {\n            return this.objects[searchName][type];\n        }\n        return undefined;\n    }\n    getConfig() {\n        return this.conf;\n    }\n    // assumption: Config is immutable, and can only be changed via this method\n    setConfig(conf) {\n        for (const obj of this.getObjects()) {\n            obj.setDirty();\n        }\n        this.conf = conf;\n        return this;\n    }\n    inErrorNamespace(name) {\n        const reg = new RegExp(this.getConfig().getSyntaxSetttings().errorNamespace, \"i\");\n        return reg.test(name);\n    }\n    addFile(file) {\n        return this.addFiles([file]);\n    }\n    updateFile(file) {\n        const obj = this.find(file.getObjectName(), file.getObjectType());\n        obj.updateFile(file);\n        return this;\n    }\n    removeFile(file) {\n        const obj = this.find(file.getObjectName(), file.getObjectType());\n        obj.removeFile(file);\n        if (obj.getFiles().length === 0) {\n            this.references.clear(obj);\n            this.removeObject(obj);\n        }\n        return this;\n    }\n    addFiles(files) {\n        var _a;\n        const globalExclude = ((_a = this.conf.getGlobal().exclude) !== null && _a !== void 0 ? _a : [])\n            .map(pattern => new RegExp(pattern, \"i\"));\n        for (const f of files) {\n            const filename = f.getFilename();\n            const isNotAbapgitFile = filename.split(\".\").length <= 2;\n            if (isNotAbapgitFile || excludeHelper_1.ExcludeHelper.isExcluded(filename, globalExclude)) {\n                continue;\n            }\n            const found = this.findOrCreate(f.getObjectName(), f.getObjectType());\n            found.addFile(f);\n        }\n        return this;\n    }\n    addDependencies(files) {\n        for (const f of files) {\n            this.dependencies[f.getFilename().toUpperCase()] = true;\n        }\n        return this.addFiles(files);\n    }\n    addDependency(file) {\n        this.dependencies[file.getFilename().toUpperCase()] = true;\n        this.addFile(file);\n        return this;\n    }\n    isDependency(obj) {\n        const filename = obj.getFiles()[0].getFilename().toUpperCase();\n        return this.dependencies[filename] === true;\n    }\n    isFileDependency(filename) {\n        return this.dependencies[filename.toUpperCase()] === true;\n    }\n    // assumption: the file is already in the registry\n    findObjectForFile(file) {\n        const filename = file.getFilename();\n        for (const obj of this.getObjects()) {\n            for (const ofile of obj.getFiles()) {\n                if (ofile.getFilename() === filename) {\n                    return obj;\n                }\n            }\n        }\n        return undefined;\n    }\n    // todo, this will be changed to async sometime\n    findIssues(input) {\n        if (this.isDirty() === true) {\n            this.parse();\n        }\n        return this.runRules(input);\n    }\n    // todo, this will be changed to async sometime\n    findIssuesObject(iobj) {\n        if (this.isDirty() === true) {\n            this.parse();\n        }\n        return this.runRules(undefined, iobj);\n    }\n    // todo, this will be changed to async sometime\n    parse() {\n        if (this.isDirty() === false) {\n            return this;\n        }\n        ParsingPerformance.clear();\n        this.issues = [];\n        for (const o of this.getObjects()) {\n            this.parsePrivate(o);\n            this.issues.push(...o.getParsingIssues());\n        }\n        new find_global_definitions_1.FindGlobalDefinitions(this).run();\n        return this;\n    }\n    async parseAsync(input) {\n        var _a, _b;\n        if (this.isDirty() === false) {\n            return this;\n        }\n        ParsingPerformance.clear();\n        (_a = input === null || input === void 0 ? void 0 : input.progress) === null || _a === void 0 ? void 0 : _a.set(this.getObjectCount(false), \"Lexing and parsing\");\n        this.issues = [];\n        for (const o of this.getObjects()) {\n            await ((_b = input === null || input === void 0 ? void 0 : input.progress) === null || _b === void 0 ? void 0 : _b.tick(\"Lexing and parsing(\" + this.conf.getVersion() + \") - \" + o.getType() + \" \" + o.getName()));\n            this.parsePrivate(o);\n            this.issues.push(...o.getParsingIssues());\n        }\n        if ((input === null || input === void 0 ? void 0 : input.outputPerformance) === true) {\n            ParsingPerformance.output();\n        }\n        new find_global_definitions_1.FindGlobalDefinitions(this).run(input === null || input === void 0 ? void 0 : input.progress);\n        return this;\n    }\n    //////////////////////////////////////////\n    // todo, refactor, this is a mess, see where-used, a lot of the code should be in this method instead\n    parsePrivate(input) {\n        const config = this.getConfig();\n        const result = input.parse(config.getVersion(), config.getSyntaxSetttings().globalMacros, this);\n        ParsingPerformance.push(input, result);\n    }\n    isDirty() {\n        for (const o of this.getObjects()) {\n            const dirty = o.isDirty();\n            if (dirty === true) {\n                return true;\n            }\n        }\n        return false;\n    }\n    runRules(input, iobj) {\n        var _a, _b, _c, _d, _e, _f;\n        const rulePerformance = {};\n        const issues = this.issues.slice(0);\n        const objects = iobj ? [iobj] : this.getObjects();\n        const rules = this.conf.getEnabledRules();\n        const skipLogic = new skip_logic_1.SkipLogic(this);\n        (_a = input === null || input === void 0 ? void 0 : input.progress) === null || _a === void 0 ? void 0 : _a.set(iobj ? 1 : this.getObjectCount(false), \"Run Syntax\");\n        const check = [];\n        for (const obj of objects) {\n            (_b = input === null || input === void 0 ? void 0 : input.progress) === null || _b === void 0 ? void 0 : _b.tick(\"Run Syntax - \" + obj.getName());\n            if (skipLogic.skip(obj) || this.isDependency(obj)) {\n                continue;\n            }\n            if (obj instanceof _abap_object_1.ABAPObject) {\n                new syntax_1.SyntaxLogic(this, obj).run();\n            }\n            check.push(obj);\n        }\n        (_c = input === null || input === void 0 ? void 0 : input.progress) === null || _c === void 0 ? void 0 : _c.set(rules.length, \"Initialize Rules\");\n        for (const rule of rules) {\n            (_d = input === null || input === void 0 ? void 0 : input.progress) === null || _d === void 0 ? void 0 : _d.tick(\"Initialize Rules - \" + rule.getMetadata().key);\n            if (rule.initialize === undefined) {\n                throw new Error(rule.getMetadata().key + \" missing initialize method\");\n            }\n            rule.initialize(this);\n            rulePerformance[rule.getMetadata().key] = 0;\n        }\n        (_e = input === null || input === void 0 ? void 0 : input.progress) === null || _e === void 0 ? void 0 : _e.set(check.length, \"Finding Issues\");\n        for (const obj of check) {\n            (_f = input === null || input === void 0 ? void 0 : input.progress) === null || _f === void 0 ? void 0 : _f.tick(\"Finding Issues - \" + obj.getType() + \" \" + obj.getName());\n            for (const rule of rules) {\n                const before = Date.now();\n                issues.push(...rule.run(obj));\n                const runtime = Date.now() - before;\n                rulePerformance[rule.getMetadata().key] = rulePerformance[rule.getMetadata().key] + runtime;\n            }\n        }\n        if ((input === null || input === void 0 ? void 0 : input.outputPerformance) === true) {\n            const perf = [];\n            for (const p in rulePerformance) {\n                if (rulePerformance[p] > 100) { // ignore rules if it takes less than 100ms\n                    perf.push({ name: p, time: rulePerformance[p] });\n                }\n            }\n            perf.sort((a, b) => { return b.time - a.time; });\n            for (const p of perf) {\n                process.stderr.write(\"\\t\" + p.time + \"ms\\t\" + p.name + \"\\n\");\n            }\n        }\n        return this.excludeIssues(issues);\n    }\n    excludeIssues(issues) {\n        var _a;\n        const ret = issues;\n        const globalNoIssues = this.conf.getGlobal().noIssues || [];\n        const globalNoIssuesPatterns = globalNoIssues.map(x => new RegExp(x, \"i\"));\n        if (globalNoIssuesPatterns.length > 0) {\n            for (let i = ret.length - 1; i >= 0; i--) {\n                const filename = ret[i].getFilename();\n                if (excludeHelper_1.ExcludeHelper.isExcluded(filename, globalNoIssuesPatterns)) {\n                    ret.splice(i, 1);\n                }\n            }\n        }\n        // exclude issues, as now we know both the filename and issue key\n        for (const rule of artifacts_rules_1.ArtifactsRules.getRules()) {\n            const key = rule.getMetadata().key;\n            const ruleExclude = (_a = this.conf.readByKey(key, \"exclude\")) !== null && _a !== void 0 ? _a : [];\n            if (ruleExclude.length === 0) {\n                continue;\n            }\n            const ruleExcludePatterns = ruleExclude.map(x => new RegExp(x, \"i\"));\n            for (let i = ret.length - 1; i >= 0; i--) {\n                if (ret[i].getKey() !== key) {\n                    continue;\n                }\n                const filename = ret[i].getFilename();\n                if (excludeHelper_1.ExcludeHelper.isExcluded(filename, ruleExcludePatterns)) {\n                    ret.splice(i, 1);\n                }\n            }\n        }\n        return ret;\n    }\n    findOrCreate(name, type) {\n        try {\n            return this.find(name, type);\n        }\n        catch (_a) {\n            const newName = name.toUpperCase();\n            const newType = type ? type : \"UNKNOWN\";\n            const add = artifacts_objects_1.ArtifactsObjects.newObject(newName, newType);\n            if (this.objects[newName] === undefined) {\n                this.objects[newName] = {};\n            }\n            this.objects[newName][newType] = add;\n            if (this.objectsByType[newType] === undefined) {\n                this.objectsByType[newType] = {};\n            }\n            this.objectsByType[newType][newName] = add;\n            return add;\n        }\n    }\n    removeObject(remove) {\n        if (remove === undefined) {\n            return;\n        }\n        if (this.objects[remove.getName()][remove.getType()] === undefined) {\n            throw new Error(\"removeObject: object not found\");\n        }\n        if (Object.keys(this.objects[remove.getName()]).length === 1) {\n            delete this.objects[remove.getName()];\n        }\n        else {\n            delete this.objects[remove.getName()][remove.getType()];\n        }\n        if (Object.keys(this.objectsByType[remove.getType()]).length === 1) {\n            delete this.objectsByType[remove.getType()];\n        }\n        else {\n            delete this.objectsByType[remove.getType()][remove.getName()];\n        }\n    }\n    find(name, type) {\n        const searchType = type ? type : \"UNKNOWN\";\n        const searchName = name.toUpperCase();\n        if (this.objects[searchName] !== undefined\n            && this.objects[searchName][searchType]) {\n            return this.objects[searchName][searchType];\n        }\n        throw new Error(\"find: object not found, \" + type + \" \" + name);\n    }\n}\nexports.Registry = Registry;\n//# sourceMappingURL=registry.js.map\n\n//# sourceURL=webpack://@abaplint/cli/./node_modules/@abaplint/core/build/src/registry.js?");
 
 /***/ }),
 
@@ -12611,7 +12611,7 @@ eval("\r\nObject.defineProperty(exports, \"__esModule\", ({ value: true }));\r\n
 /***/ ((__unused_webpack_module, exports, __webpack_require__) => {
 
 "use strict";
-eval("\r\nObject.defineProperty(exports, \"__esModule\", ({ value: true }));\r\nexports.SelectPerformance = exports.SelectPerformanceConf = void 0;\r\nconst Expressions = __webpack_require__(/*! ../abap/2_statements/expressions */ \"./node_modules/@abaplint/core/build/src/abap/2_statements/expressions/index.js\");\r\nconst Statements = __webpack_require__(/*! ../abap/2_statements/statements */ \"./node_modules/@abaplint/core/build/src/abap/2_statements/statements/index.js\");\r\nconst Structures = __webpack_require__(/*! ../abap/3_structures/structures */ \"./node_modules/@abaplint/core/build/src/abap/3_structures/structures/index.js\");\r\nconst _basic_rule_config_1 = __webpack_require__(/*! ./_basic_rule_config */ \"./node_modules/@abaplint/core/build/src/rules/_basic_rule_config.js\");\r\nconst issue_1 = __webpack_require__(/*! ../issue */ \"./node_modules/@abaplint/core/build/src/issue.js\");\r\nconst _irule_1 = __webpack_require__(/*! ./_irule */ \"./node_modules/@abaplint/core/build/src/rules/_irule.js\");\r\nconst _abap_object_1 = __webpack_require__(/*! ../objects/_abap_object */ \"./node_modules/@abaplint/core/build/src/objects/_abap_object.js\");\r\nconst syntax_1 = __webpack_require__(/*! ../abap/5_syntax/syntax */ \"./node_modules/@abaplint/core/build/src/abap/5_syntax/syntax.js\");\r\nconst structure_type_1 = __webpack_require__(/*! ../abap/types/basic/structure_type */ \"./node_modules/@abaplint/core/build/src/abap/types/basic/structure_type.js\");\r\nconst DEFAULT_COLUMNS = 10;\r\nclass SelectPerformanceConf extends _basic_rule_config_1.BasicRuleConfig {\r\n    constructor() {\r\n        super(...arguments);\r\n        /** Detects ENDSELECT */\r\n        this.endSelect = true;\r\n        /** Detects SELECT * */\r\n        this.selectStar = true;\r\n        /** \"SELECT\" * is considered okay if the table is less than X columns, the table must be known to the linter */\r\n        this.starOkayIfFewColumns = DEFAULT_COLUMNS;\r\n    }\r\n}\r\nexports.SelectPerformanceConf = SelectPerformanceConf;\r\nclass SelectPerformance {\r\n    constructor() {\r\n        this.conf = new SelectPerformanceConf();\r\n    }\r\n    getMetadata() {\r\n        return {\r\n            key: \"select_performance\",\r\n            title: \"SELECT performance\",\r\n            shortDescription: `Various checks regarding SELECT performance.`,\r\n            extendedInformation: `ENDSELECT: not reported when the corresponding SELECT has PACKAGE SIZE\r\n\r\nSELECT *: not reported if using INTO/APPENDING CORRESPONDING FIELDS OF`,\r\n            tags: [_irule_1.RuleTag.SingleFile, _irule_1.RuleTag.Performance],\r\n        };\r\n    }\r\n    initialize(reg) {\r\n        this.reg = reg;\r\n        return this;\r\n    }\r\n    getConfig() {\r\n        if (this.conf.starOkayIfFewColumns === undefined) {\r\n            this.conf.starOkayIfFewColumns = DEFAULT_COLUMNS;\r\n        }\r\n        return this.conf;\r\n    }\r\n    setConfig(conf) {\r\n        this.conf = conf;\r\n    }\r\n    run(obj) {\r\n        if (!(obj instanceof _abap_object_1.ABAPObject)) {\r\n            return [];\r\n        }\r\n        const issues = [];\r\n        for (const file of obj.getABAPFiles()) {\r\n            const stru = file.getStructure();\r\n            if (stru === undefined) {\r\n                return issues;\r\n            }\r\n            if (this.conf.endSelect) {\r\n                for (const s of stru.findAllStructures(Structures.Select) || []) {\r\n                    const select = s.findDirectStatement(Statements.SelectLoop);\r\n                    if (select === undefined || select.concatTokens().toUpperCase().includes(\"PACKAGE SIZE\")) {\r\n                        continue;\r\n                    }\r\n                    const message = \"Avoid use of ENDSELECT\";\r\n                    issues.push(issue_1.Issue.atStatement(file, select, message, this.getMetadata().key, this.conf.severity));\r\n                }\r\n            }\r\n            if (this.conf.selectStar) {\r\n                const spaghetti = new syntax_1.SyntaxLogic(this.reg, obj).run().spaghetti;\r\n                const selects = stru.findAllStatements(Statements.Select);\r\n                selects.push(...stru.findAllStatements(Statements.SelectLoop));\r\n                for (const s of selects) {\r\n                    const concat = s.concatTokens().toUpperCase();\r\n                    if (concat.startsWith(\"SELECT * \") === false\r\n                        && concat.startsWith(\"SELECT SINGLE * \") === false) {\r\n                        continue;\r\n                    }\r\n                    else if (concat.includes(\" INTO CORRESPONDING FIELDS OF \")\r\n                        || concat.includes(\" APPENDING CORRESPONDING FIELDS OF \")) {\r\n                        continue;\r\n                    }\r\n                    const columnCount = this.findNumberOfColumns(s, file, spaghetti);\r\n                    if (columnCount\r\n                        && columnCount <= this.getConfig().starOkayIfFewColumns) {\r\n                        continue;\r\n                    }\r\n                    const message = \"Avoid use of SELECT *\";\r\n                    issues.push(issue_1.Issue.atToken(file, s.getFirstToken(), message, this.getMetadata().key, this.conf.severity));\r\n                }\r\n            }\r\n        }\r\n        return issues;\r\n    }\r\n    findNumberOfColumns(s, file, spaghetti) {\r\n        const dbnames = s.findAllExpressions(Expressions.DatabaseTable);\r\n        if (dbnames.length === 1) {\r\n            const start = dbnames[0].getFirstToken().getStart();\r\n            const scope = spaghetti.lookupPosition(start, file.getFilename());\r\n            const name = scope === null || scope === void 0 ? void 0 : scope.findTableReference(start);\r\n            const tabl = this.reg.getObject(\"TABL\", name);\r\n            const parsed = tabl === null || tabl === void 0 ? void 0 : tabl.parseType(this.reg);\r\n            if (parsed instanceof structure_type_1.StructureType) {\r\n                return parsed.getComponents().length;\r\n            }\r\n        }\r\n        return undefined;\r\n    }\r\n}\r\nexports.SelectPerformance = SelectPerformance;\r\n//# sourceMappingURL=select_performance.js.map\n\n//# sourceURL=webpack://@abaplint/cli/./node_modules/@abaplint/core/build/src/rules/select_performance.js?");
+eval("\r\nObject.defineProperty(exports, \"__esModule\", ({ value: true }));\r\nexports.SelectPerformance = exports.SelectPerformanceConf = void 0;\r\nconst Expressions = __webpack_require__(/*! ../abap/2_statements/expressions */ \"./node_modules/@abaplint/core/build/src/abap/2_statements/expressions/index.js\");\r\nconst Statements = __webpack_require__(/*! ../abap/2_statements/statements */ \"./node_modules/@abaplint/core/build/src/abap/2_statements/statements/index.js\");\r\nconst Structures = __webpack_require__(/*! ../abap/3_structures/structures */ \"./node_modules/@abaplint/core/build/src/abap/3_structures/structures/index.js\");\r\nconst _basic_rule_config_1 = __webpack_require__(/*! ./_basic_rule_config */ \"./node_modules/@abaplint/core/build/src/rules/_basic_rule_config.js\");\r\nconst issue_1 = __webpack_require__(/*! ../issue */ \"./node_modules/@abaplint/core/build/src/issue.js\");\r\nconst _irule_1 = __webpack_require__(/*! ./_irule */ \"./node_modules/@abaplint/core/build/src/rules/_irule.js\");\r\nconst _abap_object_1 = __webpack_require__(/*! ../objects/_abap_object */ \"./node_modules/@abaplint/core/build/src/objects/_abap_object.js\");\r\nconst syntax_1 = __webpack_require__(/*! ../abap/5_syntax/syntax */ \"./node_modules/@abaplint/core/build/src/abap/5_syntax/syntax.js\");\r\nconst structure_type_1 = __webpack_require__(/*! ../abap/types/basic/structure_type */ \"./node_modules/@abaplint/core/build/src/abap/types/basic/structure_type.js\");\r\nconst DEFAULT_COLUMNS = 10;\r\nclass SelectPerformanceConf extends _basic_rule_config_1.BasicRuleConfig {\r\n    constructor() {\r\n        super(...arguments);\r\n        /** Detects ENDSELECT */\r\n        this.endSelect = true;\r\n        /** Detects SELECT * */\r\n        this.selectStar = true;\r\n        /** \"SELECT\" * is considered okay if the table is less than X columns, the table must be known to the linter */\r\n        this.starOkayIfFewColumns = DEFAULT_COLUMNS;\r\n    }\r\n}\r\nexports.SelectPerformanceConf = SelectPerformanceConf;\r\nclass SelectPerformance {\r\n    constructor() {\r\n        this.conf = new SelectPerformanceConf();\r\n    }\r\n    getMetadata() {\r\n        return {\r\n            key: \"select_performance\",\r\n            title: \"SELECT performance\",\r\n            shortDescription: `Various checks regarding SELECT performance.`,\r\n            extendedInformation: `ENDSELECT: not reported when the corresponding SELECT has PACKAGE SIZE\r\n\r\nSELECT *: not reported if using INTO/APPENDING CORRESPONDING FIELDS OF`,\r\n            tags: [_irule_1.RuleTag.SingleFile, _irule_1.RuleTag.Performance],\r\n            badExample: `SELECT field1, field2 FROM table\r\n    INTO @DATA(structure) UP TO 1 ROWS ORDER BY field3 DESCENDING.\r\nENDSELECT.`,\r\n            goodExample: `SELECT field1, field2 FROM table UP TO 1 ROWS\r\n  INTO TABLE @DATA(table) ORDER BY field3 DESCENDING`,\r\n        };\r\n    }\r\n    initialize(reg) {\r\n        this.reg = reg;\r\n        return this;\r\n    }\r\n    getConfig() {\r\n        if (this.conf.starOkayIfFewColumns === undefined) {\r\n            this.conf.starOkayIfFewColumns = DEFAULT_COLUMNS;\r\n        }\r\n        return this.conf;\r\n    }\r\n    setConfig(conf) {\r\n        this.conf = conf;\r\n    }\r\n    run(obj) {\r\n        if (!(obj instanceof _abap_object_1.ABAPObject)) {\r\n            return [];\r\n        }\r\n        const issues = [];\r\n        for (const file of obj.getABAPFiles()) {\r\n            const stru = file.getStructure();\r\n            if (stru === undefined) {\r\n                return issues;\r\n            }\r\n            if (this.conf.endSelect) {\r\n                for (const s of stru.findAllStructures(Structures.Select) || []) {\r\n                    const select = s.findDirectStatement(Statements.SelectLoop);\r\n                    if (select === undefined || select.concatTokens().toUpperCase().includes(\"PACKAGE SIZE\")) {\r\n                        continue;\r\n                    }\r\n                    const message = \"Avoid use of ENDSELECT\";\r\n                    issues.push(issue_1.Issue.atStatement(file, select, message, this.getMetadata().key, this.conf.severity));\r\n                }\r\n            }\r\n            if (this.conf.selectStar) {\r\n                const spaghetti = new syntax_1.SyntaxLogic(this.reg, obj).run().spaghetti;\r\n                const selects = stru.findAllStatements(Statements.Select);\r\n                selects.push(...stru.findAllStatements(Statements.SelectLoop));\r\n                for (const s of selects) {\r\n                    const concat = s.concatTokens().toUpperCase();\r\n                    if (concat.startsWith(\"SELECT * \") === false\r\n                        && concat.startsWith(\"SELECT SINGLE * \") === false) {\r\n                        continue;\r\n                    }\r\n                    else if (concat.includes(\" INTO CORRESPONDING FIELDS OF \")\r\n                        || concat.includes(\" APPENDING CORRESPONDING FIELDS OF \")) {\r\n                        continue;\r\n                    }\r\n                    const columnCount = this.findNumberOfColumns(s, file, spaghetti);\r\n                    if (columnCount\r\n                        && columnCount <= this.getConfig().starOkayIfFewColumns) {\r\n                        continue;\r\n                    }\r\n                    const message = \"Avoid use of SELECT *\";\r\n                    issues.push(issue_1.Issue.atToken(file, s.getFirstToken(), message, this.getMetadata().key, this.conf.severity));\r\n                }\r\n            }\r\n        }\r\n        return issues;\r\n    }\r\n    findNumberOfColumns(s, file, spaghetti) {\r\n        const dbnames = s.findAllExpressions(Expressions.DatabaseTable);\r\n        if (dbnames.length === 1) {\r\n            const start = dbnames[0].getFirstToken().getStart();\r\n            const scope = spaghetti.lookupPosition(start, file.getFilename());\r\n            const name = scope === null || scope === void 0 ? void 0 : scope.findTableReference(start);\r\n            const tabl = this.reg.getObject(\"TABL\", name);\r\n            const parsed = tabl === null || tabl === void 0 ? void 0 : tabl.parseType(this.reg);\r\n            if (parsed instanceof structure_type_1.StructureType) {\r\n                return parsed.getComponents().length;\r\n            }\r\n        }\r\n        return undefined;\r\n    }\r\n}\r\nexports.SelectPerformance = SelectPerformance;\r\n//# sourceMappingURL=select_performance.js.map\n\n//# sourceURL=webpack://@abaplint/cli/./node_modules/@abaplint/core/build/src/rules/select_performance.js?");
 
 /***/ }),
 

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@abaplint/cli",
-    "version": "2.91.3",
+    "version": "2.91.4",
     "description": "abaplint - Command Line Interface",
     "bin": {
         "abaplint": "./abaplint"
@@ -39,12 +39,12 @@
     },
     "homepage": "https://abaplint.org",
     "devDependencies": {
-        "@abaplint/core": "^2.91.3",
+        "@abaplint/core": "^2.91.4",
         "@types/chai": "^4.3.1",
         "@types/glob": "^7.2.0",
         "@types/minimist": "^1.2.2",
         "@types/mocha": "^9.1.1",
-        "@types/node": "^17.0.41",
+        "@types/node": "^18.0.0",
         "@types/progress": "^2.0.5",
         "chai": "^4.3.6",
         "chalk": "^5.0.1",
@@ -57,7 +57,7 @@
         "progress": "^2.0.3",
         "typescript": "^4.7.3",
         "webpack": "^5.73.0",
-        "webpack-cli": "^4.9.2",
+        "webpack-cli": "^4.10.0",
         "xml-js": "^1.6.11"
     },
     "dependencies": {}