@abaplint/cli 2.120.68 → 2.120.71

package/build/cli.js

@@ -10389,7 +10389,7 @@ class StringTemplateFormatting extends combi_1.Expression {
         const alpha = (0, combi_1.ver)(version_1.Release.v740sp02, (0, combi_1.seq)("ALPHA =", alphaOptions), { also: combi_1.AlsoIn.OpenABAP });
         const xsd = (0, combi_1.ver)(version_1.Release.v740sp02, (0, combi_1.seq)("XSD =", zeroXSDOptions));
         const country = (0, combi_1.seq)("COUNTRY =", _1.Source);
-        const formatting = (0, combi_1.altPrio)((0, combi_1.seq)("TIME =", dateTimeOptions), (0, combi_1.seq)("DATE =", dateTimeOptions), (0, combi_1.seq)("CASE =", caseOptions), (0, combi_1.seq)("EXPONENT", _1.Source), (0, combi_1.seq)("ZERO =", zeroXSDOptions), xsd, (0, combi_1.seq)("STYLE =", styleOptions), (0, combi_1.seq)("CURRENCY =", _1.Source), (0, combi_1.per)(sign, number, decimals, width, pad, alpha, align, country), (0, combi_1.per)(timezone, timestamp));
+        const formatting = (0, combi_1.altPrio)((0, combi_1.seq)("TIME =", dateTimeOptions), (0, combi_1.seq)("DATE =", dateTimeOptions), (0, combi_1.seq)("CASE =", caseOptions), (0, combi_1.seq)("ZERO =", zeroXSDOptions), xsd, (0, combi_1.seq)("STYLE =", styleOptions), (0, combi_1.seq)("CURRENCY =", _1.Source), (0, combi_1.per)(sign, number, decimals, width, pad, alpha, align, country, (0, combi_1.seq)("EXPONENT =", _1.Source)), (0, combi_1.per)(timezone, timestamp));
         return formatting;
     }
 }
@@ -30121,12 +30121,15 @@ var __importStar = (this && this.__importStar) || (function () {
 Object.defineProperty(exports, "__esModule", ({ value: true }));
 exports.Compare = void 0;
 const Expressions = __importStar(__webpack_require__(/*! ../../2_statements/expressions */ "../core/build/src/abap/2_statements/expressions/index.js"));
+const nodes_1 = __webpack_require__(/*! ../../nodes */ "../core/build/src/abap/nodes/index.js");
 const source_1 = __webpack_require__(/*! ./source */ "../core/build/src/abap/5_syntax/expressions/source.js");
 const method_call_chain_1 = __webpack_require__(/*! ./method_call_chain */ "../core/build/src/abap/5_syntax/expressions/method_call_chain.js");
 const source_field_symbol_1 = __webpack_require__(/*! ./source_field_symbol */ "../core/build/src/abap/5_syntax/expressions/source_field_symbol.js");
 const _syntax_input_1 = __webpack_require__(/*! ../_syntax_input */ "../core/build/src/abap/5_syntax/_syntax_input.js");
 const basic_1 = __webpack_require__(/*! ../../types/basic */ "../core/build/src/abap/types/basic/index.js");
 const _type_utils_1 = __webpack_require__(/*! ../_type_utils */ "../core/build/src/abap/5_syntax/_type_utils.js");
+const _builtin_1 = __webpack_require__(/*! ../_builtin */ "../core/build/src/abap/5_syntax/_builtin.js");
+const _object_oriented_1 = __webpack_require__(/*! ../_object_oriented */ "../core/build/src/abap/5_syntax/_object_oriented.js");
 class Compare {
     static runSyntax(node, input) {
         var _a;
@@ -30141,6 +30144,11 @@ class Compare {
         for (const t of node.findDirectExpressions(Expressions.MethodCallChain)) {
             method_call_chain_1.MethodCallChain.runSyntax(t, input);
         }
+        const initialMessage = this.checkInitialOperand(node, input);
+        if (initialMessage !== undefined) {
+            input.issues.push((0, _syntax_input_1.syntaxIssue)(input, node.getFirstToken(), initialMessage));
+            return;
+        }
         const typeUtils = new _type_utils_1.TypeUtils(input.scope);
         const compareOperator = (_a = node.findDirectExpression(Expressions.CompareOperator)) === null || _a === void 0 ? void 0 : _a.concatTokens().toUpperCase();
         if (compareOperator === "CS"
@@ -30164,6 +30172,46 @@ class Compare {
             input.issues.push((0, _syntax_input_1.syntaxIssue)(input, node.getFirstToken(), message));
         }
     }
+    // a built-in function with a character-like result cannot be the operand of IS [NOT] INITIAL,
+    // "Unexpected operator IS" on a system, while one with a numeric result, lines( ), can
+    static checkInitialOperand(node, input) {
+        var _a, _b, _c, _d;
+        if (input.scope.getOpenABAP()) {
+            return undefined;
+        }
+        const tokens = node.getChildren().filter(c => c instanceof nodes_1.TokenNode).map(c => c.getFirstToken().getStr().toUpperCase());
+        if (tokens.includes("IS") === false || tokens[tokens.length - 1] !== "INITIAL") {
+            return undefined;
+        }
+        const chain = (_a = node.findDirectExpression(Expressions.Source)) === null || _a === void 0 ? void 0 : _a.getChildren();
+        // xsdbool( ) and boolc( ) are their own form in the Source grammar, a condition in parentheses
+        const first = (_b = chain === null || chain === void 0 ? void 0 : chain[0]) === null || _b === void 0 ? void 0 : _b.getFirstToken().getStr().toUpperCase();
+        if ((chain === null || chain === void 0 ? void 0 : chain.length) === 4 && chain[0] instanceof nodes_1.TokenNode && (first === "XSDBOOL" || first === "BOOLC")) {
+            return `Built-in function "${chain[0].getFirstToken().getStr()}" cannot be the operand of IS INITIAL`;
+        }
+        if ((chain === null || chain === void 0 ? void 0 : chain.length) !== 1 || !(chain[0] instanceof nodes_1.ExpressionNode) || !(chain[0].get() instanceof Expressions.MethodCallChain)) {
+            return undefined;
+        }
+        const calls = chain[0].getChildren();
+        if (calls.length !== 1 || !(calls[0] instanceof nodes_1.ExpressionNode) || !(calls[0].get() instanceof Expressions.MethodCall)) {
+            return undefined;
+        }
+        const name = (_c = calls[0].findDirectExpression(Expressions.MethodName)) === null || _c === void 0 ? void 0 : _c.concatTokens();
+        const builtin = _builtin_1.BuiltIn.searchBuiltin(name);
+        if (name === undefined || builtin === undefined) {
+            return undefined;
+        }
+        // a method of the same name hides the built-in function
+        const enclosing = input.scope.findClassDefinition(input.scope.getEnclosingClassName());
+        if (enclosing !== undefined && new _object_oriented_1.ObjectOriented(input.scope).searchMethodName(enclosing, name).method !== undefined) {
+            return undefined;
+        }
+        const returning = (_d = builtin.getParameters().getReturning()) === null || _d === void 0 ? void 0 : _d.getType();
+        if (returning instanceof basic_1.StringType || returning instanceof basic_1.CharacterType) {
+            return `Built-in function "${name}" cannot be the operand of IS INITIAL`;
+        }
+        return undefined;
+    }
 }
 exports.Compare = Compare;
 //# sourceMappingURL=compare.js.map
@@ -31936,6 +31984,9 @@ class FormParam {
             else if (typeName === "P" && bfound instanceof basic_1.PackedType) {
                 bfound = basic_1.PGenericType.get();
             }
+            else if (typeName === "N" && bfound instanceof basic_1.NumericType) {
+                bfound = basic_1.NGenericType.get();
+            }
         }
         if (nameToken && bfound) {
             return new _typed_identifier_1.TypedIdentifier(nameToken, input.filename, bfound, ["form_parameter" /* IdentifierMeta.FormParameter */]);
@@ -33322,6 +33373,9 @@ class MethodParam {
         else if (concat === "TYPE P" || concat.startsWith("TYPE P ")) {
             return new _typed_identifier_1.TypedIdentifier(name.getFirstToken(), input.filename, basic_1.PGenericType.get(), meta);
         }
+        else if (concat === "TYPE N" || concat.startsWith("TYPE N ")) {
+            return new _typed_identifier_1.TypedIdentifier(name.getFirstToken(), input.filename, basic_1.NGenericType.get(), meta);
+        }
         const found = new basic_types_1.BasicTypes(input).parseType(type);
         if (found) {
             return new _typed_identifier_1.TypedIdentifier(name.getFirstToken(), input.filename, found, meta);
@@ -40024,9 +40078,9 @@ class CreateObject {
             if (name === undefined) {
                 continue;
             }
-            const source = p.findDirectExpression(Expressions.Source);
-            const sourceType = source_1.Source.runSyntax(source, input);
             const found = allImporting === null || allImporting === void 0 ? void 0 : allImporting.find(p => p.getName().toUpperCase() === name);
+            const source = p.findDirectExpression(Expressions.Source);
+            const sourceType = source_1.Source.runSyntax(source, input, found === null || found === void 0 ? void 0 : found.getType());
             if (found === undefined) {
                 const message = `constructor parameter "${name}" does not exist`;
                 input.issues.push((0, _syntax_input_1.syntaxIssue)(input, node.getFirstToken(), message));
@@ -51483,6 +51537,7 @@ __exportStar(__webpack_require__(/*! ./generic_object_reference_type */ "../core
 __exportStar(__webpack_require__(/*! ./hex_type */ "../core/build/src/abap/types/basic/hex_type.js"), exports);
 __exportStar(__webpack_require__(/*! ./integer_type */ "../core/build/src/abap/types/basic/integer_type.js"), exports);
 __exportStar(__webpack_require__(/*! ./integer8_type */ "../core/build/src/abap/types/basic/integer8_type.js"), exports);
+__exportStar(__webpack_require__(/*! ./ngeneric_type */ "../core/build/src/abap/types/basic/ngeneric_type.js"), exports);
 __exportStar(__webpack_require__(/*! ./numeric_generic_type */ "../core/build/src/abap/types/basic/numeric_generic_type.js"), exports);
 __exportStar(__webpack_require__(/*! ./numeric_type */ "../core/build/src/abap/types/basic/numeric_type.js"), exports);
 __exportStar(__webpack_require__(/*! ./object_reference_type */ "../core/build/src/abap/types/basic/object_reference_type.js"), exports);
@@ -51591,6 +51646,39 @@ IntegerType.singletons = new Map();
 
 /***/ },
 
+/***/ "../core/build/src/abap/types/basic/ngeneric_type.js"
+/*!***********************************************************!*\
+  !*** ../core/build/src/abap/types/basic/ngeneric_type.js ***!
+  \***********************************************************/
+(__unused_webpack_module, exports, __webpack_require__) {
+
+"use strict";
+
+Object.defineProperty(exports, "__esModule", ({ value: true }));
+exports.NGenericType = void 0;
+const numeric_type_1 = __webpack_require__(/*! ./numeric_type */ "../core/build/src/abap/types/basic/numeric_type.js");
+// "TYPE n" of a method or FORM parameter, where no length can be given.
+// It is a NumericType, so everything that handles n keeps treating it as such
+class NGenericType extends numeric_type_1.NumericType {
+    static get() {
+        return this.singleton;
+    }
+    constructor() {
+        super(1);
+    }
+    toText() {
+        return "```n```";
+    }
+    isGeneric() {
+        return true;
+    }
+}
+exports.NGenericType = NGenericType;
+NGenericType.singleton = new NGenericType();
+//# sourceMappingURL=ngeneric_type.js.map
+
+/***/ },
+
 /***/ "../core/build/src/abap/types/basic/numeric_generic_type.js"
 /*!******************************************************************!*\
   !*** ../core/build/src/abap/types/basic/numeric_generic_type.js ***!
@@ -70485,7 +70573,7 @@ class Registry {
     }
     static abaplintVersion() {
         // magic, see build script "version.js"
-        return "2.120.68";
+        return "2.120.71";
     }
     getDDICReferences() {
         return this.ddicReferences;
@@ -73174,7 +73262,7 @@ exports.CDSCheckSyntaxConf = CDSCheckSyntaxConf;
 const KNOWN_QUAN_DATA_ELEMENTS = ["MENGE_D"];
 const KNOWN_CURR_DATA_ELEMENTS = ["BWERT", "DZWERT"];
 // Reserved names, cannot be used as element names, see DDIC table TRESE
-const RESERVED_ELEMENT_NAMES = ["BEGIN", "NUMBER", "POSITION"];
+const RESERVED_ELEMENT_NAMES = ["BEGIN", "NUMBER", "POSITION", "ZONE", "HANDLER", "SECTION"];
 const MAX_LABEL_LENGTH = 40;
 // Annotations which are not supported in CDS view entities
 const VIEW_ENTITY_FORBIDDEN_ANNOTATIONS = ["Semantics.unitOfMeasure", "Semantics.currencyCode"];
@@ -79984,8 +80072,17 @@ ${indentation}    output = ${uniqueName}.\n`;
                 const extra = (valueBody === null || valueBody === void 0 ? void 0 : valueBody.findDirectExpression(Expressions.For)) ? "  " : "";
                 data = indentation + extra + `DATA ${structureName} LIKE LINE OF ${uniqueName}.\n`;
             }
+            // all rows are built in the same work area, a component a row leaves out must be initial,
+            // not what an earlier row (or an earlier pass of a surrounding loop) put there
+            const clearRows = valueBody !== undefined && this.valueRowsNeedClear(valueBody);
+            const prefix = [];
             for (const a of (valueBody === null || valueBody === void 0 ? void 0 : valueBody.getChildren()) || []) {
                 if (a.get() instanceof Expressions.FieldAssignment) {
+                    if (clearRows === true) {
+                        // the shared prefix applies to every following row, re-applied after each CLEAR
+                        prefix.push(a.concatTokens());
+                        continue;
+                    }
                     if (added === false) {
                         body += data;
                         added = true;
@@ -80009,6 +80106,16 @@ ${indentation}    output = ${uniqueName}.\n`;
                 }
                 if (a instanceof nodes_1.ExpressionNode && a.get() instanceof Expressions.ValueBodyLine) {
                     let skip = false;
+                    if (clearRows === true && this.isStructuredValueRow(a)) {
+                        if (added === false) {
+                            body += data;
+                            added = true;
+                        }
+                        body += indentation + `CLEAR ${structureName}.\n`;
+                        for (const p of prefix) {
+                            body += indentation + structureName + "-" + p + ".\n";
+                        }
+                    }
                     for (const b of (a === null || a === void 0 ? void 0 : a.getChildren()) || []) {
                         if (b.get() instanceof Expressions.FieldAssignment) {
                             if (added === false) {
@@ -80087,6 +80194,39 @@ ${indentation}    output = ${uniqueName}.\n`;
         }
         return undefined;
     }
+    /** a row that is built in the work area, ie. not "( source )" or "( LINES OF source )" */
+    isStructuredValueRow(row) {
+        return row.findDirectExpression(Expressions.Source) === undefined
+            && row.findDirectExpression(Expressions.ValueBodyLines) === undefined;
+    }
+    /** true if a row can observe a component that an earlier row, or an earlier pass of a surrounding loop,
+     * left in the shared work area. Not the case if all rows assign the same components, and the shared
+     * prefix is not changed between rows, eg. FOR rows or "( a = 1 b = 2 ) ( a = 3 b = 4 )" */
+    valueRowsNeedClear(valueBody) {
+        let shape = undefined;
+        let rowSeen = false;
+        for (const c of valueBody.getChildren()) {
+            if (c.get() instanceof Expressions.FieldAssignment) {
+                if (rowSeen === true) {
+                    return true;
+                }
+            }
+            else if (c instanceof nodes_1.ExpressionNode
+                && c.get() instanceof Expressions.ValueBodyLine
+                && this.isStructuredValueRow(c)) {
+                rowSeen = true;
+                const current = c.findDirectExpressions(Expressions.FieldAssignment)
+                    .map(f => { var _a; return (_a = f.findDirectExpression(Expressions.FieldSub)) === null || _a === void 0 ? void 0 : _a.concatTokens().toUpperCase().replace(/\s/g, ""); })
+                    .sort()
+                    .join(",");
+                if (shape !== undefined && shape !== current) {
+                    return true;
+                }
+                shape = current;
+            }
+        }
+        return false;
+    }
     outlineLet(node, indentation, highSyntax, lowFile) {
         var _a;
         let ret = "";
@@ -94832,7 +94972,8 @@ class RedundantConversion {
             key: "redundant_conversion",
             title: "Redundant Conversion",
             shortDescription: `Find redundant CONV expressions`,
-            extendedInformation: `Reports CONV expressions whose operand already has the conversion's target type.`,
+            extendedInformation: `Reports CONV expressions whose operand already has the conversion's target type,
+including the result of a built-in function with a fixed result type, like to_upper( ) or strlen( ).`,
             tags: [_irule_1.RuleTag.Quickfix],
             badExample: `DATA text TYPE string.
 text = CONV string( text ).`,
@@ -94869,7 +95010,8 @@ text = text.`,
             if (structure === undefined) {
                 continue;
             }
-            for (const source of structure.findAllExpressions(Expressions.Source)) {
+            // recursive, a CONV can be the argument of a built-in function, which is itself a Source
+            for (const source of structure.findAllExpressionsRecursive(Expressions.Source)) {
                 if (source.getFirstToken().getStr().toUpperCase() !== "CONV") {
                     continue;
                 }
@@ -94928,6 +95070,15 @@ text = text.`,
     }
     sourceType(source, scope) {
         let context;
+        // boolc( <condition> ) is not a MethodCallChain, xsdbool( ) has the same shape but is not reported
+        const first = source.getFirstToken();
+        if (first.getStr().toUpperCase() === "BOOLC"
+            && source.findDirectExpression(Expressions.Cond) !== undefined
+            && source.getChildren().length === 4
+            && scope.getData().references.some(reference => reference.referenceType === _reference_1.ReferenceType.BuiltinMethodReference
+                && reference.position.getStart().equals(first.getStart()))) {
+            return basic_1.StringType.get();
+        }
         for (const child of source.getChildren()) {
             if (!(child instanceof nodes_1.ExpressionNode)) {
                 continue;
@@ -94938,6 +95089,15 @@ text = text.`,
                     return undefined;
                 }
             }
+            else if (child.get() instanceof Expressions.MethodCallChain) {
+                if (source.getChildren().length !== 1) {
+                    return undefined;
+                }
+                context = this.builtinResultType(child, scope);
+                if (context === undefined) {
+                    return undefined;
+                }
+            }
             else if (child.get() instanceof Expressions.Constant) {
                 context = this.infer(context, constant_1.Constant.runSyntax(child));
             }
@@ -94958,6 +95118,32 @@ text = text.`,
         }
         return context;
     }
+    /** The result type of a call to a built-in function whose result type does not depend on its arguments,
+     *  undefined for anything else, e.g. abs( ) or xsdbool( ), or a method of the same name */
+    builtinResultType(chain, scope) {
+        var _a;
+        const children = chain.getChildren();
+        if (children.length !== 1 || !(children[0].get() instanceof Expressions.MethodCall)) {
+            return undefined;
+        }
+        const name = (_a = children[0].findDirectExpression(Expressions.MethodName)) === null || _a === void 0 ? void 0 : _a.getFirstToken();
+        if (name === undefined) {
+            return undefined;
+        }
+        const isBuiltin = scope.getData().references.some(reference => reference.referenceType === _reference_1.ReferenceType.BuiltinMethodReference
+            && reference.position.getStart().equals(name.getStart()));
+        if (isBuiltin === false) {
+            return undefined;
+        }
+        const upper = name.getStr().toUpperCase();
+        if (RedundantConversion.stringResult.has(upper)) {
+            return basic_1.StringType.get();
+        }
+        else if (RedundantConversion.integerResult.has(upper)) {
+            return basic_1.IntegerType.get();
+        }
+        return undefined;
+    }
     fieldChainType(fieldChain, scope) {
         var _a;
         const operand = (_a = scope.getData().references.find(reference => reference.referenceType === _reference_1.ReferenceType.DataReadReference
@@ -95022,6 +95208,17 @@ text = text.`,
     }
 }
 exports.RedundantConversion = RedundantConversion;
+// built-in functions that always return a string, whatever their arguments
+RedundantConversion.stringResult = new Set([
+    "BOOLC", "CONCAT_LINES_OF", "CONDENSE", "ESCAPE", "FROM_MIXED", "INSERT", "REPEAT", "REPLACE",
+    "REVERSE", "SEGMENT", "SHIFT_LEFT", "SHIFT_RIGHT", "SUBSTRING", "SUBSTRING_AFTER", "SUBSTRING_BEFORE",
+    "SUBSTRING_FROM", "SUBSTRING_TO", "TO_LOWER", "TO_MIXED", "TO_UPPER", "TRANSLATE"
+]);
+// built-in functions that always return an i
+RedundantConversion.integerResult = new Set([
+    "CHARLEN", "COUNT", "COUNT_ANY_NOT_OF", "COUNT_ANY_OF", "DBMAXLEN", "DISTANCE", "FIND", "FIND_ANY_NOT_OF",
+    "FIND_ANY_OF", "FIND_END", "LINES", "NUMOFCHAR", "STRLEN", "XSTRLEN"
+]);
 //# sourceMappingURL=redundant_conversion.js.map
 
 /***/ },
@@ -95362,7 +95559,9 @@ class RFCErrorHandling extends _abap_rule_1.ABAPRule {
             title: "RFC error handling",
             tags: [_irule_1.RuleTag.SingleFile],
             shortDescription: `Checks that exceptions 'system_failure' and 'communication_failure' are handled in RFC calls`,
-            extendedInformation: `https://help.sap.com/doc/abapdocu_latest_index_htm/latest/en-US/abenrfc_exception.html`,
+            extendedInformation: `RESOURCE_FAILURE is also required for asynchronous calls with DESTINATION IN GROUP.
+
+https://help.sap.com/doc/abapdocu_latest_index_htm/latest/en-US/abenrfc_exception.html`,
             badExample: `CALL FUNCTION 'ZRFC'
   DESTINATION lv_rfc.`,
             goodExample: `CALL FUNCTION 'ZRFC'
@@ -95370,12 +95569,12 @@ class RFCErrorHandling extends _abap_rule_1.ABAPRule {
   EXCEPTIONS
     system_failure        = 1 MESSAGE msg
     communication_failure = 2 MESSAGE msg
-    resource_failure      = 3
-    OTHERS                = 4.`,
+    OTHERS                = 3.`,
         };
     }
-    getMessage() {
-        return "RFC error handling: At least one unhandled exception from SYSTEM_FAILURE, COMMUNICATION_FAILURE, RESOURCE_FAILURE";
+    getMessage(requireResourceFailure) {
+        return "RFC error handling: At least one unhandled exception from SYSTEM_FAILURE, COMMUNICATION_FAILURE"
+            + (requireResourceFailure ? ", RESOURCE_FAILURE" : "");
     }
     getConfig() {
         return this.conf;
@@ -95390,12 +95589,15 @@ class RFCErrorHandling extends _abap_rule_1.ABAPRule {
             if (!(stat.get() instanceof Statements.CallFunction)) {
                 continue;
             }
-            if (!stat.findFirstExpression(Expressions.Destination)) {
+            const destination = stat.findFirstExpression(Expressions.Destination);
+            if (destination === undefined) {
                 continue;
             }
+            const requireResourceFailure = stat.findDirectTokenByText("STARTING") !== undefined
+                && destination.findDirectTokenByText("GROUP") !== undefined;
             const list = stat.findFirstExpression(Expressions.ParameterListExceptions);
             if (list === undefined) {
-                const issue = issue_1.Issue.atToken(file, token, this.getMessage(), this.getMetadata().key, this.conf.severity);
+                const issue = issue_1.Issue.atToken(file, token, this.getMessage(requireResourceFailure), this.getMetadata().key, this.conf.severity);
                 output.push(issue);
                 continue;
             }
@@ -95406,8 +95608,8 @@ class RFCErrorHandling extends _abap_rule_1.ABAPRule {
             }
             if (names.indexOf("SYSTEM_FAILURE") < 0
                 || names.indexOf("COMMUNICATION_FAILURE") < 0
-                || names.indexOf("RESOURCE_FAILURE") < 0) {
-                const issue = issue_1.Issue.atToken(file, token, this.getMessage(), this.getMetadata().key, this.conf.severity);
+                || (requireResourceFailure && names.indexOf("RESOURCE_FAILURE") < 0)) {
+                const issue = issue_1.Issue.atToken(file, token, this.getMessage(requireResourceFailure), this.getMetadata().key, this.conf.severity);
                 output.push(issue);
                 continue;
             }
@@ -102222,7 +102424,7 @@ class XMLConsistency {
     }
     runTable(obj, file) {
         var _a, _b, _c, _d;
-        var _e;
+        var _e, _f;
         const issues = [];
         for (const field of (_e = obj.getFields()) !== null && _e !== void 0 ? _e : []) {
             if (field.DATATYPE === "QUAN" && (!((_a = field.REFTABLE) === null || _a === void 0 ? void 0 : _a.trim()) || !((_b = field.REFFIELD) === null || _b === void 0 ? void 0 : _b.trim()))) {
@@ -102231,6 +102433,14 @@ class XMLConsistency {
             }
         }
         if (obj.getTableCategory() === Objects.TableCategory.Transparent) {
+            // Confirmed reserved database field names, see issue #4331, DAY and HOUR reported by activation.
+            // TRESE also contains names such as TEXT and LENGTH which are allowed here.
+            const reservedFieldNames = ["ZONE", "HANDLER", "SECTION", "PARAMETER", "DAY", "HOUR"];
+            for (const field of (_f = obj.getFields()) !== null && _f !== void 0 ? _f : []) {
+                if (reservedFieldNames.includes(field.FIELDNAME.toUpperCase())) {
+                    issues.push(issue_1.Issue.atRow(file, 1, `Table field name "${field.FIELDNAME}" is reserved`, this.getMetadata().key, this.conf.severity));
+                }
+            }
             if (!((_c = obj.getDeliveryClass()) === null || _c === void 0 ? void 0 : _c.trim())) {
                 const message = `Transparent table must have delivery class(CONTFLAG in DD02V) set`;
                 issues.push(issue_1.Issue.atRow(file, 1, message, this.getMetadata().key, this.conf.transparentTableSeverity));

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@abaplint/cli",
-    "version": "2.120.68",
+    "version": "2.120.71",
     "description": "abaplint - Command Line Interface",
     "funding": "https://github.com/sponsors/larshp",
     "bin": {
@@ -39,7 +39,7 @@
     },
     "homepage": "https://abaplint.org",
     "devDependencies": {
-        "@abaplint/core": "^2.120.68",
+        "@abaplint/core": "^2.120.71",
         "@types/chai": "^4.3.20",
         "@types/minimist": "^1.2.5",
         "@types/mocha": "^10.0.10",