@abaplint/cli 2.120.67 → 2.120.70

package/build/cli.js

@@ -26579,6 +26579,17 @@ class CurrentScope {
         var _a;
         return ((_a = this.localFriends.get(className.toUpperCase())) === null || _a === void 0 ? void 0 : _a.includes(friendName.toUpperCase())) === true;
     }
+    getEnclosingMethodName() {
+        let curr = this.current;
+        while (curr !== undefined) {
+            const stype = curr.getIdentifier().stype;
+            if (stype === _scope_type_1.ScopeType.Method || stype === _scope_type_1.ScopeType.MethodInstance) {
+                return curr.getIdentifier().sname;
+            }
+            curr = curr.getParent();
+        }
+        return undefined;
+    }
     getEnclosingClassName() {
         let curr = this.current;
         while (curr !== undefined) {
@@ -26842,6 +26853,42 @@ class ObjectOriented {
         }
         return "private";
     }
+    // the fixture methods of a test class are called by ABAP Unit only, returns the message otherwise
+    checkSpecialTestMethodCall(method, foundDef) {
+        if (method === undefined
+            || !(foundDef instanceof types_1.ClassDefinition)
+            || foundDef.isForTesting() === false) {
+            return undefined;
+        }
+        const name = method.getName().toUpperCase();
+        if (["SETUP", "TEARDOWN", "CLASS_SETUP", "CLASS_TEARDOWN"].includes(name) === false) {
+            return undefined;
+        }
+        return `The special method "${name}" cannot be called directly`;
+    }
+    // SUPER-> can only call the previous implementation of the method it is used in, returns the message otherwise
+    // both names are resolved in the super class, so an alias and the method it stands for are the same
+    checkSuperCall(superDef, methodName) {
+        const enclosing = this.scope.getEnclosingMethodName();
+        if (methodName === undefined
+            || enclosing === undefined
+            || methodName.toUpperCase() === enclosing.toUpperCase()) {
+            return undefined;
+        }
+        const message = "SUPER-> can only be used to call the previous implementation of the same method";
+        // a method that is not a redefinition has no previous implementation
+        const enclosingClass = this.scope.findClassDefinition(this.scope.getEnclosingClassName());
+        const ownDefinition = enclosingClass === null || enclosingClass === void 0 ? void 0 : enclosingClass.getMethodDefinitions().getByName(enclosing);
+        if (ownDefinition !== undefined && ownDefinition.isRedefinition() === false) {
+            return message;
+        }
+        const called = this.searchMethodName(superDef, methodName).method;
+        const own = this.searchMethodName(superDef, enclosing).method;
+        if (called === undefined || own === undefined || called === own) {
+            return undefined;
+        }
+        return message;
+    }
     // the class declaring the attribute or constant, searched from def up through the super classes
     findAttributeOwner(def, found) {
         const visited = [];
@@ -31889,6 +31936,9 @@ class FormParam {
             else if (typeName === "P" && bfound instanceof basic_1.PackedType) {
                 bfound = basic_1.PGenericType.get();
             }
+            else if (typeName === "N" && bfound instanceof basic_1.NumericType) {
+                bfound = basic_1.NGenericType.get();
+            }
         }
         if (nameToken && bfound) {
             return new _typed_identifier_1.TypedIdentifier(nameToken, input.filename, bfound, ["form_parameter" /* IdentifierMeta.FormParameter */]);
@@ -32840,6 +32890,14 @@ class MethodCallChain {
                 const methodToken = (_a = current.findDirectExpression(Expressions.MethodName)) === null || _a === void 0 ? void 0 : _a.getFirstToken();
                 const methodName = methodToken === null || methodToken === void 0 ? void 0 : methodToken.getStr();
                 const def = input.scope.findObjectDefinition(className);
+                const isSuper = current === children[2]
+                    && first.get() instanceof Expressions.FieldChain
+                    && first.concatTokens().toUpperCase() === "SUPER";
+                const superMessage = isSuper ? helper.checkSuperCall(def, methodName) : undefined;
+                if (superMessage !== undefined) {
+                    input.issues.push((0, _syntax_input_1.syntaxIssue)(input, methodToken, superMessage));
+                    return basic_1.VoidType.get(_syntax_input_1.CheckSyntaxKey);
+                }
                 // eslint-disable-next-line prefer-const
                 let { method, def: foundDef } = helper.searchMethodName(def, methodName);
                 if (method === undefined && current === first) {
@@ -32867,6 +32925,11 @@ class MethodCallChain {
                         input.issues.push((0, _syntax_input_1.syntaxIssue)(input, methodToken, message));
                         return basic_1.VoidType.get(_syntax_input_1.CheckSyntaxKey);
                     }
+                    const specialMessage = isSuper ? undefined : helper.checkSpecialTestMethodCall(method, foundDef);
+                    if (specialMessage !== undefined) {
+                        input.issues.push((0, _syntax_input_1.syntaxIssue)(input, methodToken, specialMessage));
+                        return basic_1.VoidType.get(_syntax_input_1.CheckSyntaxKey);
+                    }
                     const voidedName = context instanceof basic_1.VoidType ? context.getVoided() : undefined;
                     const extra = helper.methodReferenceExtras(foundDef, className || voidedName);
                     input.scope.addReference(methodToken, method, _reference_1.ReferenceType.MethodReference, input.filename, extra);
@@ -33262,6 +33325,9 @@ class MethodParam {
         else if (concat === "TYPE P" || concat.startsWith("TYPE P ")) {
             return new _typed_identifier_1.TypedIdentifier(name.getFirstToken(), input.filename, basic_1.PGenericType.get(), meta);
         }
+        else if (concat === "TYPE N" || concat.startsWith("TYPE N ")) {
+            return new _typed_identifier_1.TypedIdentifier(name.getFirstToken(), input.filename, basic_1.NGenericType.get(), meta);
+        }
         const found = new basic_types_1.BasicTypes(input).parseType(type);
         if (found) {
             return new _typed_identifier_1.TypedIdentifier(name.getFirstToken(), input.filename, found, meta);
@@ -33730,6 +33796,14 @@ class MethodSource {
                 const methodToken = current.getFirstToken();
                 const methodName = methodToken === null || methodToken === void 0 ? void 0 : methodToken.getStr();
                 const def = input.scope.findObjectDefinition(className);
+                const isSuper = implicitMe === false
+                    && first.get() instanceof Expressions.SourceField
+                    && first.concatTokens().toUpperCase() === "SUPER";
+                const superMessage = isSuper ? helper.checkSuperCall(def, methodName) : undefined;
+                if (superMessage !== undefined) {
+                    input.issues.push((0, _syntax_input_1.syntaxIssue)(input, methodToken, superMessage));
+                    return basic_1.VoidType.get(_syntax_input_1.CheckSyntaxKey);
+                }
                 // eslint-disable-next-line prefer-const
                 let { method, def: foundDef } = helper.searchMethodName(def, methodName);
                 if (implicitMe && current === first && (method === null || method === void 0 ? void 0 : method.isStatic()) === false && input.scope.isInStaticMethod() === true) {
@@ -33746,6 +33820,11 @@ class MethodSource {
                     return basic_1.VoidType.get(_syntax_input_1.CheckSyntaxKey);
                 }
                 else if (method) {
+                    const specialMessage = isSuper ? undefined : helper.checkSpecialTestMethodCall(method, foundDef);
+                    if (specialMessage !== undefined) {
+                        input.issues.push((0, _syntax_input_1.syntaxIssue)(input, methodToken, specialMessage));
+                        return basic_1.VoidType.get(_syntax_input_1.CheckSyntaxKey);
+                    }
                     const extra = helper.methodReferenceExtras(foundDef, className);
                     input.scope.addReference(methodToken, method, _reference_1.ReferenceType.MethodReference, input.filename, extra);
                     context = method;
@@ -34844,6 +34923,7 @@ const corresponding_body_1 = __webpack_require__(/*! ./corresponding_body */ "..
 const _builtin_1 = __webpack_require__(/*! ../_builtin */ "../core/build/src/abap/5_syntax/_builtin.js");
 const attribute_chain_1 = __webpack_require__(/*! ./attribute_chain */ "../core/build/src/abap/5_syntax/expressions/attribute_chain.js");
 const dereference_1 = __webpack_require__(/*! ./dereference */ "../core/build/src/abap/5_syntax/expressions/dereference.js");
+const cast_1 = __webpack_require__(/*! ./cast */ "../core/build/src/abap/5_syntax/expressions/cast.js");
 const _typed_identifier_1 = __webpack_require__(/*! ../../types/_typed_identifier */ "../core/build/src/abap/types/_typed_identifier.js");
 const _type_utils_1 = __webpack_require__(/*! ../_type_utils */ "../core/build/src/abap/5_syntax/_type_utils.js");
 const _syntax_input_1 = __webpack_require__(/*! ../_syntax_input */ "../core/build/src/abap/5_syntax/_syntax_input.js");
@@ -35067,6 +35147,10 @@ class Source {
                         return basic_1.VoidType.get(_syntax_input_1.CheckSyntaxKey);
                     }
                 }
+                else if (get instanceof Expressions.Cast) {
+                    const found = cast_1.Cast.runSyntax(first, input, targetType);
+                    context = arithmetic === true ? this.infer(context, found, true) : found;
+                }
                 else if (get instanceof Expressions.FieldChain) {
                     const found = field_chain_1.FieldChain.runSyntax(first, input, type, allowGenericDeference);
                     context = arithmetic === true ? this.infer(context, found, true) : found;
@@ -35083,6 +35167,11 @@ class Source {
                     context = this.infer(context, found, arithmetic);
                 }
                 else if (get instanceof Expressions.Dereference) {
+                    if (this.isNewObjectDereference(node, first)) {
+                        const message = "NEW cannot be dereferenced directly";
+                        input.issues.push((0, _syntax_input_1.syntaxIssue)(input, first.getFirstToken(), message));
+                        return basic_1.VoidType.get(_syntax_input_1.CheckSyntaxKey);
+                    }
                     context = dereference_1.Dereference.runSyntax(first, context, input);
                 }
                 else if (get instanceof Expressions.ComponentChain) {
@@ -35270,6 +35359,16 @@ class Source {
         }
         return targetType;
     }
+    // "NEW ty( )->*" is a syntax error, also in releases where a method call can be dereferenced
+    static isNewObjectDereference(node, deref) {
+        var _a;
+        const children = node.getChildren();
+        const before = children[children.indexOf(deref) - 1];
+        return before instanceof nodes_1.ExpressionNode
+            && before.get() instanceof Expressions.MethodCallChain
+            && before.getChildren().length === 1
+            && ((_a = before.getFirstChild()) === null || _a === void 0 ? void 0 : _a.get()) instanceof Expressions.NewObject;
+    }
 }
 exports.Source = Source;
 //# sourceMappingURL=source.js.map
@@ -39931,9 +40030,9 @@ class CreateObject {
             if (name === undefined) {
                 continue;
             }
-            const source = p.findDirectExpression(Expressions.Source);
-            const sourceType = source_1.Source.runSyntax(source, input);
             const found = allImporting === null || allImporting === void 0 ? void 0 : allImporting.find(p => p.getName().toUpperCase() === name);
+            const source = p.findDirectExpression(Expressions.Source);
+            const sourceType = source_1.Source.runSyntax(source, input, found === null || found === void 0 ? void 0 : found.getType());
             if (found === undefined) {
                 const message = `constructor parameter "${name}" does not exist`;
                 input.issues.push((0, _syntax_input_1.syntaxIssue)(input, node.getFirstToken(), message));
@@ -51390,6 +51489,7 @@ __exportStar(__webpack_require__(/*! ./generic_object_reference_type */ "../core
 __exportStar(__webpack_require__(/*! ./hex_type */ "../core/build/src/abap/types/basic/hex_type.js"), exports);
 __exportStar(__webpack_require__(/*! ./integer_type */ "../core/build/src/abap/types/basic/integer_type.js"), exports);
 __exportStar(__webpack_require__(/*! ./integer8_type */ "../core/build/src/abap/types/basic/integer8_type.js"), exports);
+__exportStar(__webpack_require__(/*! ./ngeneric_type */ "../core/build/src/abap/types/basic/ngeneric_type.js"), exports);
 __exportStar(__webpack_require__(/*! ./numeric_generic_type */ "../core/build/src/abap/types/basic/numeric_generic_type.js"), exports);
 __exportStar(__webpack_require__(/*! ./numeric_type */ "../core/build/src/abap/types/basic/numeric_type.js"), exports);
 __exportStar(__webpack_require__(/*! ./object_reference_type */ "../core/build/src/abap/types/basic/object_reference_type.js"), exports);
@@ -51498,6 +51598,39 @@ IntegerType.singletons = new Map();
 
 /***/ },
 
+/***/ "../core/build/src/abap/types/basic/ngeneric_type.js"
+/*!***********************************************************!*\
+  !*** ../core/build/src/abap/types/basic/ngeneric_type.js ***!
+  \***********************************************************/
+(__unused_webpack_module, exports, __webpack_require__) {
+
+"use strict";
+
+Object.defineProperty(exports, "__esModule", ({ value: true }));
+exports.NGenericType = void 0;
+const numeric_type_1 = __webpack_require__(/*! ./numeric_type */ "../core/build/src/abap/types/basic/numeric_type.js");
+// "TYPE n" of a method or FORM parameter, where no length can be given.
+// It is a NumericType, so everything that handles n keeps treating it as such
+class NGenericType extends numeric_type_1.NumericType {
+    static get() {
+        return this.singleton;
+    }
+    constructor() {
+        super(1);
+    }
+    toText() {
+        return "```n```";
+    }
+    isGeneric() {
+        return true;
+    }
+}
+exports.NGenericType = NGenericType;
+NGenericType.singleton = new NGenericType();
+//# sourceMappingURL=ngeneric_type.js.map
+
+/***/ },
+
 /***/ "../core/build/src/abap/types/basic/numeric_generic_type.js"
 /*!******************************************************************!*\
   !*** ../core/build/src/abap/types/basic/numeric_generic_type.js ***!
@@ -70392,7 +70525,7 @@ class Registry {
     }
     static abaplintVersion() {
         // magic, see build script "version.js"
-        return "2.120.67";
+        return "2.120.70";
     }
     getDDICReferences() {
         return this.ddicReferences;
@@ -79891,8 +80024,17 @@ ${indentation}    output = ${uniqueName}.\n`;
                 const extra = (valueBody === null || valueBody === void 0 ? void 0 : valueBody.findDirectExpression(Expressions.For)) ? "  " : "";
                 data = indentation + extra + `DATA ${structureName} LIKE LINE OF ${uniqueName}.\n`;
             }
+            // all rows are built in the same work area, a component a row leaves out must be initial,
+            // not what an earlier row (or an earlier pass of a surrounding loop) put there
+            const clearRows = valueBody !== undefined && this.valueRowsNeedClear(valueBody);
+            const prefix = [];
             for (const a of (valueBody === null || valueBody === void 0 ? void 0 : valueBody.getChildren()) || []) {
                 if (a.get() instanceof Expressions.FieldAssignment) {
+                    if (clearRows === true) {
+                        // the shared prefix applies to every following row, re-applied after each CLEAR
+                        prefix.push(a.concatTokens());
+                        continue;
+                    }
                     if (added === false) {
                         body += data;
                         added = true;
@@ -79916,6 +80058,16 @@ ${indentation}    output = ${uniqueName}.\n`;
                 }
                 if (a instanceof nodes_1.ExpressionNode && a.get() instanceof Expressions.ValueBodyLine) {
                     let skip = false;
+                    if (clearRows === true && this.isStructuredValueRow(a)) {
+                        if (added === false) {
+                            body += data;
+                            added = true;
+                        }
+                        body += indentation + `CLEAR ${structureName}.\n`;
+                        for (const p of prefix) {
+                            body += indentation + structureName + "-" + p + ".\n";
+                        }
+                    }
                     for (const b of (a === null || a === void 0 ? void 0 : a.getChildren()) || []) {
                         if (b.get() instanceof Expressions.FieldAssignment) {
                             if (added === false) {
@@ -79994,6 +80146,39 @@ ${indentation}    output = ${uniqueName}.\n`;
         }
         return undefined;
     }
+    /** a row that is built in the work area, ie. not "( source )" or "( LINES OF source )" */
+    isStructuredValueRow(row) {
+        return row.findDirectExpression(Expressions.Source) === undefined
+            && row.findDirectExpression(Expressions.ValueBodyLines) === undefined;
+    }
+    /** true if a row can observe a component that an earlier row, or an earlier pass of a surrounding loop,
+     * left in the shared work area. Not the case if all rows assign the same components, and the shared
+     * prefix is not changed between rows, eg. FOR rows or "( a = 1 b = 2 ) ( a = 3 b = 4 )" */
+    valueRowsNeedClear(valueBody) {
+        let shape = undefined;
+        let rowSeen = false;
+        for (const c of valueBody.getChildren()) {
+            if (c.get() instanceof Expressions.FieldAssignment) {
+                if (rowSeen === true) {
+                    return true;
+                }
+            }
+            else if (c instanceof nodes_1.ExpressionNode
+                && c.get() instanceof Expressions.ValueBodyLine
+                && this.isStructuredValueRow(c)) {
+                rowSeen = true;
+                const current = c.findDirectExpressions(Expressions.FieldAssignment)
+                    .map(f => { var _a; return (_a = f.findDirectExpression(Expressions.FieldSub)) === null || _a === void 0 ? void 0 : _a.concatTokens().toUpperCase().replace(/\s/g, ""); })
+                    .sort()
+                    .join(",");
+                if (shape !== undefined && shape !== current) {
+                    return true;
+                }
+                shape = current;
+            }
+        }
+        return false;
+    }
     outlineLet(node, indentation, highSyntax, lowFile) {
         var _a;
         let ret = "";
@@ -95269,7 +95454,9 @@ class RFCErrorHandling extends _abap_rule_1.ABAPRule {
             title: "RFC error handling",
             tags: [_irule_1.RuleTag.SingleFile],
             shortDescription: `Checks that exceptions 'system_failure' and 'communication_failure' are handled in RFC calls`,
-            extendedInformation: `https://help.sap.com/doc/abapdocu_latest_index_htm/latest/en-US/abenrfc_exception.html`,
+            extendedInformation: `RESOURCE_FAILURE is also required for asynchronous calls with DESTINATION IN GROUP.
+
+https://help.sap.com/doc/abapdocu_latest_index_htm/latest/en-US/abenrfc_exception.html`,
             badExample: `CALL FUNCTION 'ZRFC'
   DESTINATION lv_rfc.`,
             goodExample: `CALL FUNCTION 'ZRFC'
@@ -95277,12 +95464,12 @@ class RFCErrorHandling extends _abap_rule_1.ABAPRule {
   EXCEPTIONS
     system_failure        = 1 MESSAGE msg
     communication_failure = 2 MESSAGE msg
-    resource_failure      = 3
-    OTHERS                = 4.`,
+    OTHERS                = 3.`,
         };
     }
-    getMessage() {
-        return "RFC error handling: At least one unhandled exception from SYSTEM_FAILURE, COMMUNICATION_FAILURE, RESOURCE_FAILURE";
+    getMessage(requireResourceFailure) {
+        return "RFC error handling: At least one unhandled exception from SYSTEM_FAILURE, COMMUNICATION_FAILURE"
+            + (requireResourceFailure ? ", RESOURCE_FAILURE" : "");
     }
     getConfig() {
         return this.conf;
@@ -95297,12 +95484,15 @@ class RFCErrorHandling extends _abap_rule_1.ABAPRule {
             if (!(stat.get() instanceof Statements.CallFunction)) {
                 continue;
             }
-            if (!stat.findFirstExpression(Expressions.Destination)) {
+            const destination = stat.findFirstExpression(Expressions.Destination);
+            if (destination === undefined) {
                 continue;
             }
+            const requireResourceFailure = stat.findDirectTokenByText("STARTING") !== undefined
+                && destination.findDirectTokenByText("GROUP") !== undefined;
             const list = stat.findFirstExpression(Expressions.ParameterListExceptions);
             if (list === undefined) {
-                const issue = issue_1.Issue.atToken(file, token, this.getMessage(), this.getMetadata().key, this.conf.severity);
+                const issue = issue_1.Issue.atToken(file, token, this.getMessage(requireResourceFailure), this.getMetadata().key, this.conf.severity);
                 output.push(issue);
                 continue;
             }
@@ -95313,8 +95503,8 @@ class RFCErrorHandling extends _abap_rule_1.ABAPRule {
             }
             if (names.indexOf("SYSTEM_FAILURE") < 0
                 || names.indexOf("COMMUNICATION_FAILURE") < 0
-                || names.indexOf("RESOURCE_FAILURE") < 0) {
-                const issue = issue_1.Issue.atToken(file, token, this.getMessage(), this.getMetadata().key, this.conf.severity);
+                || (requireResourceFailure && names.indexOf("RESOURCE_FAILURE") < 0)) {
+                const issue = issue_1.Issue.atToken(file, token, this.getMessage(requireResourceFailure), this.getMetadata().key, this.conf.severity);
                 output.push(issue);
                 continue;
             }

package/package.json

@@ -1,7 +1,6 @@
 {
-
     "name": "@abaplint/cli",
-    "version": "2.120.67",
+    "version": "2.120.70",
     "description": "abaplint - Command Line Interface",
     "funding": "https://github.com/sponsors/larshp",
     "bin": {
@@ -40,7 +39,7 @@
     },
     "homepage": "https://abaplint.org",
     "devDependencies": {
-        "@abaplint/core": "^2.120.67",
+        "@abaplint/core": "^2.120.70",
         "@types/chai": "^4.3.20",
         "@types/minimist": "^1.2.5",
         "@types/mocha": "^10.0.10",