@abaplint/cli 2.120.67 → 2.120.68

package/build/cli.js

@@ -26579,6 +26579,17 @@ class CurrentScope {
         var _a;
         return ((_a = this.localFriends.get(className.toUpperCase())) === null || _a === void 0 ? void 0 : _a.includes(friendName.toUpperCase())) === true;
     }
+    getEnclosingMethodName() {
+        let curr = this.current;
+        while (curr !== undefined) {
+            const stype = curr.getIdentifier().stype;
+            if (stype === _scope_type_1.ScopeType.Method || stype === _scope_type_1.ScopeType.MethodInstance) {
+                return curr.getIdentifier().sname;
+            }
+            curr = curr.getParent();
+        }
+        return undefined;
+    }
     getEnclosingClassName() {
         let curr = this.current;
         while (curr !== undefined) {
@@ -26842,6 +26853,42 @@ class ObjectOriented {
         }
         return "private";
     }
+    // the fixture methods of a test class are called by ABAP Unit only, returns the message otherwise
+    checkSpecialTestMethodCall(method, foundDef) {
+        if (method === undefined
+            || !(foundDef instanceof types_1.ClassDefinition)
+            || foundDef.isForTesting() === false) {
+            return undefined;
+        }
+        const name = method.getName().toUpperCase();
+        if (["SETUP", "TEARDOWN", "CLASS_SETUP", "CLASS_TEARDOWN"].includes(name) === false) {
+            return undefined;
+        }
+        return `The special method "${name}" cannot be called directly`;
+    }
+    // SUPER-> can only call the previous implementation of the method it is used in, returns the message otherwise
+    // both names are resolved in the super class, so an alias and the method it stands for are the same
+    checkSuperCall(superDef, methodName) {
+        const enclosing = this.scope.getEnclosingMethodName();
+        if (methodName === undefined
+            || enclosing === undefined
+            || methodName.toUpperCase() === enclosing.toUpperCase()) {
+            return undefined;
+        }
+        const message = "SUPER-> can only be used to call the previous implementation of the same method";
+        // a method that is not a redefinition has no previous implementation
+        const enclosingClass = this.scope.findClassDefinition(this.scope.getEnclosingClassName());
+        const ownDefinition = enclosingClass === null || enclosingClass === void 0 ? void 0 : enclosingClass.getMethodDefinitions().getByName(enclosing);
+        if (ownDefinition !== undefined && ownDefinition.isRedefinition() === false) {
+            return message;
+        }
+        const called = this.searchMethodName(superDef, methodName).method;
+        const own = this.searchMethodName(superDef, enclosing).method;
+        if (called === undefined || own === undefined || called === own) {
+            return undefined;
+        }
+        return message;
+    }
     // the class declaring the attribute or constant, searched from def up through the super classes
     findAttributeOwner(def, found) {
         const visited = [];
@@ -32840,6 +32887,14 @@ class MethodCallChain {
                 const methodToken = (_a = current.findDirectExpression(Expressions.MethodName)) === null || _a === void 0 ? void 0 : _a.getFirstToken();
                 const methodName = methodToken === null || methodToken === void 0 ? void 0 : methodToken.getStr();
                 const def = input.scope.findObjectDefinition(className);
+                const isSuper = current === children[2]
+                    && first.get() instanceof Expressions.FieldChain
+                    && first.concatTokens().toUpperCase() === "SUPER";
+                const superMessage = isSuper ? helper.checkSuperCall(def, methodName) : undefined;
+                if (superMessage !== undefined) {
+                    input.issues.push((0, _syntax_input_1.syntaxIssue)(input, methodToken, superMessage));
+                    return basic_1.VoidType.get(_syntax_input_1.CheckSyntaxKey);
+                }
                 // eslint-disable-next-line prefer-const
                 let { method, def: foundDef } = helper.searchMethodName(def, methodName);
                 if (method === undefined && current === first) {
@@ -32867,6 +32922,11 @@ class MethodCallChain {
                         input.issues.push((0, _syntax_input_1.syntaxIssue)(input, methodToken, message));
                         return basic_1.VoidType.get(_syntax_input_1.CheckSyntaxKey);
                     }
+                    const specialMessage = isSuper ? undefined : helper.checkSpecialTestMethodCall(method, foundDef);
+                    if (specialMessage !== undefined) {
+                        input.issues.push((0, _syntax_input_1.syntaxIssue)(input, methodToken, specialMessage));
+                        return basic_1.VoidType.get(_syntax_input_1.CheckSyntaxKey);
+                    }
                     const voidedName = context instanceof basic_1.VoidType ? context.getVoided() : undefined;
                     const extra = helper.methodReferenceExtras(foundDef, className || voidedName);
                     input.scope.addReference(methodToken, method, _reference_1.ReferenceType.MethodReference, input.filename, extra);
@@ -33730,6 +33790,14 @@ class MethodSource {
                 const methodToken = current.getFirstToken();
                 const methodName = methodToken === null || methodToken === void 0 ? void 0 : methodToken.getStr();
                 const def = input.scope.findObjectDefinition(className);
+                const isSuper = implicitMe === false
+                    && first.get() instanceof Expressions.SourceField
+                    && first.concatTokens().toUpperCase() === "SUPER";
+                const superMessage = isSuper ? helper.checkSuperCall(def, methodName) : undefined;
+                if (superMessage !== undefined) {
+                    input.issues.push((0, _syntax_input_1.syntaxIssue)(input, methodToken, superMessage));
+                    return basic_1.VoidType.get(_syntax_input_1.CheckSyntaxKey);
+                }
                 // eslint-disable-next-line prefer-const
                 let { method, def: foundDef } = helper.searchMethodName(def, methodName);
                 if (implicitMe && current === first && (method === null || method === void 0 ? void 0 : method.isStatic()) === false && input.scope.isInStaticMethod() === true) {
@@ -33746,6 +33814,11 @@ class MethodSource {
                     return basic_1.VoidType.get(_syntax_input_1.CheckSyntaxKey);
                 }
                 else if (method) {
+                    const specialMessage = isSuper ? undefined : helper.checkSpecialTestMethodCall(method, foundDef);
+                    if (specialMessage !== undefined) {
+                        input.issues.push((0, _syntax_input_1.syntaxIssue)(input, methodToken, specialMessage));
+                        return basic_1.VoidType.get(_syntax_input_1.CheckSyntaxKey);
+                    }
                     const extra = helper.methodReferenceExtras(foundDef, className);
                     input.scope.addReference(methodToken, method, _reference_1.ReferenceType.MethodReference, input.filename, extra);
                     context = method;
@@ -34844,6 +34917,7 @@ const corresponding_body_1 = __webpack_require__(/*! ./corresponding_body */ "..
 const _builtin_1 = __webpack_require__(/*! ../_builtin */ "../core/build/src/abap/5_syntax/_builtin.js");
 const attribute_chain_1 = __webpack_require__(/*! ./attribute_chain */ "../core/build/src/abap/5_syntax/expressions/attribute_chain.js");
 const dereference_1 = __webpack_require__(/*! ./dereference */ "../core/build/src/abap/5_syntax/expressions/dereference.js");
+const cast_1 = __webpack_require__(/*! ./cast */ "../core/build/src/abap/5_syntax/expressions/cast.js");
 const _typed_identifier_1 = __webpack_require__(/*! ../../types/_typed_identifier */ "../core/build/src/abap/types/_typed_identifier.js");
 const _type_utils_1 = __webpack_require__(/*! ../_type_utils */ "../core/build/src/abap/5_syntax/_type_utils.js");
 const _syntax_input_1 = __webpack_require__(/*! ../_syntax_input */ "../core/build/src/abap/5_syntax/_syntax_input.js");
@@ -35067,6 +35141,10 @@ class Source {
                         return basic_1.VoidType.get(_syntax_input_1.CheckSyntaxKey);
                     }
                 }
+                else if (get instanceof Expressions.Cast) {
+                    const found = cast_1.Cast.runSyntax(first, input, targetType);
+                    context = arithmetic === true ? this.infer(context, found, true) : found;
+                }
                 else if (get instanceof Expressions.FieldChain) {
                     const found = field_chain_1.FieldChain.runSyntax(first, input, type, allowGenericDeference);
                     context = arithmetic === true ? this.infer(context, found, true) : found;
@@ -35083,6 +35161,11 @@ class Source {
                     context = this.infer(context, found, arithmetic);
                 }
                 else if (get instanceof Expressions.Dereference) {
+                    if (this.isNewObjectDereference(node, first)) {
+                        const message = "NEW cannot be dereferenced directly";
+                        input.issues.push((0, _syntax_input_1.syntaxIssue)(input, first.getFirstToken(), message));
+                        return basic_1.VoidType.get(_syntax_input_1.CheckSyntaxKey);
+                    }
                     context = dereference_1.Dereference.runSyntax(first, context, input);
                 }
                 else if (get instanceof Expressions.ComponentChain) {
@@ -35270,6 +35353,16 @@ class Source {
         }
         return targetType;
     }
+    // "NEW ty( )->*" is a syntax error, also in releases where a method call can be dereferenced
+    static isNewObjectDereference(node, deref) {
+        var _a;
+        const children = node.getChildren();
+        const before = children[children.indexOf(deref) - 1];
+        return before instanceof nodes_1.ExpressionNode
+            && before.get() instanceof Expressions.MethodCallChain
+            && before.getChildren().length === 1
+            && ((_a = before.getFirstChild()) === null || _a === void 0 ? void 0 : _a.get()) instanceof Expressions.NewObject;
+    }
 }
 exports.Source = Source;
 //# sourceMappingURL=source.js.map
@@ -70392,7 +70485,7 @@ class Registry {
     }
     static abaplintVersion() {
         // magic, see build script "version.js"
-        return "2.120.67";
+        return "2.120.68";
     }
     getDDICReferences() {
         return this.ddicReferences;

package/package.json

@@ -1,7 +1,6 @@
 {
-
     "name": "@abaplint/cli",
-    "version": "2.120.67",
+    "version": "2.120.68",
     "description": "abaplint - Command Line Interface",
     "funding": "https://github.com/sponsors/larshp",
     "bin": {
@@ -40,7 +39,7 @@
     },
     "homepage": "https://abaplint.org",
     "devDependencies": {
-        "@abaplint/core": "^2.120.67",
+        "@abaplint/core": "^2.120.68",
         "@types/chai": "^4.3.20",
         "@types/minimist": "^1.2.5",
         "@types/mocha": "^10.0.10",