@abaplint/cli 2.120.66 → 2.120.68

package/build/cli.js

@@ -16912,7 +16912,9 @@ class ModifyLine {
         const ocp = (0, combi_1.str)("OF CURRENT PAGE");
         const intensified = (0, combi_1.seq)("INTENSIFIED", onOff);
         const intensifiedOpt = (0, combi_1.seq)("INTENSIFIED", (0, combi_1.opt)(onOff));
-        const lineFormat = (0, combi_1.seq)("LINE FORMAT", (0, combi_1.per)("INPUT OFF", "INVERSE", "RESET", intensifiedOpt, expressions_1.Color));
+        const inputOpt = (0, combi_1.seq)("INPUT", (0, combi_1.opt)((0, combi_1.alt)(eq, onOff)));
+        const inverseOpt = (0, combi_1.seq)("INVERSE", (0, combi_1.opt)((0, combi_1.alt)(eq, onOff)));
+        const lineFormat = (0, combi_1.seq)("LINE FORMAT", (0, combi_1.per)(inputOpt, inverseOpt, "RESET", intensifiedOpt, expressions_1.Color));
         const options = (0, combi_1.per)(index, value, format, page, lineFormat, lineValue, ocp, intensified, expressions_1.Color);
         const ret = (0, combi_1.seq)("MODIFY", (0, combi_1.altPrio)("CURRENT LINE", (0, combi_1.seq)("LINE", expressions_1.Source)), (0, combi_1.opt)(options));
         return (0, combi_1.verNotLang)(version_1.LanguageVersion.Cloud, ret);
@@ -26471,6 +26473,7 @@ class CurrentScope {
         if (name === undefined) {
             return undefined;
         }
+        name = name.replace(/^!/, "");
         const found = (_a = this.current) === null || _a === void 0 ? void 0 : _a.findVariable(name);
         if (found) {
             return found;
@@ -26576,6 +26579,17 @@ class CurrentScope {
         var _a;
         return ((_a = this.localFriends.get(className.toUpperCase())) === null || _a === void 0 ? void 0 : _a.includes(friendName.toUpperCase())) === true;
     }
+    getEnclosingMethodName() {
+        let curr = this.current;
+        while (curr !== undefined) {
+            const stype = curr.getIdentifier().stype;
+            if (stype === _scope_type_1.ScopeType.Method || stype === _scope_type_1.ScopeType.MethodInstance) {
+                return curr.getIdentifier().sname;
+            }
+            curr = curr.getParent();
+        }
+        return undefined;
+    }
     getEnclosingClassName() {
         let curr = this.current;
         while (curr !== undefined) {
@@ -26800,6 +26814,97 @@ class ObjectOriented {
     }
     // does the supplied class have friendship with "friendName"?
     // note that interfaces of the friend, and subclasses of the friend also have friendship
+    // returns the visibility as text if a member declared in foundDef, reached via def, cannot be accessed from enclosing
+    memberNotVisible(visibility, def, foundDef, enclosing) {
+        var _a, _b;
+        if (visibility === visibility_1.Visibility.Public || foundDef === undefined) {
+            return undefined;
+        }
+        else if (!(foundDef instanceof types_1.ClassDefinition)) {
+            // interface members are always public
+            return undefined;
+        }
+        const name = foundDef.getName().toUpperCase();
+        enclosing = enclosing === null || enclosing === void 0 ? void 0 : enclosing.toUpperCase();
+        if (enclosing === undefined || enclosing === name) {
+            return undefined;
+        }
+        // friendship with the class used at the call site also gives access to inherited members
+        const visited = [];
+        let current = def instanceof types_1.ClassDefinition ? def : foundDef;
+        while (current !== undefined && visited.includes(current.getName().toUpperCase()) === false) {
+            visited.push(current.getName().toUpperCase());
+            if (this.hasFriendship(current, enclosing)) {
+                return undefined;
+            }
+            const sup = current.getSuperClass();
+            current = sup === undefined ? undefined : this.scope.findClassDefinition(sup);
+        }
+        if (visibility === visibility_1.Visibility.Protected) {
+            // subclasses can access protected members
+            let sup = (_a = this.scope.findClassDefinition(enclosing)) === null || _a === void 0 ? void 0 : _a.getSuperClass();
+            while (sup !== undefined) {
+                if (sup.toUpperCase() === name) {
+                    return undefined;
+                }
+                sup = (_b = this.scope.findClassDefinition(sup)) === null || _b === void 0 ? void 0 : _b.getSuperClass();
+            }
+            return "protected";
+        }
+        return "private";
+    }
+    // the fixture methods of a test class are called by ABAP Unit only, returns the message otherwise
+    checkSpecialTestMethodCall(method, foundDef) {
+        if (method === undefined
+            || !(foundDef instanceof types_1.ClassDefinition)
+            || foundDef.isForTesting() === false) {
+            return undefined;
+        }
+        const name = method.getName().toUpperCase();
+        if (["SETUP", "TEARDOWN", "CLASS_SETUP", "CLASS_TEARDOWN"].includes(name) === false) {
+            return undefined;
+        }
+        return `The special method "${name}" cannot be called directly`;
+    }
+    // SUPER-> can only call the previous implementation of the method it is used in, returns the message otherwise
+    // both names are resolved in the super class, so an alias and the method it stands for are the same
+    checkSuperCall(superDef, methodName) {
+        const enclosing = this.scope.getEnclosingMethodName();
+        if (methodName === undefined
+            || enclosing === undefined
+            || methodName.toUpperCase() === enclosing.toUpperCase()) {
+            return undefined;
+        }
+        const message = "SUPER-> can only be used to call the previous implementation of the same method";
+        // a method that is not a redefinition has no previous implementation
+        const enclosingClass = this.scope.findClassDefinition(this.scope.getEnclosingClassName());
+        const ownDefinition = enclosingClass === null || enclosingClass === void 0 ? void 0 : enclosingClass.getMethodDefinitions().getByName(enclosing);
+        if (ownDefinition !== undefined && ownDefinition.isRedefinition() === false) {
+            return message;
+        }
+        const called = this.searchMethodName(superDef, methodName).method;
+        const own = this.searchMethodName(superDef, enclosing).method;
+        if (called === undefined || own === undefined || called === own) {
+            return undefined;
+        }
+        return message;
+    }
+    // the class declaring the attribute or constant, searched from def up through the super classes
+    findAttributeOwner(def, found) {
+        const visited = [];
+        let current = def;
+        while (current instanceof types_1.ClassDefinition && visited.includes(current.getName().toUpperCase()) === false) {
+            visited.push(current.getName().toUpperCase());
+            const attributes = current.getAttributes();
+            if (attributes.getAll().includes(found)
+                || attributes.getConstants().includes(found)) {
+                return current;
+            }
+            const sup = current.getSuperClass();
+            current = sup === undefined ? undefined : this.findSuperDefinition(sup);
+        }
+        return undefined;
+    }
     hasFriendship(cd, friendName) {
         var _a;
         const friends = cd.getFriends().map(f => f.toUpperCase());
@@ -29776,6 +29881,8 @@ const _object_oriented_1 = __webpack_require__(/*! ../_object_oriented */ "../co
 const data_reference_type_1 = __webpack_require__(/*! ../../types/basic/data_reference_type */ "../core/build/src/abap/types/basic/data_reference_type.js");
 const _reference_1 = __webpack_require__(/*! ../_reference */ "../core/build/src/abap/5_syntax/_reference.js");
 const basic_1 = __webpack_require__(/*! ../../types/basic */ "../core/build/src/abap/types/basic/index.js");
+const class_attribute_1 = __webpack_require__(/*! ../../types/class_attribute */ "../core/build/src/abap/types/class_attribute.js");
+const class_constant_1 = __webpack_require__(/*! ../../types/class_constant */ "../core/build/src/abap/types/class_constant.js");
 const _syntax_input_1 = __webpack_require__(/*! ../_syntax_input */ "../core/build/src/abap/5_syntax/_syntax_input.js");
 class AttributeName {
     static runSyntax(context, node, input, type, error = true) {
@@ -29804,6 +29911,15 @@ class AttributeName {
                 }
                 return void_type_1.VoidType.get(_syntax_input_1.CheckSyntaxKey);
             }
+            if (found instanceof class_attribute_1.ClassAttribute || found instanceof class_constant_1.ClassConstant) {
+                const owner = helper.findAttributeOwner(def, found);
+                const notVisible = helper.memberNotVisible(found.getVisibility(), def, owner, input.scope.getEnclosingClassName());
+                if (notVisible !== undefined) {
+                    const message = `Attribute "${name}" is ${notVisible} and cannot be accessed`;
+                    input.issues.push((0, _syntax_input_1.syntaxIssue)(input, token, message));
+                    return void_type_1.VoidType.get(_syntax_input_1.CheckSyntaxKey);
+                }
+            }
             if (type) {
                 input.scope.addReference(token, found, type, input.filename);
             }
@@ -32742,8 +32858,6 @@ const _reference_1 = __webpack_require__(/*! ../_reference */ "../core/build/src
 const component_name_1 = __webpack_require__(/*! ./component_name */ "../core/build/src/abap/5_syntax/expressions/component_name.js");
 const attribute_name_1 = __webpack_require__(/*! ./attribute_name */ "../core/build/src/abap/5_syntax/expressions/attribute_name.js");
 const _syntax_input_1 = __webpack_require__(/*! ../_syntax_input */ "../core/build/src/abap/5_syntax/_syntax_input.js");
-const visibility_1 = __webpack_require__(/*! ../../4_file_information/visibility */ "../core/build/src/abap/4_file_information/visibility.js");
-const class_definition_1 = __webpack_require__(/*! ../../types/class_definition */ "../core/build/src/abap/types/class_definition.js");
 class MethodCallChain {
     static runSyntax(node, input, targetType) {
         var _a, _b;
@@ -32773,6 +32887,14 @@ class MethodCallChain {
                 const methodToken = (_a = current.findDirectExpression(Expressions.MethodName)) === null || _a === void 0 ? void 0 : _a.getFirstToken();
                 const methodName = methodToken === null || methodToken === void 0 ? void 0 : methodToken.getStr();
                 const def = input.scope.findObjectDefinition(className);
+                const isSuper = current === children[2]
+                    && first.get() instanceof Expressions.FieldChain
+                    && first.concatTokens().toUpperCase() === "SUPER";
+                const superMessage = isSuper ? helper.checkSuperCall(def, methodName) : undefined;
+                if (superMessage !== undefined) {
+                    input.issues.push((0, _syntax_input_1.syntaxIssue)(input, methodToken, superMessage));
+                    return basic_1.VoidType.get(_syntax_input_1.CheckSyntaxKey);
+                }
                 // eslint-disable-next-line prefer-const
                 let { method, def: foundDef } = helper.searchMethodName(def, methodName);
                 if (method === undefined && current === first) {
@@ -32792,12 +32914,19 @@ class MethodCallChain {
                         input.issues.push((0, _syntax_input_1.syntaxIssue)(input, methodToken, message));
                         return basic_1.VoidType.get(_syntax_input_1.CheckSyntaxKey);
                     }
-                    const notVisible = method ? this.checkVisibility(method, def, foundDef, input) : undefined;
+                    const notVisible = method
+                        ? helper.memberNotVisible(method.getVisibility(), def, foundDef, input.scope.getEnclosingClassName())
+                        : undefined;
                     if (notVisible !== undefined) {
                         const message = `Method "${methodName}" is ${notVisible} and cannot be accessed`;
                         input.issues.push((0, _syntax_input_1.syntaxIssue)(input, methodToken, message));
                         return basic_1.VoidType.get(_syntax_input_1.CheckSyntaxKey);
                     }
+                    const specialMessage = isSuper ? undefined : helper.checkSpecialTestMethodCall(method, foundDef);
+                    if (specialMessage !== undefined) {
+                        input.issues.push((0, _syntax_input_1.syntaxIssue)(input, methodToken, specialMessage));
+                        return basic_1.VoidType.get(_syntax_input_1.CheckSyntaxKey);
+                    }
                     const voidedName = context instanceof basic_1.VoidType ? context.getVoided() : undefined;
                     const extra = helper.methodReferenceExtras(foundDef, className || voidedName);
                     input.scope.addReference(methodToken, method, _reference_1.ReferenceType.MethodReference, input.filename, extra);
@@ -32840,47 +32969,6 @@ class MethodCallChain {
         return context;
     }
     //////////////////////////////////////
-    // returns the visibility as text if the method cannot be accessed from the current scope
-    static checkVisibility(method, def, foundDef, input) {
-        var _a, _b, _c;
-        const visibility = method.getVisibility();
-        if (visibility === visibility_1.Visibility.Public || foundDef === undefined) {
-            return undefined;
-        }
-        else if (!(foundDef instanceof class_definition_1.ClassDefinition)) {
-            // interface members are always public
-            return undefined;
-        }
-        const name = foundDef.getName().toUpperCase();
-        const enclosing = (_a = input.scope.getEnclosingClassName()) === null || _a === void 0 ? void 0 : _a.toUpperCase();
-        if (enclosing === undefined || enclosing === name) {
-            return undefined;
-        }
-        // friendship with the class used at the call site also gives access to inherited members
-        const helper = new _object_oriented_1.ObjectOriented(input.scope);
-        const visited = [];
-        let current = def instanceof class_definition_1.ClassDefinition ? def : foundDef;
-        while (current !== undefined && visited.includes(current.getName().toUpperCase()) === false) {
-            visited.push(current.getName().toUpperCase());
-            if (helper.hasFriendship(current, enclosing)) {
-                return undefined;
-            }
-            const sup = current.getSuperClass();
-            current = sup === undefined ? undefined : input.scope.findClassDefinition(sup);
-        }
-        if (visibility === visibility_1.Visibility.Protected) {
-            // subclasses can access protected members
-            let sup = (_b = input.scope.findClassDefinition(enclosing)) === null || _b === void 0 ? void 0 : _b.getSuperClass();
-            while (sup !== undefined) {
-                if (sup.toUpperCase() === name) {
-                    return undefined;
-                }
-                sup = (_c = input.scope.findClassDefinition(sup)) === null || _c === void 0 ? void 0 : _c.getSuperClass();
-            }
-            return "protected";
-        }
-        return "private";
-    }
     static findTop(first, input, targetType) {
         var _a;
         if (first.get() instanceof Expressions.ClassName) {
@@ -33702,6 +33790,14 @@ class MethodSource {
                 const methodToken = current.getFirstToken();
                 const methodName = methodToken === null || methodToken === void 0 ? void 0 : methodToken.getStr();
                 const def = input.scope.findObjectDefinition(className);
+                const isSuper = implicitMe === false
+                    && first.get() instanceof Expressions.SourceField
+                    && first.concatTokens().toUpperCase() === "SUPER";
+                const superMessage = isSuper ? helper.checkSuperCall(def, methodName) : undefined;
+                if (superMessage !== undefined) {
+                    input.issues.push((0, _syntax_input_1.syntaxIssue)(input, methodToken, superMessage));
+                    return basic_1.VoidType.get(_syntax_input_1.CheckSyntaxKey);
+                }
                 // eslint-disable-next-line prefer-const
                 let { method, def: foundDef } = helper.searchMethodName(def, methodName);
                 if (implicitMe && current === first && (method === null || method === void 0 ? void 0 : method.isStatic()) === false && input.scope.isInStaticMethod() === true) {
@@ -33718,6 +33814,11 @@ class MethodSource {
                     return basic_1.VoidType.get(_syntax_input_1.CheckSyntaxKey);
                 }
                 else if (method) {
+                    const specialMessage = isSuper ? undefined : helper.checkSpecialTestMethodCall(method, foundDef);
+                    if (specialMessage !== undefined) {
+                        input.issues.push((0, _syntax_input_1.syntaxIssue)(input, methodToken, specialMessage));
+                        return basic_1.VoidType.get(_syntax_input_1.CheckSyntaxKey);
+                    }
                     const extra = helper.methodReferenceExtras(foundDef, className);
                     input.scope.addReference(methodToken, method, _reference_1.ReferenceType.MethodReference, input.filename, extra);
                     context = method;
@@ -34816,6 +34917,7 @@ const corresponding_body_1 = __webpack_require__(/*! ./corresponding_body */ "..
 const _builtin_1 = __webpack_require__(/*! ../_builtin */ "../core/build/src/abap/5_syntax/_builtin.js");
 const attribute_chain_1 = __webpack_require__(/*! ./attribute_chain */ "../core/build/src/abap/5_syntax/expressions/attribute_chain.js");
 const dereference_1 = __webpack_require__(/*! ./dereference */ "../core/build/src/abap/5_syntax/expressions/dereference.js");
+const cast_1 = __webpack_require__(/*! ./cast */ "../core/build/src/abap/5_syntax/expressions/cast.js");
 const _typed_identifier_1 = __webpack_require__(/*! ../../types/_typed_identifier */ "../core/build/src/abap/types/_typed_identifier.js");
 const _type_utils_1 = __webpack_require__(/*! ../_type_utils */ "../core/build/src/abap/5_syntax/_type_utils.js");
 const _syntax_input_1 = __webpack_require__(/*! ../_syntax_input */ "../core/build/src/abap/5_syntax/_syntax_input.js");
@@ -35039,6 +35141,10 @@ class Source {
                         return basic_1.VoidType.get(_syntax_input_1.CheckSyntaxKey);
                     }
                 }
+                else if (get instanceof Expressions.Cast) {
+                    const found = cast_1.Cast.runSyntax(first, input, targetType);
+                    context = arithmetic === true ? this.infer(context, found, true) : found;
+                }
                 else if (get instanceof Expressions.FieldChain) {
                     const found = field_chain_1.FieldChain.runSyntax(first, input, type, allowGenericDeference);
                     context = arithmetic === true ? this.infer(context, found, true) : found;
@@ -35055,6 +35161,11 @@ class Source {
                     context = this.infer(context, found, arithmetic);
                 }
                 else if (get instanceof Expressions.Dereference) {
+                    if (this.isNewObjectDereference(node, first)) {
+                        const message = "NEW cannot be dereferenced directly";
+                        input.issues.push((0, _syntax_input_1.syntaxIssue)(input, first.getFirstToken(), message));
+                        return basic_1.VoidType.get(_syntax_input_1.CheckSyntaxKey);
+                    }
                     context = dereference_1.Dereference.runSyntax(first, context, input);
                 }
                 else if (get instanceof Expressions.ComponentChain) {
@@ -35242,6 +35353,16 @@ class Source {
         }
         return targetType;
     }
+    // "NEW ty( )->*" is a syntax error, also in releases where a method call can be dereferenced
+    static isNewObjectDereference(node, deref) {
+        var _a;
+        const children = node.getChildren();
+        const before = children[children.indexOf(deref) - 1];
+        return before instanceof nodes_1.ExpressionNode
+            && before.get() instanceof Expressions.MethodCallChain
+            && before.getChildren().length === 1
+            && ((_a = before.getFirstChild()) === null || _a === void 0 ? void 0 : _a.get()) instanceof Expressions.NewObject;
+    }
 }
 exports.Source = Source;
 //# sourceMappingURL=source.js.map
@@ -36209,6 +36330,7 @@ const expressions_1 = __webpack_require__(/*! ../../2_statements/expressions */
 const field_length_1 = __webpack_require__(/*! ./field_length */ "../core/build/src/abap/5_syntax/expressions/field_length.js");
 const cast_1 = __webpack_require__(/*! ./cast */ "../core/build/src/abap/5_syntax/expressions/cast.js");
 const _syntax_input_1 = __webpack_require__(/*! ../_syntax_input */ "../core/build/src/abap/5_syntax/_syntax_input.js");
+const version_1 = __webpack_require__(/*! ../../../version */ "../core/build/src/version.js");
 class Target {
     static runSyntax(node, input) {
         const concat = node.concatTokens();
@@ -36274,6 +36396,12 @@ class Target {
                 if (!(context instanceof basic_1.VoidType)) {
                     context = context.getType();
                 }
+                if ((context === null || context === void 0 ? void 0 : context.isGeneric()) === true
+                    && !(0, version_1.releaseAtLeast)(input.scope.getRelease(), version_1.Release.v756)
+                    && input.scope.getLanguageVersion() !== version_1.LanguageVersion.Cloud
+                    && !input.scope.getOpenABAP()) {
+                    throw new Error("A generic reference cannot be dereferenced");
+                }
             }
             else if (current.get() instanceof Expressions.ComponentName) {
                 context = component_name_1.ComponentName.runSyntax(context, current, input);
@@ -70063,6 +70191,7 @@ class Indent {
                 || type instanceof Statements.ProcessBeforeOutput
                 || type instanceof Statements.ProcessOnValueRequest
                 || type instanceof Statements.TopOfPage
+                || type instanceof Statements.EndOfPage
                 || type instanceof Statements.Get
                 || type instanceof Statements.EndOfSelection
                 || type instanceof Statements.LoadOfProgram) {
@@ -70158,6 +70287,7 @@ class Indent {
                 || type instanceof Statements.Initialization
                 || type instanceof Statements.AtUserCommand
                 || type instanceof Statements.TopOfPage
+                || type instanceof Statements.EndOfPage
                 || type instanceof Statements.EndOfSelection
                 || type instanceof Statements.Public
                 || type instanceof Statements.Protected
@@ -70355,7 +70485,7 @@ class Registry {
     }
     static abaplintVersion() {
         // magic, see build script "version.js"
-        return "2.120.66";
+        return "2.120.68";
     }
     getDDICReferences() {
         return this.ddicReferences;

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@abaplint/cli",
-    "version": "2.120.66",
+    "version": "2.120.68",
     "description": "abaplint - Command Line Interface",
     "funding": "https://github.com/sponsors/larshp",
     "bin": {
@@ -39,7 +39,7 @@
     },
     "homepage": "https://abaplint.org",
     "devDependencies": {
-        "@abaplint/core": "^2.120.66",
+        "@abaplint/core": "^2.120.68",
         "@types/chai": "^4.3.20",
         "@types/minimist": "^1.2.5",
         "@types/mocha": "^10.0.10",