@abaplint/cli 2.120.59 → 2.120.61

package/build/cli.js

@@ -6355,7 +6355,9 @@ const combi_1 = __webpack_require__(/*! ../combi */ "../core/build/src/abap/2_st
 const _1 = __webpack_require__(/*! . */ "../core/build/src/abap/2_statements/expressions/index.js");
 class MethodDefExceptions extends combi_1.Expression {
     getRunnable() {
-        const exceptions = (0, combi_1.seq)("EXCEPTIONS", (0, combi_1.plusPrio)(_1.NamespaceSimpleName));
+        // parameter section keywords cannot be exception names
+        const name = (0, combi_1.seq)((0, combi_1.stopBefore1)("IMPORTING", "EXPORTING", "CHANGING", "RETURNING", "RAISING", "EXCEPTIONS"), _1.NamespaceSimpleName);
+        const exceptions = (0, combi_1.seq)("EXCEPTIONS", (0, combi_1.plusPrio)(name));
         return exceptions;
     }
 }
@@ -6427,7 +6429,9 @@ const class_name_1 = __webpack_require__(/*! ./class_name */ "../core/build/src/
 class MethodDefRaising extends combi_1.Expression {
     getRunnable() {
         const resumable = (0, combi_1.seq)("RESUMABLE", (0, combi_1.tok)(tokens_1.ParenLeft), class_name_1.ClassName, (0, combi_1.tok)(tokens_1.ParenRightW));
-        const raising = (0, combi_1.seq)("RAISING", (0, combi_1.plus)((0, combi_1.altPrio)(resumable, class_name_1.ClassName)));
+        // parameter section keywords cannot be exception names
+        const name = (0, combi_1.seq)((0, combi_1.stopBefore1)("IMPORTING", "EXPORTING", "CHANGING", "RETURNING", "RAISING", "EXCEPTIONS"), class_name_1.ClassName);
+        const raising = (0, combi_1.seq)("RAISING", (0, combi_1.plus)((0, combi_1.altPrio)(resumable, name)));
         return raising;
     }
 }
@@ -16731,7 +16735,7 @@ class MethodDef {
         (0, combi_1.seq)("VALIDATE ON SAVE IMPORTING", expressions_1.MethodParamName, "FOR", expressions_1.TypeName), (0, combi_1.seq)("MODIFY", (0, combi_1.opt)("IMPORTING"), (0, combi_1.plus)((0, combi_1.seq)(expressions_1.MethodParamName, modify))), (0, combi_1.seq)("PRECHECK IMPORTING", expressions_1.MethodParamName, modify), (0, combi_1.seq)("DETERMINATION", expressions_1.TypeName, "IMPORTING", expressions_1.MethodParamName, "FOR", expressions_1.TypeName), (0, combi_1.seq)("VALIDATION", expressions_1.TypeName, "IMPORTING", expressions_1.MethodParamName, "FOR", expressions_1.TypeName), (0, combi_1.seq)("NUMBERING IMPORTING", expressions_1.MethodParamName, modify), (0, combi_1.seq)("READ IMPORTING", expressions_1.MethodParamName, (0, combi_1.altPrio)(forRead, forfunction)), (0, combi_1.seq)("FEATURES IMPORTING", expressions_1.MethodParamName, "REQUEST", expressions_1.NamespaceSimpleName, "FOR", expressions_1.NamespaceSimpleName, result), (0, combi_1.seq)("BEHAVIOR IMPORTING", expressions_1.MethodParamName, "FOR CREATE", expressions_1.TypeName, expressions_1.MethodParamName, "FOR UPDATE", expressions_1.TypeName, expressions_1.MethodParamName, "FOR DELETE", expressions_1.TypeName), (0, combi_1.seq)("BEHAVIOR IMPORTING", expressions_1.MethodParamName, "FOR READ", expressions_1.TypeName, result), (0, combi_1.seq)("BEHAVIOR IMPORTING", expressions_1.MethodParamName, "FOR UPDATE", expressions_1.TypeName), (0, combi_1.seq)((0, combi_1.alt)("BEHAVIOR", "LOCK"), "IMPORTING", expressions_1.MethodParamName, "FOR LOCK", expressions_1.TypeName), (0, combi_1.seq)("DETERMINE", (0, combi_1.alt)("ON MODIFY", "ON SAVE"), "IMPORTING", expressions_1.MethodParamName, "FOR", expressions_1.TypeName), (0, combi_1.seq)("GLOBAL AUTHORIZATION IMPORTING REQUEST", expressions_1.MethodParamName, "FOR", expressions_1.TypeName, result), (0, combi_1.seq)("GLOBAL FEATURES IMPORTING REQUEST", expressions_1.MethodParamName, "FOR", expressions_1.TypeName, result), (0, combi_1.seq)((0, combi_1.seq)((0, combi_1.opt)("INSTANCE"), "AUTHORIZATION IMPORTING"), expressions_1.MethodParamName, "REQUEST", expressions_1.MethodParamName, "FOR", expressions_1.TypeName, result), (0, combi_1.seq)("INSTANCE FEATURES IMPORTING", expressions_1.MethodParamName, "REQUEST", expressions_1.MethodParamName, "FOR", expressions_1.TypeName, result));
         // todo, this is only from version something
         // AMDP OPTIONS clause blocked in KeyUser
-        const amdp = (0, combi_1.verNotLang)(version_1.LanguageVersion.KeyUser, (0, combi_1.seq)("AMDP OPTIONS", (0, combi_1.optPrio)("READ-ONLY"), "CDS SESSION CLIENT", (0, combi_1.alt)("CURRENT", "DEPENDENT"), (0, combi_1.optPrio)(expressions_1.MethodDefImporting), (0, combi_1.optPrio)(expressions_1.MethodDefExporting), (0, combi_1.optPrio)(expressions_1.MethodDefRaising)));
+        const amdp = (0, combi_1.verNotLang)(version_1.LanguageVersion.KeyUser, (0, combi_1.seq)("AMDP OPTIONS", (0, combi_1.per)("READ-ONLY", (0, combi_1.seq)("CDS SESSION CLIENT", (0, combi_1.alt)("CURRENT", "DEPENDENT"))), (0, combi_1.optPrio)(expressions_1.MethodDefImporting), (0, combi_1.optPrio)(expressions_1.MethodDefExporting), (0, combi_1.optPrio)(expressions_1.MethodDefRaising)));
         // FOR DDL OBJECT / FOR TABLE FUNCTION / FOR SCALAR FUNCTION blocked in KeyUser
         const regular = (0, combi_1.seq)((0, combi_1.altPrio)("CLASS-METHODS", "METHODS"), expressions_1.MethodName, (0, combi_1.alt)((0, combi_1.seq)((0, combi_1.optPrio)(expressions_1.Abstract), (0, combi_1.optPrio)(def), expressions_1.EventHandler), parameters, testing, (0, combi_1.verNotLang)(version_1.LanguageVersion.KeyUser, (0, combi_1.seq)("FOR", behavior)), amdp, "NOT AT END OF MODE", (0, combi_1.optPrio)(expressions_1.Redefinition)));
         // RAP event handlers are instance methods; CLASS-METHODS is not allowed.
@@ -16762,7 +16766,8 @@ class MethodImplementation {
         const name = (0, combi_1.regex)(/[\w~]+/);
         const kernel = (0, combi_1.seq)("KERNEL MODULE", (0, combi_1.plus)(name), (0, combi_1.optPrio)((0, combi_1.altPrio)("FAIL", "IGNORE")));
         const using = (0, combi_1.seq)("USING", (0, combi_1.plus)(expressions_1.SimpleFieldChain));
-        const database = (0, combi_1.seq)("DATABASE", (0, combi_1.alt)("PROCEDURE", "FUNCTION", "GRAPH WORKSPACE"), "FOR HDB", expressions_1.Language, (0, combi_1.opt)("OPTIONS READ-ONLY"), (0, combi_1.opt)(using));
+        const options = (0, combi_1.seq)("OPTIONS", (0, combi_1.per)("READ-ONLY", "SUPPRESS SYNTAX ERRORS", "DETERMINISTIC"));
+        const database = (0, combi_1.seq)("DATABASE", (0, combi_1.alt)("PROCEDURE", "FUNCTION", "GRAPH WORKSPACE"), "FOR HDB", expressions_1.Language, (0, combi_1.opt)(options), (0, combi_1.opt)(using));
         // BY DATABASE and BY KERNEL both blocked in KeyUser
         const by = (0, combi_1.verNotLang)(version_1.LanguageVersion.KeyUser, (0, combi_1.seq)("BY", (0, combi_1.alt)(kernel, database)));
         return (0, combi_1.seq)("METHOD", expressions_1.MethodName, (0, combi_1.optPrio)(by));
@@ -24931,6 +24936,12 @@ class BuiltIn {
         }
         return this.buildDefinition(def, name);
     }
+    static hasUnnamedArgument(name) {
+        if (name === undefined) {
+            return false;
+        }
+        return BuiltIn.unnamedArgument.has(name.toUpperCase());
+    }
     static isPredicate(name) {
         if (name === undefined) {
             return undefined;
@@ -26032,6 +26043,12 @@ BuiltIn.methods = {
         return: basic_1.IntegerType.get(),
     },
 };
+// functions called with exactly one unnamed argument, all others take named arguments like "val"
+BuiltIn.unnamedArgument = new Set([
+    "ABS", "ACOS", "ASIN", "ATAN", "BOOLC", "CEIL", "CHARLEN", "COS", "COSH", "DBMAXLEN", "EXP", "FLOOR",
+    "FRAC", "LINES", "LOG", "LOG10", "NUMOFCHAR", "SIGN", "SIN", "SINH", "SQRT", "STRLEN", "TAN", "TANH",
+    "TRUNC", "XSTRLEN"
+]);
 //# sourceMappingURL=_builtin.js.map
 
 /***/ },
@@ -38085,17 +38102,54 @@ var __importStar = (this && this.__importStar) || (function () {
 })();
 Object.defineProperty(exports, "__esModule", ({ value: true }));
 exports.Case = void 0;
+exports.checkCaseOperand = checkCaseOperand;
 const Expressions = __importStar(__webpack_require__(/*! ../../2_statements/expressions */ "../core/build/src/abap/2_statements/expressions/index.js"));
 const source_1 = __webpack_require__(/*! ../expressions/source */ "../core/build/src/abap/5_syntax/expressions/source.js");
+const _syntax_input_1 = __webpack_require__(/*! ../_syntax_input */ "../core/build/src/abap/5_syntax/_syntax_input.js");
+const _builtin_1 = __webpack_require__(/*! ../_builtin */ "../core/build/src/abap/5_syntax/_builtin.js");
+const _object_oriented_1 = __webpack_require__(/*! ../_object_oriented */ "../core/build/src/abap/5_syntax/_object_oriented.js");
+const basic_1 = __webpack_require__(/*! ../../types/basic */ "../core/build/src/abap/types/basic/index.js");
+const version_1 = __webpack_require__(/*! ../../../version */ "../core/build/src/version.js");
 class Case {
     runSyntax(node, input) {
         // just recurse
         for (const s of node.findDirectExpressions(Expressions.Source)) {
             source_1.Source.runSyntax(s, input);
+            checkCaseOperand(s, input);
         }
     }
 }
 exports.Case = Case;
+// Before 7.40 SP02 the operands of CASE and WHEN are enhanced functional operand positions: besides
+// data objects and functional methods, only built-in functions with exactly one unnamed argument are allowed
+function checkCaseOperand(source, input) {
+    var _a, _b;
+    if ((0, version_1.releaseAtLeast)(input.scope.getRelease(), version_1.Release.v740sp02)
+        || input.scope.getLanguageVersion() === version_1.LanguageVersion.Cloud
+        || input.scope.getOpenABAP()) {
+        return;
+    }
+    const chain = source.findDirectExpression(Expressions.MethodCallChain);
+    if (chain === undefined || source.getChildren().length !== 1 || chain.getChildren().length !== 1) {
+        return;
+    }
+    const call = chain.findDirectExpression(Expressions.MethodCall);
+    const nameToken = (_a = call === null || call === void 0 ? void 0 : call.findDirectExpression(Expressions.MethodName)) === null || _a === void 0 ? void 0 : _a.getFirstToken();
+    const name = nameToken === null || nameToken === void 0 ? void 0 : nameToken.getStr();
+    if (nameToken === undefined || _builtin_1.BuiltIn.searchBuiltin(name) === undefined || _builtin_1.BuiltIn.hasUnnamedArgument(name)) {
+        return;
+    }
+    // a method of the enclosing class takes precedence over the built-in function
+    const meType = (_b = input.scope.findVariable("me")) === null || _b === void 0 ? void 0 : _b.getType();
+    if (meType instanceof basic_1.ObjectReferenceType) {
+        const def = input.scope.findObjectDefinition(meType.getIdentifierName());
+        if (new _object_oriented_1.ObjectOriented(input.scope).searchMethodName(def, name).method !== undefined) {
+            return;
+        }
+    }
+    const message = "Built-in function " + name + " not allowed as CASE/WHEN operand before v740sp02";
+    input.issues.push((0, _syntax_input_1.syntaxIssue)(input, nameToken, message));
+}
 //# sourceMappingURL=case.js.map
 
 /***/ },
@@ -39453,10 +39507,22 @@ const basic_types_1 = __webpack_require__(/*! ../basic_types */ "../core/build/s
 const basic_1 = __webpack_require__(/*! ../../types/basic */ "../core/build/src/abap/types/basic/index.js");
 const _typed_identifier_1 = __webpack_require__(/*! ../../types/_typed_identifier */ "../core/build/src/abap/types/_typed_identifier.js");
 const _reference_1 = __webpack_require__(/*! ../_reference */ "../core/build/src/abap/5_syntax/_reference.js");
+const _syntax_input_1 = __webpack_require__(/*! ../_syntax_input */ "../core/build/src/abap/5_syntax/_syntax_input.js");
 class CreateData {
     runSyntax(node, input) {
+        const likeLineOf = node.concatTokens().toUpperCase().includes(" LIKE LINE OF ");
         for (const s of node.findDirectExpressions(Expressions.Source)) {
-            source_1.Source.runSyntax(s, input);
+            const sourceType = source_1.Source.runSyntax(s, input);
+            if (likeLineOf === true
+                && sourceType !== undefined
+                && !(sourceType instanceof basic_1.TableType)
+                && !(sourceType instanceof basic_1.VoidType)
+                && !(sourceType instanceof basic_1.UnknownType)
+                && !(sourceType instanceof basic_1.AnyType)) {
+                const message = `"${s.concatTokens()}" is not an internal table`;
+                input.issues.push((0, _syntax_input_1.syntaxIssue)(input, node.getFirstToken(), message));
+                return;
+            }
         }
         for (const t of node.findDirectExpressions(Expressions.Target)) {
             target_1.Target.runSyntax(t, input);
@@ -39641,6 +39707,11 @@ class CreateObject {
             ooName = found.getVoided();
         }
         input.scope.addReference(t === null || t === void 0 ? void 0 : t.getFirstToken(), cdef, _reference_1.ReferenceType.ConstructorReference, input.filename, { ooName: ooName });
+        if (type && type.get() instanceof Expressions.Dynamic) {
+            // the class is only known at runtime, cdef is the static type of the target
+            this.validateParameters(undefined, node, input);
+            return;
+        }
         if (cdef !== undefined) {
             const err = CreateObject.checkInstantiationAllowed(cdef, input);
             if (err) {
@@ -47152,11 +47223,15 @@ Object.defineProperty(exports, "__esModule", ({ value: true }));
 exports.When = void 0;
 const Expressions = __importStar(__webpack_require__(/*! ../../2_statements/expressions */ "../core/build/src/abap/2_statements/expressions/index.js"));
 const source_1 = __webpack_require__(/*! ../expressions/source */ "../core/build/src/abap/5_syntax/expressions/source.js");
+const case_1 = __webpack_require__(/*! ./case */ "../core/build/src/abap/5_syntax/statements/case.js");
 class When {
     runSyntax(node, input) {
         for (const s of node.findAllExpressions(Expressions.Source)) {
             source_1.Source.runSyntax(s, input);
         }
+        for (const s of node.findDirectExpressions(Expressions.Source)) {
+            (0, case_1.checkCaseOperand)(s, input);
+        }
     }
 }
 exports.When = When;
@@ -70690,7 +70765,7 @@ class Registry {
     }
     static abaplintVersion() {
         // magic, see build script "version.js"
-        return "2.120.59";
+        return "2.120.61";
     }
     getDDICReferences() {
         return this.ddicReferences;
@@ -71323,12 +71398,13 @@ https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#abap-doc-on
         return issues;
     }
     getAbapdoc(rows, pos) {
+        var _a, _b, _c;
         let previousRow = pos.getRow() - 2;
-        let rowText = rows[previousRow].trim().toUpperCase();
+        let rowText = ((_a = rows[previousRow]) !== null && _a !== void 0 ? _a : "").trim().toUpperCase();
         const text = [];
         if (rowText === "METHODS" || rowText === "CLASS-METHODS") {
             previousRow--;
-            rowText = rows[previousRow].trim().toUpperCase();
+            rowText = ((_b = rows[previousRow]) !== null && _b !== void 0 ? _b : "").trim().toUpperCase();
         }
         text.push(rowText);
         //we need to push the first row despite if it is actually an abapdoc or not
@@ -71336,7 +71412,7 @@ https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#abap-doc-on
         if (rowText.trim().substring(0, 2) === "\"!") {
             while (previousRow >= 0) {
                 previousRow--;
-                rowText = rows[previousRow].trim().toUpperCase();
+                rowText = ((_c = rows[previousRow]) !== null && _c !== void 0 ? _c : "").trim().toUpperCase();
                 if (rowText.trim().substring(0, 2) !== "\"!") {
                     break;
                 }

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@abaplint/cli",
-    "version": "2.120.59",
+    "version": "2.120.61",
     "description": "abaplint - Command Line Interface",
     "funding": "https://github.com/sponsors/larshp",
     "bin": {
@@ -39,7 +39,7 @@
     },
     "homepage": "https://abaplint.org",
     "devDependencies": {
-        "@abaplint/core": "^2.120.59",
+        "@abaplint/core": "^2.120.61",
         "@types/chai": "^4.3.20",
         "@types/minimist": "^1.2.5",
         "@types/mocha": "^10.0.10",