@abaplint/cli 2.120.53 → 2.120.54

package/build/cli.js

@@ -12387,7 +12387,7 @@ class CallTransaction {
     getMatcher() {
         const options = (0, combi_1.seq)("OPTIONS FROM", expressions_1.Source);
         const messages = (0, combi_1.seq)("MESSAGES INTO", expressions_1.Target);
-        const auth = (0, combi_1.seq)((0, combi_1.altPrio)("WITH", "WITHOUT"), "AUTHORITY-CHECK");
+        const auth = (0, combi_1.ver)(version_1.Release.v740sp02, (0, combi_1.seq)((0, combi_1.altPrio)("WITH", "WITHOUT"), "AUTHORITY-CHECK"));
         const perm = (0, combi_1.per)((0, combi_1.seq)("UPDATE", expressions_1.Source), "AND SKIP FIRST SCREEN", options, messages, (0, combi_1.seq)("MODE", expressions_1.Source));
         const ret = (0, combi_1.seq)("CALL TRANSACTION", expressions_1.Source, (0, combi_1.optPrio)(auth), (0, combi_1.optPrio)((0, combi_1.seq)("USING", expressions_1.Source)), (0, combi_1.opt)(perm));
         return (0, combi_1.verNotLang)(version_1.LanguageVersion.Cloud, ret);
@@ -70644,7 +70644,7 @@ class Registry {
     }
     static abaplintVersion() {
         // magic, see build script "version.js"
-        return "2.120.53";
+        return "2.120.54";
     }
     getDDICReferences() {
         return this.ddicReferences;
@@ -78104,7 +78104,11 @@ Make sure to test the downported code, it might not always be completely correct
           return found;
         }
         */
-        let found = this.downportEnum(low, high, lowFile, highSyntax, highFile);
+        let found = this.stripCallTransactionAuthorityCheck(high, lowFile);
+        if (found) {
+            return found;
+        }
+        found = this.downportEnum(low, high, lowFile, highSyntax, highFile);
         if (found) {
             return found;
         }
@@ -80598,6 +80602,27 @@ ${indentation}    output = ${uniqueName}.\n`;
         }
         return false;
     }
+    /** WITH/WITHOUT AUTHORITY-CHECK on CALL TRANSACTION requires v740sp02, so the statement is
+     * Unknown in the low version, note that only WITHOUT is handled here */
+    stripCallTransactionAuthorityCheck(high, lowFile) {
+        if (!(high.get() instanceof Statements.CallTransaction)) {
+            return undefined;
+        }
+        const tokens = high.getTokens();
+        // the lexer splits "AUTHORITY-CHECK" into three tokens: AUTHORITY, -, CHECK
+        for (let i = 1; i < tokens.length - 3; i++) {
+            if (tokens[i].getStr().toUpperCase() === "WITHOUT"
+                && tokens[i + 1].getStr().toUpperCase() === "AUTHORITY"
+                && tokens[i + 2].getStr() === "-"
+                && tokens[i + 3].getStr().toUpperCase() === "CHECK") {
+                // also remove the preceding space so no double space is left behind
+                const fix = edit_helper_1.EditHelper.deleteRange(lowFile, tokens[i - 1].getEnd(), tokens[i + 3].getEnd());
+                const message = "Remove WITHOUT AUTHORITY-CHECK from CALL TRANSACTION";
+                return issue_1.Issue.atToken(lowFile, tokens[i], message, this.getMetadata().key, this.conf.severity, fix);
+            }
+        }
+        return undefined;
+    }
     replaceXsdBool(node, lowFile, highSyntax) {
         if (this.lowReg.getConfig().isOpenABAP()) {
             return undefined;
@@ -85007,6 +85032,7 @@ __exportStar(__webpack_require__(/*! ./parser_missing_space */ "../core/build/sr
 __exportStar(__webpack_require__(/*! ./pragma_style */ "../core/build/src/rules/pragma_style.js"), exports);
 __exportStar(__webpack_require__(/*! ./prefer_corresponding */ "../core/build/src/rules/prefer_corresponding.js"), exports);
 __exportStar(__webpack_require__(/*! ./prefer_inline */ "../core/build/src/rules/prefer_inline.js"), exports);
+__exportStar(__webpack_require__(/*! ./prefer_insert_into_table */ "../core/build/src/rules/prefer_insert_into_table.js"), exports);
 __exportStar(__webpack_require__(/*! ./prefer_is_not */ "../core/build/src/rules/prefer_is_not.js"), exports);
 __exportStar(__webpack_require__(/*! ./prefer_pragmas */ "../core/build/src/rules/prefer_pragmas.js"), exports);
 __exportStar(__webpack_require__(/*! ./prefer_raise_exception_new */ "../core/build/src/rules/prefer_raise_exception_new.js"), exports);
@@ -92686,6 +92712,127 @@ exports.PreferInline = PreferInline;
 
 /***/ },
 
+/***/ "../core/build/src/rules/prefer_insert_into_table.js"
+/*!***********************************************************!*\
+  !*** ../core/build/src/rules/prefer_insert_into_table.js ***!
+  \***********************************************************/
+(__unused_webpack_module, exports, __webpack_require__) {
+
+"use strict";
+
+var __createBinding = (this && this.__createBinding) || (Object.create ? (function(o, m, k, k2) {
+    if (k2 === undefined) k2 = k;
+    var desc = Object.getOwnPropertyDescriptor(m, k);
+    if (!desc || ("get" in desc ? !m.__esModule : desc.writable || desc.configurable)) {
+      desc = { enumerable: true, get: function() { return m[k]; } };
+    }
+    Object.defineProperty(o, k2, desc);
+}) : (function(o, m, k, k2) {
+    if (k2 === undefined) k2 = k;
+    o[k2] = m[k];
+}));
+var __setModuleDefault = (this && this.__setModuleDefault) || (Object.create ? (function(o, v) {
+    Object.defineProperty(o, "default", { enumerable: true, value: v });
+}) : function(o, v) {
+    o["default"] = v;
+});
+var __importStar = (this && this.__importStar) || (function () {
+    var ownKeys = function(o) {
+        ownKeys = Object.getOwnPropertyNames || function (o) {
+            var ar = [];
+            for (var k in o) if (Object.prototype.hasOwnProperty.call(o, k)) ar[ar.length] = k;
+            return ar;
+        };
+        return ownKeys(o);
+    };
+    return function (mod) {
+        if (mod && mod.__esModule) return mod;
+        var result = {};
+        if (mod != null) for (var k = ownKeys(mod), i = 0; i < k.length; i++) if (k[i] !== "default") __createBinding(result, mod, k[i]);
+        __setModuleDefault(result, mod);
+        return result;
+    };
+})();
+Object.defineProperty(exports, "__esModule", ({ value: true }));
+exports.PreferInsertIntoTable = exports.PreferInsertIntoTableConf = void 0;
+const issue_1 = __webpack_require__(/*! ../issue */ "../core/build/src/issue.js");
+const Statements = __importStar(__webpack_require__(/*! ../abap/2_statements/statements */ "../core/build/src/abap/2_statements/statements/index.js"));
+const _abap_rule_1 = __webpack_require__(/*! ./_abap_rule */ "../core/build/src/rules/_abap_rule.js");
+const _basic_rule_config_1 = __webpack_require__(/*! ./_basic_rule_config */ "../core/build/src/rules/_basic_rule_config.js");
+const _irule_1 = __webpack_require__(/*! ./_irule */ "../core/build/src/rules/_irule.js");
+const edit_helper_1 = __webpack_require__(/*! ../edit_helper */ "../core/build/src/edit_helper.js");
+class PreferInsertIntoTableConf extends _basic_rule_config_1.BasicRuleConfig {
+}
+exports.PreferInsertIntoTableConf = PreferInsertIntoTableConf;
+class PreferInsertIntoTable extends _abap_rule_1.ABAPRule {
+    constructor() {
+        super(...arguments);
+        this.conf = new PreferInsertIntoTableConf();
+    }
+    getMetadata() {
+        return {
+            key: "prefer_insert_into_table",
+            title: "Prefer INSERT INTO TABLE over APPEND",
+            shortDescription: `Prefer INSERT INTO TABLE over APPEND`,
+            extendedInformation: `INSERT INTO TABLE respects the table type, while APPEND always adds to the end regardless of table type.
+
+https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md`,
+            tags: [_irule_1.RuleTag.SingleFile, _irule_1.RuleTag.Styleguide, _irule_1.RuleTag.Quickfix],
+            badExample: `APPEND row TO itab.`,
+            goodExample: `INSERT row INTO TABLE itab.`,
+        };
+    }
+    getConfig() { return this.conf; }
+    setConfig(conf) { this.conf = conf; }
+    runParsed(file) {
+        const issues = [];
+        for (const stat of file.getStatements()) {
+            if (!(stat.get() instanceof Statements.Append)) {
+                continue;
+            }
+            if (stat.concatTokens().toUpperCase().includes(" SORTED BY ")) {
+                continue;
+            }
+            const fix = this.buildFix(file, stat);
+            const message = "Prefer INSERT INTO TABLE over APPEND";
+            issues.push(issue_1.Issue.atStatement(file, stat, message, this.getMetadata().key, this.conf.severity, fix));
+        }
+        return issues;
+    }
+    buildFix(file, stat) {
+        const tokens = stat.getTokens();
+        // Find the APPEND token (first token)
+        const appendToken = tokens[0];
+        if (appendToken.getStr().toUpperCase() !== "APPEND") {
+            return undefined;
+        }
+        // Find the last "TO" token that precedes the table target.
+        // In all fixable forms the table target follows the last standalone "TO":
+        //   APPEND row TO itab
+        //   APPEND LINES OF itab2 TO itab
+        //   APPEND LINES OF itab2 FROM 1 TO 3 TO itab   <- last TO is the table
+        //   APPEND INITIAL LINE TO itab
+        let lastToIndex = -1;
+        for (let i = tokens.length - 1; i >= 0; i--) {
+            if (tokens[i].getStr().toUpperCase() === "TO") {
+                lastToIndex = i;
+                break;
+            }
+        }
+        if (lastToIndex < 0) {
+            return undefined;
+        }
+        const toToken = tokens[lastToIndex];
+        const fix1 = edit_helper_1.EditHelper.replaceToken(file, appendToken, "INSERT");
+        const fix2 = edit_helper_1.EditHelper.replaceToken(file, toToken, "INTO TABLE");
+        return edit_helper_1.EditHelper.merge(fix1, fix2);
+    }
+}
+exports.PreferInsertIntoTable = PreferInsertIntoTable;
+//# sourceMappingURL=prefer_insert_into_table.js.map
+
+/***/ },
+
 /***/ "../core/build/src/rules/prefer_is_not.js"
 /*!************************************************!*\
   !*** ../core/build/src/rules/prefer_is_not.js ***!

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@abaplint/cli",
-    "version": "2.120.53",
+    "version": "2.120.54",
     "description": "abaplint - Command Line Interface",
     "funding": "https://github.com/sponsors/larshp",
     "bin": {
@@ -39,7 +39,7 @@
     },
     "homepage": "https://abaplint.org",
     "devDependencies": {
-        "@abaplint/core": "^2.120.53",
+        "@abaplint/core": "^2.120.54",
         "@types/chai": "^4.3.20",
         "@types/minimist": "^1.2.5",
         "@types/mocha": "^10.0.10",