@abaplint/cli 2.120.45 → 2.120.47

package/build/cli.js

@@ -31834,6 +31834,17 @@ var __importStar = (this && this.__importStar) || (function () {
         return result;
     };
 })();
+var __rest = (this && this.__rest) || function (s, e) {
+    var t = {};
+    for (var p in s) if (Object.prototype.hasOwnProperty.call(s, p) && e.indexOf(p) < 0)
+        t[p] = s[p];
+    if (s != null && typeof Object.getOwnPropertySymbols === "function")
+        for (var i = 0, p = Object.getOwnPropertySymbols(s); i < p.length; i++) {
+            if (e.indexOf(p[i]) < 0 && Object.prototype.propertyIsEnumerable.call(s, p[i]))
+                t[p[i]] = s[p[i]];
+        }
+    return t;
+};
 Object.defineProperty(exports, "__esModule", ({ value: true }));
 exports.InlineData = void 0;
 const Expressions = __importStar(__webpack_require__(/*! ../../2_statements/expressions */ "../core/build/src/abap/2_statements/expressions/index.js"));
@@ -31866,7 +31877,7 @@ class InlineData {
                 input.issues.push((0, _syntax_input_1.syntaxIssue)(input, node.getFirstToken(), message));
                 type = basic_1.VoidType.get(_syntax_input_1.CheckSyntaxKey);
             }
-            const identifier = new _typed_identifier_1.TypedIdentifier(token, input.filename, type, ["inline" /* IdentifierMeta.InlineDefinition */]);
+            const identifier = new _typed_identifier_1.TypedIdentifier(token, input.filename, this.stripDerivedFromConstant(type), ["inline" /* IdentifierMeta.InlineDefinition */]);
             input.scope.addIdentifier(identifier);
             input.scope.addReference(token, identifier, _reference_1.ReferenceType.DataWriteReference, input.filename);
         }
@@ -31877,6 +31888,26 @@ class InlineData {
             input.scope.addReference(token, identifier, _reference_1.ReferenceType.DataWriteReference, input.filename);
         }
     }
+    // The inferred type is taken from the source expression, which might be a literal.
+    // The variable itself is not a constant, so the relaxations that apply to literals
+    // must not be inherited, eg. a "c" variable is not assignable to a "string" parameter
+    static stripDerivedFromConstant(type) {
+        const data = type.getAbstractTypeData();
+        if ((data === null || data === void 0 ? void 0 : data.derivedFromConstant) !== true) {
+            return type;
+        }
+        const { derivedFromConstant } = data, rest = __rest(data, ["derivedFromConstant"]);
+        if (type instanceof basic_1.CharacterType) {
+            return new basic_1.CharacterType(type.getLength(), rest);
+        }
+        else if (type instanceof basic_1.IntegerType) {
+            return basic_1.IntegerType.get(rest);
+        }
+        else if (type instanceof basic_1.StringType) {
+            return basic_1.StringType.get(rest);
+        }
+        return type;
+    }
 }
 exports.InlineData = InlineData;
 //# sourceMappingURL=inline_data.js.map
@@ -41565,17 +41596,35 @@ const Expressions = __importStar(__webpack_require__(/*! ../../2_statements/expr
 const inline_data_1 = __webpack_require__(/*! ../expressions/inline_data */ "../core/build/src/abap/5_syntax/expressions/inline_data.js");
 const basic_1 = __webpack_require__(/*! ../../types/basic */ "../core/build/src/abap/types/basic/index.js");
 const target_1 = __webpack_require__(/*! ../expressions/target */ "../core/build/src/abap/5_syntax/expressions/target.js");
+const _syntax_input_1 = __webpack_require__(/*! ../_syntax_input */ "../core/build/src/abap/5_syntax/_syntax_input.js");
 class GetTime {
     runSyntax(node, input) {
         const target = node.findDirectExpression(Expressions.Target);
+        const stamp = node.findDirectTokenByText("STAMP") !== undefined;
         const inline = target === null || target === void 0 ? void 0 : target.findDirectExpression(Expressions.InlineData);
         if (inline) {
             inline_data_1.InlineData.runSyntax(inline, input, new basic_1.PackedType(8, 0));
         }
         else if (target) {
-            target_1.Target.runSyntax(target, input);
+            const type = target_1.Target.runSyntax(target, input);
+            if (stamp === true && this.compatibleTimeStamp(type) === false) {
+                const message = "GET TIME STAMP FIELD, target type not compatible";
+                input.issues.push((0, _syntax_input_1.syntaxIssue)(input, node.getFirstToken(), message));
+                return;
+            }
         }
     }
+    // the target must be a timestamp, ie. packed(timestamp and timestampl) or utclong
+    compatibleTimeStamp(type) {
+        return type === undefined
+            || type instanceof basic_1.PackedType
+            || type instanceof basic_1.UTCLongType
+            || type instanceof basic_1.VoidType
+            || type instanceof basic_1.AnyType
+            || type instanceof basic_1.DataType
+            || type instanceof basic_1.UnknownType
+            || type.isGeneric();
+    }
 }
 exports.GetTime = GetTime;
 //# sourceMappingURL=get_time.js.map
@@ -70343,7 +70392,7 @@ class Registry {
     }
     static abaplintVersion() {
         // magic, see build script "version.js"
-        return "2.120.45";
+        return "2.120.47";
     }
     getDDICReferences() {
         return this.ddicReferences;
@@ -71974,7 +72023,7 @@ class AllowedObjectNaming {
             key: "allowed_object_naming",
             title: "Allowed object naming",
             shortDescription: `Enforces basic name length and namespace restrictions, see note SAP 104010`,
-            tags: [_irule_1.RuleTag.Naming, _irule_1.RuleTag.SingleFile],
+            tags: [_irule_1.RuleTag.Naming, _irule_1.RuleTag.SingleFile, _irule_1.RuleTag.Syntax],
         };
     }
     initialize(_reg) {
@@ -77831,6 +77880,10 @@ Make sure to test the downported code, it might not always be completely correct
         if (found) {
             return found;
         }
+        found = this.outlineTableExpressionKeyBuiltin(low, high, lowFile, highSyntax);
+        if (found) {
+            return found;
+        }
         found = this.assignWithTable(low, high, lowFile);
         if (found) {
             return found;
@@ -78528,6 +78581,69 @@ ${indentation}`);
         }
         return condition;
     }
+    /** A built-in function is only recognized as one in an operand position that admits an
+     * expression, and "WITH KEY comp = ..." does not become such a position until v740. The
+     * table expression rewrites carry the key operand over verbatim, so
+     * "tab[ comp = to_upper( x ) ]" downports to a READ TABLE that a 702 or 731 compiler can
+     * only read as a functional method call - "method TO_UPPER is unknown", reported as a
+     * SYNTAX_ERROR of the whole class pool. Hoist the call into a variable first, an
+     * assignment IS an expression position at 702.
+     *
+     * Built-ins that predate 702 (lines, strlen, numofchar, ...) carry no release in
+     * BuiltIn.methods; they are accepted in the operand as they are and stay untouched. So do
+     * functional method calls, which are exactly the reading that makes the built-in fail, and
+     * the INDEX operand of "tab[ 1 ]", which is not a key operand. */
+    outlineTableExpressionKeyBuiltin(low, high, lowFile, highSyntax) {
+        if (!(low.get() instanceof _statement_1.Unknown)) {
+            return undefined;
+        }
+        for (const tableExpression of high.findAllExpressionsRecursive(Expressions.TableExpression)) {
+            let afterComponent = false;
+            for (const child of tableExpression.getChildren()) {
+                if (child.get() instanceof Expressions.ComponentChainSimple) {
+                    afterComponent = true;
+                    continue;
+                }
+                else if (afterComponent === false
+                    || !(child.get() instanceof Expressions.Source)
+                    || !(child instanceof nodes_1.ExpressionNode)) {
+                    continue;
+                }
+                const type = this.builtinReturnType(child, lowFile, highSyntax);
+                if (type === undefined) {
+                    continue;
+                }
+                const uniqueName = this.uniqueName(high.getFirstToken().getStart(), lowFile.getFilename(), highSyntax);
+                const indentation = " ".repeat(high.getFirstToken().getStart().getCol() - 1);
+                const code = `DATA ${uniqueName} TYPE ${type}.\n` +
+                    indentation + `${uniqueName} = ${child.concatTokens()}.\n` +
+                    indentation;
+                const fix1 = edit_helper_1.EditHelper.insertAt(lowFile, high.getFirstToken().getStart(), code);
+                const fix2 = edit_helper_1.EditHelper.replaceRange(lowFile, child.getFirstToken().getStart(), child.getLastToken().getEnd(), uniqueName);
+                const fix = edit_helper_1.EditHelper.merge(fix2, fix1);
+                return issue_1.Issue.atToken(lowFile, child.getFirstToken(), "Outline built-in function in table expression key", this.getMetadata().key, this.conf.severity, fix);
+            }
+        }
+        return undefined;
+    }
+    /** the ABAP type returned by the built-in function this Source starts with, or undefined
+     * if it does not start with one, or with one that predates 702 */
+    builtinReturnType(source, lowFile, highSyntax) {
+        var _a, _b, _c;
+        const spag = highSyntax.spaghetti.lookupPosition(source.getFirstToken().getStart(), lowFile.getFilename());
+        for (const r of (spag === null || spag === void 0 ? void 0 : spag.getData().references) || []) {
+            if (r.referenceType !== _reference_1.ReferenceType.BuiltinMethodReference
+                || r.position.getStart().equals(source.getFirstToken().getStart()) === false) {
+                continue;
+            }
+            const name = r.position.getName().toUpperCase();
+            if (((_a = _builtin_1.BuiltIn.methods[name]) === null || _a === void 0 ? void 0 : _a.release) === undefined) {
+                return undefined;
+            }
+            return (_c = (_b = _builtin_1.BuiltIn.searchBuiltin(name)) === null || _b === void 0 ? void 0 : _b.getParameters().getReturning()) === null || _c === void 0 ? void 0 : _c.getType().toABAP();
+        }
+        return undefined;
+    }
     outlineCatchSimple(node, lowFile) {
         // outlines "CATCH cx_bcs INTO DATA(lx_bcs_excep).", note that this does not need to look at types
         var _a, _b;
@@ -80138,9 +80254,13 @@ ${indentation}    output = ${uniqueName}.\n`;
                 continue;
             }
             const uniqueName = this.uniqueName(i.getFirstToken().getStart(), lowFile.getFilename(), highSyntax);
-            const type = this.findType(i, lowFile, highSyntax);
             const indent = " ".repeat(high.getFirstToken().getStart().getCol() - 1);
-            const abap = `DATA ${uniqueName} TYPE ${type}.\n` +
+            // the CONV type might just be a component of the row type, so prefer the row type
+            const rowOf = this.findRowTypeOf(high, i);
+            const declaration = rowOf === undefined
+                ? `DATA ${uniqueName} TYPE ${this.findType(i, lowFile, highSyntax)}.`
+                : `DATA ${uniqueName} LIKE LINE OF ${rowOf}.`;
+            const abap = declaration + "\n" +
                 indent + `${uniqueName} = ${body}.\n` +
                 indent;
             const fix1 = edit_helper_1.EditHelper.insertAt(lowFile, high.getFirstToken().getStart(), abap);
@@ -80150,6 +80270,19 @@ ${indentation}    output = ${uniqueName}.\n`;
         }
         return undefined;
     }
+    /** if the source expression is the complete source of an INSERT or APPEND statement, then the
+     * outlined variable must be typed via the row type of the table, returns the table name */
+    findRowTypeOf(high, source) {
+        var _a;
+        if (!(high.get() instanceof Statements.InsertInternal)
+            && !(high.get() instanceof Statements.Append)) {
+            return undefined;
+        }
+        else if (high.getChildren()[1] !== source) {
+            return undefined;
+        }
+        return (_a = high.findDirectExpression(Expressions.Target)) === null || _a === void 0 ? void 0 : _a.concatTokens();
+    }
     // "CAST" to "?="
     outlineCast(low, high, lowFile, highSyntax) {
         var _a;

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@abaplint/cli",
-    "version": "2.120.45",
+    "version": "2.120.47",
     "description": "abaplint - Command Line Interface",
     "funding": "https://github.com/sponsors/larshp",
     "bin": {
@@ -39,7 +39,7 @@
     },
     "homepage": "https://abaplint.org",
     "devDependencies": {
-        "@abaplint/core": "^2.120.45",
+        "@abaplint/core": "^2.120.47",
         "@types/chai": "^4.3.20",
         "@types/minimist": "^1.2.5",
         "@types/mocha": "^10.0.10",