@abaplint/cli 2.120.30 → 2.120.32

package/build/cli.js

@@ -27700,7 +27700,10 @@ class TypeUtils {
                 || source instanceof basic_1.DataType
                 || source instanceof basic_1.UnknownType;
         }
-        if (source instanceof basic_1.CharacterType) {
+        if (source instanceof cgeneric_type_1.CGenericType && target instanceof basic_1.StringType) {
+            return false;
+        }
+        else if (source instanceof basic_1.CharacterType) {
             if (target instanceof basic_1.CharacterType) {
                 if (((_b = source.getAbstractTypeData()) === null || _b === void 0 ? void 0 : _b.derivedFromConstant) === true) {
                     return source.getLength() <= target.getLength();
@@ -31478,11 +31481,20 @@ class FormParam {
             return new _typed_identifier_1.TypedIdentifier(nameToken, input.filename, basic_1.AnyType.get(), ["form_parameter" /* IdentifierMeta.FormParameter */]);
         }
         let bfound = new basic_types_1.BasicTypes(input).parseType(node);
-        const isTypeC = ((_c = node.findFirstExpression(expressions_1.TypeName)) === null || _c === void 0 ? void 0 : _c.concatTokens().toUpperCase()) === "C";
+        const typeName = (_c = node.findFirstExpression(expressions_1.TypeName)) === null || _c === void 0 ? void 0 : _c.concatTokens().toUpperCase();
         const hasExplicitLength = node.findFirstExpression(expressions_1.Length) !== undefined
             || node.findFirstExpression(expressions_1.ConstantFieldLength) !== undefined;
-        if (isTypeC && hasExplicitLength === false && bfound instanceof basic_1.CharacterType) {
-            bfound = basic_1.CGenericType.get();
+        // the length cannot be specified for FORM parameters, so these types are generic
+        if (hasExplicitLength === false) {
+            if (typeName === "C" && bfound instanceof basic_1.CharacterType) {
+                bfound = basic_1.CGenericType.get();
+            }
+            else if (typeName === "X" && bfound instanceof basic_1.HexType) {
+                bfound = basic_1.XGenericType.get();
+            }
+            else if (typeName === "P" && bfound instanceof basic_1.PackedType) {
+                bfound = basic_1.PGenericType.get();
+            }
         }
         if (nameToken && bfound) {
             return new _typed_identifier_1.TypedIdentifier(nameToken, input.filename, bfound, ["form_parameter" /* IdentifierMeta.FormParameter */]);
@@ -43509,6 +43521,11 @@ class Parameter {
             input.issues.push((0, _syntax_input_1.syntaxIssue)(input, node.getFirstToken(), message));
             return;
         }
+        const radioGroup = node.findFirstExpression(Expressions.RadioGroupName);
+        if (radioGroup && radioGroup.concatTokens().length > 4) {
+            const message = "Radio button group name too long, " + radioGroup.concatTokens();
+            input.issues.push((0, _syntax_input_1.syntaxIssue)(input, radioGroup.getFirstToken(), message));
+        }
         if (this.hasUserCommand(node) && this.hasLength(node)) {
             const message = "USER-COMMAND and LENGTH not possible together";
             input.issues.push((0, _syntax_input_1.syntaxIssue)(input, node.getFirstToken(), message));
@@ -43606,6 +43623,7 @@ const target_1 = __webpack_require__(/*! ../expressions/target */ "../core/build
 const _syntax_input_1 = __webpack_require__(/*! ../_syntax_input */ "../core/build/src/abap/5_syntax/_syntax_input.js");
 const assert_error_1 = __webpack_require__(/*! ../assert_error */ "../core/build/src/abap/5_syntax/assert_error.js");
 const dynamic_1 = __webpack_require__(/*! ../expressions/dynamic */ "../core/build/src/abap/5_syntax/expressions/dynamic.js");
+const _type_utils_1 = __webpack_require__(/*! ../_type_utils */ "../core/build/src/abap/5_syntax/_type_utils.js");
 class Perform {
     runSyntax(node, input) {
         if (!(node.get() instanceof Statements.Perform)) {
@@ -43613,19 +43631,22 @@ class Perform {
         }
         ////////////////////////////
         // check parameters are defined
+        const changing = [];
         for (const c of node.findDirectExpressions(Expressions.PerformChanging)) {
             for (const s of c.findDirectExpressions(Expressions.Target)) {
-                target_1.Target.runSyntax(s, input);
+                changing.push({ node: s, type: target_1.Target.runSyntax(s, input) });
             }
         }
+        const tables = [];
         for (const t of node.findDirectExpressions(Expressions.PerformTables)) {
             for (const s of t.findDirectExpressions(Expressions.Source)) {
-                source_1.Source.runSyntax(s, input);
+                tables.push({ node: s, type: source_1.Source.runSyntax(s, input) });
             }
         }
+        const using = [];
         for (const u of node.findDirectExpressions(Expressions.PerformUsing)) {
             for (const s of u.findDirectExpressions(Expressions.SimpleSource3)) {
-                source_1.Source.runSyntax(s, input);
+                using.push({ node: s, type: source_1.Source.runSyntax(s, input) });
             }
         }
         ////////////////////////////
@@ -43650,7 +43671,36 @@ class Perform {
             return;
         }
         input.scope.addReference(expr.getFirstToken(), found, _reference_1.ReferenceType.FormReference, input.filename);
-        // todo, also check parameters match
+        ////////////////////////////
+        // check parameters match
+        // USING and CHANGING are interchangeable, the actual parameters form a single positional list
+        if (this.checkParameters(node, tables, found.getTablesParameters(), "TABLES", input) === false) {
+            return;
+        }
+        const formal = found.getUsingParameters().concat(found.getChangingParameters());
+        this.checkParameters(node, using.concat(changing), formal, "USING/CHANGING", input);
+    }
+    // returns false if an issue was reported
+    checkParameters(node, actual, formal, kind, input) {
+        if (actual.length !== formal.length) {
+            const message = `PERFORM, expected ${formal.length} ${kind} parameters, found ${actual.length}`;
+            input.issues.push((0, _syntax_input_1.syntaxIssue)(input, node.getFirstToken(), message));
+            return false;
+        }
+        const typeUtils = new _type_utils_1.TypeUtils(input.scope);
+        for (let i = 0; i < actual.length; i++) {
+            const { node: source, type } = actual[i];
+            if (type === undefined) {
+                continue;
+            }
+            const parameter = formal[i];
+            if (typeUtils.isAssignableStrict(type, parameter.getType(), source) === false) {
+                const message = `PERFORM parameter type not compatible, ${parameter.getName()}`;
+                input.issues.push((0, _syntax_input_1.syntaxIssue)(input, source.getFirstToken(), message));
+                return false;
+            }
+        }
+        return true;
     }
 }
 exports.Perform = Perform;
@@ -70003,7 +70053,7 @@ class Registry {
     }
     static abaplintVersion() {
         // magic, see build script "version.js"
-        return "2.120.30";
+        return "2.120.32";
     }
     getDDICReferences() {
         return this.ddicReferences;
@@ -84231,6 +84281,7 @@ __exportStar(__webpack_require__(/*! ./newline_between_methods */ "../core/build
 __exportStar(__webpack_require__(/*! ./no_aliases */ "../core/build/src/rules/no_aliases.js"), exports);
 __exportStar(__webpack_require__(/*! ./no_chained_assignment */ "../core/build/src/rules/no_chained_assignment.js"), exports);
 __exportStar(__webpack_require__(/*! ./no_comments_between_methods */ "../core/build/src/rules/no_comments_between_methods.js"), exports);
+__exportStar(__webpack_require__(/*! ./no_dynamic_stuff */ "../core/build/src/rules/no_dynamic_stuff.js"), exports);
 __exportStar(__webpack_require__(/*! ./no_external_form_calls */ "../core/build/src/rules/no_external_form_calls.js"), exports);
 __exportStar(__webpack_require__(/*! ./no_inline_in_optional_branches */ "../core/build/src/rules/no_inline_in_optional_branches.js"), exports);
 __exportStar(__webpack_require__(/*! ./no_macros */ "../core/build/src/rules/no_macros.js"), exports);
@@ -84310,6 +84361,7 @@ __exportStar(__webpack_require__(/*! ./when_others_last */ "../core/build/src/ru
 __exportStar(__webpack_require__(/*! ./whitespace_end */ "../core/build/src/rules/whitespace_end.js"), exports);
 __exportStar(__webpack_require__(/*! ./xml_consistency */ "../core/build/src/rules/xml_consistency.js"), exports);
 __exportStar(__webpack_require__(/*! ./no_exclamation_escape */ "../core/build/src/rules/no_exclamation_escape.js"), exports);
+__exportStar(__webpack_require__(/*! ./xml_bom */ "../core/build/src/rules/xml_bom.js"), exports);
 __exportStar(__webpack_require__(/*! ./no_exclamation_escape */ "../core/build/src/rules/no_exclamation_escape.js"), exports);
 //# sourceMappingURL=index.js.map
 
@@ -88343,6 +88395,255 @@ exports.NoCommentsBetweenMethods = NoCommentsBetweenMethods;
 
 /***/ },
 
+/***/ "../core/build/src/rules/no_dynamic_stuff.js"
+/*!***************************************************!*\
+  !*** ../core/build/src/rules/no_dynamic_stuff.js ***!
+  \***************************************************/
+(__unused_webpack_module, exports, __webpack_require__) {
+
+"use strict";
+
+var __createBinding = (this && this.__createBinding) || (Object.create ? (function(o, m, k, k2) {
+    if (k2 === undefined) k2 = k;
+    var desc = Object.getOwnPropertyDescriptor(m, k);
+    if (!desc || ("get" in desc ? !m.__esModule : desc.writable || desc.configurable)) {
+      desc = { enumerable: true, get: function() { return m[k]; } };
+    }
+    Object.defineProperty(o, k2, desc);
+}) : (function(o, m, k, k2) {
+    if (k2 === undefined) k2 = k;
+    o[k2] = m[k];
+}));
+var __setModuleDefault = (this && this.__setModuleDefault) || (Object.create ? (function(o, v) {
+    Object.defineProperty(o, "default", { enumerable: true, value: v });
+}) : function(o, v) {
+    o["default"] = v;
+});
+var __importStar = (this && this.__importStar) || (function () {
+    var ownKeys = function(o) {
+        ownKeys = Object.getOwnPropertyNames || function (o) {
+            var ar = [];
+            for (var k in o) if (Object.prototype.hasOwnProperty.call(o, k)) ar[ar.length] = k;
+            return ar;
+        };
+        return ownKeys(o);
+    };
+    return function (mod) {
+        if (mod && mod.__esModule) return mod;
+        var result = {};
+        if (mod != null) for (var k = ownKeys(mod), i = 0; i < k.length; i++) if (k[i] !== "default") __createBinding(result, mod, k[i]);
+        __setModuleDefault(result, mod);
+        return result;
+    };
+})();
+Object.defineProperty(exports, "__esModule", ({ value: true }));
+exports.NoDynamicStuff = exports.NoDynamicStuffConf = void 0;
+const Statements = __importStar(__webpack_require__(/*! ../abap/2_statements/statements */ "../core/build/src/abap/2_statements/statements/index.js"));
+const Expressions = __importStar(__webpack_require__(/*! ../abap/2_statements/expressions */ "../core/build/src/abap/2_statements/expressions/index.js"));
+const _abap_rule_1 = __webpack_require__(/*! ./_abap_rule */ "../core/build/src/rules/_abap_rule.js");
+const _basic_rule_config_1 = __webpack_require__(/*! ./_basic_rule_config */ "../core/build/src/rules/_basic_rule_config.js");
+const issue_1 = __webpack_require__(/*! ../issue */ "../core/build/src/issue.js");
+const _irule_1 = __webpack_require__(/*! ./_irule */ "../core/build/src/rules/_irule.js");
+class NoDynamicStuffConf extends _basic_rule_config_1.BasicRuleConfig {
+    constructor() {
+        super(...arguments);
+        /** Detects dynamic method calls, ie. CALL METHOD (name), SET HANDLER and CALL BADI */
+        this.callMethod = true;
+        /** Detects dynamic CALL FUNCTION, ie. the function module name is not a literal */
+        this.callFunction = true;
+        /** Detects CALL DATABASE PROCEDURE, the procedure name is always dynamic */
+        this.callDatabaseProcedure = true;
+        /** Detects dynamic CALL TRANSFORMATION */
+        this.callTransformation = true;
+        /** Detects dynamic CALL TRANSACTION, ie. the transaction code is not a literal */
+        this.callTransaction = true;
+        /** Detects dynamic PERFORM */
+        this.perform = true;
+        /** Detects dynamic SUBMIT */
+        this.submit = true;
+        /** Detects dynamic CREATE OBJECT */
+        this.createObject = true;
+        /** Detects dynamic CREATE DATA */
+        this.createData = true;
+        /** Detects dynamic GET BADI */
+        this.getBadi = true;
+        /** Detects dynamic ASSIGN, including ASSIGN COMPONENT */
+        this.assign = true;
+        /** Detects dynamic internal table access, ie. dynamic WHERE, keys, SORT BY and TRANSPORTING */
+        this.internalTable = true;
+        /** Detects dynamic EXPORT and IMPORT */
+        this.exportImport = true;
+    }
+}
+exports.NoDynamicStuffConf = NoDynamicStuffConf;
+class NoDynamicStuff extends _abap_rule_1.ABAPRule {
+    constructor() {
+        super(...arguments);
+        this.conf = new NoDynamicStuffConf();
+    }
+    getMetadata() {
+        return {
+            key: "no_dynamic_stuff",
+            title: "No dynamic stuff",
+            shortDescription: `Detects dynamic calls and other dynamic language constructs`,
+            extendedInformation: `Dynamic constructs cannot be checked statically, they are not found by
+where-used lists and refactorings, and they can introduce injection vulnerabilities.
+
+Dynamic tokens containing a literal, eg. CALL METHOD ('CL_FOO')=>('BAR'), are not reported,
+as these are equivalent to the static variant.
+
+Dynamic SQL is reported by rule dangerous_statement.`,
+            tags: [_irule_1.RuleTag.SingleFile, _irule_1.RuleTag.Security],
+            badExample: `CALL METHOD (lv_class)=>(lv_method).
+CALL FUNCTION lv_function_module.
+CREATE OBJECT ref TYPE (lv_class).
+ASSIGN (lv_name) TO <fs>.
+SORT tab BY (lv_field).`,
+            goodExample: `cl_class=>method( ).
+CALL FUNCTION 'ZFOO'.
+CREATE OBJECT ref TYPE cl_class.
+ASSIGN foo TO <fs>.
+SORT tab BY field.`,
+        };
+    }
+    getConfig() {
+        return this.conf;
+    }
+    setConfig(conf) {
+        this.conf = conf;
+    }
+    runParsed(file) {
+        const issues = [];
+        for (const statementNode of file.getStatements()) {
+            const found = this.check(statementNode);
+            if (found !== undefined) {
+                issues.push(issue_1.Issue.atStatement(file, statementNode, "Dynamic " + found, this.getMetadata().key, this.conf.severity));
+            }
+        }
+        return issues;
+    }
+    check(node) {
+        const statement = node.get();
+        // note that MethodSource is also used by SET HANDLER and CALL BADI
+        if (this.conf.callMethod === true && this.dynamicMethodSource(node) === true) {
+            return "method call";
+        }
+        if (statement instanceof Statements.CallFunction) {
+            if (this.conf.callFunction === true
+                && this.notLiteral(node.findDirectExpression(Expressions.FunctionName))) {
+                return "CALL FUNCTION";
+            }
+        }
+        else if (statement instanceof Statements.CallDatabase) {
+            if (this.conf.callDatabaseProcedure === true) {
+                return "CALL DATABASE PROCEDURE";
+            }
+        }
+        else if (statement instanceof Statements.CallTransformation) {
+            if (this.conf.callTransformation === true && this.hasDynamic(node)) {
+                return "CALL TRANSFORMATION";
+            }
+        }
+        else if (statement instanceof Statements.CallTransaction) {
+            // the transaction code is a Source, ie. there is no parenthesized dynamic variant
+            if (this.conf.callTransaction === true
+                && this.notLiteral(node.findDirectExpression(Expressions.Source))) {
+                return "CALL TRANSACTION";
+            }
+        }
+        else if (statement instanceof Statements.Perform) {
+            if (this.conf.perform === true && this.hasDynamic(node)) {
+                return "PERFORM";
+            }
+        }
+        else if (statement instanceof Statements.Submit) {
+            if (this.conf.submit === true && this.hasDynamic(node)) {
+                return "SUBMIT";
+            }
+        }
+        else if (statement instanceof Statements.CreateObject) {
+            if (this.conf.createObject === true && this.hasDynamic(node)) {
+                return "CREATE OBJECT";
+            }
+        }
+        else if (statement instanceof Statements.CreateData) {
+            if (this.conf.createData === true && this.hasDynamic(node)) {
+                return "CREATE DATA";
+            }
+        }
+        else if (statement instanceof Statements.GetBadi) {
+            if (this.conf.getBadi === true && this.hasDynamic(node)) {
+                return "GET BADI";
+            }
+        }
+        else if (statement instanceof Statements.Assign
+            || statement instanceof Statements.AssignLocalCopy) {
+            if (this.conf.assign === true
+                && (this.hasDynamic(node) || this.dynamicAssignComponent(node))) {
+                return "ASSIGN";
+            }
+        }
+        else if (statement instanceof Statements.Export) {
+            if (this.conf.exportImport === true && this.hasDynamic(node)) {
+                return "EXPORT";
+            }
+        }
+        else if (statement instanceof Statements.Import) {
+            if (this.conf.exportImport === true && this.hasDynamic(node)) {
+                return "IMPORT";
+            }
+        }
+        else if (statement instanceof Statements.At
+            || statement instanceof Statements.DeleteInternal
+            || statement instanceof Statements.InsertInternal
+            || statement instanceof Statements.Loop
+            || statement instanceof Statements.ModifyInternal
+            || statement instanceof Statements.ReadTable
+            || statement instanceof Statements.Sort
+            || statement instanceof Statements.SortDataset) {
+            if (this.conf.internalTable === true && this.hasDynamic(node)) {
+                return "internal table access";
+            }
+        }
+        return undefined;
+    }
+    dynamicMethodSource(node) {
+        for (const source of node.findAllExpressions(Expressions.MethodSource)) {
+            // Dynamic is always a direct child of MethodSource, dynamics further down
+            // are parameters of the method call and not part of the method name
+            for (const dynamic of source.findDirectExpressions(Expressions.Dynamic)) {
+                if (this.isLiteral(dynamic) === false) {
+                    return true;
+                }
+            }
+        }
+        return false;
+    }
+    dynamicAssignComponent(node) {
+        var _a;
+        const component = (_a = node.findDirectExpression(Expressions.AssignSource)) === null || _a === void 0 ? void 0 : _a.findExpressionAfterToken("COMPONENT");
+        return component !== undefined && this.isLiteral(component) === false;
+    }
+    hasDynamic(node) {
+        for (const dynamic of node.findAllExpressions(Expressions.Dynamic)) {
+            if (this.isLiteral(dynamic) === false) {
+                return true;
+            }
+        }
+        return false;
+    }
+    notLiteral(node) {
+        return node !== undefined && this.isLiteral(node) === false;
+    }
+    isLiteral(node) {
+        return node.findDirectExpression(Expressions.Constant) !== undefined;
+    }
+}
+exports.NoDynamicStuff = NoDynamicStuff;
+//# sourceMappingURL=no_dynamic_stuff.js.map
+
+/***/ },
+
 /***/ "../core/build/src/rules/no_exclamation_escape.js"
 /*!********************************************************!*\
   !*** ../core/build/src/rules/no_exclamation_escape.js ***!
@@ -99536,6 +99837,64 @@ exports.WhitespaceEnd = WhitespaceEnd;
 
 /***/ },
 
+/***/ "../core/build/src/rules/xml_bom.js"
+/*!******************************************!*\
+  !*** ../core/build/src/rules/xml_bom.js ***!
+  \******************************************/
+(__unused_webpack_module, exports, __webpack_require__) {
+
+"use strict";
+
+Object.defineProperty(exports, "__esModule", ({ value: true }));
+exports.XMLBOM = exports.XMLBOMConf = void 0;
+const edit_helper_1 = __webpack_require__(/*! ../edit_helper */ "../core/build/src/edit_helper.js");
+const issue_1 = __webpack_require__(/*! ../issue */ "../core/build/src/issue.js");
+const position_1 = __webpack_require__(/*! ../position */ "../core/build/src/position.js");
+const _basic_rule_config_1 = __webpack_require__(/*! ./_basic_rule_config */ "../core/build/src/rules/_basic_rule_config.js");
+const _irule_1 = __webpack_require__(/*! ./_irule */ "../core/build/src/rules/_irule.js");
+class XMLBOMConf extends _basic_rule_config_1.BasicRuleConfig {
+}
+exports.XMLBOMConf = XMLBOMConf;
+class XMLBOM {
+    constructor() {
+        this.conf = new XMLBOMConf();
+    }
+    getMetadata() {
+        return {
+            key: "xml_bom",
+            title: "XML UTF-8 byte order mark",
+            shortDescription: "Checks that XML files start with a UTF-8 byte order mark",
+            extendedInformation: "Checks that each XML file has a UTF-8 byte order mark (BOM) at its beginning.",
+            tags: [_irule_1.RuleTag.Syntax, _irule_1.RuleTag.Quickfix],
+        };
+    }
+    getConfig() {
+        return this.conf;
+    }
+    setConfig(conf) {
+        this.conf = conf;
+    }
+    initialize(_reg) {
+        return this;
+    }
+    run(obj) {
+        const file = obj.getXMLFile();
+        if (file === undefined || file.getRaw().startsWith("\uFEFF")) {
+            return [];
+        }
+        return [this.createIssue(file)];
+    }
+    createIssue(file) {
+        const start = new position_1.Position(1, 1);
+        const fix = edit_helper_1.EditHelper.insertAt(file, start, "\uFEFF");
+        return issue_1.Issue.atRange(file, start, start, "XML file must start with a UTF-8 byte order mark", this.getMetadata().key, this.conf.severity, fix);
+    }
+}
+exports.XMLBOM = XMLBOM;
+//# sourceMappingURL=xml_bom.js.map
+
+/***/ },
+
 /***/ "../core/build/src/rules/xml_consistency.js"
 /*!**************************************************!*\
   !*** ../core/build/src/rules/xml_consistency.js ***!

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@abaplint/cli",
-    "version": "2.120.30",
+    "version": "2.120.32",
     "description": "abaplint - Command Line Interface",
     "funding": "https://github.com/sponsors/larshp",
     "bin": {
@@ -39,7 +39,7 @@
     },
     "homepage": "https://abaplint.org",
     "devDependencies": {
-        "@abaplint/core": "^2.120.30",
+        "@abaplint/core": "^2.120.32",
         "@types/chai": "^4.3.20",
         "@types/minimist": "^1.2.5",
         "@types/mocha": "^10.0.10",