@abaplint/cli 2.120.27 → 2.120.29

package/build/cli.js

@@ -9079,7 +9079,7 @@ const sql_field_1 = __webpack_require__(/*! ./sql_field */ "../core/build/src/ab
 const sql_grouping_sets_1 = __webpack_require__(/*! ./sql_grouping_sets */ "../core/build/src/abap/2_statements/expressions/sql_grouping_sets.js");
 class SQLGroupBy extends combi_1.Expression {
     getRunnable() {
-        const fieldName = (0, combi_1.alt)(sql_field_name_1.SQLFieldName, dynamic_1.Dynamic);
+        const fieldName = (0, combi_1.seq)((0, combi_1.stopBefore)("ORDER", "BY"), (0, combi_1.alt)(sql_field_name_1.SQLFieldName, dynamic_1.Dynamic));
         const expr = (0, combi_1.ver)(version_1.Release.v740sp02, sql_field_1.SQLField, { also: combi_1.AlsoIn.OpenABAP });
         const newGroup = (0, combi_1.ver)(version_1.Release.v740sp02, (0, combi_1.seq)("GROUP BY", expr, (0, combi_1.altPrio)((0, combi_1.plus)((0, combi_1.seq)(",", expr)), (0, combi_1.optPrio)((0, combi_1.plus)(fieldName)))), { also: combi_1.AlsoIn.OpenABAP });
         const old = (0, combi_1.seq)((0, combi_1.plus)((0, combi_1.seq)(fieldName, ",")), fieldName);
@@ -26676,6 +26676,31 @@ class ObjectOriented {
         }
         return ret;
     }
+    // does the supplied class have friendship with "friendName"?
+    // note that interfaces of the friend, and subclasses of the friend also have friendship
+    hasFriendship(cd, friendName) {
+        var _a;
+        const friends = cd.getFriends().map(f => f.toUpperCase());
+        const isFriend = (name) => friends.includes(name.toUpperCase()) || this.scope.isLocalFriend(cd.getName(), name);
+        if (isFriend(friendName)) {
+            return true;
+        }
+        const friendDefinition = this.scope.findClassDefinition(friendName);
+        if (friendDefinition === undefined) {
+            return false;
+        }
+        if (this.findInterfaces(friendDefinition).some(i => friends.includes(i.name.toUpperCase()))) {
+            return true;
+        }
+        let sup = friendDefinition.getSuperClass();
+        while (sup !== undefined) {
+            if (isFriend(sup)) {
+                return true;
+            }
+            sup = (_a = this.scope.findClassDefinition(sup)) === null || _a === void 0 ? void 0 : _a.getSuperClass();
+        }
+        return false;
+    }
     searchEvent(def, name) {
         if (def === undefined || name === undefined) {
             return undefined;
@@ -27865,6 +27890,9 @@ class TypeUtils {
             console.dir(source);
             console.dir(target);
         */
+        if (source instanceof basic_1.UTCLongType || target instanceof basic_1.UTCLongType) {
+            return this.isUTCLongAssignable(source, target);
+        }
         if (target instanceof basic_1.TableType) {
             if (target.isWithHeader()) {
                 return this.isAssignable(source, target.getRowType());
@@ -28016,6 +28044,33 @@ class TypeUtils {
         }
         return true;
     }
+    // utclong can only be converted to and from character like types
+    isUTCLongAssignable(source, target) {
+        if (this.isGenericOrVoid(source) || this.isGenericOrVoid(target)) {
+            return true;
+        }
+        else if (source instanceof basic_1.UTCLongType && target instanceof basic_1.UTCLongType) {
+            return true;
+        }
+        else if (source instanceof basic_1.UTCLongType) {
+            return this.isTextLike(target);
+        }
+        return this.isTextLike(source);
+    }
+    isGenericOrVoid(type) {
+        return type instanceof basic_1.VoidType
+            || type instanceof basic_1.AnyType
+            || type instanceof basic_1.DataType
+            || type instanceof basic_1.UnknownType;
+    }
+    isTextLike(type) {
+        return type instanceof basic_1.CharacterType
+            || type instanceof basic_1.StringType
+            || type instanceof basic_1.CLikeType
+            || type instanceof basic_1.CSequenceType
+            || type instanceof cgeneric_type_1.CGenericType
+            || type instanceof basic_1.SimpleType;
+    }
 }
 exports.TypeUtils = TypeUtils;
 //# sourceMappingURL=_type_utils.js.map
@@ -29137,7 +29192,7 @@ function checkDatabaseFields(fields, dbSources, input, token) {
         if (field === "*") {
             continue;
         }
-        if (/^\w+$/.test(field) && type.getComponentByName(field) === undefined) {
+        if (/^[A-Z_]\w*$/i.test(field) && type.getComponentByName(field) === undefined) {
             const message = `checkFields, field ${field} not found`;
             input.issues.push((0, _syntax_input_1.syntaxIssue)(input, token, message));
             return;
@@ -32311,6 +32366,8 @@ const _reference_1 = __webpack_require__(/*! ../_reference */ "../core/build/src
 const component_name_1 = __webpack_require__(/*! ./component_name */ "../core/build/src/abap/5_syntax/expressions/component_name.js");
 const attribute_name_1 = __webpack_require__(/*! ./attribute_name */ "../core/build/src/abap/5_syntax/expressions/attribute_name.js");
 const _syntax_input_1 = __webpack_require__(/*! ../_syntax_input */ "../core/build/src/abap/5_syntax/_syntax_input.js");
+const visibility_1 = __webpack_require__(/*! ../../4_file_information/visibility */ "../core/build/src/abap/4_file_information/visibility.js");
+const class_definition_1 = __webpack_require__(/*! ../../types/class_definition */ "../core/build/src/abap/types/class_definition.js");
 class MethodCallChain {
     static runSyntax(node, input, targetType) {
         var _a, _b;
@@ -32359,6 +32416,12 @@ class MethodCallChain {
                         input.issues.push((0, _syntax_input_1.syntaxIssue)(input, methodToken, message));
                         return basic_1.VoidType.get(_syntax_input_1.CheckSyntaxKey);
                     }
+                    const notVisible = method ? this.checkVisibility(method, def, foundDef, input) : undefined;
+                    if (notVisible !== undefined) {
+                        const message = `Method "${methodName}" is ${notVisible} and cannot be accessed`;
+                        input.issues.push((0, _syntax_input_1.syntaxIssue)(input, methodToken, message));
+                        return basic_1.VoidType.get(_syntax_input_1.CheckSyntaxKey);
+                    }
                     const voidedName = context instanceof basic_1.VoidType ? context.getVoided() : undefined;
                     const extra = helper.methodReferenceExtras(foundDef, className || voidedName);
                     input.scope.addReference(methodToken, method, _reference_1.ReferenceType.MethodReference, input.filename, extra);
@@ -32401,6 +32464,47 @@ class MethodCallChain {
         return context;
     }
     //////////////////////////////////////
+    // returns the visibility as text if the method cannot be accessed from the current scope
+    static checkVisibility(method, def, foundDef, input) {
+        var _a, _b, _c;
+        const visibility = method.getVisibility();
+        if (visibility === visibility_1.Visibility.Public || foundDef === undefined) {
+            return undefined;
+        }
+        else if (!(foundDef instanceof class_definition_1.ClassDefinition)) {
+            // interface members are always public
+            return undefined;
+        }
+        const name = foundDef.getName().toUpperCase();
+        const enclosing = (_a = input.scope.getEnclosingClassName()) === null || _a === void 0 ? void 0 : _a.toUpperCase();
+        if (enclosing === undefined || enclosing === name) {
+            return undefined;
+        }
+        // friendship with the class used at the call site also gives access to inherited members
+        const helper = new _object_oriented_1.ObjectOriented(input.scope);
+        const visited = [];
+        let current = def instanceof class_definition_1.ClassDefinition ? def : foundDef;
+        while (current !== undefined && visited.includes(current.getName().toUpperCase()) === false) {
+            visited.push(current.getName().toUpperCase());
+            if (helper.hasFriendship(current, enclosing)) {
+                return undefined;
+            }
+            const sup = current.getSuperClass();
+            current = sup === undefined ? undefined : input.scope.findClassDefinition(sup);
+        }
+        if (visibility === visibility_1.Visibility.Protected) {
+            // subclasses can access protected members
+            let sup = (_b = input.scope.findClassDefinition(enclosing)) === null || _b === void 0 ? void 0 : _b.getSuperClass();
+            while (sup !== undefined) {
+                if (sup.toUpperCase() === name) {
+                    return undefined;
+                }
+                sup = (_c = input.scope.findClassDefinition(sup)) === null || _c === void 0 ? void 0 : _c.getSuperClass();
+            }
+            return "protected";
+        }
+        return "private";
+    }
     static findTop(first, input, targetType) {
         var _a;
         if (first.get() instanceof Expressions.ClassName) {
@@ -33823,7 +33927,7 @@ class Select {
             return;
         }
         (0, _check_database_fields_1.checkDatabaseFields)(fields.map(field => field.code), dbSources, input, node.getFirstToken());
-        const intoExpression = this.handleInto(node, input, fields, dbSources);
+        const intoExpression = this.handleInto(node, input, fields, dbSources, from);
         const fae = node.findDirectExpression(Expressions.SQLForAllEntries);
         if (fae) {
             input.scope.push(_scope_type_1.ScopeType.OpenSQL, "SELECT", token.getStart(), input.filename);
@@ -33984,12 +34088,12 @@ class Select {
             input.issues.push((0, _syntax_input_1.syntaxIssue)(input, node.getFirstToken(), message));
         }
     }
-    static handleInto(node, input, fields, dbSources) {
+    static handleInto(node, input, fields, dbSources, from) {
         const intoTable = node.findDirectExpression(Expressions.SQLIntoTable);
         if (intoTable) {
             const inline = intoTable.findFirstExpression(Expressions.InlineData);
             if (inline) {
-                inline_data_1.InlineData.runSyntax(inline, input, this.buildTableType(fields, dbSources, input.scope));
+                inline_data_1.InlineData.runSyntax(inline, input, this.buildTableType(fields, dbSources, input.scope, from));
             }
             return intoTable;
         }
@@ -34137,11 +34241,36 @@ class Select {
             return basic_1.VoidType.get("SELECT_todo13");
         }
     }
-    static buildTableType(fields, dbSources, scope) {
-        if (dbSources.length !== 1) {
+    static buildTableType(fields, dbSources, scope, from) {
+        var _a;
+        const tableOptions = { withHeader: false, keyType: basic_1.TableKeyType.empty };
+        if (dbSources.length > 1) {
+            const sourceInfos = this.buildDatabaseSourceInfos(from, dbSources);
+            if (fields.length === 1 && fields[0].code === "*") {
+                const components = [];
+                for (const info of sourceInfos) {
+                    const type = (_a = info.source) === null || _a === void 0 ? void 0 : _a.parseType(scope.getRegistry());
+                    if (!(type instanceof basic_1.StructureType)) {
+                        return basic_1.VoidType.get("SELECT_todo3");
+                    }
+                    components.push({ name: info.alias || info.name, type });
+                }
+                return new basic_1.TableType(new basic_1.StructureType(components), tableOptions, undefined);
+            }
+            const components = [];
+            for (const field of fields) {
+                const type = this.findFieldType(field.code, sourceInfos, scope);
+                if (type === undefined) {
+                    return basic_1.VoidType.get("SELECT_todo3");
+                }
+                const name = field.as || field.code.split("~").pop();
+                components.push({ name, type });
+            }
+            return new basic_1.TableType(new basic_1.StructureType(components), tableOptions, undefined);
+        }
+        else if (dbSources.length !== 1) {
             return basic_1.VoidType.get("SELECT_todo3");
         }
-        const tableOptions = { withHeader: false, keyType: basic_1.TableKeyType.empty };
         if (dbSources[0] === undefined) {
             // then its a voided table
             return new basic_1.TableType(basic_1.VoidType.get("SELECT_todo4"), tableOptions, undefined);
@@ -34167,6 +34296,39 @@ class Select {
         }
         return basic_1.VoidType.get("SELECT_todo7");
     }
+    static buildDatabaseSourceInfos(from, dbSources) {
+        const fromSources = from.findAllExpressions(Expressions.SQLFromSource);
+        return dbSources.map((source, index) => {
+            var _a, _b;
+            const fromSource = fromSources[index];
+            const name = ((_a = fromSource === null || fromSource === void 0 ? void 0 : fromSource.findFirstExpression(Expressions.DatabaseTable)) === null || _a === void 0 ? void 0 : _a.getFirstToken().getStr().replace(/^\*/, "").toUpperCase()) || "";
+            const alias = ((_b = fromSource === null || fromSource === void 0 ? void 0 : fromSource.findDirectExpression(Expressions.SQLAsName)) === null || _b === void 0 ? void 0 : _b.concatTokens().toUpperCase()) || "";
+            return { source, name, alias };
+        });
+    }
+    static findFieldType(code, sourceInfos, scope) {
+        var _a;
+        const separator = code.indexOf("~");
+        const qualifier = separator >= 0 ? code.substring(0, separator) : undefined;
+        const fieldName = separator >= 0 ? code.substring(separator + 1) : code;
+        const candidates = qualifier === undefined
+            ? sourceInfos
+            : sourceInfos.filter(info => info.alias === qualifier || info.name === qualifier);
+        for (const candidate of candidates) {
+            let type = (_a = candidate.source) === null || _a === void 0 ? void 0 : _a.parseType(scope.getRegistry());
+            for (const component of fieldName.split("-")) {
+                if (!(type instanceof basic_1.StructureType)) {
+                    type = undefined;
+                    break;
+                }
+                type = type.getComponentByName(component);
+            }
+            if (type) {
+                return type;
+            }
+        }
+        return undefined;
+    }
     static findFields(node, input) {
         var _a, _b;
         let expr = undefined;
@@ -34180,7 +34342,7 @@ class Select {
             let code = field.concatTokens().toUpperCase();
             const as = ((_b = field.findDirectExpression(Expressions.SQLAsName)) === null || _b === void 0 ? void 0 : _b.concatTokens()) || "";
             if (as !== "") {
-                code = code.replace(" AS " + as, "");
+                code = code.replace(" AS " + as.toUpperCase(), "");
             }
             ret.push({ code, as, expression: field });
         }
@@ -35011,6 +35173,7 @@ const basic_1 = __webpack_require__(/*! ../../types/basic */ "../core/build/src/
 const _syntax_input_1 = __webpack_require__(/*! ../_syntax_input */ "../core/build/src/abap/5_syntax/_syntax_input.js");
 const sql_set_op_group_1 = __webpack_require__(/*! ./sql_set_op_group */ "../core/build/src/abap/5_syntax/expressions/sql_set_op_group.js");
 const sql_source_1 = __webpack_require__(/*! ./sql_source */ "../core/build/src/abap/5_syntax/expressions/sql_source.js");
+const RANGE_COMPONENTS = ["SIGN", "OPTION", "LOW", "HIGH"];
 class SQLIn {
     static runSyntax(node, input) {
         const setop = node.findDirectExpression(Expressions.SQLSetOpGroup);
@@ -35030,6 +35193,12 @@ class SQLIn {
                     input.issues.push((0, _syntax_input_1.syntaxIssue)(input, node.getFirstToken(), message));
                     return;
                 }
+                if (intype instanceof basic_1.TableType && this.isRangeRow(intype.getRowType()) === false) {
+                    const name = insource.concatTokens().replace(/^@/, "").replace(/\[\]$/, "");
+                    const message = `row structure of ${name} is not correct`;
+                    input.issues.push((0, _syntax_input_1.syntaxIssue)(input, node.getFirstToken(), message));
+                    return;
+                }
             }
             return;
         }
@@ -35040,6 +35209,16 @@ class SQLIn {
             sql_source_1.SQLSource.runSyntax(s, input);
         }
     }
+    // "IN itab" expects a ranges table, ie. the row must have SIGN, OPTION, LOW and HIGH
+    static isRangeRow(rowType) {
+        if (rowType instanceof basic_1.VoidType || rowType instanceof basic_1.UnknownType || rowType instanceof basic_1.AnyType) {
+            return true;
+        }
+        else if (!(rowType instanceof basic_1.StructureType)) {
+            return false;
+        }
+        return RANGE_COMPONENTS.every(c => rowType.getComponentByName(c) !== undefined);
+    }
 }
 exports.SQLIn = SQLIn;
 //# sourceMappingURL=sql_in.js.map
@@ -35936,6 +36115,7 @@ var __importStar = (this && this.__importStar) || (function () {
 })();
 Object.defineProperty(exports, "__esModule", ({ value: true }));
 exports.ValueBody = void 0;
+const nodes_1 = __webpack_require__(/*! ../../nodes */ "../core/build/src/abap/nodes/index.js");
 const Expressions = __importStar(__webpack_require__(/*! ../../2_statements/expressions */ "../core/build/src/abap/2_statements/expressions/index.js"));
 const for_1 = __webpack_require__(/*! ./for */ "../core/build/src/abap/5_syntax/expressions/for.js");
 const source_1 = __webpack_require__(/*! ./source */ "../core/build/src/abap/5_syntax/expressions/source.js");
@@ -35945,7 +36125,7 @@ const basic_1 = __webpack_require__(/*! ../../types/basic */ "../core/build/src/
 const _syntax_input_1 = __webpack_require__(/*! ../_syntax_input */ "../core/build/src/abap/5_syntax/_syntax_input.js");
 class ValueBody {
     static runSyntax(node, input, targetType) {
-        var _a, _b;
+        var _a, _b, _c;
         if (node === undefined) {
             return targetType;
         }
@@ -35962,26 +36142,45 @@ class ValueBody {
             }
         }
         const fields = new Set();
-        for (const s of node.findDirectExpressions(Expressions.FieldAssignment)) {
-            field_assignment_1.FieldAssignment.runSyntax(s, input, targetType);
-            if (node.findDirectExpression(Expressions.ValueBodyLine) === undefined) {
-                // todo: refine, still needs to be checked when there are table lines
-                const fieldname = (_a = s.findDirectExpression(Expressions.FieldSub)) === null || _a === void 0 ? void 0 : _a.concatTokens().toUpperCase();
+        const hasTableLines = node.findDirectExpression(Expressions.ValueBodyLine) !== undefined;
+        for (const child of node.getChildren()) {
+            if (!(child instanceof nodes_1.ExpressionNode)) {
+                continue;
+            }
+            else if (child.get() instanceof Expressions.FieldAssignment) {
+                const fieldname = (_a = child.findDirectExpression(Expressions.FieldSub)) === null || _a === void 0 ? void 0 : _a.concatTokens().toUpperCase();
+                if (fieldname && hasTableLines === false && fields.has(fieldname)) {
+                    const message = "Duplicate field assignment";
+                    input.issues.push((0, _syntax_input_1.syntaxIssue)(input, child.getFirstToken(), message));
+                    return basic_1.VoidType.get(_syntax_input_1.CheckSyntaxKey);
+                }
                 if (fieldname) {
-                    if (fields.has(fieldname)) {
+                    fields.add(fieldname);
+                }
+            }
+            else if (child.get() instanceof Expressions.ValueBodyLine) {
+                const rowFields = new Set(fields);
+                for (const assignment of child.findDirectExpressions(Expressions.FieldAssignment)) {
+                    const fieldname = (_b = assignment.findDirectExpression(Expressions.FieldSub)) === null || _b === void 0 ? void 0 : _b.concatTokens().toUpperCase();
+                    if (fieldname && rowFields.has(fieldname)) {
                         const message = "Duplicate field assignment";
-                        input.issues.push((0, _syntax_input_1.syntaxIssue)(input, s.getFirstToken(), message));
+                        input.issues.push((0, _syntax_input_1.syntaxIssue)(input, assignment.getFirstToken(), message));
                         return basic_1.VoidType.get(_syntax_input_1.CheckSyntaxKey);
                     }
-                    fields.add(fieldname);
+                    if (fieldname) {
+                        rowFields.add(fieldname);
+                    }
                 }
             }
         }
+        for (const s of node.findDirectExpressions(Expressions.FieldAssignment)) {
+            field_assignment_1.FieldAssignment.runSyntax(s, input, targetType);
+        }
         let type = undefined; // todo, this is only correct if there is a single source in the body
         for (const s of node.findDirectExpressions(Expressions.Source)) {
             type = source_1.Source.runSyntax(s, input, type);
         }
-        for (const s of ((_b = node.findDirectExpression(Expressions.ValueBase)) === null || _b === void 0 ? void 0 : _b.findDirectExpressions(Expressions.Source)) || []) {
+        for (const s of ((_c = node.findDirectExpression(Expressions.ValueBase)) === null || _c === void 0 ? void 0 : _c.findDirectExpressions(Expressions.Source)) || []) {
             type = source_1.Source.runSyntax(s, input, type);
         }
         for (const foo of node.findDirectExpressions(Expressions.ValueBodyLine)) {
@@ -39098,7 +39297,7 @@ class CreateObject {
         this.validateParameters(cdef, node, input);
     }
     static checkInstantiationAllowed(cdef, input) {
-        var _a, _b, _c;
+        var _a, _b;
         const createVis = cdef.getCreateVisibility();
         if (createVis === visibility_1.Visibility.Public) {
             return undefined;
@@ -39111,34 +39310,17 @@ class CreateObject {
         if (enclosingClass.toUpperCase() === cdef.getName().toUpperCase()) {
             return undefined;
         }
-        if (cdef.getFriends().some(f => f.toUpperCase() === enclosingClass.toUpperCase()) ||
-            input.scope.isLocalFriend(cdef.getName(), enclosingClass)) {
+        if (new _object_oriented_1.ObjectOriented(input.scope).hasFriendship(cdef, enclosingClass)) {
             return undefined;
         }
-        const enclosingDefinition = input.scope.findClassDefinition(enclosingClass);
-        if (enclosingDefinition !== undefined) {
-            const implementedInterfaces = new _object_oriented_1.ObjectOriented(input.scope).findInterfaces(enclosingDefinition);
-            if (cdef.getFriends().some(friend => implementedInterfaces.some(implemented => implemented.name.toUpperCase() === friend.toUpperCase()))) {
-                return undefined;
-            }
-        }
-        // subclasses of friends also have friendship
-        let enclosingSup = enclosingDefinition === null || enclosingDefinition === void 0 ? void 0 : enclosingDefinition.getSuperClass();
-        while (enclosingSup !== undefined) {
-            if (cdef.getFriends().some(f => f.toUpperCase() === enclosingSup.toUpperCase()) ||
-                input.scope.isLocalFriend(cdef.getName(), enclosingSup)) {
-                return undefined;
-            }
-            enclosingSup = (_a = input.scope.findClassDefinition(enclosingSup)) === null || _a === void 0 ? void 0 : _a.getSuperClass();
-        }
         if (createVis === visibility_1.Visibility.Protected) {
             // subclasses are also allowed
-            let sup = (_b = input.scope.findClassDefinition(enclosingClass)) === null || _b === void 0 ? void 0 : _b.getSuperClass();
+            let sup = (_a = input.scope.findClassDefinition(enclosingClass)) === null || _a === void 0 ? void 0 : _a.getSuperClass();
             while (sup !== undefined) {
                 if (sup.toUpperCase() === cdef.getName().toUpperCase()) {
                     return undefined;
                 }
-                sup = (_c = input.scope.findClassDefinition(sup)) === null || _c === void 0 ? void 0 : _c.getSuperClass();
+                sup = (_b = input.scope.findClassDefinition(sup)) === null || _b === void 0 ? void 0 : _b.getSuperClass();
             }
         }
         return cdef.getName() + " cannot be instantiated, class is defined as " +
@@ -39402,6 +39584,7 @@ const source_1 = __webpack_require__(/*! ../expressions/source */ "../core/build
 const dynamic_1 = __webpack_require__(/*! ../expressions/dynamic */ "../core/build/src/abap/5_syntax/expressions/dynamic.js");
 const database_table_1 = __webpack_require__(/*! ../expressions/database_table */ "../core/build/src/abap/5_syntax/expressions/database_table.js");
 const _check_database_fields_1 = __webpack_require__(/*! ../expressions/_check_database_fields */ "../core/build/src/abap/5_syntax/expressions/_check_database_fields.js");
+const sql_in_1 = __webpack_require__(/*! ../expressions/sql_in */ "../core/build/src/abap/5_syntax/expressions/sql_in.js");
 class DeleteDatabase {
     runSyntax(node, input) {
         for (const s of node.findAllExpressions(Expressions.Source)) {
@@ -39413,6 +39596,12 @@ class DeleteDatabase {
         for (const d of node.findAllExpressions(Expressions.Dynamic)) {
             dynamic_1.Dynamic.runSyntax(d, input);
         }
+        for (const compare of node.findAllExpressions(Expressions.SQLCompare)) {
+            const sqlin = compare.findDirectExpression(Expressions.SQLIn);
+            if (sqlin !== undefined) {
+                sql_in_1.SQLIn.runSyntax(sqlin, input);
+            }
+        }
         const dbtab = node.findFirstExpression(Expressions.DatabaseTable);
         if (dbtab !== undefined) {
             const dbSource = database_table_1.DatabaseTable.runSyntax(dbtab, input);
@@ -69773,7 +69962,7 @@ class Registry {
     }
     static abaplintVersion() {
         // magic, see build script "version.js"
-        return "2.120.27";
+        return "2.120.29";
     }
     getDDICReferences() {
         return this.ddicReferences;
@@ -72460,6 +72649,11 @@ class CDSCheckSyntaxConf extends _basic_rule_config_1.BasicRuleConfig {
 exports.CDSCheckSyntaxConf = CDSCheckSyntaxConf;
 const KNOWN_QUAN_DATA_ELEMENTS = ["MENGE_D"];
 const KNOWN_CURR_DATA_ELEMENTS = ["BWERT", "DZWERT"];
+// Reserved names, cannot be used as element names, see DDIC table TRESE
+const RESERVED_ELEMENT_NAMES = ["BEGIN", "NUMBER", "POSITION"];
+const MAX_LABEL_LENGTH = 40;
+// Annotations which are not supported in CDS view entities
+const VIEW_ENTITY_FORBIDDEN_ANNOTATIONS = ["Semantics.unitOfMeasure"];
 class CDSCheckSyntax {
     constructor() {
         this.conf = new CDSCheckSyntaxConf();
@@ -72501,6 +72695,9 @@ Missing objects are only reported when their names match the configured errorNam
         this.checkTypes(tree, ddic, issues, file);
         this.checkRootProjection(tree, ddic, issues, file);
         this.checkFieldAnnotations(tree, ddic, issues, file);
+        this.checkLabels(tree, issues, file);
+        this.checkViewEntityAnnotations(tree, issues, file);
+        this.checkReservedNames(tree, issues, file);
         this.checkFields(tree, sources, object, issues, file);
         return issues;
     }
@@ -72685,6 +72882,62 @@ Missing objects are only reported when their names match the configured errorNam
                 || a.toUpperCase().includes("@SEMANTICS:{CURRENCYCODE:TRUE"));
         }
     }
+    checkLabels(tree, issues, file) {
+        for (const annotation of tree.findAllExpressionsRecursive(expressions_1.CDSAnnotation)) {
+            const concatenated = annotation.concatTokens();
+            if (/@\s*<?\s*EndUserText/i.test(concatenated) === false) {
+                continue;
+            }
+            const expression = /label\s*:\s*'((?:[^']|'')*)'/gi;
+            let match = expression.exec(concatenated);
+            while (match !== null) {
+                const label = match[1].replace(/''/g, "'");
+                if (label.length > MAX_LABEL_LENGTH) {
+                    const message = `CDS label is ${label.length} characters, maximum is ${MAX_LABEL_LENGTH}`;
+                    issues.push(issue_1.Issue.atToken(file, annotation.getFirstToken(), message, this.getMetadata().key, this.conf.severity));
+                }
+                match = expression.exec(concatenated);
+            }
+        }
+    }
+    checkViewEntityAnnotations(tree, issues, file) {
+        const view = tree.findFirstExpression(expressions_1.CDSDefineView);
+        if (view === undefined || view.findDirectTokenByText("ENTITY") === undefined) {
+            return;
+        }
+        for (const annotation of tree.findAllExpressionsRecursive(expressions_1.CDSAnnotation)) {
+            const normalized = annotation.concatTokens().replace(/\s/g, "").toUpperCase().replace(/^@</, "@");
+            for (const forbidden of VIEW_ENTITY_FORBIDDEN_ANNOTATIONS) {
+                const upper = forbidden.toUpperCase();
+                if (normalized.startsWith("@" + upper) === false
+                    && normalized.startsWith("@" + upper.replace(".", ":{")) === false) {
+                    continue;
+                }
+                const message = `Annotation ${forbidden} is not allowed in view entities`;
+                issues.push(issue_1.Issue.atToken(file, annotation.getFirstToken(), message, this.getMetadata().key, this.conf.severity));
+            }
+        }
+    }
+    checkReservedNames(tree, issues, file) {
+        var _a, _b;
+        for (const element of tree.findAllExpressionsRecursive(expressions_1.CDSElement)) {
+            if (element.findDirectTokenByText("INCLUDE") !== undefined) {
+                continue;
+            }
+            let nameNode = (_a = element.findDirectExpression(expressions_1.CDSAs)) === null || _a === void 0 ? void 0 : _a.findDirectExpression(expressions_1.CDSName);
+            if (nameNode === undefined) {
+                const names = ((_b = element.findDirectExpression(expressions_1.CDSPrefixedName)) === null || _b === void 0 ? void 0 : _b.findDirectExpressions(expressions_1.CDSName)) || [];
+                nameNode = names[names.length - 1];
+            }
+            if (nameNode === undefined) {
+                continue;
+            }
+            const name = this.name(nameNode);
+            if (RESERVED_ELEMENT_NAMES.includes(name.toUpperCase())) {
+                issues.push(issue_1.Issue.atToken(file, nameNode.getFirstToken(), `CDS element name "${name}" is reserved`, this.getMetadata().key, this.conf.severity));
+            }
+        }
+    }
     checkFields(tree, sources, object, issues, file) {
         var _a;
         const associationNames = new Set();

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@abaplint/cli",
-    "version": "2.120.27",
+    "version": "2.120.29",
     "description": "abaplint - Command Line Interface",
     "funding": "https://github.com/sponsors/larshp",
     "bin": {
@@ -39,7 +39,7 @@
     },
     "homepage": "https://abaplint.org",
     "devDependencies": {
-        "@abaplint/core": "^2.120.27",
+        "@abaplint/core": "^2.120.29",
         "@types/chai": "^4.3.20",
         "@types/minimist": "^1.2.5",
         "@types/mocha": "^10.0.10",