@abaplint/cli 2.120.10 → 2.120.12

package/build/cli.js

@@ -4970,7 +4970,7 @@ class For extends combi_1.Expression {
         const itera = (0, combi_1.seq)(_1.InlineFieldDefinition, (0, combi_1.opt)(then), whil);
         const groupBy = (0, combi_1.seq)("GROUP BY", (0, combi_1.alt)(field_chain_1.FieldChain, (0, combi_1.seq)("(", (0, combi_1.plus)(_1.LoopGroupByComponent), ")")), (0, combi_1.opt)((0, combi_1.seq)((0, combi_1.alt)("ASCENDING", "DESCENDING"), (0, combi_1.opt)("AS TEXT"))), (0, combi_1.opt)("WITHOUT MEMBERS"));
         const t = (0, combi_1.alt)(_1.TargetField, _1.TargetFieldSymbol);
-        const groups = (0, combi_1.ver)(version_1.Release.v740sp08, (0, combi_1.seq)("GROUPS", t, "OF", t, "IN", _1.Source, (0, combi_1.optPrio)(groupBy)));
+        const groups = (0, combi_1.ver)(version_1.Release.v740sp08, (0, combi_1.seq)("GROUPS", t, "OF", t, "IN", _1.Source, (0, combi_1.optPrio)(groupBy)), { also: combi_1.AlsoIn.OpenABAP });
         const f = (0, combi_1.seq)("FOR", (0, combi_1.alt)(itera, inn, groups), (0, combi_1.optPrio)(_1.Let));
         return (0, combi_1.ver)(version_1.Release.v740sp05, f, { also: combi_1.AlsoIn.OpenABAP });
     }
@@ -5653,7 +5653,8 @@ const combi_1 = __webpack_require__(/*! ../combi */ "../core/build/src/abap/2_st
 const _1 = __webpack_require__(/*! . */ "../core/build/src/abap/2_statements/expressions/index.js");
 class InlineFieldDefinition extends combi_1.Expression {
     getRunnable() {
-        return (0, combi_1.altPrio)((0, combi_1.seq)(_1.Field, "=", _1.Source), (0, combi_1.seq)(_1.Field, "TYPE", _1.TypeName));
+        const field = (0, combi_1.altPrio)(_1.Field, _1.FieldSymbol);
+        return (0, combi_1.altPrio)((0, combi_1.seq)(field, "=", _1.Source), (0, combi_1.seq)(_1.Field, "TYPE", _1.TypeName));
     }
 }
 exports.InlineFieldDefinition = InlineFieldDefinition;
@@ -7207,7 +7208,7 @@ const tokens_1 = __webpack_require__(/*! ../../1_lexer/tokens */ "../core/build/
 const version_1 = __webpack_require__(/*! ../../../version */ "../core/build/src/version.js");
 class ReduceNext extends combi_1.Expression {
     getRunnable() {
-        const calcAssign = (0, combi_1.ver)(version_1.Release.v754, (0, combi_1.alt)((0, combi_1.seq)((0, combi_1.tok)(tokens_1.WPlus), "="), (0, combi_1.seq)((0, combi_1.tok)(tokens_1.WDash), "="), "/=", "*=", "&&="));
+        const calcAssign = (0, combi_1.ver)(version_1.Release.v754, (0, combi_1.alt)((0, combi_1.seq)((0, combi_1.tok)(tokens_1.WPlus), "="), (0, combi_1.seq)((0, combi_1.tok)(tokens_1.WDash), "="), "/=", "*=", "&&="), { also: combi_1.AlsoIn.OpenABAP });
         const fields = (0, combi_1.seq)(_1.SimpleTarget, (0, combi_1.altPrio)("=", calcAssign), _1.Source);
         return (0, combi_1.seq)("NEXT", (0, combi_1.plus)(fields));
     }
@@ -27355,6 +27356,16 @@ class TypeUtils {
         }
         return false;
     }
+    isCharLikeField(type) {
+        return type instanceof basic_1.CharacterType
+            || type instanceof basic_1.NumericType
+            || type instanceof basic_1.DateType
+            || type instanceof basic_1.TimeType
+            || type instanceof basic_1.CLikeType
+            || type instanceof basic_1.AnyType
+            || type instanceof basic_1.UnknownType
+            || type instanceof basic_1.VoidType;
+    }
     isCharLike(type) {
         if (type === undefined) {
             return false;
@@ -29646,18 +29657,30 @@ exports.ComponentCompare = void 0;
 const Expressions = __importStar(__webpack_require__(/*! ../../2_statements/expressions */ "../core/build/src/abap/2_statements/expressions/index.js"));
 const _syntax_input_1 = __webpack_require__(/*! ../_syntax_input */ "../core/build/src/abap/5_syntax/_syntax_input.js");
 const component_chain_1 = __webpack_require__(/*! ./component_chain */ "../core/build/src/abap/5_syntax/expressions/component_chain.js");
+const component_name_1 = __webpack_require__(/*! ./component_name */ "../core/build/src/abap/5_syntax/expressions/component_name.js");
 const source_1 = __webpack_require__(/*! ./source */ "../core/build/src/abap/5_syntax/expressions/source.js");
 class ComponentCompare {
-    static runSyntax(node, input, type) {
+    static runSyntax(node, input, leftType, rightType) {
         const chain = node.findDirectExpression(Expressions.ComponentChainSimple);
         if (chain === undefined) {
             const message = "ComponentCompare, chain not found";
             input.issues.push((0, _syntax_input_1.syntaxIssue)(input, node.getFirstToken(), message));
             return;
         }
-        const fieldType = component_chain_1.ComponentChain.runSyntax(type, chain, input);
+        const fieldType = component_chain_1.ComponentChain.runSyntax(leftType, chain, input);
         for (const s of node.findDirectExpressions(Expressions.Source)) {
-            source_1.Source.runSyntax(s, input, fieldType);
+            const fieldChain = s.findDirectExpression(Expressions.FieldChain);
+            const first = fieldChain === null || fieldChain === void 0 ? void 0 : fieldChain.getFirstChild();
+            if (rightType && fieldChain && first) {
+                let sourceType = rightType;
+                if (first.concatTokens().toUpperCase() !== "TABLE_LINE") {
+                    sourceType = component_name_1.ComponentName.runSyntax(sourceType, first, input);
+                }
+                component_chain_1.ComponentChain.runSyntax(sourceType, fieldChain, input);
+            }
+            else {
+                source_1.Source.runSyntax(s, input, fieldType);
+            }
         }
     }
 }
@@ -29796,15 +29819,15 @@ exports.ComponentCond = void 0;
 const Expressions = __importStar(__webpack_require__(/*! ../../2_statements/expressions */ "../core/build/src/abap/2_statements/expressions/index.js"));
 const component_compare_1 = __webpack_require__(/*! ./component_compare */ "../core/build/src/abap/5_syntax/expressions/component_compare.js");
 class ComponentCond {
-    static runSyntax(node, input, type) {
+    static runSyntax(node, input, leftType, rightType) {
         for (const t of node.findDirectExpressions(Expressions.ComponentCondSub)) {
             const c = t.findDirectExpression(Expressions.ComponentCond);
             if (c) {
-                ComponentCond.runSyntax(c, input, type);
+                ComponentCond.runSyntax(c, input, leftType, rightType);
             }
         }
         for (const t of node.findDirectExpressions(Expressions.ComponentCompare)) {
-            component_compare_1.ComponentCompare.runSyntax(t, input, type);
+            component_compare_1.ComponentCompare.runSyntax(t, input, leftType, rightType);
         }
     }
 }
@@ -31022,21 +31045,14 @@ class FilterBody {
         if (node === undefined) {
             return targetType;
         }
-        let type = undefined;
+        const types = [];
         for (const s of node.findDirectExpressions(Expressions.Source)) {
-            if (type === undefined) {
-                type = source_1.Source.runSyntax(s, input);
-            }
-            else {
-                source_1.Source.runSyntax(s, input);
-            }
-        }
-        // todo
-        if (node.findDirectTokenByText("EXCEPT") === undefined) {
-            const rowType = type instanceof basic_1.TableType ? type.getRowType() : undefined;
-            component_cond_1.ComponentCond.runSyntax(node.findDirectExpression(Expressions.ComponentCond), input, rowType);
+            types.push(source_1.Source.runSyntax(s, input));
         }
-        return type ? type : targetType;
+        const inputRowType = types[0] instanceof basic_1.TableType ? types[0].getRowType() : undefined;
+        const filterRowType = types[1] instanceof basic_1.TableType ? types[1].getRowType() : undefined;
+        component_cond_1.ComponentCond.runSyntax(node.findDirectExpression(Expressions.ComponentCond), input, inputRowType, filterRowType);
+        return types[0] ? types[0] : targetType;
     }
 }
 exports.FilterBody = FilterBody;
@@ -31527,7 +31543,8 @@ class InlineFieldDefinition {
     static runSyntax(node, input, targetType) {
         var _a;
         let type = undefined;
-        const field = (_a = node.findDirectExpression(Expressions.Field)) === null || _a === void 0 ? void 0 : _a.getFirstToken();
+        const field = (_a = (node.findDirectExpression(Expressions.Field)
+            || node.findDirectExpression(Expressions.FieldSymbol))) === null || _a === void 0 ? void 0 : _a.getFirstToken();
         if (field === undefined) {
             return undefined;
         }
@@ -35797,7 +35814,11 @@ class ValueBody {
                 field_assignment_1.FieldAssignment.runSyntax(s, input, rowType);
             }
             for (const s of foo.findDirectExpressions(Expressions.Source)) {
-                source_1.Source.runSyntax(s, input, rowType);
+                const sourceType = source_1.Source.runSyntax(s, input, rowType);
+                if (rowType instanceof basic_1.StringType && sourceType instanceof basic_1.CharacterType) {
+                    const message = "VALUE, source type CharacterType not compatible with StringType";
+                    input.issues.push((0, _syntax_input_1.syntaxIssue)(input, s.getFirstToken(), message));
+                }
             }
         }
         if (letScoped === true) {
@@ -46629,7 +46650,11 @@ class Write {
         }
         const target = node.findDirectExpression(Expressions.Target);
         if (target) {
-            target_1.Target.runSyntax(target, input);
+            const targetType = target_1.Target.runSyntax(target, input);
+            if (new _type_utils_1.TypeUtils(input.scope).isCharLikeField(targetType) === false) {
+                const message = `"${target.getFirstToken().getStr()}" must be a character-like field (data type C, N, D, or T)`;
+                input.issues.push((0, _syntax_input_1.syntaxIssue)(input, target.getFirstToken(), message));
+            }
         }
     }
 }
@@ -51514,6 +51539,7 @@ class ClassDefinition extends _identifier_1.Identifier {
         // perform checks after everything has been initialized
         this.checkInterfaceVisibility(input, node);
         this.checkMethodsFromSuperClasses(input);
+        this.checkClassNameLength(input);
         this.checkMethodNameLength(input);
         this.checkClassConstructorStatic(input);
     }
@@ -51564,6 +51590,12 @@ class ClassDefinition extends _identifier_1.Identifier {
       }
     */
     ///////////////////
+    checkClassNameLength(input) {
+        if (this.getName().length > 30) {
+            const message = `Class name "${this.getName()}" is too long, maximum length is 30 characters`;
+            input.issues.push((0, _syntax_input_1.syntaxIssue)(input, this.getToken(), message));
+        }
+    }
     findSuper(def, input) {
         var _a;
         const token = (_a = def === null || def === void 0 ? void 0 : def.findDirectExpression(expressions_1.SuperClassName)) === null || _a === void 0 ? void 0 : _a.getFirstToken();
@@ -56040,7 +56072,7 @@ exports.DDLAspect = DDLAspect;
 "use strict";
 
 Object.defineProperty(exports, "__esModule", ({ value: true }));
-exports.DDLValueHelp = exports.DDLForeignKey = exports.DDLForeignKeyTarget = void 0;
+exports.DDLReference = exports.DDLValueHelp = exports.DDLForeignKey = exports.DDLForeignKeyTarget = void 0;
 const combi_1 = __webpack_require__(/*! ../../abap/2_statements/combi */ "../core/build/src/abap/2_statements/combi.js");
 const ddl_literal_1 = __webpack_require__(/*! ./ddl_literal */ "../core/build/src/ddl/expressions/ddl_literal.js");
 const ddl_name_1 = __webpack_require__(/*! ./ddl_name */ "../core/build/src/ddl/expressions/ddl_name.js");
@@ -56064,6 +56096,12 @@ class DDLValueHelp extends combi_1.Expression {
     }
 }
 exports.DDLValueHelp = DDLValueHelp;
+class DDLReference extends combi_1.Expression {
+    getRunnable() {
+        return (0, combi_1.seq)("WITH", "REFERENCE", "TABLE", ddl_name_1.DDLName, "AND", "REFERENCE", "FIELD", ddl_name_1.DDLName);
+    }
+}
+exports.DDLReference = DDLReference;
 //# sourceMappingURL=ddl_clauses.js.map
 
 /***/ },
@@ -56339,7 +56377,7 @@ const ddl_name_1 = __webpack_require__(/*! ./ddl_name */ "../core/build/src/ddl/
 const ddl_type_1 = __webpack_require__(/*! ./ddl_type */ "../core/build/src/ddl/expressions/ddl_type.js");
 class DDLTableField extends combi_1.Expression {
     getRunnable() {
-        const trailingClause = (0, combi_1.alt)(ddl_clauses_1.DDLForeignKey, ddl_clauses_1.DDLValueHelp);
+        const trailingClause = (0, combi_1.alt)(ddl_clauses_1.DDLForeignKey, ddl_clauses_1.DDLReference, ddl_clauses_1.DDLValueHelp);
         return (0, combi_1.seq)((0, combi_1.star)(expressions_1.CDSAnnotation), (0, combi_1.optPrio)("KEY"), ddl_name_1.DDLName, ":", ddl_type_1.DDLType, (0, combi_1.optPrio)("NOT NULL"), (0, combi_1.star)(trailingClause), ";");
     }
 }
@@ -67561,6 +67599,13 @@ class Table extends _abstract_object_1.AbstractObject {
         }
         return (_a = this.parsedData) === null || _a === void 0 ? void 0 : _a.secondaryIndexes;
     }
+    getFields() {
+        var _a;
+        if (this.parsedData === undefined) {
+            this.parseXML();
+        }
+        return (_a = this.parsedData) === null || _a === void 0 ? void 0 : _a.fields;
+    }
     getAllowedNaming() {
         let length = 30;
         const regex = /^((\/[A-Z_\d]{3,8}\/)|[a-zA-Z0-9]{3}|CI_)\w+$/;
@@ -67613,9 +67658,13 @@ class Table extends _abstract_object_1.AbstractObject {
             && this.parsedData.dataClass === "USER3") {
             return new Types.UnknownType("Data class = USER3 not allowed in cloud");
         }
-        if (this.getTableCategory() === TableCategory.Transparent
-            && this.listKeys(reg).length === 0) {
-            return new Types.UnknownType("Table " + this.getName() + " has no key fields");
+        if (this.getTableCategory() === TableCategory.Transparent) {
+            if (this.listKeys(reg).length === 0) {
+                return new Types.UnknownType("Table " + this.getName() + " has no key fields");
+            }
+            else if (this.keyFieldsNotFirst()) {
+                return new Types.UnknownType("Table " + this.getName() + " key fields must be first");
+            }
         }
         if (this.parsedType) {
             return this.parsedType;
@@ -67791,6 +67840,21 @@ class Table extends _abstract_object_1.AbstractObject {
         return this.parsedData.enhancementCategory;
     }
     ///////////////
+    keyFieldsNotFirst() {
+        var _a;
+        let seenNonKey = false;
+        for (const field of ((_a = this.parsedData) === null || _a === void 0 ? void 0 : _a.fields) || []) {
+            if (field.KEYFLAG === "X") {
+                if (seenNonKey === true) {
+                    return true;
+                }
+            }
+            else {
+                seenNonKey = true;
+            }
+        }
+        return false;
+    }
     parseXML() {
         var _a, _b, _c, _d, _e, _f, _g, _h, _j, _k, _l, _m, _o;
         const parsed = super.parseRaw2();
@@ -67827,6 +67891,8 @@ class Table extends _abstract_object_1.AbstractObject {
                 KEYFLAG: field.KEYFLAG,
                 GROUPNAME: field.GROUPNAME,
                 CHECKTABLE: field.CHECKTABLE,
+                REFTABLE: field.REFTABLE,
+                REFFIELD: field.REFFIELD,
                 REFTYPE: field.REFTYPE,
                 DDTEXT: field.DDTEXT,
             });
@@ -69365,7 +69431,7 @@ class Registry {
     }
     static abaplintVersion() {
         // magic, see build script "version.js"
-        return "2.120.10";
+        return "2.120.12";
     }
     getDDICReferences() {
         return this.ddicReferences;
@@ -83165,6 +83231,7 @@ __exportStar(__webpack_require__(/*! ./no_comments_between_methods */ "../core/b
 __exportStar(__webpack_require__(/*! ./no_external_form_calls */ "../core/build/src/rules/no_external_form_calls.js"), exports);
 __exportStar(__webpack_require__(/*! ./no_inline_in_optional_branches */ "../core/build/src/rules/no_inline_in_optional_branches.js"), exports);
 __exportStar(__webpack_require__(/*! ./no_macros */ "../core/build/src/rules/no_macros.js"), exports);
+__exportStar(__webpack_require__(/*! ./no_mandt_in_database_operations */ "../core/build/src/rules/no_mandt_in_database_operations.js"), exports);
 __exportStar(__webpack_require__(/*! ./no_prefixes */ "../core/build/src/rules/no_prefixes.js"), exports);
 __exportStar(__webpack_require__(/*! ./no_public_attributes */ "../core/build/src/rules/no_public_attributes.js"), exports);
 __exportStar(__webpack_require__(/*! ./no_yoda_conditions */ "../core/build/src/rules/no_yoda_conditions.js"), exports);
@@ -87642,6 +87709,153 @@ exports.NoMacros = NoMacros;
 
 /***/ },
 
+/***/ "../core/build/src/rules/no_mandt_in_database_operations.js"
+/*!******************************************************************!*\
+  !*** ../core/build/src/rules/no_mandt_in_database_operations.js ***!
+  \******************************************************************/
+(__unused_webpack_module, exports, __webpack_require__) {
+
+"use strict";
+
+var __createBinding = (this && this.__createBinding) || (Object.create ? (function(o, m, k, k2) {
+    if (k2 === undefined) k2 = k;
+    var desc = Object.getOwnPropertyDescriptor(m, k);
+    if (!desc || ("get" in desc ? !m.__esModule : desc.writable || desc.configurable)) {
+      desc = { enumerable: true, get: function() { return m[k]; } };
+    }
+    Object.defineProperty(o, k2, desc);
+}) : (function(o, m, k, k2) {
+    if (k2 === undefined) k2 = k;
+    o[k2] = m[k];
+}));
+var __setModuleDefault = (this && this.__setModuleDefault) || (Object.create ? (function(o, v) {
+    Object.defineProperty(o, "default", { enumerable: true, value: v });
+}) : function(o, v) {
+    o["default"] = v;
+});
+var __importStar = (this && this.__importStar) || (function () {
+    var ownKeys = function(o) {
+        ownKeys = Object.getOwnPropertyNames || function (o) {
+            var ar = [];
+            for (var k in o) if (Object.prototype.hasOwnProperty.call(o, k)) ar[ar.length] = k;
+            return ar;
+        };
+        return ownKeys(o);
+    };
+    return function (mod) {
+        if (mod && mod.__esModule) return mod;
+        var result = {};
+        if (mod != null) for (var k = ownKeys(mod), i = 0; i < k.length; i++) if (k[i] !== "default") __createBinding(result, mod, k[i]);
+        __setModuleDefault(result, mod);
+        return result;
+    };
+})();
+Object.defineProperty(exports, "__esModule", ({ value: true }));
+exports.NoMandtInDatabaseOperations = exports.NoMandtInDatabaseOperationsConf = void 0;
+const Expressions = __importStar(__webpack_require__(/*! ../abap/2_statements/expressions */ "../core/build/src/abap/2_statements/expressions/index.js"));
+const Statements = __importStar(__webpack_require__(/*! ../abap/2_statements/statements */ "../core/build/src/abap/2_statements/statements/index.js"));
+const issue_1 = __webpack_require__(/*! ../issue */ "../core/build/src/issue.js");
+const _abap_rule_1 = __webpack_require__(/*! ./_abap_rule */ "../core/build/src/rules/_abap_rule.js");
+const _basic_rule_config_1 = __webpack_require__(/*! ./_basic_rule_config */ "../core/build/src/rules/_basic_rule_config.js");
+const _irule_1 = __webpack_require__(/*! ./_irule */ "../core/build/src/rules/_irule.js");
+class NoMandtInDatabaseOperationsConf extends _basic_rule_config_1.BasicRuleConfig {
+}
+exports.NoMandtInDatabaseOperationsConf = NoMandtInDatabaseOperationsConf;
+class NoMandtInDatabaseOperations extends _abap_rule_1.ABAPRule {
+    constructor() {
+        super(...arguments);
+        this.conf = new NoMandtInDatabaseOperationsConf();
+    }
+    getMetadata() {
+        return {
+            key: "no_mandt_in_database_operations",
+            title: "No MANDT in database operations",
+            shortDescription: "Do not specify the client in database operations; the ABAP runtime handles it automatically.",
+            extendedInformation: "Only check for the name MANDT, not for the field type. The rule does not check for dynamic SQL.",
+            tags: [_irule_1.RuleTag.SingleFile, _irule_1.RuleTag.Syntax],
+            badExample: `SELECT * FROM zcustomers
+  CLIENT SPECIFIED
+  WHERE mandt = @sy-mandt
+  INTO TABLE @DATA(customers).`,
+            goodExample: `SELECT * FROM zcustomers
+  INTO TABLE @DATA(customers).`,
+        };
+    }
+    getConfig() {
+        return this.conf;
+    }
+    setConfig(conf) {
+        this.conf = conf;
+    }
+    runParsed(file) {
+        const issues = [];
+        for (const statement of file.getStatements()) {
+            if (this.isDatabaseOperation(statement) === false) {
+                continue;
+            }
+            const mandt = this.findMandtInCondition(statement);
+            if (mandt !== undefined) {
+                const issue = issue_1.Issue.atToken(file, mandt.getFirstToken(), this.getMetadata().title, this.getMetadata().key, this.conf.severity);
+                issues.push(issue);
+                continue;
+            }
+            const explicitClient = this.findExplicitClient(statement);
+            if (explicitClient !== undefined) {
+                const issue = issue_1.Issue.atToken(file, explicitClient, this.getMetadata().title, this.getMetadata().key, this.conf.severity);
+                issues.push(issue);
+            }
+        }
+        return issues;
+    }
+    isDatabaseOperation(statement) {
+        const type = statement.get();
+        return type instanceof Statements.DeleteDatabase
+            || type instanceof Statements.InsertDatabase
+            || type instanceof Statements.MergeDatabase
+            || type instanceof Statements.ModifyDatabase
+            || type instanceof Statements.OpenCursor
+            || type instanceof Statements.Select
+            || type instanceof Statements.SelectLoop
+            || type instanceof Statements.UpdateDatabase
+            || type instanceof Statements.With
+            || type instanceof Statements.WithLoop;
+    }
+    findMandtInCondition(statement) {
+        for (const condition of statement.findAllExpressions(Expressions.SQLCond)) {
+            const fields = condition.findAllExpressionsMulti([
+                Expressions.SQLFieldName,
+                Expressions.SQLAliasField,
+            ]);
+            for (const field of fields) {
+                const name = field.concatTokens().toUpperCase();
+                if (name === "MANDT" || name.endsWith("~MANDT")) {
+                    return field;
+                }
+            }
+        }
+        return undefined;
+    }
+    findExplicitClient(statement) {
+        var _a, _b;
+        const tokens = statement.getTokens();
+        for (let index = 0; index < tokens.length; index++) {
+            const current = tokens[index].getStr().toUpperCase();
+            const next = (_a = tokens[index + 1]) === null || _a === void 0 ? void 0 : _a.getStr().toUpperCase();
+            const afterNext = (_b = tokens[index + 2]) === null || _b === void 0 ? void 0 : _b.getStr().toUpperCase();
+            if ((current === "CLIENT" && next === "SPECIFIED")
+                || (current === "USING" && (next === "CLIENT" || next === "CLIENTS"))
+                || (current === "USING" && next === "ALL" && afterNext === "CLIENTS")) {
+                return current === "CLIENT" ? tokens[index] : tokens[index + (next === "ALL" ? 2 : 1)];
+            }
+        }
+        return undefined;
+    }
+}
+exports.NoMandtInDatabaseOperations = NoMandtInDatabaseOperations;
+//# sourceMappingURL=no_mandt_in_database_operations.js.map
+
+/***/ },
+
 /***/ "../core/build/src/rules/no_prefixes.js"
 /*!**********************************************!*\
   !*** ../core/build/src/rules/no_prefixes.js ***!
@@ -98382,6 +98596,7 @@ class XMLConsistency {
             extendedInformation: `Checks:
 * XML is well-formed and parseable
 * Naming for CLAS and INTF objects
+* QUAN fields in TABL objects have reference table and field values
 * Texts and translations do not exceed maximum allowed length.`,
             tags: [_irule_1.RuleTag.Naming, _irule_1.RuleTag.Syntax],
         };
@@ -98396,6 +98611,7 @@ class XMLConsistency {
         return this;
     }
     run(obj) {
+        var _a;
         const issues = [];
         const file = obj.getXMLFile();
         if (file === undefined) {
@@ -98407,6 +98623,14 @@ class XMLConsistency {
             if (res !== true) {
                 issues.push(issue_1.Issue.atRow(file, 1, "XML parser error: " + res.err.msg, this.getMetadata().key, this.conf.severity));
             }
+            else {
+                for (const attribute of ["version", "serializer_version"]) {
+                    const value = (_a = xml.match(new RegExp(`<abapGit\\b[^>]*\\b${attribute}="([^"]+)"`))) === null || _a === void 0 ? void 0 : _a[1];
+                    if (value !== undefined && value.match(/^v\d\.\d\.\d$/) === null) {
+                        issues.push(issue_1.Issue.atRow(file, 1, `Unexpected abapGit ${attribute} "${value}"`, this.getMetadata().key, this.conf.severity));
+                    }
+                }
+            }
         }
         // todo, have some XML validation in each object?
         if (obj instanceof Objects.Class) {
@@ -98427,6 +98651,9 @@ class XMLConsistency {
         else if (obj instanceof Objects.MessageClass) {
             issues.push(...this.runMessageClass(obj, file));
         }
+        else if (obj instanceof Objects.Table) {
+            issues.push(...this.runTable(obj, file));
+        }
         if (obj instanceof _abap_object_1.ABAPObject) {
             issues.push(...this.runTextPool(obj, file));
         }
@@ -98570,6 +98797,18 @@ class XMLConsistency {
         }
         return issues;
     }
+    runTable(obj, file) {
+        var _a, _b;
+        var _c;
+        const issues = [];
+        for (const field of (_c = obj.getFields()) !== null && _c !== void 0 ? _c : []) {
+            if (field.DATATYPE === "QUAN" && (!((_a = field.REFTABLE) === null || _a === void 0 ? void 0 : _a.trim()) || !((_b = field.REFFIELD) === null || _b === void 0 ? void 0 : _b.trim()))) {
+                const message = `QUAN field ${field.FIELDNAME} must have REFTABLE and REFFIELD set`;
+                issues.push(issue_1.Issue.atRow(file, 1, message, this.getMetadata().key, this.conf.severity));
+            }
+        }
+        return issues;
+    }
 }
 exports.XMLConsistency = XMLConsistency;
 //# sourceMappingURL=xml_consistency.js.map

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@abaplint/cli",
-    "version": "2.120.10",
+    "version": "2.120.12",
     "description": "abaplint - Command Line Interface",
     "funding": "https://github.com/sponsors/larshp",
     "bin": {
@@ -39,7 +39,7 @@
     },
     "homepage": "https://abaplint.org",
     "devDependencies": {
-        "@abaplint/core": "^2.120.10",
+        "@abaplint/core": "^2.120.12",
         "@types/chai": "^4.3.20",
         "@types/minimist": "^1.2.5",
         "@types/mocha": "^10.0.10",