@abaplint/cli 2.119.40 → 2.119.41

package/build/cli.js

@@ -54066,8 +54066,8 @@ var __importStar = (this && this.__importStar) || (function () {
     };
 })();
 Object.defineProperty(exports, "__esModule", ({ value: true }));
-exports.Rename = exports.PrettyPrinter = exports.Position = exports.CurrentScope = exports.RulesRunner = exports.SpaghettiScope = exports.SyntaxLogic = exports.ABAPObject = exports.Tokens = exports.ExpressionsCDS = exports.CDSParser = exports.LanguageServerTypes = exports.DDLParser = exports.AbstractFile = exports.ABAPFile = exports.MemoryFile = exports.Edits = exports.ReferenceType = exports.NativeSQL = exports.MacroContent = exports.MacroCall = exports.SpaghettiScopeNode = exports.Token = exports.ScopeType = exports.BasicTypes = exports.TypedIdentifier = exports.AbstractType = exports.VirtualPosition = exports.Comment = exports.Unknown = exports.Empty = exports.Identifier = exports.Nodes = exports.Types = exports.Expressions = exports.Statements = exports.Structures = exports.SkipLogic = exports.Objects = exports.ArtifactsRules = exports.ArtifactsObjects = exports.ArtifactsABAP = exports.BuiltIn = exports.MethodLengthStats = exports.LanguageServer = exports.Registry = exports.CyclomaticComplexityStats = exports.Version = exports.Config = exports.Issue = void 0;
-exports.LSPEdit = exports.RuleTag = exports.Severity = exports.Visibility = exports.Info = exports.Diagnostics = void 0;
+exports.Position = exports.CurrentScope = exports.RulesRunner = exports.SpaghettiScope = exports.SyntaxLogic = exports.ABAPObject = exports.Tokens = exports.ExpressionsCDS = exports.CDSParser = exports.LanguageServerTypes = exports.DDLParser = exports.AbstractFile = exports.ABAPFile = exports.MemoryFile = exports.Edits = exports.ReferenceType = exports.NativeSQL = exports.MacroContent = exports.MacroCall = exports.SpaghettiScopeNode = exports.Token = exports.ScopeType = exports.BasicTypes = exports.TypedIdentifier = exports.AbstractType = exports.VirtualPosition = exports.Comment = exports.Unknown = exports.Empty = exports.Identifier = exports.Nodes = exports.Types = exports.Expressions = exports.Statements = exports.Structures = exports.SkipLogic = exports.Objects = exports.ArtifactsRules = exports.ArtifactsObjects = exports.ArtifactsABAP = exports.BuiltIn = exports.FormLengthStats = exports.FunctionLengthStats = exports.MethodLengthStats = exports.LanguageServer = exports.Registry = exports.CyclomaticComplexityStats = exports.Version = exports.Config = exports.Issue = void 0;
+exports.LSPEdit = exports.RuleTag = exports.Severity = exports.Visibility = exports.Info = exports.Diagnostics = exports.Rename = exports.PrettyPrinter = void 0;
 const issue_1 = __webpack_require__(/*! ./issue */ "../core/build/src/issue.js");
 Object.defineProperty(exports, "Issue", ({ enumerable: true, get: function () { return issue_1.Issue; } }));
 const config_1 = __webpack_require__(/*! ./config */ "../core/build/src/config.js");
@@ -54173,6 +54173,10 @@ const _edit_1 = __webpack_require__(/*! ./lsp/_edit */ "../core/build/src/lsp/_e
 Object.defineProperty(exports, "LSPEdit", ({ enumerable: true, get: function () { return _edit_1.LSPEdit; } }));
 const _reference_1 = __webpack_require__(/*! ./abap/5_syntax/_reference */ "../core/build/src/abap/5_syntax/_reference.js");
 Object.defineProperty(exports, "ReferenceType", ({ enumerable: true, get: function () { return _reference_1.ReferenceType; } }));
+const function_length_stats_1 = __webpack_require__(/*! ./utils/function_length_stats */ "../core/build/src/utils/function_length_stats.js");
+Object.defineProperty(exports, "FunctionLengthStats", ({ enumerable: true, get: function () { return function_length_stats_1.FunctionLengthStats; } }));
+const form_length_stats_1 = __webpack_require__(/*! ./utils/form_length_stats */ "../core/build/src/utils/form_length_stats.js");
+Object.defineProperty(exports, "FormLengthStats", ({ enumerable: true, get: function () { return form_length_stats_1.FormLengthStats; } }));
 // do not include this file from anywhere within abaplint
 // https://github.com/abaplint/abaplint/issues/873
 const Edits = {
@@ -66578,7 +66582,7 @@ class Registry {
     }
     static abaplintVersion() {
         // magic, see build script "version.js"
-        return "2.119.40";
+        return "2.119.41";
     }
     getDDICReferences() {
         return this.ddicReferences;
@@ -82782,17 +82786,20 @@ const method_length_stats_1 = __webpack_require__(/*! ../utils/method_length_sta
 const _irule_1 = __webpack_require__(/*! ./_irule */ "../core/build/src/rules/_irule.js");
 const _basic_rule_config_1 = __webpack_require__(/*! ./_basic_rule_config */ "../core/build/src/rules/_basic_rule_config.js");
 const form_length_stats_1 = __webpack_require__(/*! ../utils/form_length_stats */ "../core/build/src/utils/form_length_stats.js");
+const function_length_stats_1 = __webpack_require__(/*! ../utils/function_length_stats */ "../core/build/src/utils/function_length_stats.js");
 class MethodLengthConf extends _basic_rule_config_1.BasicRuleConfig {
     constructor() {
         super(...arguments);
-        /** Maximum method/form length in statements. */
+        /** Maximum method/form/function module length in statements. */
         this.statements = 100;
-        /** Checks for empty methods/forms. */
+        /** Checks for empty methods/forms/function modules. */
         this.errorWhenEmpty = true;
         /** Option to ignore test classes for this check. */
         this.ignoreTestClasses = false;
         /** Option to check forms. */
         this.checkForms = true;
+        /** Option to check function modules. */
+        this.checkFunctionModules = true;
     }
 }
 exports.MethodLengthConf = MethodLengthConf;
@@ -82808,8 +82815,8 @@ class MethodLength {
     getMetadata() {
         return {
             key: "method_length",
-            title: "Method/Form Length",
-            shortDescription: `Checks relating to method/form length.`,
+            title: "Method/Form/Function Module Length",
+            shortDescription: `Checks relating to method/form/function module length.`,
             extendedInformation: `https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#keep-methods-small
 
 Abstract methods without statements are considered okay.`,
@@ -82852,7 +82859,12 @@ Abstract methods without statements are considered okay.`,
             const formStats = form_length_stats_1.FormLengthStats.run(obj);
             formIssues = this.check(formStats, "FORM");
         }
-        return methodIssues.concat(formIssues);
+        let functionIssues = [];
+        if (this.conf.checkFunctionModules) {
+            const functionStats = function_length_stats_1.FunctionLengthStats.run(obj);
+            functionIssues = this.check(functionStats, "FUNCTION MODULE");
+        }
+        return methodIssues.concat(formIssues).concat(functionIssues);
     }
     // ***********************
     check(stats, type) {
@@ -95490,6 +95502,105 @@ exports.FormLengthStats = FormLengthStats;
 
 /***/ },
 
+/***/ "../core/build/src/utils/function_length_stats.js"
+/*!********************************************************!*\
+  !*** ../core/build/src/utils/function_length_stats.js ***!
+  \********************************************************/
+(__unused_webpack_module, exports, __webpack_require__) {
+
+"use strict";
+
+var __createBinding = (this && this.__createBinding) || (Object.create ? (function(o, m, k, k2) {
+    if (k2 === undefined) k2 = k;
+    var desc = Object.getOwnPropertyDescriptor(m, k);
+    if (!desc || ("get" in desc ? !m.__esModule : desc.writable || desc.configurable)) {
+      desc = { enumerable: true, get: function() { return m[k]; } };
+    }
+    Object.defineProperty(o, k2, desc);
+}) : (function(o, m, k, k2) {
+    if (k2 === undefined) k2 = k;
+    o[k2] = m[k];
+}));
+var __setModuleDefault = (this && this.__setModuleDefault) || (Object.create ? (function(o, v) {
+    Object.defineProperty(o, "default", { enumerable: true, value: v });
+}) : function(o, v) {
+    o["default"] = v;
+});
+var __importStar = (this && this.__importStar) || (function () {
+    var ownKeys = function(o) {
+        ownKeys = Object.getOwnPropertyNames || function (o) {
+            var ar = [];
+            for (var k in o) if (Object.prototype.hasOwnProperty.call(o, k)) ar[ar.length] = k;
+            return ar;
+        };
+        return ownKeys(o);
+    };
+    return function (mod) {
+        if (mod && mod.__esModule) return mod;
+        var result = {};
+        if (mod != null) for (var k = ownKeys(mod), i = 0; i < k.length; i++) if (k[i] !== "default") __createBinding(result, mod, k[i]);
+        __setModuleDefault(result, mod);
+        return result;
+    };
+})();
+Object.defineProperty(exports, "__esModule", ({ value: true }));
+exports.FunctionLengthStats = void 0;
+const Statements = __importStar(__webpack_require__(/*! ../abap/2_statements/statements */ "../core/build/src/abap/2_statements/statements/index.js"));
+const Expressions = __importStar(__webpack_require__(/*! ../abap/2_statements/expressions */ "../core/build/src/abap/2_statements/expressions/index.js"));
+const _abap_object_1 = __webpack_require__(/*! ../objects/_abap_object */ "../core/build/src/objects/_abap_object.js");
+const _statement_1 = __webpack_require__(/*! ../abap/2_statements/statements/_statement */ "../core/build/src/abap/2_statements/statements/_statement.js");
+class FunctionLengthStats {
+    static run(obj) {
+        const res = [];
+        let pos = undefined;
+        let name = "";
+        let count = 0;
+        let func = false;
+        if (!(obj instanceof _abap_object_1.ABAPObject)) {
+            return [];
+        }
+        for (const file of obj.getABAPFiles()) {
+            for (const stat of file.getStatements()) {
+                const type = stat.get();
+                if (type instanceof Statements.FunctionModule) {
+                    pos = stat.getFirstToken().getStart();
+                    name = this.findName(stat);
+                    func = true;
+                    count = 0;
+                }
+                else if (type instanceof Statements.EndFunction) {
+                    if (pos) {
+                        res.push({ name: name, className: "", count, file, pos });
+                    }
+                    else {
+                        continue;
+                    }
+                    func = false;
+                }
+                else if (func === true
+                    && !(type instanceof _statement_1.Comment)
+                    && !(type instanceof _statement_1.Empty)) {
+                    count = count + 1;
+                }
+            }
+        }
+        return res;
+    }
+    static findName(stat) {
+        const nameExpr = stat.findFirstExpression(Expressions.Field);
+        if (nameExpr) {
+            return nameExpr.getFirstToken().getStr();
+        }
+        else {
+            throw new Error("FunctionLength, findName, expected Field");
+        }
+    }
+}
+exports.FunctionLengthStats = FunctionLengthStats;
+//# sourceMappingURL=function_length_stats.js.map
+
+/***/ },
+
 /***/ "../core/build/src/utils/include_graph.js"
 /*!************************************************!*\
   !*** ../core/build/src/utils/include_graph.js ***!

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@abaplint/cli",
-    "version": "2.119.40",
+    "version": "2.119.41",
     "description": "abaplint - Command Line Interface",
     "funding": "https://github.com/sponsors/larshp",
     "bin": {
@@ -38,7 +38,7 @@
     },
     "homepage": "https://abaplint.org",
     "devDependencies": {
-        "@abaplint/core": "^2.119.40",
+        "@abaplint/core": "^2.119.41",
         "@types/chai": "^4.3.20",
         "@types/minimist": "^1.2.5",
         "@types/mocha": "^10.0.10",
@@ -49,7 +49,7 @@
         "eslint": "^9.39.4",
         "glob": "^13.0.6",
         "json5": "^2.2.3",
-        "memfs": "^4.57.7",
+        "memfs": "^4.57.8",
         "minimist": "^1.2.8",
         "mocha": "^11.7.6",
         "p-limit": "^3.1.0",