@abaplint/cli 2.119.38 → 2.119.40

package/build/cli.js

@@ -37415,6 +37415,7 @@ const source_1 = __webpack_require__(/*! ../expressions/source */ "../core/build
 const component_compare_1 = __webpack_require__(/*! ../expressions/component_compare */ "../core/build/src/abap/5_syntax/expressions/component_compare.js");
 const component_cond_1 = __webpack_require__(/*! ../expressions/component_cond */ "../core/build/src/abap/5_syntax/expressions/component_cond.js");
 const basic_1 = __webpack_require__(/*! ../../types/basic */ "../core/build/src/abap/types/basic/index.js");
+const _syntax_input_1 = __webpack_require__(/*! ../_syntax_input */ "../core/build/src/abap/5_syntax/_syntax_input.js");
 class DeleteInternal {
     runSyntax(node, input) {
         var _a;
@@ -37425,7 +37426,8 @@ class DeleteInternal {
         const target = node.findDirectExpression(Expressions.Target);
         if (target) {
             let tabl = undefined;
-            if (node.getChildren().length === 5 && node.getChildren()[2].concatTokens().toUpperCase() === "FROM") {
+            const localVariable = input.scope.findVariable(target.concatTokens());
+            if (localVariable === undefined && node.getChildren().length === 5 && node.getChildren()[2].concatTokens().toUpperCase() === "FROM") {
                 // it might be a database table
                 tabl = (_a = input.scope.getDDIC()) === null || _a === void 0 ? void 0 : _a.lookupTableOrView(target.concatTokens());
                 if (tabl) {
@@ -37434,6 +37436,15 @@ class DeleteInternal {
             }
             if (tabl === undefined) {
                 targetType = target_1.Target.runSyntax(target, input);
+                if (node.findDirectTokenByText("TABLE") === undefined
+                    && node.findDirectTokenByText("ADJACENT") === undefined
+                    && node.findDirectTokenByText("FROM")
+                    && targetType instanceof basic_1.TableType
+                    && targetType.getAccessType() === basic_1.TableAccessType.hashed) {
+                    const message = "Implicit or explicit index operation on hashed table is not possible";
+                    input.issues.push((0, _syntax_input_1.syntaxIssue)(input, node.getFirstToken(), message));
+                    return;
+                }
                 if (targetType instanceof basic_1.TableType) {
                     targetType = targetType.getRowType();
                 }
@@ -66567,7 +66578,7 @@ class Registry {
     }
     static abaplintVersion() {
         // magic, see build script "version.js"
-        return "2.119.38";
+        return "2.119.40";
     }
     getDDICReferences() {
         return this.ddicReferences;
@@ -89434,6 +89445,9 @@ class SelectionScreenTextsMissing {
             key: "selection_screen_texts_missing",
             title: "Selection screen texts missing",
             shortDescription: `Checks that selection screen parameters and select-options have selection texts`,
+            extendedInformation: `Excludes parameters and select-options that:
+* are inside a "SELECTION-SCREEN BEGIN OF LINE" block
+* have the addition "NO-DISPLAY"`,
         };
     }
     getConfig() {
@@ -89459,7 +89473,7 @@ class SelectionScreenTextsMissing {
         this.checkFile(obj.getMainABAPFile(), selTexts, output, checked);
         return output;
     }
-    checkFile(file, selTexts, output, checked) {
+    checkFile(file, selTexts, output, checked, mainProgName = undefined) {
         if (file === undefined) {
             return;
         }
@@ -89467,26 +89481,44 @@ class SelectionScreenTextsMissing {
             return;
         }
         checked.add(file.getFilename());
+        let inLine = false;
         for (const stat of file.getStatements()) {
             const s = stat.get();
-            if (s instanceof statements_1.Parameter || s instanceof statements_1.SelectOption) {
-                const fieldNode = stat.findFirstExpression(expressions_1.FieldSub);
-                if (fieldNode) {
-                    const fieldName = fieldNode.getFirstToken().getStr().toUpperCase();
-                    if (selTexts[fieldName] === undefined) {
-                        output.push(issue_1.Issue.atToken(file, fieldNode.getFirstToken(), `Selection text missing for "${fieldName}"`, this.getMetadata().key, this.conf.severity));
-                    }
+            if (s instanceof statements_1.SelectionScreen) {
+                const tokens = stat.concatTokens().toUpperCase();
+                if (tokens.includes("BEGIN OF LINE")) {
+                    inLine = true;
                 }
+                else if (tokens.includes("END OF LINE")) {
+                    // known issue: doesn't support BEGIN and END OF LINE span across several includes (not seen a lot in the wild)
+                    inLine = false;
+                }
+                continue;
             }
-            else if (s instanceof statements_1.Include) {
+            if (s instanceof statements_1.Include) {
                 const nameNode = stat.findFirstExpression(expressions_1.IncludeName);
                 if (nameNode) {
                     const inclName = nameNode.getFirstToken().getStr().toUpperCase();
                     const inclObj = this.reg.getObject("PROG", inclName);
                     if (inclObj) {
-                        this.checkFile(inclObj.getMainABAPFile(), selTexts, output, checked);
+                        this.checkFile(inclObj.getMainABAPFile(), selTexts, output, checked, mainProgName !== null && mainProgName !== void 0 ? mainProgName : file.getFilename());
                     }
                 }
+                continue;
+            }
+            if (inLine || !(s instanceof statements_1.Parameter || s instanceof statements_1.SelectOption)) {
+                continue;
+            }
+            if (stat.concatTokens().toUpperCase().includes("NO-DISPLAY")) {
+                continue;
+            }
+            const fieldNode = stat.findFirstExpression(expressions_1.FieldSub);
+            if (fieldNode) {
+                const fieldName = fieldNode.getFirstToken().getStr().toUpperCase();
+                if (selTexts[fieldName] === undefined) {
+                    const suffix = mainProgName ? `, ${mainProgName}` : ``;
+                    output.push(issue_1.Issue.atToken(file, fieldNode.getFirstToken(), `Selection text missing for "${fieldName}"${suffix}`, this.getMetadata().key, this.conf.severity));
+                }
             }
         }
     }

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@abaplint/cli",
-    "version": "2.119.38",
+    "version": "2.119.40",
     "description": "abaplint - Command Line Interface",
     "funding": "https://github.com/sponsors/larshp",
     "bin": {
@@ -38,7 +38,7 @@
     },
     "homepage": "https://abaplint.org",
     "devDependencies": {
-        "@abaplint/core": "^2.119.38",
+        "@abaplint/core": "^2.119.40",
         "@types/chai": "^4.3.20",
         "@types/minimist": "^1.2.5",
         "@types/mocha": "^10.0.10",