@abaplint/cli 2.119.22 → 2.119.24

package/build/cli.js

@@ -32011,7 +32011,7 @@ class Data {
         const dd = node.findFirstExpression(Expressions.DataDefinition);
         if (dd) {
             const id = data_definition_1.DataDefinition.runSyntax(dd, input);
-            if (id && this.isOnlyDigits(id.getName())) {
+            if (id && this.isOnlyDigits(id.getName()) && this.allowOnlyDigitsName(node, input) === false) {
                 const message = "not possible to have a name with only digits";
                 input.issues.push((0, _syntax_input_1.syntaxIssue)(input, id.getToken(), message));
                 return new _typed_identifier_1.TypedIdentifier(id.getToken(), input.filename, basic_1.VoidType.get(_syntax_input_1.CheckSyntaxKey));
@@ -32025,7 +32025,7 @@ class Data {
             return id;
         }
         if (name) {
-            if (this.isOnlyDigits(name.concatTokens())) {
+            if (this.isOnlyDigits(name.concatTokens()) && this.allowOnlyDigitsName(node, input) === false) {
                 const message = "not possible to have a name with only digits";
                 input.issues.push((0, _syntax_input_1.syntaxIssue)(input, name.getFirstToken(), message));
             }
@@ -32036,6 +32036,9 @@ class Data {
     isOnlyDigits(name) {
         return /^[0-9]+$/.test(name);
     }
+    allowOnlyDigitsName(node, input) {
+        return input.scope.isAnyOO() === false && node.getColon() !== undefined;
+    }
 }
 exports.Data = Data;
 //# sourceMappingURL=data.js.map
@@ -47422,9 +47425,11 @@ class ABAPObject extends _abstract_object_1.AbstractObject {
         }
         for (const t of (0, xml_utils_1.xmlToArray)(parsed.abapGit["asx:abap"]["asx:values"].TPOOL.item)) {
             const id = (_e = t.ID) === null || _e === void 0 ? void 0 : _e.toUpperCase();
-            if (id === undefined
-                || (id !== "R" && t.KEY === undefined)) {
-                throw new Error("findTexts, undefined");
+            if (id === undefined) {
+                continue;
+            }
+            if (id !== "R" && t.KEY === undefined) {
+                continue;
             }
             const key = (_g = ((_f = t.KEY) !== null && _f !== void 0 ? _f : t.ID)) === null || _g === void 0 ? void 0 : _g.toUpperCase();
             if (key === undefined) {
@@ -47437,16 +47442,16 @@ class ABAPObject extends _abstract_object_1.AbstractObject {
         }
     }
     findTextsTranslations(parsed) {
-        var _a, _b, _c, _d, _e, _f;
+        var _a, _b, _c, _d, _e, _f, _g;
         this.textsTranslations = [];
-        const values = (_c = (_b = (_a = parsed === null || parsed === void 0 ? void 0 : parsed.abapGit) === null || _a === void 0 ? void 0 : _a["asx:abap"]) === null || _b === void 0 ? void 0 : _b["asx:values"].I18N_TPOOL) === null || _c === void 0 ? void 0 : _c.item;
+        const values = (_d = (_c = (_b = (_a = parsed === null || parsed === void 0 ? void 0 : parsed.abapGit) === null || _a === void 0 ? void 0 : _a["asx:abap"]) === null || _b === void 0 ? void 0 : _b["asx:values"]) === null || _c === void 0 ? void 0 : _c.I18N_TPOOL) === null || _d === void 0 ? void 0 : _d.item;
         if (values === undefined) {
             return;
         }
         for (const langItem of (0, xml_utils_1.xmlToArray)(values)) {
             const textElements = {};
-            for (const item of (0, xml_utils_1.xmlToArray)((_d = langItem.TEXTPOOL) === null || _d === void 0 ? void 0 : _d.item)) {
-                const key = (_f = ((_e = item.KEY) !== null && _e !== void 0 ? _e : item.ID)) === null || _f === void 0 ? void 0 : _f.toUpperCase();
+            for (const item of (0, xml_utils_1.xmlToArray)((_e = langItem.TEXTPOOL) === null || _e === void 0 ? void 0 : _e.item)) {
+                const key = (_g = ((_f = item.KEY) !== null && _f !== void 0 ? _f : item.ID)) === null || _g === void 0 ? void 0 : _g.toUpperCase();
                 if (key !== undefined) {
                     textElements[key] = { entry: (0, xml_utils_1.unescape)(item.ENTRY), maxLength: parseInt(item.LENGTH, 10) };
                 }
@@ -55378,23 +55383,22 @@ class Transaction extends _abstract_object_1.AbstractObject {
         return (_a = this.parsedXML) === null || _a === void 0 ? void 0 : _a.textsTranslations;
     }
     parse() {
-        var _a, _b, _c, _d;
+        var _a, _b, _c, _d, _e, _f;
         if (this.parsedXML) {
             return { updated: false, runtime: 0 };
         }
         const start = Date.now();
         this.parsedXML = {};
         const parsed = super.parseRaw2();
-        if (parsed === undefined
-            || parsed.abapGit === undefined
-            || parsed.abapGit["asx:abap"]["asx:values"] === undefined) {
+        const values = (_b = (_a = parsed === null || parsed === void 0 ? void 0 : parsed.abapGit) === null || _a === void 0 ? void 0 : _a["asx:abap"]) === null || _b === void 0 ? void 0 : _b["asx:values"];
+        if (values === undefined) {
             return { updated: false, runtime: 0 };
         }
-        this.parsedXML.description = (_a = parsed.abapGit["asx:abap"]["asx:values"].TSTCT) === null || _a === void 0 ? void 0 : _a.TTEXT;
-        this.parsedXML.programName = (_b = parsed.abapGit["asx:abap"]["asx:values"].TSTC) === null || _b === void 0 ? void 0 : _b.PGMNA;
-        this.parsedXML.cinfo = (_c = parsed.abapGit["asx:abap"]["asx:values"].TSTC) === null || _c === void 0 ? void 0 : _c.CINFO;
+        this.parsedXML.description = (_c = values.TSTCT) === null || _c === void 0 ? void 0 : _c.TTEXT;
+        this.parsedXML.programName = (_d = values.TSTC) === null || _d === void 0 ? void 0 : _d.PGMNA;
+        this.parsedXML.cinfo = (_e = values.TSTC) === null || _e === void 0 ? void 0 : _e.CINFO;
         this.parsedXML.textsTranslations = [];
-        for (const item of (0, xml_utils_1.xmlToArray)((_d = parsed.abapGit["asx:abap"]["asx:values"].I18N_TPOOL) === null || _d === void 0 ? void 0 : _d.TSTCT)) {
+        for (const item of (0, xml_utils_1.xmlToArray)((_f = values.I18N_TPOOL) === null || _f === void 0 ? void 0 : _f.TSTCT)) {
             this.parsedXML.textsTranslations.push({ language: item.SPRSL, description: item.TTEXT });
         }
         const end = Date.now();
@@ -56457,7 +56461,7 @@ class Registry {
     }
     static abaplintVersion() {
         // magic, see build script "version.sh"
-        return "2.119.22";
+        return "2.119.24";
     }
     getDDICReferences() {
         return this.ddicReferences;
@@ -66741,25 +66745,54 @@ class FunctionModuleRecommendationsConf extends _basic_rule_config_1.BasicRuleCo
          * @uniqueItems true
          */
         this.recommendations = [
+            { name: "CALCULATE_HASH_FOR_CHAR", replace: "use CL_ABAP_MESSAGE_DIGEST" },
             { name: "CALCULATE_HASH_FOR_RAW", replace: "use CL_ABAP_HMAC or CL_ABAP_MESSAGE_DIGEST" },
             { name: "CCU_TIMESTAMP_DIFFERENCE", replace: "use CL_ABAP_TSTMP" },
+            { name: "CLPB_EXPORT", replace: "use CL_GUI_FRONTEND_SERVICES" },
+            { name: "CLPB_IMPORT", replace: "use CL_GUI_FRONTEND_SERVICES" },
             { name: "CONVERT_DATE_TO_EXTERNAL", replace: "use CL_ABAP_DATFM" },
             { name: "CONVERT_TIME_INPUT", replace: "use CL_ABAP_TIMEFM" },
+            { name: "DOWNLOAD", replace: "use CL_GUI_FRONTEND_SERVICES" },
             { name: "ECATT_CONV_XSTRING_TO_STRING", replace: "use CL_BINARY_CONVERT" },
             { name: "F4_FILENAME", replace: "use CL_GUI_FRONTEND_SERVICES" },
             { name: "FUNCTION_EXISTS", replace: "surround with try-catch CX_SY_DYN_CALL_ILLEGAL_METHOD instead" },
+            { name: "GUI_CREATE_DIRECTORY", replace: "use CL_GUI_FRONTEND_SERVICES" },
+            { name: "GUI_DELETE_FILE", replace: "use CL_GUI_FRONTEND_SERVICES" },
             { name: "GUI_DOWNLOAD", replace: "use CL_GUI_FRONTEND_SERVICES" },
+            { name: "GUI_EXEC", replace: "use CL_GUI_FRONTEND_SERVICES" },
+            { name: "GUI_FB_USAGE", replace: "use CL_GUI_FRONTEND_SERVICES" },
+            { name: "GUI_FILE_LOAD_DIALOG", replace: "use CL_GUI_FRONTEND_SERVICES" },
+            { name: "GUI_FILE_SAVE_DIALOG", replace: "use CL_GUI_FRONTEND_SERVICES" },
+            { name: "GUI_GET_DESKTOP_INFO", replace: "use CL_GUI_FRONTEND_SERVICES" },
+            { name: "GUI_GET_FILE_INFO", replace: "use CL_GUI_FRONTEND_SERVICES" },
+            { name: "GUI_GET_REGVALUE", replace: "use CL_GUI_FRONTEND_SERVICES" },
+            { name: "GUI_MULTIPLE_FILE_LOAD_DIALOG", replace: "use CL_GUI_FRONTEND_SERVICES" },
+            { name: "GUI_REMOVE_DIRECTORY", replace: "use CL_GUI_FRONTEND_SERVICES" },
+            { name: "GUI_RUN", replace: "use CL_GUI_FRONTEND_SERVICES" },
+            { name: "GUI_SET_REGVALUE", replace: "use CL_GUI_FRONTEND_SERVICES" },
             { name: "GUI_UPLOAD", replace: "use CL_GUI_FRONTEND_SERVICES" },
+            { name: "GUI_VSS_DOWNLOAD", replace: "use CL_GUI_FRONTEND_SERVICES" },
+            { name: "GUI_VSS_UPLOAD", replace: "use CL_GUI_FRONTEND_SERVICES" },
             { name: "GUID_CREATE", replace: "use CL_SYSTEM_UUID" },
             { name: "IGN_TIMESTAMP_DIFFERENCE", replace: "use CL_ABAP_TSTMP" },
             { name: "IGN_TIMESTAMP_PLUSMINUS", replace: "use CL_ABAP_TSTMP" },
             { name: "ISM_SD_GET_PRICING_CONDITIONS", replace: "use CL_PRC_RESULT_FACTORY as per note 2220005" },
             { name: "JOB_CREATE", replace: "use CL_BP_ABAP_JOB" },
             { name: "JOB_SUBMIT", replace: "use CL_BP_ABAP_JOB" },
+            { name: "MD5_CALCULATE_HASH_FOR_CHAR", replace: "use CL_ABAP_MESSAGE_DIGEST" },
+            { name: "MD5_CALCULATE_HASH_FOR_RAW", replace: "use CL_ABAP_MESSAGE_DIGEST" },
+            { name: "POPUP_TO_CONFIRM_LOSS_OF_DATA", replace: "use POPUP_TO_CONFIRM" },
             { name: "POPUP_TO_CONFIRM_STEP", replace: "use POPUP_TO_CONFIRM" },
+            { name: "POPUP_TO_CONFIRM_WITH_MESSAGE", replace: "use POPUP_TO_CONFIRM" },
+            { name: "POPUP_TO_CONFIRM_WITH_VALUE", replace: "use POPUP_TO_CONFIRM" },
+            { name: "POPUP_TO_CONFIRM_WITH_VALUE_2", replace: "use POPUP_TO_CONFIRM" },
             { name: "POPUP_TO_DECIDE", replace: "use POPUP_TO_CONFIRM" },
+            { name: "POPUP_TO_DECIDE_INFO", replace: "use POPUP_TO_CONFIRM" },
+            { name: "POPUP_TO_DECIDE_WITH_MESSAGE", replace: "use POPUP_TO_CONFIRM" },
             { name: "POPUP_TO_GET_VALUE", replace: "use POPUP_GET_VALUES" },
             { name: "QF05_RANDOM_INTEGER", replace: "use CL_ABAP_RANDOM_INT" },
+            { name: "REGISTRY_GET", replace: "use CL_GUI_FRONTEND_SERVICES" },
+            { name: "REGISTRY_SET", replace: "use CL_GUI_FRONTEND_SERVICES" },
             { name: "REUSE_ALV_GRID_DISPLAY", replace: "use CL_SALV_TABLE=>FACTORY or CL_GUI_ALV_GRID" },
             { name: "ROUND", replace: "use built in function: round()" },
             { name: "SAPGUI_PROGRESS_INDICATOR", replace: "use CL_PROGRESS_INDICATOR" },
@@ -66769,7 +66802,17 @@ class FunctionModuleRecommendationsConf extends _basic_rule_config_1.BasicRuleCo
             { name: "SSFC_BASE64_DECODE", replace: "use class CL_HTTP_UTILITY methods" },
             { name: "SSFC_BASE64_ENCODE", replace: "use class CL_HTTP_UTILITY methods" },
             { name: "SUBST_GET_FILE_LIST", replace: "see note 1686357" },
+            { name: "SYSTEM_GET_UNIQUE_ID", replace: "use CL_SYSTEM_UUID" },
+            { name: "SYSTEM_UUID_C_CREATE", replace: "use CL_SYSTEM_UUID" },
+            { name: "UPLOAD", replace: "use CL_GUI_FRONTEND_SERVICES" },
+            { name: "WS_DOWNLOAD", replace: "use CL_GUI_FRONTEND_SERVICES" },
+            { name: "WS_EXECUTE", replace: "use CL_GUI_FRONTEND_SERVICES" },
             { name: "WS_FILENAME_GET", replace: "use CL_GUI_FRONTEND_SERVICES" },
+            { name: "WS_FILE_ATTRIB", replace: "use CL_GUI_FRONTEND_SERVICES" },
+            { name: "WS_FILE_COPY", replace: "use CL_GUI_FRONTEND_SERVICES" },
+            { name: "WS_FILE_DELETE", replace: "use CL_GUI_FRONTEND_SERVICES" },
+            { name: "WS_QUERY", replace: "use CL_GUI_FRONTEND_SERVICES" },
+            { name: "WS_UPLOAD", replace: "use CL_GUI_FRONTEND_SERVICES" },
         ];
     }
 }

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@abaplint/cli",
-    "version": "2.119.22",
+    "version": "2.119.24",
     "description": "abaplint - Command Line Interface",
     "funding": "https://github.com/sponsors/larshp",
     "bin": {
@@ -38,7 +38,7 @@
     },
     "homepage": "https://abaplint.org",
     "devDependencies": {
-        "@abaplint/core": "^2.119.22",
+        "@abaplint/core": "^2.119.24",
         "@types/chai": "^4.3.20",
         "@types/minimist": "^1.2.5",
         "@types/mocha": "^10.0.10",