@abaplint/cli 2.119.1 → 2.119.3

package/build/cli.js

@@ -8638,7 +8638,9 @@ class SQLFunction extends combi_1.Expression {
         const dats_add_months = (0, combi_1.ver)(version_1.Version.v754, (0, combi_1.seq)((0, combi_1.regex)(/^dats_add_months$/i), (0, combi_1.tok)(tokens_1.ParenLeftW), sql_function_input_1.SQLFunctionInput, commaParam, (0, combi_1.tok)(tokens_1.WParenRightW)));
         const ltrim = (0, combi_1.ver)(version_1.Version.v750, (0, combi_1.seq)((0, combi_1.regex)(/^ltrim$/i), (0, combi_1.tok)(tokens_1.ParenLeftW), sql_function_input_1.SQLFunctionInput, commaParam, (0, combi_1.tok)(tokens_1.WParenRightW)));
         const rtrim = (0, combi_1.ver)(version_1.Version.v750, (0, combi_1.seq)((0, combi_1.regex)(/^rtrim$/i), (0, combi_1.tok)(tokens_1.ParenLeftW), sql_function_input_1.SQLFunctionInput, commaParam, (0, combi_1.tok)(tokens_1.WParenRightW)));
-        return (0, combi_1.altPrio)(uuid, abs, ceil, floor, cast, div, mod, coalesce, concat, replace, length, lower, upper, round, concat_with_space, ltrim, rtrim, substring, dats_is_valid, dats_days_between, dats_add_days, dats_add_months);
+        const right = (0, combi_1.ver)(version_1.Version.v750, (0, combi_1.seq)((0, combi_1.regex)(/^right$/i), (0, combi_1.tok)(tokens_1.ParenLeftW), sql_function_input_1.SQLFunctionInput, commaParam, (0, combi_1.tok)(tokens_1.WParenRightW)));
+        const left = (0, combi_1.ver)(version_1.Version.v751, (0, combi_1.seq)((0, combi_1.regex)(/^left$/i), (0, combi_1.tok)(tokens_1.ParenLeftW), sql_function_input_1.SQLFunctionInput, commaParam, (0, combi_1.tok)(tokens_1.WParenRightW)));
+        return (0, combi_1.altPrio)(uuid, abs, ceil, floor, cast, div, mod, coalesce, concat, replace, length, lower, upper, round, concat_with_space, ltrim, rtrim, right, left, substring, dats_is_valid, dats_days_between, dats_add_days, dats_add_months);
     }
 }
 exports.SQLFunction = SQLFunction;
@@ -23529,6 +23531,8 @@ var ScopeType;
 (function (ScopeType) {
     ScopeType["BuiltIn"] = "_builtin";
     ScopeType["Dummy"] = "_dummy";
+    // definitions inside this one are local
+    ScopeType["SelectionEvent"] = "selection_event";
     ScopeType["Global"] = "_global";
     ScopeType["Program"] = "_program";
     ScopeType["TypePool"] = "_type_pool";
@@ -24010,7 +24014,11 @@ class TypeUtils {
             }
         }
         else if (source instanceof basic_1.TableType) {
-            if (target instanceof basic_1.TableType) {
+            if (source.getRowType() instanceof basic_1.AnyType) {
+                // then its a generic table, todo: add top level generic table type?
+                return true;
+            }
+            else if (target instanceof basic_1.TableType) {
                 const sourceKeyType = source.getOptions().keyType;
                 const targetKeyType = target.getOptions().keyType;
                 if (sourceKeyType !== targetKeyType
@@ -36681,6 +36689,7 @@ const commit_entities_1 = __webpack_require__(/*! ./statements/commit_entities *
 const _syntax_input_1 = __webpack_require__(/*! ./_syntax_input */ "./node_modules/@abaplint/core/build/src/abap/5_syntax/_syntax_input.js");
 const assert_error_1 = __webpack_require__(/*! ./assert_error */ "./node_modules/@abaplint/core/build/src/abap/5_syntax/assert_error.js");
 const field_group_1 = __webpack_require__(/*! ./statements/field_group */ "./node_modules/@abaplint/core/build/src/abap/5_syntax/statements/field_group.js");
+const stuff_1 = __webpack_require__(/*! ../../stuff */ "./node_modules/@abaplint/core/build/src/stuff.js");
 // -----------------------------------
 const map = {};
 function addToMap(handler) {
@@ -36934,6 +36943,9 @@ class SyntaxLogic {
     updateScopeStructure(node) {
         const filename = this.currentFile.getFilename();
         const stru = node.get();
+        if (this.scope.getType() === _scope_type_1.ScopeType.SelectionEvent && this.isSelectionEventBoundaryStructure(stru)) {
+            this.scope.pop(node.getFirstToken().getStart());
+        }
         const input = {
             scope: this.scope,
             filename,
@@ -36973,6 +36985,7 @@ class SyntaxLogic {
     updateScopeStatement(node) {
         const filename = this.currentFile.getFilename();
         const s = node.get();
+        this.updateSelectionEventScope(node);
         const input = {
             scope: this.scope,
             filename,
@@ -37018,6 +37031,27 @@ class SyntaxLogic {
             }
         }
     }
+    updateSelectionEventScope(node) {
+        const statement = node.get();
+        if (this.scope.getType() === _scope_type_1.ScopeType.SelectionEvent && this.isSelectionEventBoundary(statement)) {
+            this.scope.pop(node.getFirstToken().getStart());
+        }
+        if (this.opensSelectionEventScope(statement)) {
+            this.scope.push(_scope_type_1.ScopeType.SelectionEvent, statement.constructor.name, node.getFirstToken().getStart(), this.currentFile.getFilename());
+        }
+    }
+    opensSelectionEventScope(statement) {
+        return statement instanceof Statements.AtSelectionScreen;
+    }
+    isSelectionEventBoundary(statement) {
+        return stuff_1.SELECTION_EVENTS.some(event => statement instanceof event)
+            || statement instanceof Statements.Form
+            || statement instanceof Statements.FunctionModule;
+    }
+    isSelectionEventBoundaryStructure(structure) {
+        return structure instanceof Structures.ClassDefinition
+            || structure instanceof Structures.Interface;
+    }
 }
 exports.SyntaxLogic = SyntaxLogic;
 //# sourceMappingURL=syntax.js.map
@@ -40342,7 +40376,7 @@ class ClassDefinition extends _identifier_1.Identifier {
                 input.scope.addReference(token, undefined, _reference_1.ReferenceType.ObjectOrientedVoidReference, input.filename);
             }
             else {
-                input.issues.push((0, _syntax_input_1.syntaxIssue)(input, token, name.toUpperCase() + " does not exist"));
+                input.issues.push((0, _syntax_input_1.syntaxIssue)(input, token, "Friend class " + name.toUpperCase() + " does not exist"));
             }
             result.push(name);
         }
@@ -56143,7 +56177,7 @@ class Registry {
     }
     static abaplintVersion() {
         // magic, see build script "version.sh"
-        return "2.119.1";
+        return "2.119.3";
     }
     getDDICReferences() {
         return this.ddicReferences;
@@ -68679,6 +68713,7 @@ const _basic_rule_config_1 = __webpack_require__(/*! ./_basic_rule_config */ "./
 const _abap_rule_1 = __webpack_require__(/*! ./_abap_rule */ "./node_modules/@abaplint/core/build/src/rules/_abap_rule.js");
 const Expressions = __webpack_require__(/*! ../abap/2_statements/expressions */ "./node_modules/@abaplint/core/build/src/abap/2_statements/expressions/index.js");
 const _irule_1 = __webpack_require__(/*! ./_irule */ "./node_modules/@abaplint/core/build/src/rules/_irule.js");
+const edit_helper_1 = __webpack_require__(/*! ../edit_helper */ "./node_modules/@abaplint/core/build/src/edit_helper.js");
 class KeepSingleParameterCallsOnOneLineConf extends _basic_rule_config_1.BasicRuleConfig {
     constructor() {
         super(...arguments);
@@ -68698,7 +68733,7 @@ class KeepSingleParameterCallsOnOneLine extends _abap_rule_1.ABAPRule {
             title: "Keep single parameters on one line",
             shortDescription: `Keep single parameter calls on one line`,
             extendedInformation: `https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#keep-single-parameter-calls-on-one-line`,
-            tags: [_irule_1.RuleTag.Whitespace, _irule_1.RuleTag.Styleguide, _irule_1.RuleTag.SingleFile],
+            tags: [_irule_1.RuleTag.Whitespace, _irule_1.RuleTag.Styleguide, _irule_1.RuleTag.SingleFile, _irule_1.RuleTag.Quickfix],
             badExample: `call_method(\n  2 ).`,
             goodExample: `call_method( 2 ).`,
         };
@@ -68774,7 +68809,8 @@ class KeepSingleParameterCallsOnOneLine extends _abap_rule_1.ABAPRule {
                 }
             }
             const message = "Keep single parameter on one line";
-            return [issue_1.Issue.atToken(file, c.getFirstToken(), message, this.getMetadata().key, this.conf.severity)];
+            const fix = edit_helper_1.EditHelper.replaceRange(file, c.getFirstToken().getStart(), c.getLastToken().getEnd(), c.concatTokens());
+            return [issue_1.Issue.atToken(file, c.getFirstToken(), message, this.getMetadata().key, this.conf.severity, fix)];
         }
         return [];
     }
@@ -69865,6 +69901,7 @@ const issue_1 = __webpack_require__(/*! ../issue */ "./node_modules/@abaplint/co
 const _basic_rule_config_1 = __webpack_require__(/*! ./_basic_rule_config */ "./node_modules/@abaplint/core/build/src/rules/_basic_rule_config.js");
 const Objects = __webpack_require__(/*! ../objects */ "./node_modules/@abaplint/core/build/src/objects/index.js");
 const _abap_object_1 = __webpack_require__(/*! ../objects/_abap_object */ "./node_modules/@abaplint/core/build/src/objects/_abap_object.js");
+const _irule_1 = __webpack_require__(/*! ./_irule */ "./node_modules/@abaplint/core/build/src/rules/_irule.js");
 const Statements = __webpack_require__(/*! ../abap/2_statements/statements */ "./node_modules/@abaplint/core/build/src/abap/2_statements/statements/index.js");
 const Expressions = __webpack_require__(/*! ../abap/2_statements/expressions */ "./node_modules/@abaplint/core/build/src/abap/2_statements/expressions/index.js");
 const position_1 = __webpack_require__(/*! ../position */ "./node_modules/@abaplint/core/build/src/position.js");
@@ -69882,6 +69919,7 @@ class MainFileContents {
             key: "main_file_contents",
             title: "Main file contents",
             shortDescription: `Checks related to report declarations.`,
+            tags: [_irule_1.RuleTag.Syntax],
             extendedInformation: `Does not run if the target version is Cloud
 
 * PROGs must begin with "REPORT <name>." or "PROGRAM <name>.

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@abaplint/cli",
-    "version": "2.119.1",
+    "version": "2.119.3",
     "description": "abaplint - Command Line Interface",
     "funding": "https://github.com/sponsors/larshp",
     "bin": {
@@ -38,7 +38,7 @@
     },
     "homepage": "https://abaplint.org",
     "devDependencies": {
-        "@abaplint/core": "^2.119.1",
+        "@abaplint/core": "^2.119.3",
         "@types/chai": "^4.3.20",
         "@types/minimist": "^1.2.5",
         "@types/mocha": "^10.0.10",