@abaplint/cli 2.117.1 → 2.117.2

package/build/cli.js

@@ -47123,6 +47123,7 @@ function parseDynpros(parsed) {
                     name: f.NAME,
                     type: f.TYPE,
                     length: parseNumber(f.LENGTH),
+                    vislength: parseNumber(f.VISLENGTH),
                     line: parseNumber(f.LINE),
                     column: parseNumber(f.COLUMN),
                     height: parseNumber(f.HEIGHT),
@@ -55815,7 +55816,7 @@ class Registry {
     }
     static abaplintVersion() {
         // magic, see build script "version.sh"
-        return "2.117.1";
+        return "2.117.2";
     }
     getDDICReferences() {
         return this.ddicReferences;
@@ -64156,15 +64157,15 @@ class DynproChecks {
         const ret = [];
         for (let index = 0; index < dynpro.fields.length; index++) {
             const current = dynpro.fields[index];
-            if (current.name === undefined) {
+            if (current.name === undefined || current.type === "FRAME") {
                 continue;
             }
             for (let compare = index + 1; compare < dynpro.fields.length; compare++) {
                 const other = dynpro.fields[compare];
-                if (other.name === undefined || this.overlaps(current, other) === false) {
+                if (other.name === undefined || other.type === "FRAME" || this.overlaps(current, other) === false) {
                     continue;
                 }
-                const message = `Screen ${dynpro.number}, fields ${current.name} and ${other.name} are overlapping`;
+                const message = `Screen ${dynpro.number}, ${current.type} ${current.name} and ${other.type} ${other.name} are overlapping`;
                 ret.push(issue_1.Issue.atPosition(file, new position_1.Position(1, 1), message, this.getMetadata().key, this.getConfig().severity));
             }
         }
@@ -64181,8 +64182,8 @@ class DynproChecks {
         if (firstLastLine < second.line || secondLastLine < first.line) {
             return false;
         }
-        const firstLastColumn = first.column + Math.max(first.length, 1) - 1;
-        const secondLastColumn = second.column + Math.max(second.length, 1) - 1;
+        const firstLastColumn = first.column + Math.max(first.vislength || first.length, 1) - 1;
+        const secondLastColumn = second.column + Math.max(second.vislength || second.length, 1) - 1;
         return first.column <= secondLastColumn && second.column <= firstLastColumn;
     }
 }
@@ -70315,7 +70316,8 @@ class MSAGConsistency {
             key: "msag_consistency",
             title: "MSAG consistency check",
             shortDescription: `Checks the validity of messages in message classes`,
-            extendedInformation: `Message numbers must be 3 digits, message text must not be empty, no message number duplicates`,
+            extendedInformation: `Message numbers must be 3 digits, message text must not be empty,\n` +
+                `message text must not exceed 73 characters, no message number duplicates`,
         };
     }
     getDescription(reason) {
@@ -70351,6 +70353,12 @@ class MSAGConsistency {
                 const issue = issue_1.Issue.atPosition(obj.getFiles()[0], position, text, this.getMetadata().key, this.conf.severity);
                 issues.push(issue);
             }
+            if (message.getMessage().length > 73) {
+                const text = `Message text too long (max 73 characters): message ${message.getNumber()}`;
+                const position = new position_1.Position(1, 1);
+                const issue = issue_1.Issue.atPosition(obj.getFiles()[0], position, text, this.getMetadata().key, this.conf.severity);
+                issues.push(issue);
+            }
             const num = message.getNumber();
             if (numbers.has(num)) {
                 const text = "Duplicate message number " + num;
@@ -70364,7 +70372,7 @@ class MSAGConsistency {
             if (this.getConfig().numericParameters === true) {
                 const placeholderCount = message.getPlaceholderCount();
                 if (placeholderCount > 4) {
-                    const text = `More than 4 placeholders in mesasge ${message.getNumber()}`;
+                    const text = `More than 4 placeholders in message ${message.getNumber()}`;
                     const position = new position_1.Position(1, 1);
                     const issue = issue_1.Issue.atPosition(obj.getFiles()[0], position, text, this.getMetadata().key, this.conf.severity);
                     issues.push(issue);

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@abaplint/cli",
-    "version": "2.117.1",
+    "version": "2.117.2",
     "description": "abaplint - Command Line Interface",
     "funding": "https://github.com/sponsors/larshp",
     "bin": {
@@ -38,7 +38,7 @@
     },
     "homepage": "https://abaplint.org",
     "devDependencies": {
-        "@abaplint/core": "^2.117.1",
+        "@abaplint/core": "^2.117.2",
         "@types/chai": "^4.3.20",
         "@types/minimist": "^1.2.5",
         "@types/mocha": "^10.0.10",