@abaplint/cli 2.115.21 → 2.115.23

package/build/cli.js

@@ -4274,7 +4274,7 @@ const let_1 = __webpack_require__(/*! ./let */ "./node_modules/@abaplint/core/bu
 class Cast extends combi_1.Expression {
     getRunnable() {
         const rparen = (0, combi_1.altPrio)((0, combi_1.tok)(tokens_1.WParenRightW), (0, combi_1.tok)(tokens_1.WParenRight));
-        const cast = (0, combi_1.seq)("CAST", _1.TypeNameOrInfer, (0, combi_1.tok)(tokens_1.ParenLeftW), (0, combi_1.optPrio)(let_1.Let), _1.Source, rparen);
+        const cast = (0, combi_1.seq)("CAST", _1.TypeNameOrInfer, (0, combi_1.tok)(tokens_1.ParenLeftW), (0, combi_1.optPrio)(let_1.Let), _1.Source, rparen, (0, combi_1.opt)(_1.Dereference));
         return (0, combi_1.ver)(version_1.Version.v740sp02, cast, version_1.Version.OpenABAP);
     }
 }
@@ -15420,7 +15420,7 @@ class Move {
         const equals = (0, combi_1.altPrio)((0, combi_1.altPrio)(chained, "?="), calcAssign);
         // todo, move "?=" to CAST?
         const eq = (0, combi_1.seq)(expressions_1.Target, equals, expressions_1.Source);
-        return (0, combi_1.altPrio)(move, eq);
+        return (0, combi_1.alt)(move, eq);
     }
 }
 exports.Move = Move;
@@ -31630,8 +31630,9 @@ class CreateObject {
                 return;
             }
             else if (found instanceof basic_1.ObjectReferenceType) {
-                const id = found.getIdentifier();
-                if (id instanceof types_1.InterfaceDefinition && type === undefined) {
+                const identifier = found.getIdentifier();
+                const idFound = input.scope.findObjectDefinition(identifier.getName());
+                if (idFound instanceof types_1.InterfaceDefinition && type === undefined) {
                     const message = "Interface reference, cannot be instantiated";
                     input.issues.push((0, _syntax_input_1.syntaxIssue)(input, node.getFirstToken(), message));
                     return;
@@ -31643,11 +31644,11 @@ class CreateObject {
                     input.issues.push((0, _syntax_input_1.syntaxIssue)(input, node.getFirstToken(), message));
                     return;
                 }
-                else if (id instanceof types_1.ClassDefinition && cdef === undefined) {
-                    cdef = id;
+                else if (idFound instanceof types_1.ClassDefinition && cdef === undefined) {
+                    cdef = idFound;
                 }
-                if (type === undefined && id instanceof types_1.ClassDefinition && id.isAbstract() === true) {
-                    const message = id.getName() + " is abstract, cannot be instantiated";
+                if (type === undefined && idFound instanceof types_1.ClassDefinition && idFound.isAbstract() === true) {
+                    const message = identifier.getName() + " is abstract, cannot be instantiated";
                     input.issues.push((0, _syntax_input_1.syntaxIssue)(input, node.getFirstToken(), message));
                     return;
                 }
@@ -33639,6 +33640,7 @@ const target_1 = __webpack_require__(/*! ../expressions/target */ "./node_module
 const inline_data_1 = __webpack_require__(/*! ../expressions/inline_data */ "./node_modules/@abaplint/core/build/src/abap/5_syntax/expressions/inline_data.js");
 const _type_utils_1 = __webpack_require__(/*! ../_type_utils */ "./node_modules/@abaplint/core/build/src/abap/5_syntax/_type_utils.js");
 const _syntax_input_1 = __webpack_require__(/*! ../_syntax_input */ "./node_modules/@abaplint/core/build/src/abap/5_syntax/_syntax_input.js");
+const dereference_1 = __webpack_require__(/*! ../expressions/dereference */ "./node_modules/@abaplint/core/build/src/abap/5_syntax/expressions/dereference.js");
 class Move {
     runSyntax(node, input) {
         const targets = node.findDirectExpressions(Expressions.Target);
@@ -33655,12 +33657,15 @@ class Move {
             }
         }
         const source = node.findDirectExpression(Expressions.Source);
-        const sourceType = source ? source_1.Source.runSyntax(source, input, targetType) : undefined;
+        let sourceType = source ? source_1.Source.runSyntax(source, input, targetType) : undefined;
         if (sourceType === undefined) {
             const message = "No source type determined";
             input.issues.push((0, _syntax_input_1.syntaxIssue)(input, node.getFirstToken(), message));
             return;
         }
+        if (node.findDirectExpression(Expressions.Dereference)) {
+            sourceType = dereference_1.Dereference.runSyntax(node, sourceType, input);
+        }
         if (inline) {
             inline_data_1.InlineData.runSyntax(inline, input, sourceType);
             targetType = sourceType;
@@ -55480,7 +55485,7 @@ class Registry {
     }
     static abaplintVersion() {
         // magic, see build script "version.sh"
-        return "2.115.21";
+        return "2.115.23";
     }
     getDDICReferences() {
         return this.ddicReferences;
@@ -65424,6 +65429,7 @@ const _abap_rule_1 = __webpack_require__(/*! ./_abap_rule */ "./node_modules/@ab
 const Objects = __webpack_require__(/*! ../objects */ "./node_modules/@abaplint/core/build/src/objects/index.js");
 const _basic_rule_config_1 = __webpack_require__(/*! ./_basic_rule_config */ "./node_modules/@abaplint/core/build/src/rules/_basic_rule_config.js");
 const _irule_1 = __webpack_require__(/*! ./_irule */ "./node_modules/@abaplint/core/build/src/rules/_irule.js");
+const objects_1 = __webpack_require__(/*! ../objects */ "./node_modules/@abaplint/core/build/src/objects/index.js");
 class GlobalClassConf extends _basic_rule_config_1.BasicRuleConfig {
 }
 exports.GlobalClassConf = GlobalClassConf;
@@ -65445,7 +65451,9 @@ class GlobalClass extends _abap_rule_1.ABAPRule {
 
 * global classes must be global definitions
 
-* global interfaces must be global definitions`,
+* global interfaces must be global definitions
+
+* global FOR TESTING, must have CATEGORY = 05 in the XML`,
             tags: [_irule_1.RuleTag.Syntax],
         };
     }
@@ -65470,6 +65478,18 @@ class GlobalClass extends _abap_rule_1.ABAPRule {
                 const issue = issue_1.Issue.atIdentifier(definition.identifier, "Class must be local", this.getMetadata().key, this.conf.severity);
                 output.push(issue);
             }
+            if (definition.isGlobal && obj instanceof Objects.Class) {
+                if (definition.isForTesting === true && obj instanceof Objects.Class && obj.getCategory() !== objects_1.ClassCategory.Test) {
+                    const message = "Class is marked as FOR TESTING, but CATEGORY is not 05 in the XML";
+                    const issue = issue_1.Issue.atIdentifier(definition.identifier, message, this.getMetadata().key, this.conf.severity);
+                    output.push(issue);
+                }
+                else if (definition.isForTesting === false && obj instanceof Objects.Class && obj.getCategory() === objects_1.ClassCategory.Test) {
+                    const message = "Class has CATEGORY 05 in the XML, but is not marked as FOR TESTING";
+                    const issue = issue_1.Issue.atIdentifier(definition.identifier, message, this.getMetadata().key, this.conf.severity);
+                    output.push(issue);
+                }
+            }
         }
         for (const impl of file.getInfo().listClassImplementations()) {
             if (file.getFilename().match(/\.clas\.abap$/)

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@abaplint/cli",
-    "version": "2.115.21",
+    "version": "2.115.23",
     "description": "abaplint - Command Line Interface",
     "funding": "https://github.com/sponsors/larshp",
     "bin": {
@@ -38,7 +38,7 @@
     },
     "homepage": "https://abaplint.org",
     "devDependencies": {
-        "@abaplint/core": "^2.115.21",
+        "@abaplint/core": "^2.115.23",
         "@types/chai": "^4.3.20",
         "@types/minimist": "^1.2.5",
         "@types/mocha": "^10.0.10",