@abaplint/cli 2.115.14 → 2.115.15

package/build/cli.js

@@ -23308,8 +23308,25 @@ class Procedural {
         }
         return undefined;
     }
+    findFunctionGroupScope(fg) {
+        var _a, _b, _c;
+        for (const module of fg.getModules()) {
+            if (module.isGlobalParameters() === false) {
+                continue;
+            }
+            // console.dir(fg.getSequencedFiles());
+            const fmFile = fg.getSequencedFiles().find((f) => { return f.getFilename().endsWith(".fugr." + module.getName().toLowerCase().replace(/\//g, "#") + ".abap"); });
+            if (fmFile === undefined) {
+                continue;
+            }
+            const nameToken = (_c = (_b = (_a = fmFile.getStructure()) === null || _a === void 0 ? void 0 : _a.findFirstStatement(Statements.FunctionModule)) === null || _b === void 0 ? void 0 : _b.findFirstExpression(Expressions.Field)) === null || _c === void 0 ? void 0 : _c.getFirstToken();
+            if (nameToken === undefined) {
+                continue;
+            }
+            this.addFunctionScope(module, nameToken, fmFile.getFilename(), true);
+        }
+    }
     findFunctionScope(obj, node, filename) {
-        var _a, _b, _c, _d, _e;
         if (!(obj instanceof objects_1.FunctionGroup)) {
             throw new Error("findFunctionScope, expected function group input");
         }
@@ -23320,6 +23337,13 @@ class Procedural {
         if (definition === undefined) {
             throw new Error("Function module definition \"" + name + "\" not found");
         }
+        if (definition.isGlobalParameters() === true) {
+            return; // already added at global level
+        }
+        this.addFunctionScope(definition, nameToken, filename);
+    }
+    addFunctionScope(definition, nameToken, filename, ignoreIfAlreadyExists = false) {
+        var _a, _b, _c, _d, _e;
         const ddic = new ddic_1.DDIC(this.reg);
         const allNames = new Set();
         for (const param of definition.getParameters()) {
@@ -23405,7 +23429,15 @@ class Procedural {
             }
             else {
                 const type = new _typed_identifier_1.TypedIdentifier(nameToken, filename, found);
-                this.scope.addNamedIdentifier(param.name, type);
+                if (ignoreIfAlreadyExists === true) {
+                    const exists = this.scope.findVariable(param.name);
+                    if (exists === undefined) {
+                        this.scope.addNamedIdentifier(param.name, type);
+                    }
+                }
+                else {
+                    this.scope.addNamedIdentifier(param.name, type);
+                }
                 allNames.add(param.name.toUpperCase());
             }
         }
@@ -36534,6 +36566,9 @@ class SyntaxLogic {
                     stype = _scope_type_1.ScopeType.FunctionGroup;
                 }
                 this.scope.push(stype, this.object.getName(), new position_1.Position(1, 1), main.getFilename());
+                if (this.object instanceof objects_1.FunctionGroup) {
+                    this.helpers.proc.findFunctionGroupScope(this.object);
+                }
             }
         }
         else if (this.object instanceof objects_1.TypePool) {
@@ -40230,6 +40265,9 @@ class FunctionModuleDefinition {
     getName() {
         return this.name;
     }
+    isGlobalParameters() {
+        return this.globalParameters;
+    }
     ///////////////
     parse(data) {
         if (data.FUNCNAME === undefined) {
@@ -40238,6 +40276,7 @@ class FunctionModuleDefinition {
         this.name = data.FUNCNAME;
         this.description = data.SHORT_TEXT;
         this.parameters = [];
+        this.globalParameters = data.GLOBAL_FLAG === "X";
         this.moduleType = FunctionModuleType.regular;
         if (data.REMOTE_CALL === "R") {
             this.moduleType = FunctionModuleType.remote;
@@ -55335,7 +55374,7 @@ class Registry {
     }
     static abaplintVersion() {
         // magic, see build script "version.sh"
-        return "2.115.14";
+        return "2.115.15";
     }
     getDDICReferences() {
         return this.ddicReferences;
@@ -64389,6 +64428,68 @@ exports.Exporting = Exporting;
 
 /***/ },
 
+/***/ "./node_modules/@abaplint/core/build/src/rules/fm_global_parameters_obsolete.js"
+/*!**************************************************************************************!*\
+  !*** ./node_modules/@abaplint/core/build/src/rules/fm_global_parameters_obsolete.js ***!
+  \**************************************************************************************/
+(__unused_webpack_module, exports, __webpack_require__) {
+
+"use strict";
+
+Object.defineProperty(exports, "__esModule", ({ value: true }));
+exports.FMGlobalParametersObsolete = exports.FMGlobalParametersObsoleteConf = void 0;
+const issue_1 = __webpack_require__(/*! ../issue */ "./node_modules/@abaplint/core/build/src/issue.js");
+const Objects = __webpack_require__(/*! ../objects */ "./node_modules/@abaplint/core/build/src/objects/index.js");
+const _basic_rule_config_1 = __webpack_require__(/*! ./_basic_rule_config */ "./node_modules/@abaplint/core/build/src/rules/_basic_rule_config.js");
+const position_1 = __webpack_require__(/*! ../position */ "./node_modules/@abaplint/core/build/src/position.js");
+class FMGlobalParametersObsoleteConf extends _basic_rule_config_1.BasicRuleConfig {
+}
+exports.FMGlobalParametersObsoleteConf = FMGlobalParametersObsoleteConf;
+class FMGlobalParametersObsolete {
+    constructor() {
+        this.conf = new FMGlobalParametersObsoleteConf();
+    }
+    getMetadata() {
+        return {
+            key: "fm_global_parameters_obsolete",
+            title: "FM Global Parameters Obsolete",
+            shortDescription: `Check for function modules with global parameteers`,
+            extendedInformation: `https://help.sap.com/doc/abapdocu_750_index_htm/7.50/en-US/abenglobal_parameters_obsolete.htm`,
+            tags: [],
+        };
+    }
+    initialize(_reg) {
+        return this;
+    }
+    getConfig() {
+        return this.conf;
+    }
+    setConfig(conf) {
+        this.conf = conf;
+    }
+    run(obj) {
+        if (!(obj instanceof Objects.FunctionGroup)) {
+            return [];
+        }
+        const issues = [];
+        for (const module of obj.getModules()) {
+            if (module.isGlobalParameters() === true) {
+                const file = obj.getMainABAPFile();
+                if (file === undefined) {
+                    continue;
+                }
+                const message = `Function Module "${module.getName()}" uses obsolete global parameters`;
+                issues.push(issue_1.Issue.atPosition(file, new position_1.Position(1, 1), message, this.getMetadata().key, this.conf.severity));
+            }
+        }
+        return issues;
+    }
+}
+exports.FMGlobalParametersObsolete = FMGlobalParametersObsolete;
+//# sourceMappingURL=fm_global_parameters_obsolete.js.map
+
+/***/ },
+
 /***/ "./node_modules/@abaplint/core/build/src/rules/forbidden_identifier.js"
 /*!*****************************************************************************!*\
   !*** ./node_modules/@abaplint/core/build/src/rules/forbidden_identifier.js ***!
@@ -66759,6 +66860,7 @@ __exportStar(__webpack_require__(/*! ./empty_structure */ "./node_modules/@abapl
 __exportStar(__webpack_require__(/*! ./exit_or_check */ "./node_modules/@abaplint/core/build/src/rules/exit_or_check.js"), exports);
 __exportStar(__webpack_require__(/*! ./expand_macros */ "./node_modules/@abaplint/core/build/src/rules/expand_macros.js"), exports);
 __exportStar(__webpack_require__(/*! ./exporting */ "./node_modules/@abaplint/core/build/src/rules/exporting.js"), exports);
+__exportStar(__webpack_require__(/*! ./fm_global_parameters_obsolete */ "./node_modules/@abaplint/core/build/src/rules/fm_global_parameters_obsolete.js"), exports);
 __exportStar(__webpack_require__(/*! ./forbidden_identifier */ "./node_modules/@abaplint/core/build/src/rules/forbidden_identifier.js"), exports);
 __exportStar(__webpack_require__(/*! ./forbidden_pseudo_and_pragma */ "./node_modules/@abaplint/core/build/src/rules/forbidden_pseudo_and_pragma.js"), exports);
 __exportStar(__webpack_require__(/*! ./forbidden_void_type */ "./node_modules/@abaplint/core/build/src/rules/forbidden_void_type.js"), exports);
@@ -66772,6 +66874,7 @@ __exportStar(__webpack_require__(/*! ./identical_conditions */ "./node_modules/@
 __exportStar(__webpack_require__(/*! ./identical_contents */ "./node_modules/@abaplint/core/build/src/rules/identical_contents.js"), exports);
 __exportStar(__webpack_require__(/*! ./identical_descriptions */ "./node_modules/@abaplint/core/build/src/rules/identical_descriptions.js"), exports);
 __exportStar(__webpack_require__(/*! ./identical_form_names */ "./node_modules/@abaplint/core/build/src/rules/identical_form_names.js"), exports);
+__exportStar(__webpack_require__(/*! ./identical_move */ "./node_modules/@abaplint/core/build/src/rules/identical_move.js"), exports);
 __exportStar(__webpack_require__(/*! ./if_in_if */ "./node_modules/@abaplint/core/build/src/rules/if_in_if.js"), exports);
 __exportStar(__webpack_require__(/*! ./implement_methods */ "./node_modules/@abaplint/core/build/src/rules/implement_methods.js"), exports);
 __exportStar(__webpack_require__(/*! ./implicit_start_of_selection */ "./node_modules/@abaplint/core/build/src/rules/implicit_start_of_selection.js"), exports);
@@ -66783,7 +66886,6 @@ __exportStar(__webpack_require__(/*! ./intf_referencing_clas */ "./node_modules/
 __exportStar(__webpack_require__(/*! ./invalid_table_index */ "./node_modules/@abaplint/core/build/src/rules/invalid_table_index.js"), exports);
 __exportStar(__webpack_require__(/*! ./keep_single_parameter_on_one_line */ "./node_modules/@abaplint/core/build/src/rules/keep_single_parameter_on_one_line.js"), exports);
 __exportStar(__webpack_require__(/*! ./keyword_case */ "./node_modules/@abaplint/core/build/src/rules/keyword_case.js"), exports);
-__exportStar(__webpack_require__(/*! ./identical_move */ "./node_modules/@abaplint/core/build/src/rules/identical_move.js"), exports);
 __exportStar(__webpack_require__(/*! ./line_break_multiple_parameters */ "./node_modules/@abaplint/core/build/src/rules/line_break_multiple_parameters.js"), exports);
 __exportStar(__webpack_require__(/*! ./line_break_style */ "./node_modules/@abaplint/core/build/src/rules/line_break_style.js"), exports);
 __exportStar(__webpack_require__(/*! ./line_length */ "./node_modules/@abaplint/core/build/src/rules/line_length.js"), exports);

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@abaplint/cli",
-    "version": "2.115.14",
+    "version": "2.115.15",
     "description": "abaplint - Command Line Interface",
     "funding": "https://github.com/sponsors/larshp",
     "bin": {
@@ -38,7 +38,7 @@
     },
     "homepage": "https://abaplint.org",
     "devDependencies": {
-        "@abaplint/core": "^2.115.14",
+        "@abaplint/core": "^2.115.15",
         "@types/chai": "^4.3.20",
         "@types/minimist": "^1.2.5",
         "@types/mocha": "^10.0.10",