@abaplint/cli 2.113.7 → 2.113.9

package/build/cli.js

@@ -32045,6 +32045,7 @@ const _typed_identifier_1 = __webpack_require__(/*! ../../types/_typed_identifie
 const basic_1 = __webpack_require__(/*! ../../types/basic */ "./node_modules/@abaplint/core/build/src/abap/types/basic/index.js");
 const basic_types_1 = __webpack_require__(/*! ../basic_types */ "./node_modules/@abaplint/core/build/src/abap/5_syntax/basic_types.js");
 const _syntax_input_1 = __webpack_require__(/*! ../_syntax_input */ "./node_modules/@abaplint/core/build/src/abap/5_syntax/_syntax_input.js");
+const tokens_1 = __webpack_require__(/*! ../../1_lexer/tokens */ "./node_modules/@abaplint/core/build/src/abap/1_lexer/tokens/index.js");
 class Parameter {
     runSyntax(node, input) {
         var _a;
@@ -32054,19 +32055,24 @@ class Parameter {
             input.issues.push((0, _syntax_input_1.syntaxIssue)(input, node.getFirstToken(), message));
             return;
         }
+        else if (nameToken === undefined) {
+            return;
+        }
         if (node.findDirectTokenByText("RADIOBUTTON") && node.findDirectTokenByText("LENGTH")) {
             const message = "RADIOBUTTON and LENGTH not possible together";
             input.issues.push((0, _syntax_input_1.syntaxIssue)(input, node.getFirstToken(), message));
             return;
         }
         const bfound = new basic_types_1.BasicTypes(input).parseType(node);
-        if (nameToken && bfound) {
+        if (bfound) {
             input.scope.addIdentifier(new _typed_identifier_1.TypedIdentifier(nameToken, input.filename, bfound));
-            return;
         }
-        if (nameToken) {
+        else {
             input.scope.addIdentifier(new _typed_identifier_1.TypedIdentifier(nameToken, input.filename, new basic_1.UnknownType("Parameter, fallback")));
         }
+        const magicName = "%_" + nameToken.getStr() + "_%_app_%";
+        const magicToken = new tokens_1.Identifier(nameToken.getStart(), magicName);
+        input.scope.addIdentifier(new _typed_identifier_1.TypedIdentifier(magicToken, input.filename, new basic_1.VoidType("PARAMETER magic")));
     }
 }
 exports.Parameter = Parameter;
@@ -32727,12 +32733,18 @@ exports.SelectionScreen = void 0;
 const Expressions = __webpack_require__(/*! ../../2_statements/expressions */ "./node_modules/@abaplint/core/build/src/abap/2_statements/expressions/index.js");
 const _typed_identifier_1 = __webpack_require__(/*! ../../types/_typed_identifier */ "./node_modules/@abaplint/core/build/src/abap/types/_typed_identifier.js");
 const basic_1 = __webpack_require__(/*! ../../types/basic */ "./node_modules/@abaplint/core/build/src/abap/types/basic/index.js");
+const _syntax_input_1 = __webpack_require__(/*! ../_syntax_input */ "./node_modules/@abaplint/core/build/src/abap/5_syntax/_syntax_input.js");
 class SelectionScreen {
     runSyntax(node, input) {
         const field = node.findFirstExpression(Expressions.InlineField);
         if (field === undefined) {
             return;
         }
+        if (field.getFirstToken().getStr().length > 8) {
+            const message = "SELECTION-SCREEN name too long, " + field.getFirstToken().getStr();
+            input.issues.push((0, _syntax_input_1.syntaxIssue)(input, field.getFirstToken(), message));
+            return;
+        }
         const name = field.getFirstToken();
         const concat = node.concatTokens().toUpperCase();
         if (concat.includes("BEGIN OF TABBED BLOCK")) {
@@ -32772,6 +32784,7 @@ const basic_1 = __webpack_require__(/*! ../../types/basic */ "./node_modules/@ab
 const basic_types_1 = __webpack_require__(/*! ../basic_types */ "./node_modules/@abaplint/core/build/src/abap/5_syntax/basic_types.js");
 const dynamic_1 = __webpack_require__(/*! ../expressions/dynamic */ "./node_modules/@abaplint/core/build/src/abap/5_syntax/expressions/dynamic.js");
 const _syntax_input_1 = __webpack_require__(/*! ../_syntax_input */ "./node_modules/@abaplint/core/build/src/abap/5_syntax/_syntax_input.js");
+const tokens_1 = __webpack_require__(/*! ../../1_lexer/tokens */ "./node_modules/@abaplint/core/build/src/abap/1_lexer/tokens/index.js");
 class SelectOption {
     runSyntax(node, input) {
         var _a;
@@ -32781,12 +32794,15 @@ class SelectOption {
             input.issues.push((0, _syntax_input_1.syntaxIssue)(input, nameToken, message));
             return;
         }
+        else if (nameToken === undefined) {
+            return;
+        }
         for (const d of node.findDirectExpressions(Expressions.Dynamic)) {
             new dynamic_1.Dynamic().runSyntax(d, input);
         }
         const nameExpression = node.findFirstExpression(Expressions.FieldChain);
         let found = new basic_types_1.BasicTypes(input).resolveLikeName(nameExpression);
-        if (found && nameToken) {
+        if (found) {
             if (found instanceof basic_1.StructureType) {
                 let length = 0;
                 for (const c of found.getComponents()) {
@@ -32808,11 +32824,13 @@ class SelectOption {
                 { name: "HIGH", type: found },
             ]);
             input.scope.addIdentifier(new _typed_identifier_1.TypedIdentifier(nameToken, input.filename, new basic_1.TableType(stru, { withHeader: true, keyType: basic_1.TableKeyType.default })));
-            return;
         }
-        if (nameToken) {
+        else {
             input.scope.addIdentifier(new _typed_identifier_1.TypedIdentifier(nameToken, input.filename, new basic_1.UnknownType("Select option, fallback")));
         }
+        const magicName = "%_" + nameToken.getStr() + "_%_app_%";
+        const magicToken = new tokens_1.Identifier(nameToken.getStart(), magicName);
+        input.scope.addIdentifier(new _typed_identifier_1.TypedIdentifier(magicToken, input.filename, new basic_1.VoidType("SELECT-OPTION magic")));
     }
 }
 exports.SelectOption = SelectOption;
@@ -50142,7 +50160,7 @@ class RenameGlobalClass {
         }
         const main = obj.getMainABAPFile();
         if (main === undefined) {
-            throw new Error("Main file not found");
+            throw new Error(`Main file not found, ${obj.getType()} ${obj.getName()}`);
         }
         let changes = [];
         // todo, this is actually the same as "id" ?
@@ -52714,7 +52732,7 @@ class Registry {
     }
     static abaplintVersion() {
         // magic, see build script "version.sh"
-        return "2.113.7";
+        return "2.113.9";
     }
     getDDICReferences() {
         return this.ddicReferences;
@@ -54281,8 +54299,9 @@ Only works if the target version is 740sp05 or above`,
             badExample: `DELETE foo FROM bar.
 MODIFY foo FROM bar.`,
             goodExample: `DELETE foo FROM @bar.
-MODIFY TABLE foo FROM bar.
-MODIFY zfoo FROM @wa.`,
+DELETE TABLE itab FROM 2.
+MODIFY zfoo FROM @wa.
+MODIFY TABLE foo FROM bar.`,
         };
     }
     getMessage() {
@@ -64894,7 +64913,7 @@ https://docs.abapopenchecks.org/checks/16/`,
                 const position = new position_1.Position(i + 1, column);
                 // merge punc into previous row
                 let rowContent = rows[i].trim();
-                // if reported row contains a paranthesis, prefix with space if needed
+                // if reported row contains parentheses, prefix with space if needed
                 if (rowContent.length > 1 && !rows[i - 1].endsWith(" ") && !rows[i - 1].endsWith(" \r")) {
                     rowContent = " " + rowContent;
                 }
@@ -64904,7 +64923,10 @@ https://docs.abapopenchecks.org/checks/16/`,
                 }
                 const startPos = new position_1.Position(i, rows[i - 1].length + 1 + offset);
                 const endPos = new position_1.Position(i + 1, rows[i].length + 1);
-                const fix = edit_helper_1.EditHelper.replaceRange(file, startPos, endPos, rowContent);
+                let fix = edit_helper_1.EditHelper.replaceRange(file, startPos, endPos, rowContent);
+                if (rows[i - 1] === undefined || rows[i - 1].indexOf("*") === 0 || rows[i - 1].includes(`"`)) {
+                    fix = undefined;
+                }
                 const issue = issue_1.Issue.atPosition(file, position, this.getMessage(), this.getMetadata().key, this.conf.severity, fix);
                 issues.push(issue);
             }

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@abaplint/cli",
-    "version": "2.113.7",
+    "version": "2.113.9",
     "description": "abaplint - Command Line Interface",
     "funding": "https://github.com/sponsors/larshp",
     "bin": {
@@ -38,12 +38,12 @@
     },
     "homepage": "https://abaplint.org",
     "devDependencies": {
-        "@abaplint/core": "^2.113.7",
+        "@abaplint/core": "^2.113.9",
         "@types/chai": "^4.3.19",
         "@types/glob": "^8.1.0",
         "@types/minimist": "^1.2.5",
-        "@types/mocha": "^10.0.7",
-        "@types/node": "^22.5.4",
+        "@types/mocha": "^10.0.8",
+        "@types/node": "^22.5.5",
         "@types/progress": "^2.0.7",
         "chai": "^4.5.0",
         "chalk": "^5.3.0",
@@ -54,7 +54,7 @@
         "minimist": "^1.2.8",
         "mocha": "^10.7.3",
         "progress": "^2.0.3",
-        "typescript": "^5.5.4",
+        "typescript": "^5.6.2",
         "webpack": "^5.94.0",
         "webpack-cli": "^5.1.4",
         "xml-js": "^1.6.11"