@abaplint/cli 2.113.219 → 2.113.221

package/build/cli.js

@@ -7608,7 +7608,7 @@ const combi_1 = __webpack_require__(/*! ../combi */ "./node_modules/@abaplint/co
 const tokens_1 = __webpack_require__(/*! ../../1_lexer/tokens */ "./node_modules/@abaplint/core/build/src/abap/1_lexer/tokens/index.js");
 class ReportName extends combi_1.Expression {
     getRunnable() {
-        return (0, combi_1.seq)((0, combi_1.regex)(/^[\w/$%]+$/), (0, combi_1.star)((0, combi_1.seq)((0, combi_1.tok)(tokens_1.Dash), (0, combi_1.regex)(/^\w+$/))));
+        return (0, combi_1.seq)((0, combi_1.regex)(/^[\w/$%&]+$/), (0, combi_1.star)((0, combi_1.seq)((0, combi_1.tok)(tokens_1.Dash), (0, combi_1.regex)(/^\w+$/))));
     }
 }
 exports.ReportName = ReportName;
@@ -8166,13 +8166,14 @@ const sql_field_name_1 = __webpack_require__(/*! ./sql_field_name */ "./node_mod
 const sql_source_1 = __webpack_require__(/*! ./sql_source */ "./node_modules/@abaplint/core/build/src/abap/2_statements/expressions/sql_source.js");
 class SQLCase extends combi_1.Expression {
     getRunnable() {
+        const abap = (0, combi_1.seq)((0, combi_1.tok)(tokens_1.WAt), _1.SimpleFieldChain2);
         const field = (0, combi_1.altPrio)(_1.SQLAggregation, SQLCase, _1.SQLFunction, _1.SQLPath, sql_field_name_1.SQLFieldName, constant_1.Constant);
         const sub = (0, combi_1.seq)((0, combi_1.altPrio)("+", "-", "*", "/", "&&"), (0, combi_1.optPrio)((0, combi_1.tok)(tokens_1.WParenLeftW)), field, (0, combi_1.optPrio)((0, combi_1.tok)(tokens_1.WParenRightW)));
         const sourc = (0, combi_1.altPrio)(SQLCase, _1.SQLAggregation, _1.SQLFunction, sql_source_1.SQLSource, constant_1.Constant);
-        const val = (0, combi_1.altPrio)(sql_cond_1.SQLCond, constant_1.Constant, (0, combi_1.seq)((0, combi_1.tok)(tokens_1.WAt), _1.SimpleSource3));
+        const val = (0, combi_1.altPrio)(sql_cond_1.SQLCond, constant_1.Constant, abap);
         const when = (0, combi_1.seq)("WHEN", val, "THEN", sourc, (0, combi_1.starPrio)(sub));
         const els = (0, combi_1.seq)("ELSE", sourc);
-        return (0, combi_1.ver)(version_1.Version.v740sp05, (0, combi_1.seq)("CASE", (0, combi_1.opt)(sql_field_name_1.SQLFieldName), (0, combi_1.plusPrio)(when), (0, combi_1.optPrio)(els), "END"));
+        return (0, combi_1.ver)(version_1.Version.v740sp05, (0, combi_1.seq)("CASE", (0, combi_1.opt)((0, combi_1.altPrio)(sql_field_name_1.SQLFieldName, abap)), (0, combi_1.plusPrio)(when), (0, combi_1.optPrio)(els), "END"));
     }
 }
 exports.SQLCase = SQLCase;
@@ -15209,7 +15210,8 @@ class ModifyEntities {
         const updateFrom = (0, combi_1.seq)("UPDATE FROM", expressions_1.Source, (0, combi_1.opt)(relating));
         const deleteFrom = (0, combi_1.seq)("DELETE FROM", expressions_1.Source);
         const updateFields = (0, combi_1.seq)("UPDATE", fieldsWith);
-        const operation = (0, combi_1.alt)((0, combi_1.seq)("UPDATE SET FIELDS WITH", expressions_1.Source), (0, combi_1.seq)("CREATE SET FIELDS WITH", expressions_1.Source), updateFields, deleteFrom, updateFrom, create, execute, (0, combi_1.seq)("CREATE", (0, combi_1.opt)(by), (0, combi_1.optPrio)("AUTO FILL CID"), (0, combi_1.altPrio)(withh, fieldsWith)));
+        const updateSetFields = (0, combi_1.seq)("UPDATE SET FIELDS WITH", expressions_1.Source);
+        const operation = (0, combi_1.alt)(updateSetFields, (0, combi_1.seq)("CREATE SET FIELDS WITH", expressions_1.Source), updateFields, deleteFrom, updateFrom, create, execute, (0, combi_1.seq)("CREATE", (0, combi_1.opt)(by), (0, combi_1.optPrio)("AUTO FILL CID"), (0, combi_1.altPrio)(withh, fieldsWith)));
         const failed = (0, combi_1.seq)("FAILED", expressions_1.Target);
         const result = (0, combi_1.seq)("RESULT", expressions_1.Target);
         const mapped = (0, combi_1.seq)("MAPPED", expressions_1.Target);
@@ -15219,7 +15221,7 @@ class ModifyEntities {
         const create2 = (0, combi_1.seq)("CREATE", fieldsWith, (0, combi_1.opt)((0, combi_1.seq)("CREATE BY", expressions_1.AssociationName, fieldsWith)));
         const create3 = (0, combi_1.seq)("CREATE BY", expressions_1.AssociationName, fieldsWith);
         const create4 = (0, combi_1.seq)("CREATE FROM", expressions_1.Source, (0, combi_1.plus)((0, combi_1.seq)("CREATE BY", expressions_1.AssociationName, "FROM", expressions_1.Source)));
-        const entity = (0, combi_1.seq)("ENTITY", (0, combi_1.opt)("IN LOCAL MODE"), (0, combi_1.alt)(expressions_1.NamespaceSimpleName, expressions_1.EntityAssociation), (0, combi_1.alt)(execute, create, updateFields, deleteFrom, updateFrom, create2, create3, create4));
+        const entity = (0, combi_1.seq)("ENTITY", (0, combi_1.opt)("IN LOCAL MODE"), (0, combi_1.alt)(expressions_1.NamespaceSimpleName, expressions_1.EntityAssociation), (0, combi_1.alt)(execute, create, updateFields, deleteFrom, updateSetFields, updateFrom, create2, create3, create4));
         return (0, combi_1.ver)(version_1.Version.v754, (0, combi_1.seq)("MODIFY", (0, combi_1.alt)(entities, entity), end));
     }
 }
@@ -16161,7 +16163,8 @@ class ReadEntities {
         const result = (0, combi_1.seq)("RESULT", expressions_1.Target);
         const failed = (0, combi_1.seq)("FAILED", expressions_1.Target);
         const reported = (0, combi_1.seq)("REPORTED", expressions_1.Target);
-        const entity = (0, combi_1.seq)("ENTITY", expressions_1.NamespaceSimpleName, (0, combi_1.opt)((0, combi_1.seq)("BY", expressions_1.AssociationName)), (0, combi_1.alt)(fields, from, all), (0, combi_1.optPrio)(result));
+        const foo = (0, combi_1.seq)((0, combi_1.opt)((0, combi_1.seq)("BY", expressions_1.AssociationName)), (0, combi_1.alt)(fields, from, all), (0, combi_1.optPrio)(result));
+        const entity = (0, combi_1.seq)("ENTITY", expressions_1.NamespaceSimpleName, (0, combi_1.plus)(foo));
         const s = (0, combi_1.seq)("ENTITIES OF", expressions_1.NamespaceSimpleName, (0, combi_1.opt)("IN LOCAL MODE"), (0, combi_1.plus)(entity), (0, combi_1.optPrio)((0, combi_1.seq)("LINK", expressions_1.Target)), (0, combi_1.optPrio)((0, combi_1.per)(failed, reported)));
         const byall = (0, combi_1.seq)("BY", expressions_1.AssociationName, all);
         const by = (0, combi_1.seq)("BY", expressions_1.AssociationName, fields);
@@ -17604,11 +17607,13 @@ class Submit {
         const cover = (0, combi_1.seq)("SAP COVER PAGE", expressions_1.Source);
         const copies = (0, combi_1.seq)("COPIES", expressions_1.Source);
         const datasetExpiration = (0, combi_1.seq)("DATASET EXPIRATION", expressions_1.Source);
+        const coverText = (0, combi_1.seq)("COVER TEXT", expressions_1.Source);
+        const listName = (0, combi_1.seq)("LIST NAME", expressions_1.Source);
         const keep = (0, combi_1.seq)("KEEP IN SPOOL", expressions_1.Source);
         const imm = (0, combi_1.seq)("IMMEDIATELY", expressions_1.Source);
         const dest = (0, combi_1.seq)("DESTINATION", expressions_1.Source);
         const language = (0, combi_1.seq)("LANGUAGE", expressions_1.Source);
-        const perm = (0, combi_1.per)((0, combi_1.plus)(awith), selectionTable, (0, combi_1.plus)(awith), spool, lineSize, lineCount, archive, user, sset, ssetp, keep, cover, imm, layout, dest, language, free, newList, uss, copies, datasetExpiration, "TO SAP-SPOOL", "WITHOUT SPOOL DYNPRO", "VIA SELECTION-SCREEN", exporting, expressions_1.AndReturn, job);
+        const perm = (0, combi_1.per)((0, combi_1.plus)(awith), selectionTable, (0, combi_1.plus)(awith), spool, lineSize, lineCount, archive, user, sset, ssetp, keep, cover, imm, layout, dest, coverText, listName, language, free, newList, uss, copies, datasetExpiration, "TO SAP-SPOOL", "WITHOUT SPOOL DYNPRO", "VIA SELECTION-SCREEN", exporting, expressions_1.AndReturn, job);
         const ret = (0, combi_1.seq)("SUBMIT", prog, (0, combi_1.opt)(perm));
         return (0, combi_1.verNot)(version_1.Version.Cloud, ret);
     }
@@ -21375,7 +21380,9 @@ class BuiltIn {
         // https://help.sap.com/doc/abapdocu_751_index_htm/7.51/en-us/abennews-610-system.htm
         const id3 = new tokens_1.Identifier(new position_1.Position(this.row++, 1), "sy-repid");
         const syrepid = new _typed_identifier_1.TypedIdentifier(id3, BuiltIn.filename, new basic_1.CharacterType(40, { qualifiedName: "sy-repid" }), ["read_only" /* IdentifierMeta.ReadOnly */, "built-in" /* IdentifierMeta.BuiltIn */]);
-        return [sy, syst, syrepid];
+        const id4 = new tokens_1.Identifier(new position_1.Position(this.row++, 1), "syst-repid");
+        const systrepid = new _typed_identifier_1.TypedIdentifier(id4, BuiltIn.filename, new basic_1.CharacterType(40, { qualifiedName: "syst-repid" }), ["read_only" /* IdentifierMeta.ReadOnly */, "built-in" /* IdentifierMeta.BuiltIn */]);
+        return [sy, syst, syrepid, systrepid];
     }
     buildConstant(name, type, value) {
         const id = new tokens_1.Identifier(new position_1.Position(this.row++, 1), name);
@@ -24395,7 +24402,7 @@ class BasicTypes {
             const name = typename.concatTokens();
             const type = (_d = this.input.scope.getDDIC().lookupDDLS(name)) === null || _d === void 0 ? void 0 : _d.type;
             if (type) {
-                return new Types.TableType(basic_1.VoidType.get("RapTodo"), options);
+                return new Types.TableType(basic_1.VoidType.get("RAP-TODO"), options);
             }
             else if (this.input.scope.getDDIC().inErrorNamespace(name)) {
                 return new Types.UnknownType(`DDLS ${name} not found`);
@@ -30682,7 +30689,7 @@ class ClassImplementation {
         }
         else {
             // todo: instead of the void type, do proper typing, ie. only empty constructor method
-            input.scope.addIdentifier(new _typed_identifier_1.TypedIdentifier(new tokens_1.Identifier(new position_1.Position(1, 1), "super"), _builtin_1.BuiltIn.filename, basic_1.VoidType.get("noSuper")));
+            input.scope.addIdentifier(new _typed_identifier_1.TypedIdentifier(new tokens_1.Identifier(new position_1.Position(1, 1), "super"), _builtin_1.BuiltIn.filename, basic_1.VoidType.get("noSuperClass")));
         }
         input.scope.addIdentifier(new _typed_identifier_1.TypedIdentifier(new tokens_1.Identifier(new position_1.Position(1, 1), "me"), _builtin_1.BuiltIn.filename, new basic_1.ObjectReferenceType(classDefinition)));
         helper.addAliasedAttributes(classDefinition); // todo, this is not correct, take care of instance vs static
@@ -41145,7 +41152,7 @@ const cds_integer_1 = __webpack_require__(/*! ./cds_integer */ "./node_modules/@
 class CDSArithmetics extends combi_1.Expression {
     getRunnable() {
         const name = (0, combi_1.seq)(_1.CDSName, (0, combi_1.optPrio)((0, combi_1.seq)(".", _1.CDSName)));
-        const val = (0, combi_1.altPrio)(cds_integer_1.CDSInteger, _1.CDSFunction, _1.CDSCase, _1.CDSCast, _1.CDSString, name);
+        const val = (0, combi_1.altPrio)(cds_integer_1.CDSInteger, _1.CDSFunction, _1.CDSCase, _1.CDSCast, _1.CDSString, _1.CDSAggregate, name);
         const operator = (0, combi_1.altPrio)("+", "-", "*", "/");
         const operatorValue = (0, combi_1.seq)(operator, val);
         const paren = (0, combi_1.seq)("(", val, (0, combi_1.plusPrio)(operatorValue), ")");
@@ -41270,7 +41277,8 @@ const combi_1 = __webpack_require__(/*! ../../abap/2_statements/combi */ "./node
 class CDSCast extends combi_1.Expression {
     getRunnable() {
         const name = (0, combi_1.seq)(_1.CDSName, (0, combi_1.starPrio)((0, combi_1.seq)(".", _1.CDSName)));
-        return (0, combi_1.seq)("CAST", "(", (0, combi_1.altPrio)(_1.CDSFunction, _1.CDSCase, _1.CDSAggregate, _1.CDSArithmetics, CDSCast, _1.CDSString, name), "AS", _1.CDSType, (0, combi_1.optPrio)((0, combi_1.seq)("PRESERVING", "TYPE")), ")");
+        const first = (0, combi_1.altPrio)(_1.CDSFunction, _1.CDSCase, _1.CDSAggregate, _1.CDSArithmetics, CDSCast, _1.CDSString, _1.CDSInteger, name);
+        return (0, combi_1.seq)("CAST", "(", first, "AS", _1.CDSType, (0, combi_1.optPrio)((0, combi_1.seq)("PRESERVING", "TYPE")), ")");
     }
 }
 exports.CDSCast = CDSCast;
@@ -41586,7 +41594,7 @@ const combi_1 = __webpack_require__(/*! ../../abap/2_statements/combi */ "./node
 class CDSFunctionInput extends combi_1.Expression {
     getRunnable() {
         const qualified = (0, combi_1.seq)(_1.CDSName, (0, combi_1.opt)(_1.CDSParameters), (0, combi_1.starPrio)((0, combi_1.seq)(".", _1.CDSName, (0, combi_1.opt)(_1.CDSParameters))));
-        const input = (0, combi_1.altPrio)(_1.CDSCast, _1.CDSFunction, _1.CDSArithmetics, _1.CDSCase, _1.CDSString, qualified, _1.CDSInteger);
+        const input = (0, combi_1.altPrio)(_1.CDSArithmetics, _1.CDSCast, _1.CDSFunction, _1.CDSCase, _1.CDSString, qualified, _1.CDSInteger);
         return input;
     }
 }
@@ -41678,7 +41686,7 @@ class CDSJoin extends combi_1.Expression {
     getRunnable() {
         const cond = (0, combi_1.seq)(_1.CDSSource, "ON", cds_condition_1.CDSCondition);
         const foo = (0, combi_1.altPrio)((0, combi_1.seq)("(", cond, ")"), cond);
-        return (0, combi_1.seq)((0, combi_1.optPrio)((0, combi_1.altPrio)("LEFT OUTER TO ONE", "LEFT OUTER", "INNER", "CROSS")), "JOIN", foo);
+        return (0, combi_1.seq)((0, combi_1.optPrio)((0, combi_1.altPrio)("LEFT OUTER TO ONE", "LEFT OUTER", "INNER", "CROSS", "RIGHT OUTER")), "JOIN", foo);
     }
 }
 exports.CDSJoin = CDSJoin;
@@ -54549,7 +54557,7 @@ class Registry {
     }
     static abaplintVersion() {
         // magic, see build script "version.sh"
-        return "2.113.219";
+        return "2.113.221";
     }
     getDDICReferences() {
         return this.ddicReferences;
@@ -55856,6 +55864,7 @@ ENDINTERFACE.`,
         }
         issues.push(...this.checkTypes(stru, file));
         issues.push(...this.checkMethods(stru, file));
+        issues.push(...this.checkEvents(stru, file));
         return issues;
     }
     check(fields, column, file) {
@@ -55915,6 +55924,26 @@ ENDINTERFACE.`,
         }
         return issues;
     }
+    checkEvents(stru, file) {
+        const issues = [];
+        const events = stru.findAllStatements(Statements.Events);
+        for (const e of events) {
+            const fields = [];
+            const params = e.findAllExpressions(Expressions.MethodParam);
+            let column = 0;
+            for (const p of params) {
+                const children = p.getChildren();
+                const name = children[children.length - 2];
+                fields.push({
+                    nameEnd: name.getLastToken().getEnd(),
+                    after: p.findFirstExpression(Expressions.TypeParam).getFirstToken().getStart()
+                });
+                column = Math.max(column, name.getFirstToken().getEnd().getCol() + 1);
+            }
+            issues.push(...this.check(fields, column, file));
+        }
+        return issues;
+    }
     checkTypes(stru, file) {
         const issues = [];
         const types = stru.findAllStructuresRecursive(Structures.Types);
@@ -58216,6 +58245,7 @@ class CloudTypes {
             || obj instanceof Objects.ApplicationLogObject
             || obj instanceof Objects.CommunicationScenario
             || obj instanceof Objects.DataControl
+            || obj instanceof Objects.Namespace
             || obj instanceof Objects.KnowledgeTransferDocument
             || obj instanceof Objects.DataDefinition
             || obj instanceof Objects.DataElement
@@ -64689,20 +64719,51 @@ WRITE 'world'.`,
     ////////////////
     analyzeIf(file, node) {
         var _a;
-        if (node.getChildren().length !== 4) {
+        const ifBody = node.findDirectStructure(Structures.Body);
+        const elseIfBodies = node.findDirectStructures(Structures.ElseIf) || [];
+        const elseBody = (_a = node.findDirectStructure(Structures.Else)) === null || _a === void 0 ? void 0 : _a.findDirectStructure(Structures.Body);
+        if (elseBody === undefined) {
             return [];
         }
-        const ifBody = node.findDirectStructure(Structures.Body);
-        if (node.findDirectStructure(Structures.ElseIf)) {
+        const ifFirst = ifBody === null || ifBody === void 0 ? void 0 : ifBody.getFirstChild();
+        const elseFirst = elseBody === null || elseBody === void 0 ? void 0 : elseBody.getFirstChild();
+        const ifLast = ifBody === null || ifBody === void 0 ? void 0 : ifBody.getLastChild();
+        const elseLast = elseBody === null || elseBody === void 0 ? void 0 : elseBody.getLastChild();
+        if (elseIfBodies.length > 0) {
+            let firstMatch = true;
+            let lastMatch = true;
+            for (const elseif of elseIfBodies) {
+                const elseifBody = elseif.findDirectStructure(Structures.Body);
+                const elseifFirst = elseifBody === null || elseifBody === void 0 ? void 0 : elseifBody.getFirstChild();
+                const elseifLast = elseifBody === null || elseifBody === void 0 ? void 0 : elseifBody.getLastChild();
+                if (ifFirst === undefined
+                    || ifLast === undefined
+                    || elseLast === undefined
+                    || elseFirst === undefined) {
+                    return [];
+                }
+                if (elseifFirst === undefined
+                    || ifFirst.concatTokens() !== elseifFirst.concatTokens()
+                    || elseFirst.concatTokens() !== elseifFirst.concatTokens()) {
+                    firstMatch = false;
+                }
+                if (elseifLast === undefined
+                    || ifLast.concatTokens() !== elseifLast.concatTokens()
+                    || elseLast.concatTokens() !== elseifLast.concatTokens()) {
+                    lastMatch = false;
+                }
+            }
+            if (firstMatch === true || lastMatch === true) {
+                const message = "Identical contents";
+                const issue = issue_1.Issue.atToken(file, node.getFirstToken(), message, this.getMetadata().key, this.conf.severity);
+                return [issue];
+            }
             return [];
         }
-        const elseBody = (_a = node.findDirectStructure(Structures.Else)) === null || _a === void 0 ? void 0 : _a.findDirectStructure(Structures.Body);
-        if (elseBody === undefined || ifBody === undefined) {
+        else if (elseBody === undefined || ifBody === undefined) {
             return [];
         }
         {
-            const ifFirst = ifBody.getFirstChild();
-            const elseFirst = elseBody.getFirstChild();
             if (ifFirst === undefined || elseFirst === undefined || this.isChained(ifFirst)) {
                 return [];
             }
@@ -64713,8 +64774,6 @@ WRITE 'world'.`,
             }
         }
         {
-            const ifLast = ifBody.getLastChild();
-            const elseLast = elseBody.getLastChild();
             if (ifLast === undefined || elseLast === undefined || this.isChained(ifLast)) {
                 return [];
             }

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@abaplint/cli",
-    "version": "2.113.219",
+    "version": "2.113.221",
     "description": "abaplint - Command Line Interface",
     "funding": "https://github.com/sponsors/larshp",
     "bin": {
@@ -38,7 +38,7 @@
     },
     "homepage": "https://abaplint.org",
     "devDependencies": {
-        "@abaplint/core": "^2.113.219",
+        "@abaplint/core": "^2.113.221",
         "@types/chai": "^4.3.20",
         "@types/minimist": "^1.2.5",
         "@types/mocha": "^10.0.10",