@abaplint/cli 2.113.218 → 2.113.220

package/build/cli.js

@@ -15209,7 +15209,8 @@ class ModifyEntities {
         const updateFrom = (0, combi_1.seq)("UPDATE FROM", expressions_1.Source, (0, combi_1.opt)(relating));
         const deleteFrom = (0, combi_1.seq)("DELETE FROM", expressions_1.Source);
         const updateFields = (0, combi_1.seq)("UPDATE", fieldsWith);
-        const operation = (0, combi_1.alt)((0, combi_1.seq)("UPDATE SET FIELDS WITH", expressions_1.Source), (0, combi_1.seq)("CREATE SET FIELDS WITH", expressions_1.Source), updateFields, deleteFrom, updateFrom, create, execute, (0, combi_1.seq)("CREATE", (0, combi_1.opt)(by), (0, combi_1.optPrio)("AUTO FILL CID"), (0, combi_1.altPrio)(withh, fieldsWith)));
+        const updateSetFields = (0, combi_1.seq)("UPDATE SET FIELDS WITH", expressions_1.Source);
+        const operation = (0, combi_1.alt)(updateSetFields, (0, combi_1.seq)("CREATE SET FIELDS WITH", expressions_1.Source), updateFields, deleteFrom, updateFrom, create, execute, (0, combi_1.seq)("CREATE", (0, combi_1.opt)(by), (0, combi_1.optPrio)("AUTO FILL CID"), (0, combi_1.altPrio)(withh, fieldsWith)));
         const failed = (0, combi_1.seq)("FAILED", expressions_1.Target);
         const result = (0, combi_1.seq)("RESULT", expressions_1.Target);
         const mapped = (0, combi_1.seq)("MAPPED", expressions_1.Target);
@@ -15219,7 +15220,7 @@ class ModifyEntities {
         const create2 = (0, combi_1.seq)("CREATE", fieldsWith, (0, combi_1.opt)((0, combi_1.seq)("CREATE BY", expressions_1.AssociationName, fieldsWith)));
         const create3 = (0, combi_1.seq)("CREATE BY", expressions_1.AssociationName, fieldsWith);
         const create4 = (0, combi_1.seq)("CREATE FROM", expressions_1.Source, (0, combi_1.plus)((0, combi_1.seq)("CREATE BY", expressions_1.AssociationName, "FROM", expressions_1.Source)));
-        const entity = (0, combi_1.seq)("ENTITY", (0, combi_1.opt)("IN LOCAL MODE"), (0, combi_1.alt)(expressions_1.NamespaceSimpleName, expressions_1.EntityAssociation), (0, combi_1.alt)(execute, create, updateFields, deleteFrom, updateFrom, create2, create3, create4));
+        const entity = (0, combi_1.seq)("ENTITY", (0, combi_1.opt)("IN LOCAL MODE"), (0, combi_1.alt)(expressions_1.NamespaceSimpleName, expressions_1.EntityAssociation), (0, combi_1.alt)(execute, create, updateFields, deleteFrom, updateSetFields, updateFrom, create2, create3, create4));
         return (0, combi_1.ver)(version_1.Version.v754, (0, combi_1.seq)("MODIFY", (0, combi_1.alt)(entities, entity), end));
     }
 }
@@ -16161,7 +16162,8 @@ class ReadEntities {
         const result = (0, combi_1.seq)("RESULT", expressions_1.Target);
         const failed = (0, combi_1.seq)("FAILED", expressions_1.Target);
         const reported = (0, combi_1.seq)("REPORTED", expressions_1.Target);
-        const entity = (0, combi_1.seq)("ENTITY", expressions_1.NamespaceSimpleName, (0, combi_1.opt)((0, combi_1.seq)("BY", expressions_1.AssociationName)), (0, combi_1.alt)(fields, from, all), (0, combi_1.optPrio)(result));
+        const foo = (0, combi_1.seq)((0, combi_1.opt)((0, combi_1.seq)("BY", expressions_1.AssociationName)), (0, combi_1.alt)(fields, from, all), (0, combi_1.optPrio)(result));
+        const entity = (0, combi_1.seq)("ENTITY", expressions_1.NamespaceSimpleName, (0, combi_1.plus)(foo));
         const s = (0, combi_1.seq)("ENTITIES OF", expressions_1.NamespaceSimpleName, (0, combi_1.opt)("IN LOCAL MODE"), (0, combi_1.plus)(entity), (0, combi_1.optPrio)((0, combi_1.seq)("LINK", expressions_1.Target)), (0, combi_1.optPrio)((0, combi_1.per)(failed, reported)));
         const byall = (0, combi_1.seq)("BY", expressions_1.AssociationName, all);
         const by = (0, combi_1.seq)("BY", expressions_1.AssociationName, fields);
@@ -21375,7 +21377,9 @@ class BuiltIn {
         // https://help.sap.com/doc/abapdocu_751_index_htm/7.51/en-us/abennews-610-system.htm
         const id3 = new tokens_1.Identifier(new position_1.Position(this.row++, 1), "sy-repid");
         const syrepid = new _typed_identifier_1.TypedIdentifier(id3, BuiltIn.filename, new basic_1.CharacterType(40, { qualifiedName: "sy-repid" }), ["read_only" /* IdentifierMeta.ReadOnly */, "built-in" /* IdentifierMeta.BuiltIn */]);
-        return [sy, syst, syrepid];
+        const id4 = new tokens_1.Identifier(new position_1.Position(this.row++, 1), "syst-repid");
+        const systrepid = new _typed_identifier_1.TypedIdentifier(id4, BuiltIn.filename, new basic_1.CharacterType(40, { qualifiedName: "syst-repid" }), ["read_only" /* IdentifierMeta.ReadOnly */, "built-in" /* IdentifierMeta.BuiltIn */]);
+        return [sy, syst, syrepid, systrepid];
     }
     buildConstant(name, type, value) {
         const id = new tokens_1.Identifier(new position_1.Position(this.row++, 1), name);
@@ -24395,7 +24399,7 @@ class BasicTypes {
             const name = typename.concatTokens();
             const type = (_d = this.input.scope.getDDIC().lookupDDLS(name)) === null || _d === void 0 ? void 0 : _d.type;
             if (type) {
-                return new Types.TableType(basic_1.VoidType.get("RapTodo"), options);
+                return new Types.TableType(basic_1.VoidType.get("RAP-TODO"), options);
             }
             else if (this.input.scope.getDDIC().inErrorNamespace(name)) {
                 return new Types.UnknownType(`DDLS ${name} not found`);
@@ -30682,7 +30686,7 @@ class ClassImplementation {
         }
         else {
             // todo: instead of the void type, do proper typing, ie. only empty constructor method
-            input.scope.addIdentifier(new _typed_identifier_1.TypedIdentifier(new tokens_1.Identifier(new position_1.Position(1, 1), "super"), _builtin_1.BuiltIn.filename, basic_1.VoidType.get("noSuper")));
+            input.scope.addIdentifier(new _typed_identifier_1.TypedIdentifier(new tokens_1.Identifier(new position_1.Position(1, 1), "super"), _builtin_1.BuiltIn.filename, basic_1.VoidType.get("noSuperClass")));
         }
         input.scope.addIdentifier(new _typed_identifier_1.TypedIdentifier(new tokens_1.Identifier(new position_1.Position(1, 1), "me"), _builtin_1.BuiltIn.filename, new basic_1.ObjectReferenceType(classDefinition)));
         helper.addAliasedAttributes(classDefinition); // todo, this is not correct, take care of instance vs static
@@ -41586,7 +41590,7 @@ const combi_1 = __webpack_require__(/*! ../../abap/2_statements/combi */ "./node
 class CDSFunctionInput extends combi_1.Expression {
     getRunnable() {
         const qualified = (0, combi_1.seq)(_1.CDSName, (0, combi_1.opt)(_1.CDSParameters), (0, combi_1.starPrio)((0, combi_1.seq)(".", _1.CDSName, (0, combi_1.opt)(_1.CDSParameters))));
-        const input = (0, combi_1.altPrio)(_1.CDSCast, _1.CDSFunction, _1.CDSArithmetics, _1.CDSCase, _1.CDSString, qualified, _1.CDSInteger);
+        const input = (0, combi_1.altPrio)(_1.CDSArithmetics, _1.CDSCast, _1.CDSFunction, _1.CDSCase, _1.CDSString, qualified, _1.CDSInteger);
         return input;
     }
 }
@@ -54549,7 +54553,7 @@ class Registry {
     }
     static abaplintVersion() {
         // magic, see build script "version.sh"
-        return "2.113.218";
+        return "2.113.220";
     }
     getDDICReferences() {
         return this.ddicReferences;
@@ -55856,6 +55860,7 @@ ENDINTERFACE.`,
         }
         issues.push(...this.checkTypes(stru, file));
         issues.push(...this.checkMethods(stru, file));
+        issues.push(...this.checkEvents(stru, file));
         return issues;
     }
     check(fields, column, file) {
@@ -55915,6 +55920,26 @@ ENDINTERFACE.`,
         }
         return issues;
     }
+    checkEvents(stru, file) {
+        const issues = [];
+        const events = stru.findAllStatements(Statements.Events);
+        for (const e of events) {
+            const fields = [];
+            const params = e.findAllExpressions(Expressions.MethodParam);
+            let column = 0;
+            for (const p of params) {
+                const children = p.getChildren();
+                const name = children[children.length - 2];
+                fields.push({
+                    nameEnd: name.getLastToken().getEnd(),
+                    after: p.findFirstExpression(Expressions.TypeParam).getFirstToken().getStart()
+                });
+                column = Math.max(column, name.getFirstToken().getEnd().getCol() + 1);
+            }
+            issues.push(...this.check(fields, column, file));
+        }
+        return issues;
+    }
     checkTypes(stru, file) {
         const issues = [];
         const types = stru.findAllStructuresRecursive(Structures.Types);
@@ -64689,20 +64714,51 @@ WRITE 'world'.`,
     ////////////////
     analyzeIf(file, node) {
         var _a;
-        if (node.getChildren().length !== 4) {
+        const ifBody = node.findDirectStructure(Structures.Body);
+        const elseIfBodies = node.findDirectStructures(Structures.ElseIf) || [];
+        const elseBody = (_a = node.findDirectStructure(Structures.Else)) === null || _a === void 0 ? void 0 : _a.findDirectStructure(Structures.Body);
+        if (elseBody === undefined) {
             return [];
         }
-        const ifBody = node.findDirectStructure(Structures.Body);
-        if (node.findDirectStructure(Structures.ElseIf)) {
+        const ifFirst = ifBody === null || ifBody === void 0 ? void 0 : ifBody.getFirstChild();
+        const elseFirst = elseBody === null || elseBody === void 0 ? void 0 : elseBody.getFirstChild();
+        const ifLast = ifBody === null || ifBody === void 0 ? void 0 : ifBody.getLastChild();
+        const elseLast = elseBody === null || elseBody === void 0 ? void 0 : elseBody.getLastChild();
+        if (elseIfBodies.length > 0) {
+            let firstMatch = true;
+            let lastMatch = true;
+            for (const elseif of elseIfBodies) {
+                const elseifBody = elseif.findDirectStructure(Structures.Body);
+                const elseifFirst = elseifBody === null || elseifBody === void 0 ? void 0 : elseifBody.getFirstChild();
+                const elseifLast = elseifBody === null || elseifBody === void 0 ? void 0 : elseifBody.getLastChild();
+                if (ifFirst === undefined
+                    || ifLast === undefined
+                    || elseLast === undefined
+                    || elseFirst === undefined) {
+                    return [];
+                }
+                if (elseifFirst === undefined
+                    || ifFirst.concatTokens() !== elseifFirst.concatTokens()
+                    || elseFirst.concatTokens() !== elseifFirst.concatTokens()) {
+                    firstMatch = false;
+                }
+                if (elseifLast === undefined
+                    || ifLast.concatTokens() !== elseifLast.concatTokens()
+                    || elseLast.concatTokens() !== elseifLast.concatTokens()) {
+                    lastMatch = false;
+                }
+            }
+            if (firstMatch === true || lastMatch === true) {
+                const message = "Identical contents";
+                const issue = issue_1.Issue.atToken(file, node.getFirstToken(), message, this.getMetadata().key, this.conf.severity);
+                return [issue];
+            }
             return [];
         }
-        const elseBody = (_a = node.findDirectStructure(Structures.Else)) === null || _a === void 0 ? void 0 : _a.findDirectStructure(Structures.Body);
-        if (elseBody === undefined || ifBody === undefined) {
+        else if (elseBody === undefined || ifBody === undefined) {
             return [];
         }
         {
-            const ifFirst = ifBody.getFirstChild();
-            const elseFirst = elseBody.getFirstChild();
             if (ifFirst === undefined || elseFirst === undefined || this.isChained(ifFirst)) {
                 return [];
             }
@@ -64713,8 +64769,6 @@ WRITE 'world'.`,
             }
         }
         {
-            const ifLast = ifBody.getLastChild();
-            const elseLast = elseBody.getLastChild();
             if (ifLast === undefined || elseLast === undefined || this.isChained(ifLast)) {
                 return [];
             }
@@ -65143,7 +65197,15 @@ class ImplementMethods extends _abap_rule_1.ABAPRule {
                     const issue = issue_1.Issue.atIdentifier(found, "Do not implement abstract method \"" + md.name + "\"", this.getMetadata().key, this.conf.severity);
                     ret.push(issue);
                 }
-                continue;
+                if (def.isAbstract) {
+                    continue;
+                }
+                else {
+                    const message = "Abstract methods can only be defined in abstract classes.";
+                    const issue = issue_1.Issue.atIdentifier(def.identifier, message, this.getMetadata().key, this.conf.severity);
+                    ret.push(issue);
+                    break;
+                }
             }
             if (impl === undefined) {
                 const message = "Class implementation for \"" + def.name + "\" not found";
@@ -65247,7 +65309,15 @@ class ImplementMethods extends _abap_rule_1.ABAPRule {
             }
             for (const m of this.findInterfaceMethods(idef)) {
                 if (this.isAbstract(m, interfaceInfo, def)) {
-                    continue;
+                    if (def.isAbstract) {
+                        continue;
+                    }
+                    else {
+                        const message = "Abstract methods can only be defined in abstract classes.";
+                        const issue = issue_1.Issue.atIdentifier(def.identifier, message, this.getMetadata().key, this.conf.severity);
+                        ret.push(issue);
+                        break;
+                    }
                 }
                 if (this.isImplemented(m, def, impl) === false) {
                     const message = "Implement method \"" + m.method.name + "\" from interface \"" + m.objectName + "\"";
@@ -70662,6 +70732,7 @@ const _abap_rule_1 = __webpack_require__(/*! ./_abap_rule */ "./node_modules/@ab
 const _basic_rule_config_1 = __webpack_require__(/*! ./_basic_rule_config */ "./node_modules/@abaplint/core/build/src/rules/_basic_rule_config.js");
 const _irule_1 = __webpack_require__(/*! ./_irule */ "./node_modules/@abaplint/core/build/src/rules/_irule.js");
 const version_1 = __webpack_require__(/*! ../version */ "./node_modules/@abaplint/core/build/src/version.js");
+const __1 = __webpack_require__(/*! .. */ "./node_modules/@abaplint/core/build/src/index.js");
 class Parser702ChainingConf extends _basic_rule_config_1.BasicRuleConfig {
 }
 exports.Parser702ChainingConf = Parser702ChainingConf;
@@ -70673,7 +70744,7 @@ class Parser702Chaining extends _abap_rule_1.ABAPRule {
     getMetadata() {
         return {
             key: "parser_702_chaining",
-            title: "Parser Error, bad chanining on 702",
+            title: "Parser Error, bad chaining on 702",
             shortDescription: `ABAP on 702 does not allow for method chaining with IMPORTING/EXPORTING/CHANGING keywords,
 this rule finds these and reports errors.
 Only active on target version 702 and below.`,
@@ -70714,13 +70785,47 @@ Only active on target version 702 and below.`,
                     || param.findDirectTokenByText("CHANGING")
                     || param.findDirectTokenByText("EXCEPTIONS")) {
                     const message = "This kind of method chaining not possible in 702";
-                    const issue = issue_1.Issue.atPosition(file, param.getFirstToken().getStart(), message, this.getMetadata().key, this.conf.severity);
-                    issues.push(issue);
+                    this.pushIssue(message, file, param, issues);
                 }
             }
         }
+        // after a value assignment (move statement whose source is a method call, or method parameter assignment),
+        // there can't be any EXPORTING/IMPORTING/CHANGING/EXCEPTIONS
+        for (const statement of file.getStatements()) {
+            if (!(statement.get() instanceof __1.Statements.Move)) {
+                continue;
+            }
+            const source = statement.findDirectExpression(Expressions.Source);
+            if (source === undefined) {
+                continue;
+            }
+            this.ensureSourceHasNoProceduralKeywords(source, file, issues);
+        }
+        for (const methodParameters of stru.findAllExpressions(Expressions.MethodParameters)) {
+            for (const params of methodParameters.findAllExpressions(Expressions.ParameterS)) {
+                const source = params.findDirectExpression(Expressions.Source);
+                if (source === undefined) {
+                    continue;
+                }
+                this.ensureSourceHasNoProceduralKeywords(source, file, issues);
+            }
+        }
         return issues;
     }
+    ensureSourceHasNoProceduralKeywords(source, file, issues) {
+        const forbiddenTokens = ["EXPORTING", "IMPORTING", "CHANGING", "EXCEPTIONS"];
+        for (const param of source.findAllExpressions(Expressions.MethodParameters)) {
+            const usedForbiddenToken = forbiddenTokens.find(text => param.findDirectTokenByText(text));
+            if (usedForbiddenToken) {
+                const message = `Unexpected word ${usedForbiddenToken} in functional method call`;
+                this.pushIssue(message, file, param, issues);
+            }
+        }
+    }
+    pushIssue(message, file, node, issues) {
+        const issue = issue_1.Issue.atPosition(file, node.getFirstToken().getStart(), message, this.getMetadata().key, this.conf.severity);
+        issues.push(issue);
+    }
 }
 exports.Parser702Chaining = Parser702Chaining;
 //# sourceMappingURL=parser_702_chaining.js.map

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@abaplint/cli",
-    "version": "2.113.218",
+    "version": "2.113.220",
     "description": "abaplint - Command Line Interface",
     "funding": "https://github.com/sponsors/larshp",
     "bin": {
@@ -38,11 +38,11 @@
     },
     "homepage": "https://abaplint.org",
     "devDependencies": {
-        "@abaplint/core": "^2.113.217",
+        "@abaplint/core": "^2.113.220",
         "@types/chai": "^4.3.20",
         "@types/minimist": "^1.2.5",
         "@types/mocha": "^10.0.10",
-        "@types/node": "^24.5.2",
+        "@types/node": "^24.6.2",
         "@types/progress": "^2.0.7",
         "chai": "^4.5.0",
         "p-limit": "^3.1.0",
@@ -50,12 +50,12 @@
         "eslint": "^9.36.0",
         "glob": "^11.0.3",
         "json5": "^2.2.3",
-        "memfs": "^4.46.1",
+        "memfs": "^4.48.1",
         "minimist": "^1.2.8",
-        "mocha": "^11.7.2",
+        "mocha": "^11.7.4",
         "progress": "^2.0.3",
-        "typescript": "^5.9.2",
-        "webpack": "^5.101.3",
+        "typescript": "^5.9.3",
+        "webpack": "^5.102.0",
         "webpack-cli": "^6.0.1",
         "xml-js": "^1.6.11"
     }