@abaplint/cli 2.113.218 → 2.113.219

package/build/cli.js

@@ -54549,7 +54549,7 @@ class Registry {
     }
     static abaplintVersion() {
         // magic, see build script "version.sh"
-        return "2.113.218";
+        return "2.113.219";
     }
     getDDICReferences() {
         return this.ddicReferences;
@@ -65143,7 +65143,15 @@ class ImplementMethods extends _abap_rule_1.ABAPRule {
                     const issue = issue_1.Issue.atIdentifier(found, "Do not implement abstract method \"" + md.name + "\"", this.getMetadata().key, this.conf.severity);
                     ret.push(issue);
                 }
-                continue;
+                if (def.isAbstract) {
+                    continue;
+                }
+                else {
+                    const message = "Abstract methods can only be defined in abstract classes.";
+                    const issue = issue_1.Issue.atIdentifier(def.identifier, message, this.getMetadata().key, this.conf.severity);
+                    ret.push(issue);
+                    break;
+                }
             }
             if (impl === undefined) {
                 const message = "Class implementation for \"" + def.name + "\" not found";
@@ -65247,7 +65255,15 @@ class ImplementMethods extends _abap_rule_1.ABAPRule {
             }
             for (const m of this.findInterfaceMethods(idef)) {
                 if (this.isAbstract(m, interfaceInfo, def)) {
-                    continue;
+                    if (def.isAbstract) {
+                        continue;
+                    }
+                    else {
+                        const message = "Abstract methods can only be defined in abstract classes.";
+                        const issue = issue_1.Issue.atIdentifier(def.identifier, message, this.getMetadata().key, this.conf.severity);
+                        ret.push(issue);
+                        break;
+                    }
                 }
                 if (this.isImplemented(m, def, impl) === false) {
                     const message = "Implement method \"" + m.method.name + "\" from interface \"" + m.objectName + "\"";
@@ -70662,6 +70678,7 @@ const _abap_rule_1 = __webpack_require__(/*! ./_abap_rule */ "./node_modules/@ab
 const _basic_rule_config_1 = __webpack_require__(/*! ./_basic_rule_config */ "./node_modules/@abaplint/core/build/src/rules/_basic_rule_config.js");
 const _irule_1 = __webpack_require__(/*! ./_irule */ "./node_modules/@abaplint/core/build/src/rules/_irule.js");
 const version_1 = __webpack_require__(/*! ../version */ "./node_modules/@abaplint/core/build/src/version.js");
+const __1 = __webpack_require__(/*! .. */ "./node_modules/@abaplint/core/build/src/index.js");
 class Parser702ChainingConf extends _basic_rule_config_1.BasicRuleConfig {
 }
 exports.Parser702ChainingConf = Parser702ChainingConf;
@@ -70673,7 +70690,7 @@ class Parser702Chaining extends _abap_rule_1.ABAPRule {
     getMetadata() {
         return {
             key: "parser_702_chaining",
-            title: "Parser Error, bad chanining on 702",
+            title: "Parser Error, bad chaining on 702",
             shortDescription: `ABAP on 702 does not allow for method chaining with IMPORTING/EXPORTING/CHANGING keywords,
 this rule finds these and reports errors.
 Only active on target version 702 and below.`,
@@ -70714,13 +70731,47 @@ Only active on target version 702 and below.`,
                     || param.findDirectTokenByText("CHANGING")
                     || param.findDirectTokenByText("EXCEPTIONS")) {
                     const message = "This kind of method chaining not possible in 702";
-                    const issue = issue_1.Issue.atPosition(file, param.getFirstToken().getStart(), message, this.getMetadata().key, this.conf.severity);
-                    issues.push(issue);
+                    this.pushIssue(message, file, param, issues);
                 }
             }
         }
+        // after a value assignment (move statement whose source is a method call, or method parameter assignment),
+        // there can't be any EXPORTING/IMPORTING/CHANGING/EXCEPTIONS
+        for (const statement of file.getStatements()) {
+            if (!(statement.get() instanceof __1.Statements.Move)) {
+                continue;
+            }
+            const source = statement.findDirectExpression(Expressions.Source);
+            if (source === undefined) {
+                continue;
+            }
+            this.ensureSourceHasNoProceduralKeywords(source, file, issues);
+        }
+        for (const methodParameters of stru.findAllExpressions(Expressions.MethodParameters)) {
+            for (const params of methodParameters.findAllExpressions(Expressions.ParameterS)) {
+                const source = params.findDirectExpression(Expressions.Source);
+                if (source === undefined) {
+                    continue;
+                }
+                this.ensureSourceHasNoProceduralKeywords(source, file, issues);
+            }
+        }
         return issues;
     }
+    ensureSourceHasNoProceduralKeywords(source, file, issues) {
+        const forbiddenTokens = ["EXPORTING", "IMPORTING", "CHANGING", "EXCEPTIONS"];
+        for (const param of source.findAllExpressions(Expressions.MethodParameters)) {
+            const usedForbiddenToken = forbiddenTokens.find(text => param.findDirectTokenByText(text));
+            if (usedForbiddenToken) {
+                const message = `Unexpected word ${usedForbiddenToken} in functional method call`;
+                this.pushIssue(message, file, param, issues);
+            }
+        }
+    }
+    pushIssue(message, file, node, issues) {
+        const issue = issue_1.Issue.atPosition(file, node.getFirstToken().getStart(), message, this.getMetadata().key, this.conf.severity);
+        issues.push(issue);
+    }
 }
 exports.Parser702Chaining = Parser702Chaining;
 //# sourceMappingURL=parser_702_chaining.js.map

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@abaplint/cli",
-    "version": "2.113.218",
+    "version": "2.113.219",
     "description": "abaplint - Command Line Interface",
     "funding": "https://github.com/sponsors/larshp",
     "bin": {
@@ -38,11 +38,11 @@
     },
     "homepage": "https://abaplint.org",
     "devDependencies": {
-        "@abaplint/core": "^2.113.217",
+        "@abaplint/core": "^2.113.219",
         "@types/chai": "^4.3.20",
         "@types/minimist": "^1.2.5",
         "@types/mocha": "^10.0.10",
-        "@types/node": "^24.5.2",
+        "@types/node": "^24.6.2",
         "@types/progress": "^2.0.7",
         "chai": "^4.5.0",
         "p-limit": "^3.1.0",
@@ -50,12 +50,12 @@
         "eslint": "^9.36.0",
         "glob": "^11.0.3",
         "json5": "^2.2.3",
-        "memfs": "^4.46.1",
+        "memfs": "^4.48.1",
         "minimist": "^1.2.8",
-        "mocha": "^11.7.2",
+        "mocha": "^11.7.4",
         "progress": "^2.0.3",
-        "typescript": "^5.9.2",
-        "webpack": "^5.101.3",
+        "typescript": "^5.9.3",
+        "webpack": "^5.102.0",
         "webpack-cli": "^6.0.1",
         "xml-js": "^1.6.11"
     }