@abaplint/cli 2.113.217 → 2.113.219

package/build/cli.js

@@ -437,7 +437,7 @@ class CodeClimate {
                         end: issue.getEnd().getRow(),
                     },
                 },
-                severity: (severityArray.includes(issue.getSeverity().toLowerCase())) ? issue.getSeverity().toLowerCase() : defaultSeverity,
+                severity: severityArray.includes(issue.getSeverity().toLowerCase()) ? issue.getSeverity().toLowerCase() : defaultSeverity,
                 fingerprint: md5(issue.getKey() + issue.getMessage() + issue.getFilename() + issue.getStart().getRow() + issue.getEnd().getRow()),
             };
             out.push(single);
@@ -478,7 +478,7 @@ class CodeFrame {
         const builtIssues = this.convertAllIssues(issues).sort(issueSort); // Make sure it is sorted by filename for caching to work
         return [
             ...builtIssues.map(i => this.renderIssue(i)),
-            (issues.length > 0 ? chalk_1.default.red(new total_1.Total().output(issues, fileCount)) : chalk_1.default.green(new total_1.Total().output(issues, fileCount))),
+            issues.length > 0 ? chalk_1.default.red(new total_1.Total().output(issues, fileCount)) : chalk_1.default.green(new total_1.Total().output(issues, fileCount)),
         ].join("\n");
     }
     convertAllIssues(issues) {
@@ -737,7 +737,7 @@ class Sonarqube {
             const single = {
                 engineId: "abaplint",
                 ruleId: issue.getKey(),
-                severity: (severityArray.includes(issue.getSeverity().toUpperCase())) ? issue.getSeverity().toUpperCase() : defaultSeverity,
+                severity: severityArray.includes(issue.getSeverity().toUpperCase()) ? issue.getSeverity().toUpperCase() : defaultSeverity,
                 type: "CODE_SMELL",
                 primaryLocation: {
                     message: issue.getMessage(),
@@ -1192,7 +1192,7 @@ class Rename {
                 continue;
             }
             for (const p of rconfig.patterns || []) {
-                if (!(o.getType().match(p.type))) {
+                if (!o.getType().match(p.type)) {
                     continue;
                 }
                 const regex = new RegExp(p.oldName, "i");
@@ -23835,7 +23835,7 @@ class TypeUtils {
                     if (!(sourceRowType instanceof basic_1.StructureType)) {
                         return false;
                     }
-                    else if (!(this.structureContainsString(sourceRowType))
+                    else if (!this.structureContainsString(sourceRowType)
                         && this.structureContainsVoid(sourceRowType) === false) {
                         return false;
                     }
@@ -23845,7 +23845,7 @@ class TypeUtils {
                     if (!(targetRowType instanceof basic_1.StructureType)) {
                         return false;
                     }
-                    else if (!(this.structureContainsString(targetRowType))
+                    else if (!this.structureContainsString(targetRowType)
                         && this.structureContainsVoid(targetRowType) === false) {
                         return false;
                     }
@@ -25643,7 +25643,7 @@ class CorrespondingBody {
         }
         const base = (_a = node.findDirectExpression(Expressions.CorrespondingBodyBase)) === null || _a === void 0 ? void 0 : _a.findDirectExpression(Expressions.Source);
         if (base) {
-            source_1.Source.runSyntax(base, input);
+            source_1.Source.runSyntax(base, input, targetType);
         }
         let type = undefined;
         for (const s of node.findDirectExpressions(Expressions.Source)) {
@@ -54549,7 +54549,7 @@ class Registry {
     }
     static abaplintVersion() {
         // magic, see build script "version.sh"
-        return "2.113.217";
+        return "2.113.219";
     }
     getDDICReferences() {
         return this.ddicReferences;
@@ -60587,7 +60587,6 @@ ${indentation}${uniqueName} = ${source.concatTokens()}.\n${indentation}`);
         const source = high.findExpressionAfterToken("MESSAGE");
         if ((source === null || source === void 0 ? void 0 : source.get()) instanceof Expressions.MessageSourceSource
             && ((_a = source.getFirstChild()) === null || _a === void 0 ? void 0 : _a.get()) instanceof Expressions.Source) {
-            ;
             const uniqueName = this.uniqueName(high.getFirstToken().getStart(), lowFile.getFilename(), highSyntax);
             const indentation = " ".repeat(high.getFirstToken().getStart().getCol() - 1);
             const firstToken = high.getFirstToken();
@@ -64019,7 +64018,7 @@ class FullyTypeConstants extends _abap_rule_1.ABAPRule {
         for (const stat of file.getStatements()) {
             if ((stat.get() instanceof Statements.Constant
                 || (this.conf.checkData === true && stat.get() instanceof Statements.Data))
-                && (!this.isTyped(stat))) {
+                && !this.isTyped(stat)) {
                 const type = stat.get() instanceof Statements.Constant ? "constant definition" : "data definition";
                 let token = (_a = stat.findFirstExpression(expressions_1.NamespaceSimpleName)) === null || _a === void 0 ? void 0 : _a.getFirstToken();
                 if (token === undefined) {
@@ -64034,7 +64033,7 @@ class FullyTypeConstants extends _abap_rule_1.ABAPRule {
         return issues;
     }
     isTyped(stat) {
-        return (stat.findFirstExpression(expressions_1.Type) || stat.findFirstExpression(expressions_1.TypeTable));
+        return stat.findFirstExpression(expressions_1.Type) || stat.findFirstExpression(expressions_1.TypeTable);
     }
 }
 exports.FullyTypeConstants = FullyTypeConstants;
@@ -65144,7 +65143,15 @@ class ImplementMethods extends _abap_rule_1.ABAPRule {
                     const issue = issue_1.Issue.atIdentifier(found, "Do not implement abstract method \"" + md.name + "\"", this.getMetadata().key, this.conf.severity);
                     ret.push(issue);
                 }
-                continue;
+                if (def.isAbstract) {
+                    continue;
+                }
+                else {
+                    const message = "Abstract methods can only be defined in abstract classes.";
+                    const issue = issue_1.Issue.atIdentifier(def.identifier, message, this.getMetadata().key, this.conf.severity);
+                    ret.push(issue);
+                    break;
+                }
             }
             if (impl === undefined) {
                 const message = "Class implementation for \"" + def.name + "\" not found";
@@ -65247,8 +65254,16 @@ class ImplementMethods extends _abap_rule_1.ABAPRule {
                 return [idef];
             }
             for (const m of this.findInterfaceMethods(idef)) {
-                if (interfaceInfo.abstractMethods.includes(m.method.name.toUpperCase())) {
-                    continue;
+                if (this.isAbstract(m, interfaceInfo, def)) {
+                    if (def.isAbstract) {
+                        continue;
+                    }
+                    else {
+                        const message = "Abstract methods can only be defined in abstract classes.";
+                        const issue = issue_1.Issue.atIdentifier(def.identifier, message, this.getMetadata().key, this.conf.severity);
+                        ret.push(issue);
+                        break;
+                    }
                 }
                 if (this.isImplemented(m, def, impl) === false) {
                     const message = "Implement method \"" + m.method.name + "\" from interface \"" + m.objectName + "\"";
@@ -65266,6 +65281,23 @@ class ImplementMethods extends _abap_rule_1.ABAPRule {
         }
         return ret;
     }
+    isAbstract(m, interfaceInfo, def) {
+        if (interfaceInfo.abstractMethods.includes(m.method.name.toUpperCase())) {
+            return true;
+        }
+        if (!def.superClassName) {
+            return false;
+        }
+        // look up in superclass if method is abstract there
+        const superClass = this.findClass(def.superClassName);
+        const superInterface = superClass === null || superClass === void 0 ? void 0 : superClass.def.interfaces.find(iface => iface.name.toUpperCase() === m.objectName.toUpperCase());
+        if (superClass && superInterface) {
+            return this.isAbstract(m, superInterface, superClass.def);
+        }
+        else {
+            return false;
+        }
+    }
     isImplemented(m, def, impl) {
         if (impl === undefined) {
             return false;
@@ -70646,6 +70678,7 @@ const _abap_rule_1 = __webpack_require__(/*! ./_abap_rule */ "./node_modules/@ab
 const _basic_rule_config_1 = __webpack_require__(/*! ./_basic_rule_config */ "./node_modules/@abaplint/core/build/src/rules/_basic_rule_config.js");
 const _irule_1 = __webpack_require__(/*! ./_irule */ "./node_modules/@abaplint/core/build/src/rules/_irule.js");
 const version_1 = __webpack_require__(/*! ../version */ "./node_modules/@abaplint/core/build/src/version.js");
+const __1 = __webpack_require__(/*! .. */ "./node_modules/@abaplint/core/build/src/index.js");
 class Parser702ChainingConf extends _basic_rule_config_1.BasicRuleConfig {
 }
 exports.Parser702ChainingConf = Parser702ChainingConf;
@@ -70657,7 +70690,7 @@ class Parser702Chaining extends _abap_rule_1.ABAPRule {
     getMetadata() {
         return {
             key: "parser_702_chaining",
-            title: "Parser Error, bad chanining on 702",
+            title: "Parser Error, bad chaining on 702",
             shortDescription: `ABAP on 702 does not allow for method chaining with IMPORTING/EXPORTING/CHANGING keywords,
 this rule finds these and reports errors.
 Only active on target version 702 and below.`,
@@ -70698,13 +70731,47 @@ Only active on target version 702 and below.`,
                     || param.findDirectTokenByText("CHANGING")
                     || param.findDirectTokenByText("EXCEPTIONS")) {
                     const message = "This kind of method chaining not possible in 702";
-                    const issue = issue_1.Issue.atPosition(file, param.getFirstToken().getStart(), message, this.getMetadata().key, this.conf.severity);
-                    issues.push(issue);
+                    this.pushIssue(message, file, param, issues);
+                }
+            }
+        }
+        // after a value assignment (move statement whose source is a method call, or method parameter assignment),
+        // there can't be any EXPORTING/IMPORTING/CHANGING/EXCEPTIONS
+        for (const statement of file.getStatements()) {
+            if (!(statement.get() instanceof __1.Statements.Move)) {
+                continue;
+            }
+            const source = statement.findDirectExpression(Expressions.Source);
+            if (source === undefined) {
+                continue;
+            }
+            this.ensureSourceHasNoProceduralKeywords(source, file, issues);
+        }
+        for (const methodParameters of stru.findAllExpressions(Expressions.MethodParameters)) {
+            for (const params of methodParameters.findAllExpressions(Expressions.ParameterS)) {
+                const source = params.findDirectExpression(Expressions.Source);
+                if (source === undefined) {
+                    continue;
                 }
+                this.ensureSourceHasNoProceduralKeywords(source, file, issues);
             }
         }
         return issues;
     }
+    ensureSourceHasNoProceduralKeywords(source, file, issues) {
+        const forbiddenTokens = ["EXPORTING", "IMPORTING", "CHANGING", "EXCEPTIONS"];
+        for (const param of source.findAllExpressions(Expressions.MethodParameters)) {
+            const usedForbiddenToken = forbiddenTokens.find(text => param.findDirectTokenByText(text));
+            if (usedForbiddenToken) {
+                const message = `Unexpected word ${usedForbiddenToken} in functional method call`;
+                this.pushIssue(message, file, param, issues);
+            }
+        }
+    }
+    pushIssue(message, file, node, issues) {
+        const issue = issue_1.Issue.atPosition(file, node.getFirstToken().getStart(), message, this.getMetadata().key, this.conf.severity);
+        issues.push(issue);
+    }
 }
 exports.Parser702Chaining = Parser702Chaining;
 //# sourceMappingURL=parser_702_chaining.js.map
@@ -75628,9 +75695,9 @@ ENDFORM.`,
         for (let i = 0; i < statements.length; i++) {
             const node = statements[i];
             const nodeType = node.get();
-            if ((nodeType instanceof Statements.MethodImplementation
+            if (nodeType instanceof Statements.MethodImplementation
                 || nodeType instanceof Statements.Form
-                || nodeType instanceof Statements.FunctionModule)) {
+                || nodeType instanceof Statements.FunctionModule) {
                 statementCounter = 0;
                 continue;
             }

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@abaplint/cli",
-    "version": "2.113.217",
+    "version": "2.113.219",
     "description": "abaplint - Command Line Interface",
     "funding": "https://github.com/sponsors/larshp",
     "bin": {
@@ -38,11 +38,11 @@
     },
     "homepage": "https://abaplint.org",
     "devDependencies": {
-        "@abaplint/core": "^2.113.217",
+        "@abaplint/core": "^2.113.219",
         "@types/chai": "^4.3.20",
         "@types/minimist": "^1.2.5",
         "@types/mocha": "^10.0.10",
-        "@types/node": "^24.5.2",
+        "@types/node": "^24.6.2",
         "@types/progress": "^2.0.7",
         "chai": "^4.5.0",
         "p-limit": "^3.1.0",
@@ -50,12 +50,12 @@
         "eslint": "^9.36.0",
         "glob": "^11.0.3",
         "json5": "^2.2.3",
-        "memfs": "^4.46.1",
+        "memfs": "^4.48.1",
         "minimist": "^1.2.8",
-        "mocha": "^11.7.2",
+        "mocha": "^11.7.4",
         "progress": "^2.0.3",
-        "typescript": "^5.9.2",
-        "webpack": "^5.101.3",
+        "typescript": "^5.9.3",
+        "webpack": "^5.102.0",
         "webpack-cli": "^6.0.1",
         "xml-js": "^1.6.11"
     }