@abaplint/cli 2.113.10 → 2.113.12

package/build/cli.js

@@ -229,7 +229,7 @@ class ApplyFixes {
                                     && list2.range.end.getRow() >= list1.range.start.getRow()) {
                                     return true;
                                 }
-                                if (list2.range.start.getRow() <= list1.range.start.getRow()
+                                if (list2.range.start.getRow() <= list1.range.end.getRow()
                                     && list2.range.end.getRow() >= list1.range.end.getRow()) {
                                     return true;
                                 }
@@ -255,6 +255,20 @@ class ApplyFixes {
             appliedIssues.push(i);
             edits.push(edit);
         }
+        /*
+        if (edits.length > 0) {
+          console.log("EDITS:");
+          for (const e of edits) {
+            for (const filename of Object.keys(e)) {
+              console.log("\t" + filename);
+              for (const i of e[filename]) {
+                console.dir(i.range);
+                console.dir(i.newText);
+              }
+            }
+          }
+        }
+        */
         const changed = (0, core_1.applyEditList)(reg, edits);
         for (const filename of changed) {
             this.changedFiles.add(filename);
@@ -52732,7 +52746,7 @@ class Registry {
     }
     static abaplintVersion() {
         // magic, see build script "version.sh"
-        return "2.113.10";
+        return "2.113.12";
     }
     getDDICReferences() {
         return this.ddicReferences;
@@ -73972,6 +73986,7 @@ class UnusedMethods {
             extendedInformation: `Checks private and protected methods.
 
 Unused methods are not reported if the object contains parser or syntax errors.
+Quick fixes only appears for private methods.
 
 Skips:
 * methods FOR TESTING
@@ -74063,12 +74078,14 @@ Skips:
             else if (this.suppressedbyPseudo(statement, file)) {
                 continue;
             }
-            const implementation = this.findMethodImplementation(i, file);
             let fix = undefined;
-            if (implementation !== undefined) {
-                const fix1 = edit_helper_1.EditHelper.deleteStatement(file, statement);
-                const fix2 = edit_helper_1.EditHelper.deleteRange(file, implementation.getFirstToken().getStart(), implementation.getLastToken().getEnd());
-                fix = edit_helper_1.EditHelper.merge(fix1, fix2);
+            if (i.visibility === visibility_1.Visibility.Private) {
+                const implementation = this.findMethodImplementation(i, file);
+                if (implementation !== undefined) {
+                    const fix1 = edit_helper_1.EditHelper.deleteStatement(file, statement);
+                    const fix2 = edit_helper_1.EditHelper.deleteRange(file, implementation.getFirstToken().getStart(), implementation.getLastToken().getEnd());
+                    fix = edit_helper_1.EditHelper.merge(fix1, fix2);
+                }
             }
             const message = "Method \"" + i.identifier.getName() + "\" not used";
             issues.push(issue_1.Issue.atIdentifier(i.identifier, message, this.getMetadata().key, this.conf.severity, fix));

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@abaplint/cli",
-    "version": "2.113.10",
+    "version": "2.113.12",
     "description": "abaplint - Command Line Interface",
     "funding": "https://github.com/sponsors/larshp",
     "bin": {
@@ -38,7 +38,7 @@
     },
     "homepage": "https://abaplint.org",
     "devDependencies": {
-        "@abaplint/core": "^2.113.10",
+        "@abaplint/core": "^2.113.12",
         "@types/chai": "^4.3.19",
         "@types/glob": "^8.1.0",
         "@types/minimist": "^1.2.5",