@abaplint/cli 2.112.0 → 2.112.2

package/build/cli.js

@@ -23938,7 +23938,7 @@ class AttributeChain {
         }
         if (context === undefined) {
             const message = "Attribute or constant \"" + name + "\" not found in \"" + def.getName() + "\"";
-            input.issues.push((0, _syntax_input_1.syntaxIssue)(input, node.getFirstToken(), message));
+            input.issues.push((0, _syntax_input_1.syntaxIssue)(input, nameToken, message));
             return new void_type_1.VoidType(_syntax_input_1.CheckSyntaxKey);
         }
         for (const t of type) {
@@ -24104,7 +24104,7 @@ class Cast {
             else if (tt === undefined) {
                 // todo, this should be an UnknownType instead?
                 const message = "Type \"" + typeName + "\" not found in scope, Cast";
-                input.issues.push((0, _syntax_input_1.syntaxIssue)(input, node.getFirstToken(), message));
+                input.issues.push((0, _syntax_input_1.syntaxIssue)(input, typeExpression.getFirstToken(), message));
                 return new basic_1.VoidType(_syntax_input_1.CheckSyntaxKey);
             }
         }
@@ -24191,21 +24191,21 @@ class ComponentChain {
                 if (concat === "-") {
                     if (!(context instanceof structure_type_1.StructureType)) {
                         const message = "ComponentChain, not a structure";
-                        input.issues.push((0, _syntax_input_1.syntaxIssue)(input, node.getFirstToken(), message));
+                        input.issues.push((0, _syntax_input_1.syntaxIssue)(input, child.getFirstToken(), message));
                         return new void_type_1.VoidType(_syntax_input_1.CheckSyntaxKey);
                     }
                 }
                 else if (concat === "=>") {
                     if (!(context instanceof basic_1.ObjectReferenceType)) {
                         const message = "ComponentChain, not a reference";
-                        input.issues.push((0, _syntax_input_1.syntaxIssue)(input, node.getFirstToken(), message));
+                        input.issues.push((0, _syntax_input_1.syntaxIssue)(input, child.getFirstToken(), message));
                         return new void_type_1.VoidType(_syntax_input_1.CheckSyntaxKey);
                     }
                 }
                 else if (concat === "->") {
                     if (!(context instanceof basic_1.ObjectReferenceType) && !(context instanceof basic_1.DataReference)) {
                         const message = "ComponentChain, not a reference";
-                        input.issues.push((0, _syntax_input_1.syntaxIssue)(input, node.getFirstToken(), message));
+                        input.issues.push((0, _syntax_input_1.syntaxIssue)(input, child.getFirstToken(), message));
                         return new void_type_1.VoidType(_syntax_input_1.CheckSyntaxKey);
                     }
                 }
@@ -24222,7 +24222,7 @@ class ComponentChain {
                     context = context.getComponentByName(name);
                     if (context === undefined) {
                         const message = "Component \"" + name + "\" not found in structure";
-                        input.issues.push((0, _syntax_input_1.syntaxIssue)(input, node.getFirstToken(), message));
+                        input.issues.push((0, _syntax_input_1.syntaxIssue)(input, child.getFirstToken(), message));
                         return new void_type_1.VoidType(_syntax_input_1.CheckSyntaxKey);
                     }
                 }
@@ -24231,7 +24231,7 @@ class ComponentChain {
                     const def = input.scope.findObjectDefinition(id.getName());
                     if (def === undefined) {
                         const message = id.getName() + " not found in scope";
-                        input.issues.push((0, _syntax_input_1.syntaxIssue)(input, node.getFirstToken(), message));
+                        input.issues.push((0, _syntax_input_1.syntaxIssue)(input, child.getFirstToken(), message));
                         return new void_type_1.VoidType(_syntax_input_1.CheckSyntaxKey);
                     }
                     const helper = new _object_oriented_1.ObjectOriented(input.scope);
@@ -24239,7 +24239,7 @@ class ComponentChain {
                     context = found === null || found === void 0 ? void 0 : found.getType();
                     if (context === undefined) {
                         const message = "Attribute \"" + name + "\" not found";
-                        input.issues.push((0, _syntax_input_1.syntaxIssue)(input, node.getFirstToken(), message));
+                        input.issues.push((0, _syntax_input_1.syntaxIssue)(input, child.getFirstToken(), message));
                         return new void_type_1.VoidType(_syntax_input_1.CheckSyntaxKey);
                     }
                     else {
@@ -24252,7 +24252,7 @@ class ComponentChain {
                 }
                 else {
                     const message = "ComponentChain, not a structure, " + (context === null || context === void 0 ? void 0 : context.constructor.name);
-                    input.issues.push((0, _syntax_input_1.syntaxIssue)(input, node.getFirstToken(), message));
+                    input.issues.push((0, _syntax_input_1.syntaxIssue)(input, child.getFirstToken(), message));
                     return new void_type_1.VoidType(_syntax_input_1.CheckSyntaxKey);
                 }
             }
@@ -25733,7 +25733,7 @@ class MethodCallChain {
                 else {
                     if (previous && previous.getFirstToken().getStr() === "=>" && (method === null || method === void 0 ? void 0 : method.isStatic()) === false) {
                         const message = "Method \"" + methodName + "\" not static";
-                        input.issues.push((0, _syntax_input_1.syntaxIssue)(input, node.getFirstToken(), message));
+                        input.issues.push((0, _syntax_input_1.syntaxIssue)(input, methodToken, message));
                         return new basic_1.VoidType(_syntax_input_1.CheckSyntaxKey);
                     }
                     const extra = {
@@ -25754,7 +25754,7 @@ class MethodCallChain {
                 }
                 else if (method === undefined && !(context instanceof basic_1.VoidType)) {
                     const message = "Method \"" + methodName + "\" not found, methodCallChain";
-                    input.issues.push((0, _syntax_input_1.syntaxIssue)(input, node.getFirstToken(), message));
+                    input.issues.push((0, _syntax_input_1.syntaxIssue)(input, methodToken, message));
                     return new basic_1.VoidType(_syntax_input_1.CheckSyntaxKey);
                 }
                 else if (method) {
@@ -34014,7 +34014,7 @@ class Data {
                 }
                 if (!(found instanceof Basic.StructureType)) {
                     const message = "not structured, " + typeName;
-                    input.issues.push((0, _syntax_input_1.syntaxIssue)(input, node.getFirstToken(), message));
+                    input.issues.push((0, _syntax_input_1.syntaxIssue)(input, typeToken, message));
                     return new _typed_identifier_1.TypedIdentifier(name, input.filename, new Basic.VoidType(_syntax_input_1.CheckSyntaxKey));
                 }
                 for (const c of found.getComponents()) {
@@ -38838,6 +38838,7 @@ class InterfaceDefinition extends _identifier_1.Identifier {
         this.typeDefinitions = this.attributes.getTypes();
         this.aliases = new aliases_1.Aliases(node, this.filename, input.scope);
         // todo, cleanup aliases, vs "object_oriented.ts" vs "class_implementation.ts"
+        // this adds the aliased types to scope?
         for (const a of this.aliases.getAll()) {
             const [objName, fieldName] = a.getComponent().split("~");
             const idef = input.scope.findInterfaceDefinition(objName);
@@ -38857,10 +38858,6 @@ class InterfaceDefinition extends _identifier_1.Identifier {
                 }
             }
         }
-        this.methodDefinitions = new method_definitions_1.MethodDefinitions(node, input);
-        if (this.methodDefinitions.getByName("CONSTRUCTOR") !== undefined) {
-            throw new Error("Interfaces cannot have constructor methods");
-        }
         const events = node.findAllStatements(Statements.Events);
         for (const e of events) {
             this.events.push(new event_definition_1.EventDefinition(e, visibility_1.Visibility.Public, input));
@@ -38882,6 +38879,10 @@ class InterfaceDefinition extends _identifier_1.Identifier {
                 }
             }
         }
+        this.methodDefinitions = new method_definitions_1.MethodDefinitions(node, input);
+        if (this.methodDefinitions.getByName("CONSTRUCTOR") !== undefined) {
+            throw new Error("Interfaces cannot have constructor methods");
+        }
     }
 }
 exports.InterfaceDefinition = InterfaceDefinition;
@@ -40732,6 +40733,10 @@ class Config {
         if (this.config.syntax.globalConstants === undefined) {
             this.config.syntax.globalConstants = [];
         }
+        else {
+            // remove duplicates,
+            this.config.syntax.globalConstants = [...new Set(this.config.syntax.globalConstants)];
+        }
         if (this.config.global.skipIncludesWithoutMain === undefined) {
             this.config.global.skipIncludesWithoutMain = false;
         }
@@ -52399,7 +52404,7 @@ class Registry {
     }
     static abaplintVersion() {
         // magic, see build script "version.sh"
-        return "2.112.0";
+        return "2.112.2";
     }
     getDDICReferences() {
         return this.ddicReferences;
@@ -57179,6 +57184,8 @@ class DoubleSpaceConf extends _basic_rule_config_1.BasicRuleConfig {
         super(...arguments);
         /** Check for double space after keywords */
         this.keywords = true;
+        /** list of keywords to skip, case insensitive */
+        this.skipKeywords = ["CHANGING", "EXPORTING", "OTHERS"];
         /** Check for double space after start parenthesis */
         this.startParen = true;
         /** Check for double space before end parenthesis */
@@ -57211,6 +57218,9 @@ class DoubleSpace extends _abap_rule_1.ABAPRule {
     }
     setConfig(conf) {
         this.conf = conf;
+        if (this.conf.skipKeywords === undefined) {
+            this.conf.skipKeywords = new DoubleSpaceConf().skipKeywords;
+        }
     }
     runParsed(file) {
         let issues = [];
@@ -57322,9 +57332,7 @@ class DoubleSpace extends _abap_rule_1.ABAPRule {
             if (prev instanceof nodes_1.TokenNodeRegex
                 || upper === "("
                 || upper === ")"
-                || upper === "CHANGING"
-                || upper === "EXPORTING"
-                || upper === "OTHERS") {
+                || this.getConfig().skipKeywords.some(e => e.toUpperCase() === upper)) {
                 // not a keyword, continue
                 prev = n;
                 continue;

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@abaplint/cli",
-    "version": "2.112.0",
+    "version": "2.112.2",
     "description": "abaplint - Command Line Interface",
     "funding": "https://github.com/sponsors/larshp",
     "bin": {
@@ -38,7 +38,7 @@
     },
     "homepage": "https://abaplint.org",
     "devDependencies": {
-        "@abaplint/core": "^2.112.0",
+        "@abaplint/core": "^2.112.2",
         "@types/chai": "^4.3.16",
         "@types/glob": "^8.1.0",
         "@types/minimist": "^1.2.5",