@abaplint/cli 2.102.7 → 2.102.9

package/build/cli.js

@@ -19249,7 +19249,12 @@ class BuiltInMethod extends _identifier_1.Identifier {
         this.row = row;
     }
     getRequiredParameters() {
-        return [];
+        const ret = [];
+        for (const i in this.method.mandatory) {
+            const id = new tokens_1.Identifier(new position_1.Position(this.row, 1), i);
+            ret.push(new _typed_identifier_1.TypedIdentifier(id, BuiltIn.filename, this.method.mandatory[i]));
+        }
+        return ret;
     }
     getOptional() {
         throw new Error("BuiltInMethod->Method not implemented.");
@@ -27640,10 +27645,15 @@ const Expressions = __webpack_require__(/*! ../../2_statements/expressions */ ".
 const _reference_1 = __webpack_require__(/*! ../_reference */ "./node_modules/@abaplint/core/build/src/abap/5_syntax/_reference.js");
 class ClassLocalFriends {
     runSyntax(node, scope, filename) {
-        const found = node.findDirectExpression(Expressions.ClassName);
+        const classNames = node.findAllExpressions(Expressions.ClassName);
+        const found = classNames[0];
         if (found) {
             const token = found.getFirstToken();
             const name = token.getStr();
+            if (scope.getParentObj().getType() === "CLAS"
+                && name.toUpperCase() !== scope.getParentObj().getName().toUpperCase()) {
+                throw new Error(`Befriending must be ` + scope.getParentObj().getName().toUpperCase());
+            }
             const def = scope.findClassDefinition(name);
             if (def) {
                 scope.addReference(token, def, _reference_1.ReferenceType.ObjectOrientedReference, filename);
@@ -27652,6 +27662,14 @@ class ClassLocalFriends {
                 throw new Error(`Class ${name.toUpperCase()} not found`);
             }
         }
+        for (let i = 1; i < classNames.length; i++) {
+            const className = classNames[i].concatTokens();
+            // make sure to check also DEFINITION DEFERRED
+            const found = scope.existsObject(className);
+            if (found.found === false) {
+                throw new Error(`Class ${className.toUpperCase()} not found`);
+            }
+        }
     }
 }
 exports.ClassLocalFriends = ClassLocalFriends;
@@ -48538,7 +48556,7 @@ class Registry {
     }
     static abaplintVersion() {
         // magic, see build script "version.sh"
-        return "2.102.7";
+        return "2.102.9";
     }
     getDDICReferences() {
         return this.ddicReferences;
@@ -52457,6 +52475,9 @@ class CyclomaticComplexity {
     }
     setConfig(conf) {
         this.conf = conf;
+        if (this.conf.max === undefined) {
+            this.conf.max = new CyclomaticComplexityConf().max;
+        }
     }
     initialize(_reg) {
         return this;
@@ -53433,13 +53454,12 @@ Make sure to test the downported code, it might not always be completely correct
                     }
                 }
             }
-            else if (ret.length === 0 && / xsdbool\(/i.test(lowFile.getRaw())) {
+            if (ret.length === 0 && lowFile.getRaw().includes(" xsdbool( ")) {
                 for (let i = 0; i < lowStatements.length; i++) {
                     const high = highStatements[i];
                     const issue = this.replaceXsdBool(high, lowFile, highSyntax);
                     if (issue) {
                         ret.push(issue);
-                        break;
                     }
                 }
             }
@@ -53474,11 +53494,13 @@ Make sure to test the downported code, it might not always be completely correct
             return undefined;
         }
         // downport XSDBOOL() early, as it is valid 702 syntax
+        /*
         let found = this.replaceXsdBool(high, lowFile, highSyntax);
         if (found) {
-            return found;
+          return found;
         }
-        found = this.downportEnum(low, high, lowFile, highSyntax, highFile);
+        */
+        let found = this.downportEnum(low, high, lowFile, highSyntax, highFile);
         if (found) {
             return found;
         }
@@ -55716,7 +55738,20 @@ ${indentation}    output = ${uniqueName}.\n`;
             if (r.referenceType === _reference_1.ReferenceType.BuiltinMethodReference
                 && r.position.getName().toUpperCase() === "XSDBOOL") {
                 const token = r.position.getToken();
-                const fix = edit_helper_1.EditHelper.replaceRange(lowFile, token.getStart(), token.getEnd(), "boolc");
+                let source = undefined;
+                for (const s of node.findAllExpressions(Expressions.Source)) {
+                    if (s.getFirstToken().getStart().equals(token.getStart())) {
+                        source = s;
+                        break;
+                    }
+                }
+                const children = source === null || source === void 0 ? void 0 : source.getChildren();
+                if (source === undefined || (children === null || children === void 0 ? void 0 : children.length) !== 4) {
+                    continue;
+                }
+                // make sure to convert to the correct type, RTTI might be used on the result of XSDBOOL
+                const code = "CONV xsdboolean( boolc( " + children[2].concatTokens() + " ) )";
+                const fix = edit_helper_1.EditHelper.replaceRange(lowFile, source.getFirstToken().getStart(), source.getLastToken().getEnd(), code);
                 return issue_1.Issue.atToken(lowFile, token, "Use BOOLC", this.getMetadata().key, this.conf.severity, fix);
             }
         }

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@abaplint/cli",
-    "version": "2.102.7",
+    "version": "2.102.9",
     "description": "abaplint - Command Line Interface",
     "funding": "https://github.com/sponsors/larshp",
     "bin": {
@@ -38,7 +38,7 @@
     },
     "homepage": "https://abaplint.org",
     "devDependencies": {
-        "@abaplint/core": "^2.102.7",
+        "@abaplint/core": "^2.102.9",
         "@types/chai": "^4.3.5",
         "@types/glob": "^7.2.0",
         "@types/minimist": "^1.2.2",
@@ -47,7 +47,7 @@
         "@types/progress": "^2.0.5",
         "chai": "^4.3.7",
         "chalk": "^5.3.0",
-        "eslint": "^8.45.0",
+        "eslint": "^8.46.0",
         "glob": "^7.2.3",
         "json5": "^2.2.3",
         "memfs": "^4.2.0",