@abaplint/cli 2.102.64 → 2.102.66

package/build/cli.js

@@ -25507,6 +25507,7 @@ const source_1 = __webpack_require__(/*! ./source */ "./node_modules/@abaplint/c
 const _object_oriented_1 = __webpack_require__(/*! ../_object_oriented */ "./node_modules/@abaplint/core/build/src/abap/5_syntax/_object_oriented.js");
 const method_parameters_1 = __webpack_require__(/*! ./method_parameters */ "./node_modules/@abaplint/core/build/src/abap/5_syntax/expressions/method_parameters.js");
 const basic_types_1 = __webpack_require__(/*! ../basic_types */ "./node_modules/@abaplint/core/build/src/abap/5_syntax/basic_types.js");
+const _type_utils_1 = __webpack_require__(/*! ../_type_utils */ "./node_modules/@abaplint/core/build/src/abap/5_syntax/_type_utils.js");
 class NewObject {
     runSyntax(node, scope, targetType, filename) {
         let ret = undefined;
@@ -25588,7 +25589,10 @@ class NewObject {
             if (type === undefined) {
                 throw new Error("NewObject, no default importing parameter found for constructor, " + name);
             }
-            new source_1.Source().runSyntax(source, scope, filename, type);
+            const sourceType = new source_1.Source().runSyntax(source, scope, filename, type);
+            if (new _type_utils_1.TypeUtils(scope).isAssignableStrict(sourceType, type) === false) {
+                throw new Error(`NEW parameter type not compatible`);
+            }
         }
         else if (parameters) {
             // parameters with names
@@ -25773,6 +25777,9 @@ class Select {
         const token = node.getFirstToken();
         const from = node.findDirectExpression(Expressions.SQLFrom);
         const dbSources = from ? new sql_from_1.SQLFrom().runSyntax(from, scope, filename) : [];
+        if (dbSources.length === 0) {
+            throw new Error(`Missing FROM`);
+        }
         const fields = this.findFields(node);
         if (fields.length === 0
             && node.findDirectExpression(Expressions.SQLFieldListLoop) === undefined) {
@@ -28638,6 +28645,7 @@ const _reference_1 = __webpack_require__(/*! ../_reference */ "./node_modules/@a
 const basic_1 = __webpack_require__(/*! ../../types/basic */ "./node_modules/@abaplint/core/build/src/abap/types/basic/index.js");
 const types_1 = __webpack_require__(/*! ../../types */ "./node_modules/@abaplint/core/build/src/abap/types/index.js");
 const _object_oriented_1 = __webpack_require__(/*! ../_object_oriented */ "./node_modules/@abaplint/core/build/src/abap/5_syntax/_object_oriented.js");
+const _type_utils_1 = __webpack_require__(/*! ../_type_utils */ "./node_modules/@abaplint/core/build/src/abap/5_syntax/_type_utils.js");
 class CreateObject {
     runSyntax(node, scope, filename) {
         let cdef = undefined;
@@ -28661,7 +28669,7 @@ class CreateObject {
             }
         }
         // just recurse
-        for (const s of node.findAllExpressions(Expressions.Source)) {
+        for (const s of node.findDirectExpressions(Expressions.Source)) {
             new source_1.Source().runSyntax(s, scope, filename);
         }
         let first = true;
@@ -28705,26 +28713,35 @@ class CreateObject {
         for (const t of node.findDirectExpressions(Expressions.Dynamic)) {
             new dynamic_1.Dynamic().runSyntax(t, scope, filename);
         }
-        this.validateParameters(cdef, node, scope);
+        this.validateParameters(cdef, node, scope, filename);
     }
-    validateParameters(cdef, node, scope) {
-        var _a, _b, _c;
+    validateParameters(cdef, node, scope, filename) {
+        var _a, _b, _c, _d;
         if (cdef === undefined) {
+            const sources = (_a = node.findDirectExpression(Expressions.ParameterListS)) === null || _a === void 0 ? void 0 : _a.findAllExpressions(Expressions.Source);
+            for (const s of sources || []) {
+                new source_1.Source().runSyntax(s, scope, filename);
+            }
             return;
         }
         const methodDef = new _object_oriented_1.ObjectOriented(scope).searchMethodName(cdef, "CONSTRUCTOR");
-        const methodParameters = (_a = methodDef.method) === null || _a === void 0 ? void 0 : _a.getParameters();
+        const methodParameters = (_b = methodDef.method) === null || _b === void 0 ? void 0 : _b.getParameters();
         const allImporting = (methodParameters === null || methodParameters === void 0 ? void 0 : methodParameters.getImporting()) || [];
         const requiredImporting = new Set(methodParameters === null || methodParameters === void 0 ? void 0 : methodParameters.getRequiredParameters().map(i => i.getName().toUpperCase()));
-        // todo, validate types
-        for (const p of ((_b = node.findDirectExpression(Expressions.ParameterListS)) === null || _b === void 0 ? void 0 : _b.findAllExpressions(Expressions.ParameterS)) || []) {
-            const name = (_c = p.findDirectExpression(Expressions.ParameterName)) === null || _c === void 0 ? void 0 : _c.concatTokens().toUpperCase();
+        for (const p of ((_c = node.findDirectExpression(Expressions.ParameterListS)) === null || _c === void 0 ? void 0 : _c.findAllExpressions(Expressions.ParameterS)) || []) {
+            const name = (_d = p.findDirectExpression(Expressions.ParameterName)) === null || _d === void 0 ? void 0 : _d.concatTokens().toUpperCase();
             if (name === undefined) {
                 continue;
             }
-            if ((allImporting === null || allImporting === void 0 ? void 0 : allImporting.some(p => p.getName().toUpperCase() === name)) === false) {
+            const source = p.findDirectExpression(Expressions.Source);
+            const sourceType = new source_1.Source().runSyntax(source, scope, filename);
+            const found = allImporting === null || allImporting === void 0 ? void 0 : allImporting.find(p => p.getName().toUpperCase() === name);
+            if (found === undefined) {
                 throw new Error(`constructor parameter "${name}" does not exist`);
             }
+            else if (new _type_utils_1.TypeUtils(scope).isAssignableStrict(sourceType, found.getType()) === false) {
+                throw new Error(`constructor parameter "${name}" type not compatible`);
+            }
             requiredImporting.delete(name);
         }
         for (const r of requiredImporting.values()) {
@@ -50139,7 +50156,7 @@ class Registry {
     }
     static abaplintVersion() {
         // magic, see build script "version.sh"
-        return "2.102.64";
+        return "2.102.66";
     }
     getDDICReferences() {
         return this.ddicReferences;
@@ -67398,6 +67415,7 @@ class SlowParameterPassing {
             key: "slow_parameter_passing",
             title: "Slow Parameter Passing",
             shortDescription: `Detects slow pass by value passing for methods where parameter is not changed`,
+            extendedInformation: `Method parameters defined in interfaces is not checked`,
             tags: [_irule_1.RuleTag.Performance],
         };
     }
@@ -67420,17 +67438,22 @@ class SlowParameterPassing {
         const methods = this.listMethodNodes(top);
         for (const m of methods) {
             const vars = m.getData().vars;
+            if (m.getIdentifier().sname.includes("~")) {
+                // skip methods defined in interfaces
+                // todo: checking for just "~" is not correct, there might be ALIASES
+                continue;
+            }
             for (const v in vars) {
                 const id = vars[v];
                 if (id.getMeta().includes("pass_by_value" /* IdentifierMeta.PassByValue */) === false) {
                     continue;
                 }
+                else if (this.reg.isFileDependency(id.getFilename()) === true) {
+                    continue;
+                }
                 const writes = this.listWritePositions(m, id);
                 if (writes.length === 0) {
                     const message = "Parameter " + id.getName() + " passed by VALUE but not changed";
-                    if (this.reg.isFileDependency(id.getFilename()) === true) {
-                        continue;
-                    }
                     issues.push(issue_1.Issue.atIdentifier(id, message, this.getMetadata().key, this.getConfig().severity));
                 }
             }

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@abaplint/cli",
-    "version": "2.102.64",
+    "version": "2.102.66",
     "description": "abaplint - Command Line Interface",
     "funding": "https://github.com/sponsors/larshp",
     "bin": {
@@ -38,12 +38,12 @@
     },
     "homepage": "https://abaplint.org",
     "devDependencies": {
-        "@abaplint/core": "^2.102.64",
+        "@abaplint/core": "^2.102.66",
         "@types/chai": "^4.3.9",
         "@types/glob": "^7.2.0",
         "@types/minimist": "^1.2.4",
         "@types/mocha": "^10.0.3",
-        "@types/node": "^20.8.9",
+        "@types/node": "^20.8.10",
         "@types/progress": "^2.0.6",
         "chai": "^4.3.10",
         "chalk": "^5.3.0",