@abaplint/cli 2.102.42 → 2.102.44

package/build/cli.js

@@ -21792,7 +21792,8 @@ class TypeUtils {
             }
         }
         else if (source instanceof basic_1.IntegerType) {
-            if (target instanceof basic_1.StringType) {
+            if (target instanceof basic_1.StringType
+                || target instanceof basic_1.PackedType) {
                 return false;
             }
             else if (target instanceof basic_1.Integer8Type) {
@@ -26827,6 +26828,15 @@ class SpaghettiScopeNode extends ScopeData {
         }
         return ret;
     }
+    listInterfaceDefinitions() {
+        let search = this;
+        const ret = [];
+        while (search !== undefined) {
+            ret.push(...Object.values(search.getData().idefs));
+            search = search.getParent();
+        }
+        return ret;
+    }
     findFormDefinition(name) {
         let search = this;
         const upper = name.toUpperCase();
@@ -40065,6 +40075,7 @@ Object.defineProperty(exports, "__esModule", ({ value: true }));
 
 Object.defineProperty(exports, "__esModule", ({ value: true }));
 exports.LSPLookup = void 0;
+/* eslint-disable max-len */
 const LServer = __webpack_require__(/*! vscode-languageserver-types */ "./node_modules/vscode-languageserver-types/lib/esm/main.js");
 const Statements = __webpack_require__(/*! ../abap/2_statements/statements */ "./node_modules/@abaplint/core/build/src/abap/2_statements/statements/index.js");
 const Expressions = __webpack_require__(/*! ../abap/2_statements/expressions */ "./node_modules/@abaplint/core/build/src/abap/2_statements/expressions/index.js");
@@ -40147,13 +40158,14 @@ class LSPLookup {
             }
             return { hover: hoverValue, definition: location, implementation: location, definitionId: variable, scope: bottomScope };
         }
-        for (const c of bottomScope.listClassDefinitions()) {
+        // TODO: this can be optimized, no need to loop through all the defintions, the scope knows the name of the object?
+        for (const c of [...bottomScope.listClassDefinitions(), ...bottomScope.listInterfaceDefinitions()]) {
             for (const m of ((_a = c.getMethodDefinitions()) === null || _a === void 0 ? void 0 : _a.getAll()) || []) {
                 for (const p of ((_b = m.getParameters()) === null || _b === void 0 ? void 0 : _b.getAll()) || []) {
                     if (p.getStart().equals(cursor.token.getStart())) {
                         const found = _lsp_utils_1.LSPUtils.identiferToLocation(p);
                         return {
-                            hover: "Method Parameter, " + cursor.token.getStr(),
+                            hover: "Method Parameter: " + cursor.token.getStr().replace("!", ""),
                             definition: found,
                             definitionId: p,
                             implementation: undefined,
@@ -40335,11 +40347,12 @@ class LSPLookup {
         };
     }
     static findMethodDefinition(found, scope) {
-        var _a, _b, _c, _d;
+        var _a, _b, _c, _d, _e, _f, _g;
         if (scope === undefined) {
             return undefined;
         }
-        if (scope.getIdentifier().stype !== _scope_type_1.ScopeType.ClassDefinition
+        if ((scope.getIdentifier().stype !== _scope_type_1.ScopeType.ClassDefinition
+            && scope.getIdentifier().stype !== _scope_type_1.ScopeType.Interface)
             || !(found.snode.get() instanceof Statements.MethodDef)) {
             return undefined;
         }
@@ -40355,8 +40368,14 @@ class LSPLookup {
             || nameToken.getStart().getRow() !== found.token.getStart().getRow()) {
             return undefined;
         }
-        const def = (_d = (_c = (_b = scope.getParent()) === null || _b === void 0 ? void 0 : _b.findClassDefinition(scope.getIdentifier().sname)) === null || _c === void 0 ? void 0 : _c.getMethodDefinitions()) === null || _d === void 0 ? void 0 : _d.getByName(nameToken.getStr());
-        return def;
+        if (scope.getIdentifier().stype === _scope_type_1.ScopeType.ClassDefinition) {
+            const def = (_d = (_c = (_b = scope.getParent()) === null || _b === void 0 ? void 0 : _b.findClassDefinition(scope.getIdentifier().sname)) === null || _c === void 0 ? void 0 : _c.getMethodDefinitions()) === null || _d === void 0 ? void 0 : _d.getByName(nameToken.getStr());
+            return def;
+        }
+        else {
+            const def = (_g = (_f = (_e = scope.getParent()) === null || _e === void 0 ? void 0 : _e.findInterfaceDefinition(scope.getIdentifier().sname)) === null || _f === void 0 ? void 0 : _f.getMethodDefinitions()) === null || _g === void 0 ? void 0 : _g.getByName(nameToken.getStr());
+            return def;
+        }
     }
     static findFunctionModule(found) {
         if (!(found.snode.get() instanceof Statements.CallFunction)) {
@@ -48896,7 +48915,7 @@ class Registry {
     }
     static abaplintVersion() {
         // magic, see build script "version.sh"
-        return "2.102.42";
+        return "2.102.44";
     }
     getDDICReferences() {
         return this.ddicReferences;
@@ -51564,7 +51583,8 @@ FIND statement with MATCH COUNT is considered okay if subrc is not checked`,
             if (statement.get() instanceof _statement_1.Comment) {
                 continue;
             }
-            else if (statement.get() instanceof Statements.EndIf) {
+            else if (statement.get() instanceof Statements.EndIf
+                || statement.get() instanceof Statements.EndTestSeam) {
                 continue;
             }
             else {
@@ -51591,7 +51611,8 @@ FIND statement with MATCH COUNT is considered okay if subrc is not checked`,
                     return true;
                 }
             }
-            else if (statement.get() instanceof Statements.EndIf) {
+            else if (statement.get() instanceof Statements.EndIf
+                || statement.get() instanceof Statements.EndTestSeam) {
                 continue;
             }
             else {
@@ -52098,7 +52119,12 @@ class CloudTypes {
     }
     run(obj) {
         if (this.reg.getConfig().getVersion() !== version_1.Version.Cloud
+            || obj instanceof Objects.ApplicationJobCatalogEntry
+            || obj instanceof Objects.ApplicationJobTemplate
             || obj instanceof Objects.AssignmentServiceToAuthorizationGroup
+            || obj instanceof Objects.ATCCheckCategory
+            || obj instanceof Objects.ATCCheckObject
+            || obj instanceof Objects.ATCCheckVariant
             || obj instanceof Objects.AuthorizationCheckField
             || obj instanceof Objects.AuthorizationObject
             || obj instanceof Objects.AuthorizationObjectExtension
@@ -52106,11 +52132,7 @@ class CloudTypes {
             || obj instanceof Objects.BusinessCatalog
             || obj instanceof Objects.BusinessCatalogAppAssignment
             || obj instanceof Objects.CDSMetadataExtension
-            || obj instanceof Objects.RestrictionField
             || obj instanceof Objects.Class
-            || obj instanceof Objects.OutboundService
-            || obj instanceof Objects.ApplicationJobCatalogEntry
-            || obj instanceof Objects.ApplicationJobTemplate
             || obj instanceof Objects.CommunicationScenario
             || obj instanceof Objects.DataControl
             || obj instanceof Objects.DataDefinition
@@ -52122,11 +52144,11 @@ class CloudTypes {
             || obj instanceof Objects.InboundService
             || obj instanceof Objects.Interface
             || obj instanceof Objects.LockObject
-            || obj instanceof Objects.ATCCheckCategory
-            || obj instanceof Objects.ATCCheckObject
-            || obj instanceof Objects.ATCCheckVariant
             || obj instanceof Objects.MessageClass
+            || obj instanceof Objects.NumberRange
+            || obj instanceof Objects.OutboundService
             || obj instanceof Objects.Package
+            || obj instanceof Objects.RestrictionField
             || obj instanceof Objects.RestrictionType
             || obj instanceof Objects.ServiceBinding
             || obj instanceof Objects.ServiceDefinition

package/package.json

@@ -1,10 +1,10 @@
 {
     "name": "@abaplint/cli",
-    "version": "2.102.42",
+    "version": "2.102.44",
     "description": "abaplint - Command Line Interface",
     "funding": "https://github.com/sponsors/larshp",
     "bin": {
-        "abaplint": "./abaplint"
+        "abaplint": "abaplint"
     },
     "scripts": {
         "lint": "eslint src/**/*.ts test/**/*.ts --format unix",
@@ -38,12 +38,12 @@
     },
     "homepage": "https://abaplint.org",
     "devDependencies": {
-        "@abaplint/core": "^2.102.42",
+        "@abaplint/core": "^2.102.44",
         "@types/chai": "^4.3.6",
         "@types/glob": "^7.2.0",
         "@types/minimist": "^1.2.2",
         "@types/mocha": "^10.0.1",
-        "@types/node": "^20.6.2",
+        "@types/node": "^20.6.3",
         "@types/progress": "^2.0.5",
         "chai": "^4.3.8",
         "chalk": "^5.3.0",