@abaplint/cli 2.102.15 → 2.102.16

package/build/cli.js

@@ -5067,7 +5067,6 @@ __exportStar(__webpack_require__(/*! ./component_compare */ "./node_modules/@aba
 __exportStar(__webpack_require__(/*! ./component_cond_sub */ "./node_modules/@abaplint/core/build/src/abap/2_statements/expressions/component_cond_sub.js"), exports);
 __exportStar(__webpack_require__(/*! ./component_cond */ "./node_modules/@abaplint/core/build/src/abap/2_statements/expressions/component_cond.js"), exports);
 __exportStar(__webpack_require__(/*! ./component_name */ "./node_modules/@abaplint/core/build/src/abap/2_statements/expressions/component_name.js"), exports);
-__exportStar(__webpack_require__(/*! ./sql_fields */ "./node_modules/@abaplint/core/build/src/abap/2_statements/expressions/sql_fields.js"), exports);
 __exportStar(__webpack_require__(/*! ./concatenated_constant */ "./node_modules/@abaplint/core/build/src/abap/2_statements/expressions/concatenated_constant.js"), exports);
 __exportStar(__webpack_require__(/*! ./cond_body */ "./node_modules/@abaplint/core/build/src/abap/2_statements/expressions/cond_body.js"), exports);
 __exportStar(__webpack_require__(/*! ./cond_sub */ "./node_modules/@abaplint/core/build/src/abap/2_statements/expressions/cond_sub.js"), exports);
@@ -5192,8 +5191,8 @@ __exportStar(__webpack_require__(/*! ./source_field */ "./node_modules/@abaplint
 __exportStar(__webpack_require__(/*! ./source */ "./node_modules/@abaplint/core/build/src/abap/2_statements/expressions/source.js"), exports);
 __exportStar(__webpack_require__(/*! ./sql_aggregation */ "./node_modules/@abaplint/core/build/src/abap/2_statements/expressions/sql_aggregation.js"), exports);
 __exportStar(__webpack_require__(/*! ./sql_alias_field */ "./node_modules/@abaplint/core/build/src/abap/2_statements/expressions/sql_alias_field.js"), exports);
-__exportStar(__webpack_require__(/*! ./sql_arithmetics */ "./node_modules/@abaplint/core/build/src/abap/2_statements/expressions/sql_arithmetics.js"), exports);
 __exportStar(__webpack_require__(/*! ./sql_arithmetic_operator */ "./node_modules/@abaplint/core/build/src/abap/2_statements/expressions/sql_arithmetic_operator.js"), exports);
+__exportStar(__webpack_require__(/*! ./sql_arithmetics */ "./node_modules/@abaplint/core/build/src/abap/2_statements/expressions/sql_arithmetics.js"), exports);
 __exportStar(__webpack_require__(/*! ./sql_as_name */ "./node_modules/@abaplint/core/build/src/abap/2_statements/expressions/sql_as_name.js"), exports);
 __exportStar(__webpack_require__(/*! ./sql_case */ "./node_modules/@abaplint/core/build/src/abap/2_statements/expressions/sql_case.js"), exports);
 __exportStar(__webpack_require__(/*! ./sql_cds_parameters */ "./node_modules/@abaplint/core/build/src/abap/2_statements/expressions/sql_cds_parameters.js"), exports);
@@ -5206,6 +5205,7 @@ __exportStar(__webpack_require__(/*! ./sql_field_list_loop */ "./node_modules/@a
 __exportStar(__webpack_require__(/*! ./sql_field_list */ "./node_modules/@abaplint/core/build/src/abap/2_statements/expressions/sql_field_list.js"), exports);
 __exportStar(__webpack_require__(/*! ./sql_field_name */ "./node_modules/@abaplint/core/build/src/abap/2_statements/expressions/sql_field_name.js"), exports);
 __exportStar(__webpack_require__(/*! ./sql_field */ "./node_modules/@abaplint/core/build/src/abap/2_statements/expressions/sql_field.js"), exports);
+__exportStar(__webpack_require__(/*! ./sql_fields */ "./node_modules/@abaplint/core/build/src/abap/2_statements/expressions/sql_fields.js"), exports);
 __exportStar(__webpack_require__(/*! ./sql_for_all_entries */ "./node_modules/@abaplint/core/build/src/abap/2_statements/expressions/sql_for_all_entries.js"), exports);
 __exportStar(__webpack_require__(/*! ./sql_from_source */ "./node_modules/@abaplint/core/build/src/abap/2_statements/expressions/sql_from_source.js"), exports);
 __exportStar(__webpack_require__(/*! ./sql_from */ "./node_modules/@abaplint/core/build/src/abap/2_statements/expressions/sql_from.js"), exports);
@@ -5238,6 +5238,7 @@ __exportStar(__webpack_require__(/*! ./text_element_key */ "./node_modules/@abap
 __exportStar(__webpack_require__(/*! ./text_element_string */ "./node_modules/@abaplint/core/build/src/abap/2_statements/expressions/text_element_string.js"), exports);
 __exportStar(__webpack_require__(/*! ./text_element */ "./node_modules/@abaplint/core/build/src/abap/2_statements/expressions/text_element.js"), exports);
 __exportStar(__webpack_require__(/*! ./throw */ "./node_modules/@abaplint/core/build/src/abap/2_statements/expressions/throw.js"), exports);
+__exportStar(__webpack_require__(/*! ./transporting_fields */ "./node_modules/@abaplint/core/build/src/abap/2_statements/expressions/transporting_fields.js"), exports);
 __exportStar(__webpack_require__(/*! ./type_name_or_infer */ "./node_modules/@abaplint/core/build/src/abap/2_statements/expressions/type_name_or_infer.js"), exports);
 __exportStar(__webpack_require__(/*! ./type_name */ "./node_modules/@abaplint/core/build/src/abap/2_statements/expressions/type_name.js"), exports);
 __exportStar(__webpack_require__(/*! ./type_param */ "./node_modules/@abaplint/core/build/src/abap/2_statements/expressions/type_param.js"), exports);
@@ -8333,6 +8334,30 @@ exports.Throw = Throw;
 
 /***/ }),
 
+/***/ "./node_modules/@abaplint/core/build/src/abap/2_statements/expressions/transporting_fields.js":
+/*!****************************************************************************************************!*\
+  !*** ./node_modules/@abaplint/core/build/src/abap/2_statements/expressions/transporting_fields.js ***!
+  \****************************************************************************************************/
+/***/ ((__unused_webpack_module, exports, __webpack_require__) => {
+
+"use strict";
+
+Object.defineProperty(exports, "__esModule", ({ value: true }));
+exports.TransportingFields = void 0;
+const combi_1 = __webpack_require__(/*! ../combi */ "./node_modules/@abaplint/core/build/src/abap/2_statements/combi.js");
+const dynamic_1 = __webpack_require__(/*! ./dynamic */ "./node_modules/@abaplint/core/build/src/abap/2_statements/expressions/dynamic.js");
+const field_sub_1 = __webpack_require__(/*! ./field_sub */ "./node_modules/@abaplint/core/build/src/abap/2_statements/expressions/field_sub.js");
+class TransportingFields extends combi_1.Expression {
+    getRunnable() {
+        const fields = (0, combi_1.plus)((0, combi_1.alt)((0, combi_1.seq)("INTO", (0, combi_1.failStar)()), field_sub_1.FieldSub));
+        return (0, combi_1.altPrio)(dynamic_1.Dynamic, fields);
+    }
+}
+exports.TransportingFields = TransportingFields;
+//# sourceMappingURL=transporting_fields.js.map
+
+/***/ }),
+
 /***/ "./node_modules/@abaplint/core/build/src/abap/2_statements/expressions/type.js":
 /*!*************************************************************************************!*\
   !*** ./node_modules/@abaplint/core/build/src/abap/2_statements/expressions/type.js ***!
@@ -14695,6 +14720,7 @@ exports.ReadTable = void 0;
 const combi_1 = __webpack_require__(/*! ../combi */ "./node_modules/@abaplint/core/build/src/abap/2_statements/combi.js");
 const expressions_1 = __webpack_require__(/*! ../expressions */ "./node_modules/@abaplint/core/build/src/abap/2_statements/expressions/index.js");
 const version_1 = __webpack_require__(/*! ../../../version */ "./node_modules/@abaplint/core/build/src/version.js");
+const transporting_fields_1 = __webpack_require__(/*! ../expressions/transporting_fields */ "./node_modules/@abaplint/core/build/src/abap/2_statements/expressions/transporting_fields.js");
 class ReadTable {
     getMatcher() {
         const comparing = (0, combi_1.seq)("COMPARING", (0, combi_1.alt)((0, combi_1.plus)(expressions_1.FieldSub), expressions_1.Dynamic));
@@ -14703,8 +14729,7 @@ class ReadTable {
         const key = (0, combi_1.seq)((0, combi_1.altPrio)("WITH KEY", "WITH TABLE KEY"), (0, combi_1.alt)(expressions_1.ComponentCompareSimple, components, (0, combi_1.seq)((0, combi_1.optPrio)("="), expressions_1.Source)));
         const using = (0, combi_1.seq)("USING KEY", (0, combi_1.alt)(expressions_1.Field, expressions_1.Dynamic));
         const from = (0, combi_1.seq)("FROM", expressions_1.Source);
-        const fields = (0, combi_1.plus)((0, combi_1.alt)((0, combi_1.seq)("INTO", (0, combi_1.failStar)()), expressions_1.FieldSub));
-        const perm = (0, combi_1.per)((0, combi_1.alt)(index, key, from), expressions_1.ReadTableTarget, using, comparing, "CASTING", "TRANSPORTING ALL FIELDS", (0, combi_1.seq)("TRANSPORTING", (0, combi_1.altPrio)(expressions_1.Dynamic, fields)), "BINARY SEARCH");
+        const perm = (0, combi_1.per)((0, combi_1.alt)(index, key, from), expressions_1.ReadTableTarget, using, comparing, "CASTING", "TRANSPORTING ALL FIELDS", (0, combi_1.seq)("TRANSPORTING", transporting_fields_1.TransportingFields), "BINARY SEARCH");
         return (0, combi_1.seq)("READ TABLE", (0, combi_1.alt)(expressions_1.SimpleSource2, (0, combi_1.ver)(version_1.Version.v740sp02, expressions_1.Source)), (0, combi_1.opt)(perm));
     }
 }
@@ -24405,22 +24430,28 @@ const Expressions = __webpack_require__(/*! ../../2_statements/expressions */ ".
 const source_1 = __webpack_require__(/*! ./source */ "./node_modules/@abaplint/core/build/src/abap/5_syntax/expressions/source.js");
 class MessageSource {
     runSyntax(node, scope, filename) {
-        var _a, _b, _c, _d;
+        var _a, _b, _c, _d, _e;
         for (const f of node.findDirectExpressions(Expressions.Source)) {
             new source_1.Source().runSyntax(f, scope, filename);
         }
         if (node.getFirstToken().getStr().toUpperCase() === "ID") {
             const id = (_a = node.findExpressionAfterToken("ID")) === null || _a === void 0 ? void 0 : _a.concatTokens();
-            const number = (_b = node.findDirectExpression(Expressions.MessageNumber)) === null || _b === void 0 ? void 0 : _b.concatTokens();
+            let number = (_b = node.findDirectExpression(Expressions.MessageNumber)) === null || _b === void 0 ? void 0 : _b.concatTokens();
+            if (number === undefined) {
+                const num = (_c = node.findExpressionAfterToken("NUMBER")) === null || _c === void 0 ? void 0 : _c.concatTokens();
+                if (num === null || num === void 0 ? void 0 : num.startsWith("'")) {
+                    number = num.substring(1, num.length - 1).toUpperCase();
+                }
+            }
             if ((id === null || id === void 0 ? void 0 : id.startsWith("'")) && number) {
                 const messageClass = id.substring(1, id.length - 1).toUpperCase();
                 scope.getMSAGReferences().addUsing(filename, node.getFirstToken(), messageClass, number);
             }
         }
         else {
-            const typeAndNumber = (_c = node.findDirectExpression(Expressions.MessageTypeAndNumber)) === null || _c === void 0 ? void 0 : _c.concatTokens();
+            const typeAndNumber = (_d = node.findDirectExpression(Expressions.MessageTypeAndNumber)) === null || _d === void 0 ? void 0 : _d.concatTokens();
             const messageNumber = typeAndNumber === null || typeAndNumber === void 0 ? void 0 : typeAndNumber.substring(1);
-            const messageClass = (_d = node.findDirectExpression(Expressions.MessageClass)) === null || _d === void 0 ? void 0 : _d.concatTokens().toUpperCase();
+            const messageClass = (_e = node.findDirectExpression(Expressions.MessageClass)) === null || _e === void 0 ? void 0 : _e.concatTokens().toUpperCase();
             if (messageNumber && messageClass) {
                 scope.getMSAGReferences().addUsing(filename, node.getFirstToken(), messageClass, messageNumber);
             }
@@ -29102,14 +29133,18 @@ class IncludeType {
         let ityp = new basic_types_1.BasicTypes(filename, scope).parseType(iname);
         const as = (_a = node.findExpressionAfterToken("AS")) === null || _a === void 0 ? void 0 : _a.concatTokens();
         if (as && ityp instanceof basic_1.StructureType) {
-            ityp = new basic_1.StructureType(ityp.getComponents().concat([{ name: as, type: ityp }]));
+            ityp = new basic_1.StructureType(ityp.getComponents().concat([{
+                    name: as,
+                    type: ityp,
+                    asInclude: true,
+                }]));
         }
         const suffix = (_b = node.findExpressionAfterToken("SUFFIX")) === null || _b === void 0 ? void 0 : _b.concatTokens();
         if (suffix && ityp instanceof basic_1.StructureType) {
             const components = [];
             for (const c of ityp.getComponents()) {
                 if (c.name === as) {
-                    components.push(Object.assign(Object.assign({}, c), { renamingSuffix: suffix }));
+                    components.push(Object.assign(Object.assign({}, c), { suffix: suffix, asInclude: c.asInclude }));
                     continue;
                 }
                 components.push({
@@ -30052,7 +30087,7 @@ const method_parameters_1 = __webpack_require__(/*! ../expressions/method_parame
 class Raise {
     runSyntax(node, scope, filename) {
         // todo
-        var _a, _b, _c, _d, _e;
+        var _a, _b, _c, _d, _e, _f;
         const helper = new _object_oriented_1.ObjectOriented(scope);
         let method;
         const classTok = (_a = node.findDirectExpression(Expressions.ClassName)) === null || _a === void 0 ? void 0 : _a.getFirstToken();
@@ -30111,7 +30146,13 @@ class Raise {
             new message_source_1.MessageSource().runSyntax(s, scope, filename);
         }
         const id = (_d = node.findExpressionAfterToken("ID")) === null || _d === void 0 ? void 0 : _d.concatTokens();
-        const number = (_e = node.findDirectExpression(Expressions.MessageNumber)) === null || _e === void 0 ? void 0 : _e.concatTokens();
+        let number = (_e = node.findDirectExpression(Expressions.MessageNumber)) === null || _e === void 0 ? void 0 : _e.concatTokens();
+        if (number === undefined) {
+            const num = (_f = node.findExpressionAfterToken("NUMBER")) === null || _f === void 0 ? void 0 : _f.concatTokens();
+            if (num === null || num === void 0 ? void 0 : num.startsWith("'")) {
+                number = num.substring(1, num.length - 1).toUpperCase();
+            }
+        }
         if ((id === null || id === void 0 ? void 0 : id.startsWith("'")) && number) {
             const messageClass = id.substring(1, id.length - 1).toUpperCase();
             scope.getMSAGReferences().addUsing(filename, node.getFirstToken(), messageClass, number);
@@ -30329,29 +30370,19 @@ class ReadTable {
                 rowType = new basic_1.DataReference(rowType);
             }
             const inline = target.findFirstExpression(Expressions.InlineData);
+            const fst = target.findDirectExpression(Expressions.FSTarget);
+            const t = target.findFirstExpression(Expressions.Target);
             if (inline) {
                 new inline_data_1.InlineData().runSyntax(inline, scope, filename, rowType);
-                return;
             }
-            const fst = target.findDirectExpression(Expressions.FSTarget);
-            if (fst) {
+            else if (fst) {
                 new fstarget_1.FSTarget().runSyntax(fst, scope, filename, rowType);
-                return;
             }
-            /*
-                  const inlinefs = target.findFirstExpression(Expressions.InlineFS);
-                  if (inlinefs) {
-                    new InlineFS().runSyntax(inlinefs, scope, filename, sourceType);
-                    return;
-                  }
-            */
-            const t = target.findFirstExpression(Expressions.Target);
-            if (t) {
+            else if (t) {
                 const targetType = new target_1.Target().runSyntax(t, scope, filename);
                 if (new _type_utils_1.TypeUtils(scope).isAssignable(rowType, targetType) === false) {
                     throw new Error("Incompatible types");
                 }
-                return;
             }
         }
         if (target === undefined && concat.includes(" TRANSPORTING NO FIELDS ") === false) {
@@ -30360,6 +30391,25 @@ class ReadTable {
                 throw new Error("READ TABLE, define INTO or TRANSPORTING NO FIELDS");
             }
         }
+        const transporting = node.findDirectExpression(Expressions.TransportingFields);
+        if (transporting
+            && !(rowType instanceof basic_1.VoidType)
+            && !(rowType instanceof basic_1.UnknownType)
+            && !(rowType instanceof basic_1.AnyType)) {
+            if (!(rowType instanceof basic_1.StructureType)) {
+                throw new Error("READ TABLE, source not structured");
+            }
+            for (const t of (transporting === null || transporting === void 0 ? void 0 : transporting.findDirectExpressions(Expressions.FieldSub)) || []) {
+                const field = t.concatTokens();
+                if (field.includes("-")) {
+                    // todo
+                    continue;
+                }
+                if (rowType.getComponentByName(field) === undefined) {
+                    throw new Error("READ TABLE, field " + field + " not found in source");
+                }
+            }
+        }
     }
 }
 exports.ReadTable = ReadTable;
@@ -41856,6 +41906,9 @@ class MSAGReferences {
         this.filenameIndex = {};
     }
     addUsing(filename, token, messageClass, number) {
+        if (number.length !== 3) {
+            return;
+        }
         if (this.filenameIndex[filename] === undefined) {
             this.filenameIndex[filename] = [];
         }
@@ -45496,6 +45549,7 @@ class MessageClass extends _abstract_object_1.AbstractObject {
         return "MSAG";
     }
     getDescription() {
+        this.parseXML();
         // todo
         return undefined;
     }
@@ -45515,6 +45569,7 @@ class MessageClass extends _abstract_object_1.AbstractObject {
         return msg ? msg : [];
     }
     getByNumber(num) {
+        this.parseXML();
         // todo, optimize performance,
         for (const message of this.getMessages()) {
             if (message.getNumber() === num) {
@@ -48569,7 +48624,7 @@ class Registry {
     }
     static abaplintVersion() {
         // magic, see build script "version.sh"
-        return "2.102.15";
+        return "2.102.16";
     }
     getDDICReferences() {
         return this.ddicReferences;
@@ -60569,17 +60624,23 @@ exports.MaxOneStatement = MaxOneStatement;
 Object.defineProperty(exports, "__esModule", ({ value: true }));
 exports.MessageExistsRule = exports.MessageExistsConf = void 0;
 const Expressions = __webpack_require__(/*! ../abap/2_statements/expressions */ "./node_modules/@abaplint/core/build/src/abap/2_statements/expressions/index.js");
+const Statements = __webpack_require__(/*! ../abap/2_statements/statements */ "./node_modules/@abaplint/core/build/src/abap/2_statements/statements/index.js");
 const issue_1 = __webpack_require__(/*! ../issue */ "./node_modules/@abaplint/core/build/src/issue.js");
-const _abap_rule_1 = __webpack_require__(/*! ./_abap_rule */ "./node_modules/@abaplint/core/build/src/rules/_abap_rule.js");
 const _basic_rule_config_1 = __webpack_require__(/*! ./_basic_rule_config */ "./node_modules/@abaplint/core/build/src/rules/_basic_rule_config.js");
 const ddic_1 = __webpack_require__(/*! ../ddic */ "./node_modules/@abaplint/core/build/src/ddic.js");
 const _irule_1 = __webpack_require__(/*! ./_irule */ "./node_modules/@abaplint/core/build/src/rules/_irule.js");
+const nodes_1 = __webpack_require__(/*! ../abap/nodes */ "./node_modules/@abaplint/core/build/src/abap/nodes/index.js");
+const _abap_object_1 = __webpack_require__(/*! ../objects/_abap_object */ "./node_modules/@abaplint/core/build/src/objects/_abap_object.js");
+const syntax_1 = __webpack_require__(/*! ../abap/5_syntax/syntax */ "./node_modules/@abaplint/core/build/src/abap/5_syntax/syntax.js");
 class MessageExistsConf extends _basic_rule_config_1.BasicRuleConfig {
+    constructor() {
+        super(...arguments);
+        this.checkPlaceholders = true;
+    }
 }
 exports.MessageExistsConf = MessageExistsConf;
-class MessageExistsRule extends _abap_rule_1.ABAPRule {
+class MessageExistsRule {
     constructor() {
-        super(...arguments);
         this.conf = new MessageExistsConf();
     }
     getMetadata() {
@@ -60596,58 +60657,116 @@ class MessageExistsRule extends _abap_rule_1.ABAPRule {
     setConfig(conf) {
         this.conf = conf;
     }
-    runParsed(file) {
+    initialize(reg) {
+        this.msagReferences = reg.getMSAGReferences();
+        this.reg = reg;
+        // the SyntaxLogic builds the references
+        for (const obj of reg.getObjects()) {
+            if (obj instanceof _abap_object_1.ABAPObject) {
+                new syntax_1.SyntaxLogic(reg, obj).run();
+            }
+        }
+        return this;
+    }
+    run(obj) {
         const issues = [];
-        const struc = file.getStructure();
-        if (struc === undefined) {
-            return [];
+        if (obj instanceof _abap_object_1.ABAPObject) {
+            for (const file of obj.getABAPFiles()) {
+                const struc = file.getStructure();
+                if (struc === undefined) {
+                    return [];
+                }
+                issues.push(...this.checkReportStatement(file));
+                issues.push(...this.checkSource(file));
+            }
         }
-        const expressions = struc.findAllExpressionsMulti([Expressions.MessageClass, Expressions.MessageSource]);
-        for (const node of expressions) {
-            if (node.get() instanceof Expressions.MessageClass) {
-                const token = node.getFirstToken();
-                const name = token.getStr();
-                if (this.reg.getObject("MSAG", name) === undefined
-                    && new ddic_1.DDIC(this.reg).inErrorNamespace(name) === true) {
-                    const message = "Message class \"" + name + "\" not found";
-                    const issue = issue_1.Issue.atToken(file, token, message, this.getMetadata().key, this.conf.severity);
+        return issues;
+    }
+    ////////////////////////////////
+    checkReportStatement(file) {
+        const issues = [];
+        for (const statement of file.getStatements()) {
+            if (!(statement.get() instanceof Statements.Report)) {
+                continue;
+            }
+            const expression = statement.findFirstExpression(Expressions.MessageClass);
+            if (expression) {
+                const issue = this.checkClass(expression, file);
+                if (issue) {
                     issues.push(issue);
                 }
             }
         }
-        for (const node of expressions) {
-            if (node.get() instanceof Expressions.MessageSource) {
-                const clas = node.findFirstExpression(Expressions.MessageClass);
-                if (clas === undefined) {
-                    // todo, handle case where message class is defined on header level instead of in the statement
-                    continue;
-                }
-                const token = clas.getFirstToken();
-                const name = token.getStr();
-                const msag = this.reg.getObject("MSAG", name);
-                if (msag === undefined) {
-                    if (new ddic_1.DDIC(this.reg).inErrorNamespace(name) === true) {
-                        const message = "Message class \"" + token.getStr() + "\" not found";
-                        const issue = issue_1.Issue.atToken(file, token, message, this.getMetadata().key, this.conf.severity);
-                        issues.push(issue);
+        return issues;
+    }
+    checkClass(node, file) {
+        const token = node.getFirstToken();
+        const name = token.getStr();
+        if (this.reg.getObject("MSAG", name) === undefined
+            && new ddic_1.DDIC(this.reg).inErrorNamespace(name) === true) {
+            const message = "Message class \"" + name + "\" not found";
+            return issue_1.Issue.atToken(file, token, message, this.getMetadata().key, this.conf.severity);
+        }
+        return undefined;
+    }
+    checkSource(file) {
+        const issues = [];
+        const references = this.msagReferences.listByFilename(file.getFilename());
+        for (const statement of file.getStatements()) {
+            if (statement.get() instanceof Statements.Raise || statement.get() instanceof Statements.Message) {
+                for (const ref of references) {
+                    // always max one message reference per statement? chained statements?
+                    if (ref.token.getStart().isBetween(statement.getStart(), statement.getEnd())) {
+                        const msag = this.reg.getObject("MSAG", ref.messageClass);
+                        if (msag === undefined) {
+                            if (new ddic_1.DDIC(this.reg).inErrorNamespace(ref.messageClass) === true) {
+                                const message = "Message class \"" + ref.token.getStr() + "\" not found";
+                                issues.push(issue_1.Issue.atToken(file, ref.token, message, this.getMetadata().key, this.conf.severity));
+                            }
+                            continue;
+                        }
+                        const text = msag.getByNumber(ref.number);
+                        if (text === undefined) {
+                            const message = "Message number \"" + ref.number + "\" not found in class \"" + ref.messageClass + "\"";
+                            issues.push(issue_1.Issue.atToken(file, ref.token, message, this.getMetadata().key, this.conf.severity));
+                            continue;
+                        }
+                        if (this.getConfig().checkPlaceholders === true) {
+                            const count = this.countWith(statement);
+                            const textCount = text.getPlaceholderCount();
+                            if (count !== textCount) {
+                                const message = `Message ${ref.number}, expected ${textCount} WITH parameters`;
+                                issues.push(issue_1.Issue.atToken(file, ref.token, message, this.getMetadata().key, this.conf.severity));
+                            }
+                        }
                     }
-                    continue;
                 }
-                const typeNumber = node.findFirstExpression(Expressions.MessageTypeAndNumber);
-                if (typeNumber === undefined) {
-                    continue;
+            }
+        }
+        return issues;
+    }
+    countWith(statement) {
+        const raiseWith = statement.findDirectExpression(Expressions.RaiseWith);
+        if (raiseWith) {
+            return raiseWith.getChildren().length - 1;
+        }
+        let count = 0;
+        let afterWith = false;
+        for (const expression of statement.getChildren()) {
+            if (expression instanceof nodes_1.TokenNode && expression.concatTokens().toUpperCase() === "WITH") {
+                afterWith = true;
+                continue;
+            }
+            if (afterWith === true) {
+                if (expression instanceof nodes_1.ExpressionNode) {
+                    count++;
                 }
-                const numberToken = typeNumber.getFirstToken();
-                const num = numberToken.getStr().substr(1);
-                if (msag.getByNumber(num) === undefined) {
-                    const message = "Message number \"" + num + "\" not found in class \"" + name + "\"";
-                    const issue = issue_1.Issue.atToken(file, numberToken, message, this.getMetadata().key, this.conf.severity);
-                    issues.push(issue);
+                else {
+                    break;
                 }
             }
         }
-        // todo, check number of placeholders in message vs code matches
-        return issues;
+        return count;
     }
 }
 exports.MessageExistsRule = MessageExistsRule;
@@ -63237,15 +63356,21 @@ This rule makes sure the spaces are consistently required across the language.`,
         return issues;
     }
     missingSpace(statement) {
-        const found = statement.findAllExpressionsMulti([Expressions.CondSub, Expressions.SQLCond,
-            Expressions.ValueBodyLine, Expressions.NewObject, Expressions.Cond,
-            Expressions.ComponentCond, Expressions.ComponentCondSub, Expressions.MethodCallParam], true);
+        const found = statement.findAllExpressionsMulti([
+            Expressions.CondSub, Expressions.SQLCond, Expressions.ValueBodyLine,
+            Expressions.NewObject, Expressions.Cond, Expressions.ComponentCond,
+            Expressions.Source,
+            Expressions.ComponentCondSub, Expressions.MethodCallParam
+        ], true);
         let pos = undefined;
         for (const f of found) {
             const type = f.get();
             if (type instanceof Expressions.Cond) {
                 pos = this.checkCond(f);
             }
+            else if (type instanceof Expressions.Source) {
+                pos = this.checkSource(f);
+            }
             else if (type instanceof Expressions.CondSub) {
                 pos = this.checkCondSub(f);
             }
@@ -63398,6 +63523,20 @@ This rule makes sure the spaces are consistently required across the language.`,
         }
         return undefined;
     }
+    checkSource(cond) {
+        const children = cond.getAllTokens();
+        if (children.length < 2) {
+            return undefined;
+        }
+        const nextLast = children[children.length - 2];
+        const last = children[children.length - 1];
+        if (nextLast.getStr().startsWith("'")
+            && nextLast.getRow() === last.getRow()
+            && nextLast.getEnd().getCol() === last.getStart().getCol()) {
+            return last.getEnd();
+        }
+        return undefined;
+    }
     checkMethodCallParam(call) {
         const children = call.getChildren();
         {

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@abaplint/cli",
-    "version": "2.102.15",
+    "version": "2.102.16",
     "description": "abaplint - Command Line Interface",
     "funding": "https://github.com/sponsors/larshp",
     "bin": {
@@ -38,7 +38,7 @@
     },
     "homepage": "https://abaplint.org",
     "devDependencies": {
-        "@abaplint/core": "^2.102.15",
+        "@abaplint/core": "^2.102.16",
         "@types/chai": "^4.3.5",
         "@types/glob": "^7.2.0",
         "@types/minimist": "^1.2.2",
@@ -50,7 +50,7 @@
         "eslint": "^8.46.0",
         "glob": "^7.2.3",
         "json5": "^2.2.3",
-        "memfs": "^4.2.0",
+        "memfs": "^4.2.1",
         "minimist": "^1.2.8",
         "mocha": "^10.2.0",
         "progress": "^2.0.3",