@abaplint/cli 2.101.31 → 2.101.33

package/build/cli.js

@@ -48465,7 +48465,7 @@ class Registry {
     }
     static abaplintVersion() {
         // magic, see build script "version.sh"
-        return "2.101.31";
+        return "2.101.33";
     }
     getDDICReferences() {
         return this.ddicReferences;
@@ -53465,6 +53465,10 @@ Make sure to test the downported code, it might not always be completely correct
         if (found) {
             return found;
         }
+        found = this.downportSelectExistence(low, high, lowFile, highSyntax);
+        if (found) {
+            return found;
+        }
         found = this.downportSQLExtras(low, high, lowFile, highSyntax);
         if (found) {
             return found;
@@ -53594,6 +53598,7 @@ Make sure to test the downported code, it might not always be completely correct
         return undefined;
     }
     //////////////////////////////////////////
+    /** removes @'s */
     downportSQLExtras(low, high, lowFile, highSyntax) {
         if (!(low.get() instanceof _statement_1.Unknown)) {
             return undefined;
@@ -53666,6 +53671,35 @@ Make sure to test the downported code, it might not always be completely correct
         }
         return undefined;
     }
+    downportSelectExistence(low, high, lowFile, highSyntax) {
+        var _a, _b, _c, _d;
+        if (!(low.get() instanceof _statement_1.Unknown)) {
+            return undefined;
+        }
+        else if (!(high.get() instanceof Statements.Select)) {
+            return undefined;
+        }
+        const fieldList = high.findFirstExpression(Expressions.SQLFieldList);
+        if ((fieldList === null || fieldList === void 0 ? void 0 : fieldList.concatTokens().toUpperCase()) !== "@ABAP_TRUE") {
+            return undefined;
+        }
+        const fieldName = (_b = (_a = high.findFirstExpression(Expressions.SQLCond)) === null || _a === void 0 ? void 0 : _a.findFirstExpression(Expressions.SQLFieldName)) === null || _b === void 0 ? void 0 : _b.concatTokens();
+        if (fieldName === undefined) {
+            return undefined;
+        }
+        const into = high.findFirstExpression(Expressions.SQLIntoStructure);
+        if (into === undefined) {
+            return undefined;
+        }
+        const intoName = (_d = (_c = into.findFirstExpression(Expressions.SQLTarget)) === null || _c === void 0 ? void 0 : _c.findFirstExpression(Expressions.Target)) === null || _d === void 0 ? void 0 : _d.concatTokens();
+        const uniqueName = this.uniqueName(high.getFirstToken().getStart(), lowFile.getFilename(), highSyntax);
+        const fix1 = edit_helper_1.EditHelper.replaceRange(lowFile, fieldList.getFirstToken().getStart(), fieldList.getLastToken().getEnd(), fieldName);
+        const fix2 = edit_helper_1.EditHelper.replaceRange(lowFile, into === null || into === void 0 ? void 0 : into.getFirstToken().getStart(), into === null || into === void 0 ? void 0 : into.getLastToken().getEnd(), `INTO @DATA(${uniqueName})`);
+        let fix = edit_helper_1.EditHelper.merge(fix2, fix1);
+        const fix3 = edit_helper_1.EditHelper.insertAt(lowFile, high.getLastToken().getEnd(), `\nCLEAR ${intoName}.\nIF sy-subrc = 0.\n  ${intoName} = abap_true\nENDIF.`);
+        fix = edit_helper_1.EditHelper.merge(fix, fix3);
+        return issue_1.Issue.atToken(lowFile, low.getFirstToken(), "SQL, refactor existence check", this.getMetadata().key, this.conf.severity, fix);
+    }
     downportSelectInline(low, high, lowFile, highSyntax) {
         if (!(low.get() instanceof _statement_1.Unknown)) {
             return undefined;
@@ -64876,7 +64910,9 @@ class SelectSingleFullKey {
             key: "select_single_full_key",
             title: "Detect SELECT SINGLE which are possibily not unique",
             shortDescription: `Detect SELECT SINGLE which are possibily not unique`,
-            extendedInformation: `Table definitions must be known, ie. inside the errorNamespace`,
+            extendedInformation: `Table definitions must be known, ie. inside the errorNamespace
+
+If the statement contains a JOIN it is not checked`,
             pseudoComment: "EC CI_NOORDER",
             tags: [],
         };
@@ -64917,6 +64953,9 @@ class SelectSingleFullKey {
                 if (!(s.get() instanceof __1.Statements.Select)) {
                     continue;
                 }
+                else if (s.findFirstExpression(__1.Expressions.SQLJoin)) {
+                    continue;
+                }
                 else if (s.findTokenSequencePosition("SELECT", "SINGLE") === undefined) {
                     continue;
                 }

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@abaplint/cli",
-    "version": "2.101.31",
+    "version": "2.101.33",
     "description": "abaplint - Command Line Interface",
     "funding": "https://github.com/sponsors/larshp",
     "bin": {
@@ -38,12 +38,12 @@
     },
     "homepage": "https://abaplint.org",
     "devDependencies": {
-        "@abaplint/core": "^2.101.31",
+        "@abaplint/core": "^2.101.33",
         "@types/chai": "^4.3.5",
         "@types/glob": "^7.2.0",
         "@types/minimist": "^1.2.2",
         "@types/mocha": "^10.0.1",
-        "@types/node": "^20.3.3",
+        "@types/node": "^20.4.1",
         "@types/progress": "^2.0.5",
         "chai": "^4.3.7",
         "chalk": "^5.3.0",