@abaplint/cli 2.101.28 → 2.101.30

package/build/cli.js

@@ -21668,6 +21668,9 @@ class TypeUtils {
                 }
                 return source.getLength() === target.getLength();
             }
+            else if (target instanceof basic_1.XStringType) {
+                return false;
+            }
             else if (target instanceof basic_1.IntegerType) {
                 if (((_e = source.getAbstractTypeData()) === null || _e === void 0 ? void 0 : _e.derivedFromConstant) === true) {
                     return true;
@@ -21717,7 +21720,10 @@ class TypeUtils {
             }
         }
         else if (source instanceof basic_1.XStringType) {
-            if (target instanceof basic_1.CLikeType) {
+            if (target instanceof basic_1.CLikeType
+                || target instanceof basic_1.IntegerType
+                || target instanceof basic_1.ObjectReferenceType
+                || target instanceof basic_1.HexType) {
                 return false;
             }
         }
@@ -25547,6 +25553,8 @@ class Source {
             switch (tok) {
                 case "(":
                 case "-":
+                case "+":
+                case "BIT":
                     break;
                 case "BOOLC":
                     {
@@ -27088,22 +27096,22 @@ const dynamic_1 = __webpack_require__(/*! ../expressions/dynamic */ "./node_modu
 const basic_1 = __webpack_require__(/*! ../../types/basic */ "./node_modules/@abaplint/core/build/src/abap/types/basic/index.js");
 class Assign {
     runSyntax(node, scope, filename) {
-        var _a, _b;
-        const sources = node.findAllExpressions(Expressions.Source);
-        const firstSource = sources[0];
-        let sourceType = new source_1.Source().runSyntax(firstSource, scope, filename);
-        if (sourceType === undefined || ((_a = node.findDirectExpression(Expressions.AssignSource)) === null || _a === void 0 ? void 0 : _a.findDirectExpression(Expressions.Dynamic))) {
+        var _a, _b, _c;
+        const sources = ((_a = node.findDirectExpression(Expressions.AssignSource)) === null || _a === void 0 ? void 0 : _a.findDirectExpressions(Expressions.Source)) || [];
+        const theSource = sources[sources.length - 1];
+        let sourceType = new source_1.Source().runSyntax(theSource, scope, filename);
+        if (sourceType === undefined || ((_b = node.findDirectExpression(Expressions.AssignSource)) === null || _b === void 0 ? void 0 : _b.findDirectExpression(Expressions.Dynamic))) {
             sourceType = new basic_1.VoidType("DynamicAssign");
         }
-        for (const d of ((_b = node.findDirectExpression(Expressions.AssignSource)) === null || _b === void 0 ? void 0 : _b.findAllExpressions(Expressions.Dynamic)) || []) {
+        for (const d of ((_c = node.findDirectExpression(Expressions.AssignSource)) === null || _c === void 0 ? void 0 : _c.findAllExpressions(Expressions.Dynamic)) || []) {
             new dynamic_1.Dynamic().runSyntax(d, scope, filename);
         }
         const target = node.findDirectExpression(Expressions.FSTarget);
         if (target) {
             new fstarget_1.FSTarget().runSyntax(target, scope, filename, sourceType);
         }
-        for (const s of sources) {
-            if (s === firstSource) {
+        for (const s of node.findAllExpressions(Expressions.Source)) {
+            if (s === theSource) {
                 continue;
             }
             new source_1.Source().runSyntax(s, scope, filename);
@@ -40962,7 +40970,11 @@ class Hover {
             return { kind: LServer.MarkupKind.Markdown, value: "String Template" };
         }
         else if (found.token instanceof Tokens.Comment) {
-            return { kind: LServer.MarkupKind.Markdown, value: "Comment" };
+            let type = "Comment";
+            if (found.token.getStr().startsWith(`"!`)) {
+                type = "ABAP Doc Comment";
+            }
+            return { kind: LServer.MarkupKind.Markdown, value: type };
         }
         const lookup = _lookup_1.LSPLookup.lookup(found, this.reg, obj);
         if (lookup === null || lookup === void 0 ? void 0 : lookup.hover) {
@@ -48453,7 +48465,7 @@ class Registry {
     }
     static abaplintVersion() {
         // magic, see build script "version.sh"
-        return "2.101.28";
+        return "2.101.30";
     }
     getDDICReferences() {
         return this.ddicReferences;
@@ -48771,7 +48783,9 @@ class SevenBitAscii {
             shortDescription: `Only allow characters from the 7bit ASCII set.`,
             extendedInformation: `https://docs.abapopenchecks.org/checks/05/
 
-Checkes files with extension ".abap" and ".asddls"`,
+https://help.sap.com/doc/abapdocu_750_index_htm/7.50/en-US/abencharacter_set_guidl.htm
+
+Checkes files with extensions ".abap" and ".asddls"`,
             tags: [_irule_1.RuleTag.SingleFile],
         };
     }
@@ -57093,7 +57107,7 @@ class FunctionModuleRecommendationsConf extends _basic_rule_config_1.BasicRuleCo
         /** Tuple of Function Module Name to be replaced, the recommended alternative and
          * the version from which the recommendation is valid.*/
         this.recommendations = [
-            { name: "CALCULATE_HASH_FOR_RAW", replace: "use CL_ABAP_HMAC" },
+            { name: "CALCULATE_HASH_FOR_RAW", replace: "use CL_ABAP_HMAC or CL_ABAP_MESSAGE_DIGEST" },
             { name: "ECATT_CONV_XSTRING_TO_STRING", replace: "use CL_BINARY_CONVERT" },
             { name: "F4_FILENAME", replace: "use CL_GUI_FRONTEND_SERVICES" },
             { name: "FUNCTION_EXISTS", replace: "surround with try-catch CX_SY_DYN_CALL_ILLEGAL_METHOD instead" },
@@ -57102,10 +57116,11 @@ class FunctionModuleRecommendationsConf extends _basic_rule_config_1.BasicRuleCo
             { name: "GUID_CREATE", replace: "use CL_SYSTEM_UUID" },
             { name: "IGN_TIMESTAMP_DIFFERENCE", replace: "use CL_ABAP_TSTMP" },
             { name: "IGN_TIMESTAMP_PLUSMINUS", replace: "use CL_ABAP_TSTMP" },
+            { name: "ISM_SD_GET PRICING CONDITIONS", replace: "use CL_PRC_RESULT_FACTORY as per note 2220005" },
             { name: "JOB_CREATE", replace: "use CL_BP_ABAP_JOB" },
             { name: "JOB_SUBMIT", replace: "use CL_BP_ABAP_JOB" },
-            { name: "POPUP_TO_DECIDE", replace: "use POPUP_TO_CONFIRM" },
             { name: "POPUP_TO_CONFIRM_STEP", replace: "use POPUP_TO_CONFIRM" },
+            { name: "POPUP_TO_DECIDE", replace: "use POPUP_TO_CONFIRM" },
             { name: "POPUP_TO_GET_VALUE", replace: "use POPUP_GET_VALUES" },
             { name: "REUSE_ALV_GRID_DISPLAY", replace: "use CL_SALV_TABLE=>FACTORY or CL_GUI_ALV_GRID" },
             { name: "ROUND", replace: "use built in function: round()" },
@@ -61045,7 +61060,7 @@ class MSAGConsistency {
             key: "msag_consistency",
             title: "MSAG consistency check",
             shortDescription: `Checks the validity of messages in message classes`,
-            extendedInformation: `Message numbers must be 3 digits, and message text must not be empty`,
+            extendedInformation: `Message numbers must be 3 digits, message text must not be empty, no message number duplicates`,
         };
     }
     getDescription(reason) {
@@ -61065,6 +61080,7 @@ class MSAGConsistency {
         if (!(obj instanceof objects_1.MessageClass)) {
             return [];
         }
+        const numbers = new Set();
         for (const message of obj.getMessages()) {
             // todo, get the right positions in xml file
             if (!message.getNumber().match(/\d\d\d/)) {
@@ -61079,6 +61095,16 @@ class MSAGConsistency {
                 const issue = issue_1.Issue.atPosition(obj.getFiles()[0], position, text, this.getMetadata().key, this.conf.severity);
                 issues.push(issue);
             }
+            const num = message.getNumber();
+            if (numbers.has(num)) {
+                const text = "Duplicate message number " + num;
+                const position = new position_1.Position(1, 1);
+                const issue = issue_1.Issue.atPosition(obj.getFiles()[0], position, text, this.getMetadata().key, this.conf.severity);
+                issues.push(issue);
+            }
+            else {
+                numbers.add(num);
+            }
         }
         return issues;
     }
@@ -62207,6 +62233,16 @@ POSIX REGEX: https://help.sap.com/doc/abapdocu_755_index_htm/7.55/en-US/index.ht
 OCCURENCES: check for OCCURENCES vs OCCURRENCES
 
 CLIENT SPECIFIED, from 754: https://help.sap.com/doc/abapdocu_latest_index_htm/latest/en-US/index.htm?file=abapselect_client_obsolete.htm`,
+            badExample: `REFRESH itab.
+
+COMPUTE foo = 2 + 2.
+
+MULTIPLY lv_foo BY 2.
+
+INTERFACE intf LOAD.
+
+IF foo IS SUPPLIED.
+ENDIF.`,
         };
     }
     getConfig() {
@@ -80743,27 +80779,27 @@ module.exports = require("zlib");
 __webpack_require__.r(__webpack_exports__);
 /* harmony export */ __webpack_require__.d(__webpack_exports__, {
 /* harmony export */   Chalk: () => (/* binding */ Chalk),
-/* harmony export */   backgroundColorNames: () => (/* reexport safe */ _ansi_styles__WEBPACK_IMPORTED_MODULE_0__.backgroundColorNames),
-/* harmony export */   backgroundColors: () => (/* reexport safe */ _ansi_styles__WEBPACK_IMPORTED_MODULE_0__.backgroundColorNames),
+/* harmony export */   backgroundColorNames: () => (/* reexport safe */ _ansi_styles__WEBPACK_IMPORTED_MODULE_1__.backgroundColorNames),
+/* harmony export */   backgroundColors: () => (/* reexport safe */ _ansi_styles__WEBPACK_IMPORTED_MODULE_1__.backgroundColorNames),
 /* harmony export */   chalkStderr: () => (/* binding */ chalkStderr),
-/* harmony export */   colorNames: () => (/* reexport safe */ _ansi_styles__WEBPACK_IMPORTED_MODULE_0__.colorNames),
-/* harmony export */   colors: () => (/* reexport safe */ _ansi_styles__WEBPACK_IMPORTED_MODULE_0__.colorNames),
+/* harmony export */   colorNames: () => (/* reexport safe */ _ansi_styles__WEBPACK_IMPORTED_MODULE_1__.colorNames),
+/* harmony export */   colors: () => (/* reexport safe */ _ansi_styles__WEBPACK_IMPORTED_MODULE_1__.colorNames),
 /* harmony export */   "default": () => (__WEBPACK_DEFAULT_EXPORT__),
-/* harmony export */   foregroundColorNames: () => (/* reexport safe */ _ansi_styles__WEBPACK_IMPORTED_MODULE_0__.foregroundColorNames),
-/* harmony export */   foregroundColors: () => (/* reexport safe */ _ansi_styles__WEBPACK_IMPORTED_MODULE_0__.foregroundColorNames),
-/* harmony export */   modifierNames: () => (/* reexport safe */ _ansi_styles__WEBPACK_IMPORTED_MODULE_0__.modifierNames),
-/* harmony export */   modifiers: () => (/* reexport safe */ _ansi_styles__WEBPACK_IMPORTED_MODULE_0__.modifierNames),
+/* harmony export */   foregroundColorNames: () => (/* reexport safe */ _ansi_styles__WEBPACK_IMPORTED_MODULE_1__.foregroundColorNames),
+/* harmony export */   foregroundColors: () => (/* reexport safe */ _ansi_styles__WEBPACK_IMPORTED_MODULE_1__.foregroundColorNames),
+/* harmony export */   modifierNames: () => (/* reexport safe */ _ansi_styles__WEBPACK_IMPORTED_MODULE_1__.modifierNames),
+/* harmony export */   modifiers: () => (/* reexport safe */ _ansi_styles__WEBPACK_IMPORTED_MODULE_1__.modifierNames),
 /* harmony export */   supportsColor: () => (/* binding */ stdoutColor),
 /* harmony export */   supportsColorStderr: () => (/* binding */ stderrColor)
 /* harmony export */ });
-/* harmony import */ var _ansi_styles__WEBPACK_IMPORTED_MODULE_0__ = __webpack_require__(/*! ./vendor/ansi-styles/index.js */ "./node_modules/chalk/source/vendor/ansi-styles/index.js");
-/* harmony import */ var _supports_color__WEBPACK_IMPORTED_MODULE_1__ = __webpack_require__(/*! #supports-color */ "./node_modules/chalk/source/vendor/supports-color/index.js");
+/* harmony import */ var _ansi_styles__WEBPACK_IMPORTED_MODULE_1__ = __webpack_require__(/*! ./vendor/ansi-styles/index.js */ "./node_modules/chalk/source/vendor/ansi-styles/index.js");
+/* harmony import */ var _supports_color__WEBPACK_IMPORTED_MODULE_0__ = __webpack_require__(/*! #supports-color */ "./node_modules/chalk/source/vendor/supports-color/index.js");
 /* harmony import */ var _utilities_js__WEBPACK_IMPORTED_MODULE_2__ = __webpack_require__(/*! ./utilities.js */ "./node_modules/chalk/source/utilities.js");
 
 
 
 
-const {stdout: stdoutColor, stderr: stderrColor} = _supports_color__WEBPACK_IMPORTED_MODULE_1__["default"];
+const {stdout: stdoutColor, stderr: stderrColor} = _supports_color__WEBPACK_IMPORTED_MODULE_0__["default"];
 
 const GENERATOR = Symbol('GENERATOR');
 const STYLER = Symbol('STYLER');
@@ -80811,7 +80847,7 @@ function createChalk(options) {
 
 Object.setPrototypeOf(createChalk.prototype, Function.prototype);
 
-for (const [styleName, style] of Object.entries(_ansi_styles__WEBPACK_IMPORTED_MODULE_0__["default"])) {
+for (const [styleName, style] of Object.entries(_ansi_styles__WEBPACK_IMPORTED_MODULE_1__["default"])) {
 	styles[styleName] = {
 		get() {
 			const builder = createBuilder(this, createStyler(style.open, style.close, this[STYLER]), this[IS_EMPTY]);
@@ -80832,21 +80868,21 @@ styles.visible = {
 const getModelAnsi = (model, level, type, ...arguments_) => {
 	if (model === 'rgb') {
 		if (level === 'ansi16m') {
-			return _ansi_styles__WEBPACK_IMPORTED_MODULE_0__["default"][type].ansi16m(...arguments_);
+			return _ansi_styles__WEBPACK_IMPORTED_MODULE_1__["default"][type].ansi16m(...arguments_);
 		}
 
 		if (level === 'ansi256') {
-			return _ansi_styles__WEBPACK_IMPORTED_MODULE_0__["default"][type].ansi256(_ansi_styles__WEBPACK_IMPORTED_MODULE_0__["default"].rgbToAnsi256(...arguments_));
+			return _ansi_styles__WEBPACK_IMPORTED_MODULE_1__["default"][type].ansi256(_ansi_styles__WEBPACK_IMPORTED_MODULE_1__["default"].rgbToAnsi256(...arguments_));
 		}
 
-		return _ansi_styles__WEBPACK_IMPORTED_MODULE_0__["default"][type].ansi(_ansi_styles__WEBPACK_IMPORTED_MODULE_0__["default"].rgbToAnsi(...arguments_));
+		return _ansi_styles__WEBPACK_IMPORTED_MODULE_1__["default"][type].ansi(_ansi_styles__WEBPACK_IMPORTED_MODULE_1__["default"].rgbToAnsi(...arguments_));
 	}
 
 	if (model === 'hex') {
-		return getModelAnsi('rgb', level, type, ..._ansi_styles__WEBPACK_IMPORTED_MODULE_0__["default"].hexToRgb(...arguments_));
+		return getModelAnsi('rgb', level, type, ..._ansi_styles__WEBPACK_IMPORTED_MODULE_1__["default"].hexToRgb(...arguments_));
 	}
 
-	return _ansi_styles__WEBPACK_IMPORTED_MODULE_0__["default"][type][model](...arguments_);
+	return _ansi_styles__WEBPACK_IMPORTED_MODULE_1__["default"][type][model](...arguments_);
 };
 
 const usedModels = ['rgb', 'hex', 'ansi256'];
@@ -80856,7 +80892,7 @@ for (const model of usedModels) {
 		get() {
 			const {level} = this;
 			return function (...arguments_) {
-				const styler = createStyler(getModelAnsi(model, levelMapping[level], 'color', ...arguments_), _ansi_styles__WEBPACK_IMPORTED_MODULE_0__["default"].color.close, this[STYLER]);
+				const styler = createStyler(getModelAnsi(model, levelMapping[level], 'color', ...arguments_), _ansi_styles__WEBPACK_IMPORTED_MODULE_1__["default"].color.close, this[STYLER]);
 				return createBuilder(this, styler, this[IS_EMPTY]);
 			};
 		},
@@ -80867,7 +80903,7 @@ for (const model of usedModels) {
 		get() {
 			const {level} = this;
 			return function (...arguments_) {
-				const styler = createStyler(getModelAnsi(model, levelMapping[level], 'bgColor', ...arguments_), _ansi_styles__WEBPACK_IMPORTED_MODULE_0__["default"].bgColor.close, this[STYLER]);
+				const styler = createStyler(getModelAnsi(model, levelMapping[level], 'bgColor', ...arguments_), _ansi_styles__WEBPACK_IMPORTED_MODULE_1__["default"].bgColor.close, this[STYLER]);
 				return createBuilder(this, styler, this[IS_EMPTY]);
 			};
 		},
@@ -81282,6 +81318,7 @@ __webpack_require__.r(__webpack_exports__);
 
 
 // From: https://github.com/sindresorhus/has-flag/blob/main/index.js
+/// function hasFlag(flag, argv = globalThis.Deno?.args ?? process.argv) {
 function hasFlag(flag, argv = globalThis.Deno ? globalThis.Deno.args : node_process__WEBPACK_IMPORTED_MODULE_0__.argv) {
 	const prefix = flag.startsWith('-') ? '' : (flag.length === 1 ? '-' : '--');
 	const position = argv.indexOf(prefix + flag);
@@ -81390,7 +81427,7 @@ function _supportsColor(haveStream, {streamIsTTY, sniffFlags = true} = {}) {
 	}
 
 	if ('CI' in env) {
-		if ('GITHUB_ACTIONS' in env) {
+		if ('GITHUB_ACTIONS' in env || 'GITEA_ACTIONS' in env) {
 			return 3;
 		}
 

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@abaplint/cli",
-    "version": "2.101.28",
+    "version": "2.101.30",
     "description": "abaplint - Command Line Interface",
     "funding": "https://github.com/sponsors/larshp",
     "bin": {
@@ -38,24 +38,24 @@
     },
     "homepage": "https://abaplint.org",
     "devDependencies": {
-        "@abaplint/core": "^2.101.28",
+        "@abaplint/core": "^2.101.30",
         "@types/chai": "^4.3.5",
         "@types/glob": "^7.2.0",
         "@types/minimist": "^1.2.2",
         "@types/mocha": "^10.0.1",
-        "@types/node": "^20.3.2",
+        "@types/node": "^20.3.3",
         "@types/progress": "^2.0.5",
         "chai": "^4.3.7",
-        "chalk": "^5.2.0",
-        "eslint": "^8.43.0",
+        "chalk": "^5.3.0",
+        "eslint": "^8.44.0",
         "glob": "^7.2.3",
         "json5": "^2.2.3",
         "memfs": "^4.2.0",
         "minimist": "^1.2.8",
         "mocha": "^10.2.0",
         "progress": "^2.0.3",
-        "typescript": "^5.1.5",
-        "webpack": "^5.88.0",
+        "typescript": "^5.1.6",
+        "webpack": "^5.88.1",
         "webpack-cli": "^5.1.4",
         "xml-js": "^1.6.11"
     },