@abaplint/cli 2.101.15 → 2.101.16

package/build/cli.js

@@ -21508,6 +21508,7 @@ class TypeUtils {
         else if (type instanceof basic_1.XStringType
             || type instanceof basic_1.HexType
             || type instanceof basic_1.VoidType
+            || type instanceof basic_1.XGenericType
             || type instanceof basic_1.XSequenceType
             || type instanceof basic_1.AnyType
             || type instanceof basic_1.UnknownType) {
@@ -21850,7 +21851,7 @@ class BasicTypes {
     }
     lookupQualifiedName(name) {
         var _a;
-        // argh, todo, rewrite this entire method, more argh
+        // argh, todo, rewrite this entire method, more argh, again argh
         if (name === undefined) {
             return undefined;
         }
@@ -21871,7 +21872,10 @@ class BasicTypes {
                     const stru = oo.getTypeDefinitions().getByName(subTypeName);
                     const struType = stru === null || stru === void 0 ? void 0 : stru.getType();
                     if (stru && struType instanceof basic_1.StructureType) {
-                        const f = struType.getComponentByName(fieldName);
+                        let f = struType.getComponentByName(fieldName);
+                        if (split[2] && f instanceof basic_1.StructureType) {
+                            f = f.getComponentByName(split[2]);
+                        }
                         if (f) {
                             return new _typed_identifier_1.TypedIdentifier(stru.getToken(), stru.getFilename(), f);
                         }
@@ -21893,7 +21897,10 @@ class BasicTypes {
             if (type) {
                 const stru = type.getType();
                 if (stru instanceof basic_1.StructureType) {
-                    const f = stru.getComponentByName(fieldName);
+                    let f = stru.getComponentByName(fieldName);
+                    if (split[2] && f instanceof basic_1.StructureType) {
+                        f = f.getComponentByName(split[2]);
+                    }
                     if (f) {
                         return new _typed_identifier_1.TypedIdentifier(type.getToken(), type.getFilename(), f);
                     }
@@ -24699,6 +24706,9 @@ class MethodParam {
         if (concat === "TYPE C" || concat.startsWith("TYPE C ")) {
             return new _typed_identifier_1.TypedIdentifier(name.getFirstToken(), filename, new cgeneric_type_1.CGenericType(), meta);
         }
+        else if (concat === "TYPE X" || concat.startsWith("TYPE X ")) {
+            return new _typed_identifier_1.TypedIdentifier(name.getFirstToken(), filename, new basic_1.XGenericType(), meta);
+        }
         const found = new basic_types_1.BasicTypes(filename, scope).parseType(type);
         if (found) {
             return new _typed_identifier_1.TypedIdentifier(name.getFirstToken(), filename, found, meta);
@@ -34708,7 +34718,7 @@ class HexType extends _abstract_type_1.AbstractType {
     constructor(length, qualifiedName) {
         super({ qualifiedName: qualifiedName });
         if (length <= 0) {
-            throw new Error("Bad LENGTHm, Hex");
+            throw new Error("Bad LENGTH, Hex");
         }
         this.length = length;
     }
@@ -34787,6 +34797,7 @@ __exportStar(__webpack_require__(/*! ./time_type */ "./node_modules/@abaplint/co
 __exportStar(__webpack_require__(/*! ./unknown_type */ "./node_modules/@abaplint/core/build/src/abap/types/basic/unknown_type.js"), exports);
 __exportStar(__webpack_require__(/*! ./utc_long_type */ "./node_modules/@abaplint/core/build/src/abap/types/basic/utc_long_type.js"), exports);
 __exportStar(__webpack_require__(/*! ./void_type */ "./node_modules/@abaplint/core/build/src/abap/types/basic/void_type.js"), exports);
+__exportStar(__webpack_require__(/*! ./xgeneric_type */ "./node_modules/@abaplint/core/build/src/abap/types/basic/xgeneric_type.js"), exports);
 __exportStar(__webpack_require__(/*! ./xsequence_type */ "./node_modules/@abaplint/core/build/src/abap/types/basic/xsequence_type.js"), exports);
 __exportStar(__webpack_require__(/*! ./xstring_type */ "./node_modules/@abaplint/core/build/src/abap/types/basic/xstring_type.js"), exports);
 //# sourceMappingURL=index.js.map
@@ -35427,6 +35438,39 @@ exports.VoidType = VoidType;
 
 /***/ }),
 
+/***/ "./node_modules/@abaplint/core/build/src/abap/types/basic/xgeneric_type.js":
+/*!*********************************************************************************!*\
+  !*** ./node_modules/@abaplint/core/build/src/abap/types/basic/xgeneric_type.js ***!
+  \*********************************************************************************/
+/***/ ((__unused_webpack_module, exports, __webpack_require__) => {
+
+"use strict";
+
+Object.defineProperty(exports, "__esModule", ({ value: true }));
+exports.XGenericType = void 0;
+const _abstract_type_1 = __webpack_require__(/*! ./_abstract_type */ "./node_modules/@abaplint/core/build/src/abap/types/basic/_abstract_type.js");
+class XGenericType extends _abstract_type_1.AbstractType {
+    toText() {
+        return "```x```";
+    }
+    isGeneric() {
+        return true;
+    }
+    toABAP() {
+        throw new Error("x, generic");
+    }
+    containsVoid() {
+        return false;
+    }
+    toCDS() {
+        return "abap.TODO_CGENERIC";
+    }
+}
+exports.XGenericType = XGenericType;
+//# sourceMappingURL=xgeneric_type.js.map
+
+/***/ }),
+
 /***/ "./node_modules/@abaplint/core/build/src/abap/types/basic/xsequence_type.js":
 /*!**********************************************************************************!*\
   !*** ./node_modules/@abaplint/core/build/src/abap/types/basic/xsequence_type.js ***!
@@ -48352,7 +48396,7 @@ class Registry {
     }
     static abaplintVersion() {
         // magic, see build script "version.sh"
-        return "2.101.15";
+        return "2.101.16";
     }
     getDDICReferences() {
         return this.ddicReferences;
@@ -48993,7 +49037,9 @@ const Expressions = __webpack_require__(/*! ../abap/2_statements/expressions */
 const _abap_rule_1 = __webpack_require__(/*! ./_abap_rule */ "./node_modules/@abaplint/core/build/src/rules/_abap_rule.js");
 const _basic_rule_config_1 = __webpack_require__(/*! ./_basic_rule_config */ "./node_modules/@abaplint/core/build/src/rules/_basic_rule_config.js");
 const _irule_1 = __webpack_require__(/*! ./_irule */ "./node_modules/@abaplint/core/build/src/rules/_irule.js");
+const position_1 = __webpack_require__(/*! ../position */ "./node_modules/@abaplint/core/build/src/position.js");
 const __1 = __webpack_require__(/*! .. */ "./node_modules/@abaplint/core/build/src/index.js");
+const edit_helper_1 = __webpack_require__(/*! ../edit_helper */ "./node_modules/@abaplint/core/build/src/edit_helper.js");
 class AlignParametersConf extends _basic_rule_config_1.BasicRuleConfig {
 }
 exports.AlignParametersConf = AlignParametersConf;
@@ -49020,7 +49066,8 @@ https://github.com/SAP/styleguides/blob/master/clean-abap/CleanABAP.md#align-par
 
 Does not take effect on non functional method calls, use https://rules.abaplint.org/functional_writing/
 
-Also https://rules.abaplint.org/max_one_method_parameter_per_line/ can help aligning parameter syntax`,
+If parameters are on the same row, no issues are reported, see
+https://rules.abaplint.org/max_one_method_parameter_per_line/ for splitting parameters to lines`,
             tags: [_irule_1.RuleTag.SingleFile, _irule_1.RuleTag.Whitespace, _irule_1.RuleTag.Styleguide],
             badExample: `CALL FUNCTION 'FOOBAR'
   EXPORTING
@@ -49083,16 +49130,28 @@ DATA(sdf) = VALUE type(
             return undefined;
         }
         let expectedEqualsColumn = 0;
+        let row = 0;
         for (const p of candidate.parameters) {
             const currentCol = p.left.getLastToken().getCol() + p.left.getLastToken().getStr().length + 1;
+            if (p.eq.getRow() === row) {
+                return undefined;
+            }
+            row = p.eq.getRow();
             if (currentCol > expectedEqualsColumn) {
                 expectedEqualsColumn = currentCol;
             }
         }
         for (const p of candidate.parameters) {
             if (p.eq.getCol() !== expectedEqualsColumn) {
+                let fix;
+                if (p.eq.getCol() < expectedEqualsColumn) {
+                    fix = edit_helper_1.EditHelper.insertAt(file, p.eq, " ".repeat(expectedEqualsColumn - p.eq.getCol()));
+                }
+                else {
+                    fix = edit_helper_1.EditHelper.deleteRange(file, new position_1.Position(p.eq.getRow(), expectedEqualsColumn), p.eq);
+                }
                 const message = "Align parameters to column " + expectedEqualsColumn;
-                return issue_1.Issue.atPosition(file, p.eq, message, this.getMetadata().key, this.getConfig().severity);
+                return issue_1.Issue.atPosition(file, p.eq, message, this.getMetadata().key, this.getConfig().severity, fix);
             }
         }
         return undefined;
@@ -56885,11 +56944,11 @@ DATA lt_bar TYPE STANDARD TABLE OF ty.`,
             const concat = tt.concatTokens().toUpperCase();
             if (concat.includes("TYPE TABLE OF")) {
                 const message = "Specify table type";
-                issues.push(issue_1.Issue.atStatement(file, statement, message, this.getMetadata().key, this.conf.severity));
+                issues.push(issue_1.Issue.atPosition(file, tt.getFirstToken().getStart(), message, this.getMetadata().key, this.conf.severity));
             }
             else if (concat.includes(" WITH ") === false && concat.includes(" RANGE OF ") === false) {
                 const message = "Specify table key";
-                issues.push(issue_1.Issue.atStatement(file, statement, message, this.getMetadata().key, this.conf.severity));
+                issues.push(issue_1.Issue.atPosition(file, tt.getFirstToken().getStart(), message, this.getMetadata().key, this.conf.severity));
             }
         }
         return issues;
@@ -64669,7 +64728,6 @@ Object.defineProperty(exports, "__esModule", ({ value: true }));
 exports.SelectSingleFullKey = exports.SelectSingleFullKeyConf = void 0;
 const issue_1 = __webpack_require__(/*! ../issue */ "./node_modules/@abaplint/core/build/src/issue.js");
 const _basic_rule_config_1 = __webpack_require__(/*! ./_basic_rule_config */ "./node_modules/@abaplint/core/build/src/rules/_basic_rule_config.js");
-const _irule_1 = __webpack_require__(/*! ./_irule */ "./node_modules/@abaplint/core/build/src/rules/_irule.js");
 const __1 = __webpack_require__(/*! .. */ "./node_modules/@abaplint/core/build/src/index.js");
 class SelectSingleFullKeyConf extends _basic_rule_config_1.BasicRuleConfig {
     constructor() {
@@ -64689,7 +64747,7 @@ class SelectSingleFullKey {
             shortDescription: `Detect SELECT SINGLE which are possibily not unique`,
             extendedInformation: `Table definitions must be known, ie. inside the errorNamespace`,
             pseudoComment: "EC CI_NOORDER",
-            tags: [_irule_1.RuleTag.Experimental],
+            tags: [],
         };
     }
     initialize(reg) {

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@abaplint/cli",
-    "version": "2.101.15",
+    "version": "2.101.16",
     "description": "abaplint - Command Line Interface",
     "funding": "https://github.com/sponsors/larshp",
     "bin": {
@@ -38,7 +38,7 @@
     },
     "homepage": "https://abaplint.org",
     "devDependencies": {
-        "@abaplint/core": "^2.101.15",
+        "@abaplint/core": "^2.101.16",
         "@types/chai": "^4.3.5",
         "@types/glob": "^7.2.0",
         "@types/minimist": "^1.2.2",
@@ -50,13 +50,13 @@
         "eslint": "^8.42.0",
         "glob": "^7.2.3",
         "json5": "^2.2.3",
-        "memfs": "^3.5.2",
+        "memfs": "^3.5.3",
         "minimist": "^1.2.8",
         "mocha": "^10.2.0",
         "progress": "^2.0.3",
         "typescript": "^5.1.3",
-        "webpack": "^5.85.1",
-        "webpack-cli": "^5.1.3",
+        "webpack": "^5.86.0",
+        "webpack-cli": "^5.1.4",
         "xml-js": "^1.6.11"
     },
     "dependencies": {}