@abaplint/cli 2.100.5 → 2.101.0

package/build/cli.js

@@ -20401,6 +20401,9 @@ class CurrentScope {
     getVersion() {
         return this.reg.getConfig().getVersion();
     }
+    getRegistry() {
+        return this.reg;
+    }
     addType(type) {
         if (type === undefined) {
             return;
@@ -20500,6 +20503,10 @@ class CurrentScope {
         const position = new _identifier_1.Identifier(usage, filename);
         (_a = this.current) === null || _a === void 0 ? void 0 : _a.getData().references.push({ position, resolved: referencing, referenceType: type, extra });
     }
+    addSQLConversion(fieldName, message, token) {
+        var _a;
+        (_a = this.current) === null || _a === void 0 ? void 0 : _a.getData().sqlConversion.push({ fieldName, message, token });
+    }
     ///////////////////////////
     findFunctionModule(name) {
         if (name === undefined) {
@@ -23386,7 +23393,7 @@ class DatabaseTable {
         const name = token.getStr();
         if (name === "(") {
             // dynamic
-            return;
+            return undefined;
         }
         const found = scope.getDDIC().lookupTableOrView2(name);
         if (found === undefined && scope.getDDIC().inErrorNamespace(name) === true) {
@@ -23399,6 +23406,7 @@ class DatabaseTable {
             scope.addReference(token, found.getIdentifier(), _reference_1.ReferenceType.TableReference, filename);
             scope.getDDICReferences().addUsing(scope.getParentObj(), { object: found, token: token, filename: filename });
         }
+        return found;
     }
 }
 exports.DatabaseTable = DatabaseTable;
@@ -25283,17 +25291,16 @@ const basic_1 = __webpack_require__(/*! ../../types/basic */ "./node_modules/@ab
 const inline_data_1 = __webpack_require__(/*! ./inline_data */ "./node_modules/@abaplint/core/build/src/abap/5_syntax/expressions/inline_data.js");
 const target_1 = __webpack_require__(/*! ./target */ "./node_modules/@abaplint/core/build/src/abap/5_syntax/expressions/target.js");
 const sql_from_1 = __webpack_require__(/*! ./sql_from */ "./node_modules/@abaplint/core/build/src/abap/5_syntax/expressions/sql_from.js");
-const source_1 = __webpack_require__(/*! ./source */ "./node_modules/@abaplint/core/build/src/abap/5_syntax/expressions/source.js");
 const sql_for_all_entries_1 = __webpack_require__(/*! ./sql_for_all_entries */ "./node_modules/@abaplint/core/build/src/abap/5_syntax/expressions/sql_for_all_entries.js");
 const _scope_type_1 = __webpack_require__(/*! ../_scope_type */ "./node_modules/@abaplint/core/build/src/abap/5_syntax/_scope_type.js");
+const sql_source_1 = __webpack_require__(/*! ./sql_source */ "./node_modules/@abaplint/core/build/src/abap/5_syntax/expressions/sql_source.js");
+const sql_compare_1 = __webpack_require__(/*! ./sql_compare */ "./node_modules/@abaplint/core/build/src/abap/5_syntax/expressions/sql_compare.js");
 class Select {
     runSyntax(node, scope, filename, skipImplicitInto = false) {
         var _a, _b;
         const token = node.getFirstToken();
         const from = node.findDirectExpression(Expressions.SQLFrom);
-        if (from) {
-            new sql_from_1.SQLFrom().runSyntax(from, scope, filename);
-        }
+        const dbSources = from ? new sql_from_1.SQLFrom().runSyntax(from, scope, filename) : [];
         for (const inline of node.findAllExpressions(Expressions.InlineData)) {
             // todo, for now these are voided
             new inline_data_1.InlineData().runSyntax(inline, scope, filename, new basic_1.VoidType("SELECT_todo"));
@@ -25319,11 +25326,22 @@ class Select {
                 }
             }
         }
-        for (const s of node.findAllExpressions(Expressions.Source)) {
-            new source_1.Source().runSyntax(s, scope, filename);
+        // OFFSET
+        for (const s of node.findDirectExpressions(Expressions.SQLSource)) {
+            new sql_source_1.SQLSource().runSyntax(s, scope, filename);
         }
-        for (const s of node.findAllExpressions(Expressions.SimpleSource3)) {
-            new source_1.Source().runSyntax(s, scope, filename);
+        for (const up of node.findDirectExpressions(Expressions.SQLUpTo)) {
+            for (const s of up.findDirectExpressions(Expressions.SQLSource)) {
+                new sql_source_1.SQLSource().runSyntax(s, scope, filename);
+            }
+        }
+        for (const fae of node.findDirectExpressions(Expressions.SQLForAllEntries)) {
+            for (const s of fae.findDirectExpressions(Expressions.SQLSource)) {
+                new sql_source_1.SQLSource().runSyntax(s, scope, filename);
+            }
+        }
+        for (const s of node.findAllExpressions(Expressions.SQLCompare)) {
+            new sql_compare_1.SQLCompare().runSyntax(s, scope, filename, dbSources);
         }
         if (scope.getType() === _scope_type_1.ScopeType.OpenSQL) {
             scope.pop(node.getLastToken().getEnd());
@@ -25683,6 +25701,79 @@ exports.SourceFieldSymbol = SourceFieldSymbol;
 
 /***/ }),
 
+/***/ "./node_modules/@abaplint/core/build/src/abap/5_syntax/expressions/sql_compare.js":
+/*!****************************************************************************************!*\
+  !*** ./node_modules/@abaplint/core/build/src/abap/5_syntax/expressions/sql_compare.js ***!
+  \****************************************************************************************/
+/***/ ((__unused_webpack_module, exports, __webpack_require__) => {
+
+"use strict";
+
+Object.defineProperty(exports, "__esModule", ({ value: true }));
+exports.SQLCompare = void 0;
+const Expressions = __webpack_require__(/*! ../../2_statements/expressions */ "./node_modules/@abaplint/core/build/src/abap/2_statements/expressions/index.js");
+const basic_1 = __webpack_require__(/*! ../../types/basic */ "./node_modules/@abaplint/core/build/src/abap/types/basic/index.js");
+const sql_source_1 = __webpack_require__(/*! ./sql_source */ "./node_modules/@abaplint/core/build/src/abap/5_syntax/expressions/sql_source.js");
+class SQLCompare {
+    runSyntax(node, scope, filename, tables) {
+        var _a;
+        let sourceType;
+        let token;
+        for (const s of node.findAllExpressions(Expressions.SQLSource)) {
+            token = s.getFirstToken();
+            sourceType = new sql_source_1.SQLSource().runSyntax(s, scope, filename);
+        }
+        const fieldName = (_a = node.findDirectExpression(Expressions.SQLFieldName)) === null || _a === void 0 ? void 0 : _a.concatTokens();
+        if (fieldName && sourceType && token) {
+            // check compatibility for rule sql_value_conversion
+            const targetType = this.findType(fieldName, tables, scope);
+            let message = "";
+            if (sourceType instanceof basic_1.IntegerType
+                && targetType instanceof basic_1.CharacterType) {
+                message = "Integer to CHAR conversion";
+            }
+            else if (sourceType instanceof basic_1.IntegerType
+                && targetType instanceof basic_1.NumericType) {
+                message = "Integer to NUMC conversion";
+            }
+            else if (sourceType instanceof basic_1.NumericType
+                && targetType instanceof basic_1.IntegerType) {
+                message = "NUMC to Integer conversion";
+            }
+            else if (sourceType instanceof basic_1.CharacterType
+                && targetType instanceof basic_1.IntegerType) {
+                message = "CHAR to Integer conversion";
+            }
+            else if (sourceType instanceof basic_1.CharacterType
+                && targetType instanceof basic_1.CharacterType
+                && sourceType.getLength() > targetType.getLength()) {
+                message = "Source field longer than database field, CHAR -> CHAR";
+            }
+            else if (sourceType instanceof basic_1.NumericType
+                && targetType instanceof basic_1.NumericType
+                && sourceType.getLength() > targetType.getLength()) {
+                message = "Source field longer than database field, NUMC -> NUMC";
+            }
+            if (message !== "") {
+                scope.addSQLConversion(fieldName, message, token);
+            }
+        }
+    }
+    findType(fieldName, tables, scope) {
+        for (const t of tables) {
+            const type = t === null || t === void 0 ? void 0 : t.parseType(scope.getRegistry());
+            if (type instanceof basic_1.StructureType) {
+                return type.getComponentByName(fieldName);
+            }
+        }
+        return undefined;
+    }
+}
+exports.SQLCompare = SQLCompare;
+//# sourceMappingURL=sql_compare.js.map
+
+/***/ }),
+
 /***/ "./node_modules/@abaplint/core/build/src/abap/5_syntax/expressions/sql_for_all_entries.js":
 /*!************************************************************************************************!*\
   !*** ./node_modules/@abaplint/core/build/src/abap/5_syntax/expressions/sql_for_all_entries.js ***!
@@ -25735,6 +25826,7 @@ const dynamic_1 = __webpack_require__(/*! ./dynamic */ "./node_modules/@abaplint
 const database_table_1 = __webpack_require__(/*! ./database_table */ "./node_modules/@abaplint/core/build/src/abap/5_syntax/expressions/database_table.js");
 class SQLFrom {
     runSyntax(node, scope, filename) {
+        const ret = [];
         const fromList = node.findAllExpressions(Expressions.SQLFromSource);
         for (const from of fromList) {
             for (const d of from.findAllExpressions(Expressions.Dynamic)) {
@@ -25742,9 +25834,10 @@ class SQLFrom {
             }
             const dbtab = from.findFirstExpression(Expressions.DatabaseTable);
             if (dbtab !== undefined) {
-                new database_table_1.DatabaseTable().runSyntax(dbtab, scope, filename);
+                ret.push(new database_table_1.DatabaseTable().runSyntax(dbtab, scope, filename));
             }
         }
+        return ret;
     }
 }
 exports.SQLFrom = SQLFrom;
@@ -25752,6 +25845,34 @@ exports.SQLFrom = SQLFrom;
 
 /***/ }),
 
+/***/ "./node_modules/@abaplint/core/build/src/abap/5_syntax/expressions/sql_source.js":
+/*!***************************************************************************************!*\
+  !*** ./node_modules/@abaplint/core/build/src/abap/5_syntax/expressions/sql_source.js ***!
+  \***************************************************************************************/
+/***/ ((__unused_webpack_module, exports, __webpack_require__) => {
+
+"use strict";
+
+Object.defineProperty(exports, "__esModule", ({ value: true }));
+exports.SQLSource = void 0;
+const Expressions = __webpack_require__(/*! ../../2_statements/expressions */ "./node_modules/@abaplint/core/build/src/abap/2_statements/expressions/index.js");
+const source_1 = __webpack_require__(/*! ./source */ "./node_modules/@abaplint/core/build/src/abap/5_syntax/expressions/source.js");
+class SQLSource {
+    runSyntax(node, scope, filename) {
+        for (const s of node.findAllExpressions(Expressions.Source)) {
+            return new source_1.Source().runSyntax(s, scope, filename);
+        }
+        for (const s of node.findAllExpressions(Expressions.SimpleSource3)) {
+            return new source_1.Source().runSyntax(s, scope, filename);
+        }
+        return undefined;
+    }
+}
+exports.SQLSource = SQLSource;
+//# sourceMappingURL=sql_source.js.map
+
+/***/ }),
+
 /***/ "./node_modules/@abaplint/core/build/src/abap/5_syntax/expressions/string_template.js":
 /*!********************************************************************************************!*\
   !*** ./node_modules/@abaplint/core/build/src/abap/5_syntax/expressions/string_template.js ***!
@@ -26349,6 +26470,7 @@ class ScopeData {
             extraLikeTypes: {},
             deferred: [],
             references: [],
+            sqlConversion: [],
         };
     }
     getData() {
@@ -47757,7 +47879,7 @@ class Registry {
     }
     static abaplintVersion() {
         // magic, see build script "version.sh"
-        return "2.100.5";
+        return "2.101.0";
     }
     getDDICReferences() {
         return this.ddicReferences;
@@ -57852,6 +57974,7 @@ __exportStar(__webpack_require__(/*! ./smim_consistency */ "./node_modules/@abap
 __exportStar(__webpack_require__(/*! ./space_before_colon */ "./node_modules/@abaplint/core/build/src/rules/space_before_colon.js"), exports);
 __exportStar(__webpack_require__(/*! ./space_before_dot */ "./node_modules/@abaplint/core/build/src/rules/space_before_dot.js"), exports);
 __exportStar(__webpack_require__(/*! ./sql_escape_host_variables */ "./node_modules/@abaplint/core/build/src/rules/sql_escape_host_variables.js"), exports);
+__exportStar(__webpack_require__(/*! ./sql_value_conversion */ "./node_modules/@abaplint/core/build/src/rules/sql_value_conversion.js"), exports);
 __exportStar(__webpack_require__(/*! ./start_at_tab */ "./node_modules/@abaplint/core/build/src/rules/start_at_tab.js"), exports);
 __exportStar(__webpack_require__(/*! ./static_call_via_instance */ "./node_modules/@abaplint/core/build/src/rules/static_call_via_instance.js"), exports);
 __exportStar(__webpack_require__(/*! ./strict_sql */ "./node_modules/@abaplint/core/build/src/rules/strict_sql.js"), exports);
@@ -63436,6 +63559,9 @@ class ReduceStringTemplates extends _abap_rule_1.ABAPRule {
                     for (const second of source.findDirectExpressions(Expressions.StringTemplate)) {
                         issues.push(issue_1.Issue.atToken(file, second.getFirstToken(), "Nested string templates, reduce", this.getMetadata().key, this.conf.severity));
                     }
+                    if (ts.findDirectExpression(Expressions.StringTemplateFormatting)) {
+                        continue;
+                    }
                     for (const constant of source.findDirectExpressions(Expressions.Constant)) {
                         for (const constantString of constant.findDirectExpressions(Expressions.ConstantString)) {
                             issues.push(issue_1.Issue.atToken(file, constantString.getFirstToken(), "Constant string in text template, reduce", this.getMetadata().key, this.conf.severity));
@@ -64977,6 +65103,81 @@ exports.SQLEscapeHostVariables = SQLEscapeHostVariables;
 
 /***/ }),
 
+/***/ "./node_modules/@abaplint/core/build/src/rules/sql_value_conversion.js":
+/*!*****************************************************************************!*\
+  !*** ./node_modules/@abaplint/core/build/src/rules/sql_value_conversion.js ***!
+  \*****************************************************************************/
+/***/ ((__unused_webpack_module, exports, __webpack_require__) => {
+
+"use strict";
+
+Object.defineProperty(exports, "__esModule", ({ value: true }));
+exports.SQLValueConversion = exports.SQLValueConversionConf = void 0;
+const issue_1 = __webpack_require__(/*! ../issue */ "./node_modules/@abaplint/core/build/src/issue.js");
+const _basic_rule_config_1 = __webpack_require__(/*! ./_basic_rule_config */ "./node_modules/@abaplint/core/build/src/rules/_basic_rule_config.js");
+const objects_1 = __webpack_require__(/*! ../objects */ "./node_modules/@abaplint/core/build/src/objects/index.js");
+const syntax_1 = __webpack_require__(/*! ../abap/5_syntax/syntax */ "./node_modules/@abaplint/core/build/src/abap/5_syntax/syntax.js");
+const _abap_object_1 = __webpack_require__(/*! ../objects/_abap_object */ "./node_modules/@abaplint/core/build/src/objects/_abap_object.js");
+class SQLValueConversionConf extends _basic_rule_config_1.BasicRuleConfig {
+}
+exports.SQLValueConversionConf = SQLValueConversionConf;
+class SQLValueConversion {
+    constructor() {
+        this.conf = new SQLValueConversionConf();
+    }
+    getMetadata() {
+        return {
+            key: "sql_value_conversion",
+            title: "Implicit SQL Value Conversion",
+            shortDescription: `Ensure types match when selecting from database`,
+            extendedInformation: `
+* Integer to CHAR conversion
+* Integer to NUMC conversion
+* NUMC to Integer conversion
+* CHAR to Integer conversion
+* Source field longer than database field, CHAR -> CHAR
+* Source field longer than database field, NUMC -> NUMC`,
+            tags: [],
+        };
+    }
+    getConfig() {
+        return this.conf;
+    }
+    setConfig(conf) {
+        this.conf = conf;
+    }
+    initialize(reg) {
+        this.reg = reg;
+        return this;
+    }
+    run(obj) {
+        if (!(obj instanceof _abap_object_1.ABAPObject) || obj instanceof objects_1.Interface) {
+            return [];
+        }
+        // messages defined in sql_compare.ts
+        const issues = this.traverse(new syntax_1.SyntaxLogic(this.reg, obj).run().spaghetti.getTop());
+        return issues;
+    }
+    traverse(node) {
+        const ret = [];
+        for (const r of node.getData().sqlConversion) {
+            const file = this.reg.getFileByName(node.getIdentifier().filename);
+            if (file === undefined) {
+                continue;
+            }
+            ret.push(issue_1.Issue.atToken(file, r.token, r.message, this.getMetadata().key, this.getConfig().severity));
+        }
+        for (const c of node.getChildren()) {
+            ret.push(...this.traverse(c));
+        }
+        return ret;
+    }
+}
+exports.SQLValueConversion = SQLValueConversion;
+//# sourceMappingURL=sql_value_conversion.js.map
+
+/***/ }),
+
 /***/ "./node_modules/@abaplint/core/build/src/rules/start_at_tab.js":
 /*!*********************************************************************!*\
   !*** ./node_modules/@abaplint/core/build/src/rules/start_at_tab.js ***!

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@abaplint/cli",
-    "version": "2.100.5",
+    "version": "2.101.0",
     "description": "abaplint - Command Line Interface",
     "funding": "https://github.com/sponsors/larshp",
     "bin": {
@@ -38,7 +38,7 @@
     },
     "homepage": "https://abaplint.org",
     "devDependencies": {
-        "@abaplint/core": "^2.100.5",
+        "@abaplint/core": "^2.101.0",
         "@types/chai": "^4.3.5",
         "@types/glob": "^7.2.0",
         "@types/minimist": "^1.2.2",
@@ -47,7 +47,7 @@
         "@types/progress": "^2.0.5",
         "chai": "^4.3.7",
         "chalk": "^5.2.0",
-        "eslint": "^8.40.0",
+        "eslint": "^8.41.0",
         "glob": "^7.2.3",
         "json5": "^2.2.3",
         "memfs": "^3.5.1",