@aaronshaf/ger 2.0.10 → 3.0.2

package/README.md

@@ -93,9 +93,6 @@ ger rebase 12345
 ger submit 12345
 ger restore 12345
 
-# AI-powered code review (requires claude, llm, or opencode CLI)
-ger review 12345
-ger review 12345 --dry-run  # Preview without posting
 ```
 
 ## Commands
@@ -711,29 +708,6 @@ ger groups-members project-reviewers --xml
 - Group IDs can be names, numeric IDs, or UUIDs
 - Use groups with `ger add-reviewer --group` to add entire teams as reviewers
 
-### AI-Powered Review
-
-The `ger review` command provides automated code review using AI tools (claude, llm, or opencode CLI).
-
-```bash
-# Full AI review with inline and overall comments
-ger review 12345
-
-# Preview what would be posted without actually posting
-ger review 12345 --dry-run
-
-# Show debug output including AI responses
-ger review 12345 --debug
-```
-
-The review command performs a two-stage review process:
-1. **Inline comments**: Specific code issues with line-by-line feedback
-2. **Overall review**: High-level assessment and recommendations
-
-Requirements:
-- One of these AI tools must be installed: `claude`, `llm`, or `opencode`
-- Gerrit credentials must be configured (`ger setup`)
-
 ## Claude Code Skill
 
 This repository includes a Claude Code Agent Skill that teaches Claude how to work effectively with Gerrit using the ger CLI. The skill provides Claude with expertise in Gerrit workflows, command usage, and best practices.

package/docs/prd/architecture.md

@@ -6,16 +6,16 @@
 ┌─────────────────────────────────────────────────────────────┐
 │                         CLI Layer                           │
 │  ┌─────────┐ ┌─────────┐ ┌─────────┐ ┌─────────┐           │
-│  │  show   │ │ comment │ │  push   │ │ review  │  ...      │
+│  │  show   │ │ comment │ │  push   │ │  vote   │  ...      │
 │  └────┬────┘ └────┬────┘ └────┬────┘ └────┬────┘           │
 └───────┼───────────┼───────────┼───────────┼─────────────────┘
         │           │           │           │
 ┌───────┴───────────┴───────────┴───────────┴─────────────────┐
 │                      Service Layer                          │
-│  ┌──────────────┐ ┌──────────────┐ ┌──────────────┐        │
-│  │ GerritApi    │ │ ConfigService│ │ ReviewStrategy│        │
-│  │ Service      │ │              │ │              │        │
-│  └──────────────┘ └──────────────┘ └──────────────┘        │
+│  ┌──────────────┐ ┌──────────────┐                         │
+│  │ GerritApi    │ │ ConfigService│                         │
+│  │ Service      │ │              │                         │
+│  └──────────────┘ └──────────────┘                         │
 └───────┬───────────────────────────────────────────────────────┘
         │
 ┌───────┴─────────────────────────────────────────────────────┐
@@ -46,7 +46,6 @@ src/
 │
 ├── services/              # Business logic services
 │   ├── config.ts          # Configuration management
-│   ├── review-strategy.ts # AI tool strategies
 │   ├── git-worktree.ts    # Git worktree operations
 │   └── commit-hook.ts     # Gerrit hook installation
 │
@@ -59,12 +58,7 @@ src/
 │   ├── git-commit.ts      # Git operations
 │   ├── formatters.ts      # Output formatting
 │   ├── shell-safety.ts    # XML/CDATA handling
-│   └── ... (diff, comment, review utils)
-│
-├── prompts/               # AI review prompts
-│   ├── default-review.md
-│   ├── system-inline-review.md
-│   └── system-overall-review.md
+│   └── ... (diff, comment utils)
 │
 └── i18n/                  # Internationalization (planned)
 
@@ -207,42 +201,6 @@ User: echo '...' | ger comment 12345
        Success/Error
 ```
 
-## AI Integration Flow
-
-```
-User: ger review 12345
-         │
-         ▼
-┌─────────────────────┐
-│ Fetch change diff   │
-│ (API: GET /patch)   │
-└─────────┬───────────┘
-          │
-          ▼
-┌─────────────────────┐
-│ Detect AI tool      │
-│ (claude/llm/etc)    │
-└─────────┬───────────┘
-          │
-          ▼
-┌─────────────────────┐     ┌─────────────────────┐
-│ Stage 1: Inline     │────►│ AI: Generate inline │
-│ comments            │     │ comments JSON       │
-└─────────┬───────────┘     └─────────────────────┘
-          │
-          ▼
-┌─────────────────────┐     ┌─────────────────────┐
-│ Stage 2: Overall    │────►│ AI: Generate        │
-│ review              │     │ summary             │
-└─────────┬───────────┘     └─────────────────────┘
-          │
-          ▼
-┌─────────────────────┐
-│ API: POST /review   │
-│ (all comments)      │
-└─────────────────────┘
-```
-
 ## Configuration Architecture
 
 ```

package/docs/prd/commands.md

@@ -28,7 +28,65 @@ ger show              # Auto-detect from HEAD
 - Full diff
 - All comments with context
 
-Reviewer listing for a specific change is provided by `show` (there is no separate `list-reviewers` command).
+### files
+
+List files changed in a change.
+
+```bash
+ger files [change-id]
+ger files 12345
+ger files              # Auto-detect from HEAD
+ger files 12345 --json
+ger files 12345 --xml
+```
+
+| Option | Description |
+|--------|-------------|
+| `--json` | Output as JSON |
+| `--xml` | Output as XML for LLM consumption |
+
+**Output:** One file per line with status prefix (`M` modified, `A` added, `D` deleted, `R` renamed). Magic files (`/COMMIT_MSG`, `/MERGE_LIST`, `/PATCHSET_LEVEL`) are filtered out.
+
+**JSON output:**
+```json
+{
+  "status": "success",
+  "change_id": "12345",
+  "files": [
+    { "path": "src/foo.ts", "status": "M", "lines_inserted": 10, "lines_deleted": 2 }
+  ]
+}
+```
+
+### reviewers
+
+List reviewers on a change.
+
+```bash
+ger reviewers [change-id]
+ger reviewers 12345
+ger reviewers          # Auto-detect from HEAD
+ger reviewers 12345 --json
+ger reviewers 12345 --xml
+```
+
+| Option | Description |
+|--------|-------------|
+| `--json` | Output as JSON |
+| `--xml` | Output as XML for LLM consumption |
+
+**Output:** One reviewer per line in `Name <email>` format (or email alone for email-only accounts).
+
+**JSON output:**
+```json
+{
+  "status": "success",
+  "change_id": "12345",
+  "reviewers": [
+    { "account_id": 1001, "name": "Alice Smith", "email": "alice@example.com", "username": "alice" }
+  ]
+}
+```
 
 ### diff
 
@@ -121,6 +179,32 @@ ger restore <change-id>
 ger restore <change-id> -m "Needed after all"
 ```
 
+### set-ready
+
+Mark a WIP change as ready for review via the Gerrit REST API. Does not require a git push.
+
+```bash
+ger set-ready <change-id>
+ger set-ready <change-id> -m "Ready for another look"
+```
+
+| Option | Description |
+|--------|-------------|
+| `-m <message>` | Optional message to include with the status change |
+
+### set-wip
+
+Mark a change as work-in-progress via the Gerrit REST API. Does not require a git push.
+
+```bash
+ger set-wip <change-id>
+ger set-wip <change-id> -m "Still in progress"
+```
+
+| Option | Description |
+|--------|-------------|
+| `-m <message>` | Optional message to include with the status change |
+
 ### workspace
 
 View local git branch tracking information.
@@ -236,26 +320,6 @@ ger vote <change-id> --label "Custom-Label" +1
 | `--label <name> <score>` | Custom label vote |
 | `-m <message>` | Optional message with vote |
 
-### review
-
-AI-powered code review (multi-stage).
-
-```bash
-ger review <change-id>
-ger review <change-id> --tool claude  # Specific AI tool
-ger review  # Auto-detect change from HEAD
-```
-
-| Option | Description |
-|--------|-------------|
-| `--tool <name>` | AI tool (claude, llm, opencode, gemini) |
-| `--inline-only` | Only post inline comments |
-| `--overall-only` | Only post overall review |
-
-**Stages:**
-1. **Inline**: Generate line-specific comments
-2. **Overall**: Generate high-level assessment
-
 ### add-reviewer
 
 Add reviewers or groups to a change.

package/index.ts

@@ -61,25 +61,6 @@ export {
   type ConfigErrorFields,
 } from './src/services/config'
 
-// ============================================================================
-// Review Strategy Service
-// ============================================================================
-
-export {
-  // Strategy types
-  type ReviewStrategy,
-  // Built-in strategies
-  claudeCliStrategy,
-  geminiCliStrategy,
-  openCodeCliStrategy,
-  // Service
-  ReviewStrategyService,
-  ReviewStrategyServiceLive,
-  type ReviewStrategyServiceImpl,
-  // Errors
-  ReviewStrategyError,
-  type ReviewStrategyErrorFields,
-} from './src/services/review-strategy'
 
 // ============================================================================
 // Git Worktree Service

package/llms.txt

@@ -114,14 +114,6 @@ ger extract-url "build-summary-report" | tail -1   # Latest Jenkins URL
 ger extract-url "jenkins" --json | jq -r '.urls[-1]'
 ```
 
-### AI Review
-
-```bash
-ger review <change-id>              # AI-powered review (requires claude/gemini/opencode CLI)
-ger review <change-id> --tool claude
-ger review <change-id> --comment --yes  # Post review comments
-```
-
 ### Groups
 
 ```bash
@@ -179,12 +171,6 @@ ger comment 12345 -m "LGTM"        # Add comment
 ger vote 12345 --code-review +2    # Approve
 ```
 
-### Post AI review
-
-```bash
-ger review 12345 --comment --yes
-```
-
 ### Check build and get failures
 
 ```bash

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@aaronshaf/ger",
-  "version": "2.0.10",
+  "version": "3.0.2",
   "description": "Gerrit CLI and SDK - A modern CLI tool and TypeScript SDK for Gerrit Code Review, built with Effect-TS",
   "keywords": [
     "gerrit",
@@ -30,10 +30,6 @@
       "import": "./src/services/config.ts",
       "types": "./src/services/config.ts"
     },
-    "./services/review-strategy": {
-      "import": "./src/services/review-strategy.ts",
-      "types": "./src/services/review-strategy.ts"
-    },
     "./services/git-worktree": {
       "import": "./src/services/git-worktree.ts",
       "types": "./src/services/git-worktree.ts"

package/src/api/gerrit.ts

@@ -18,7 +18,9 @@ import {
   GroupDetailInfo,
   AccountInfo,
 } from '@/schemas/gerrit'
+import { ReviewerListItem } from '@/schemas/reviewer'
 import { filterMeaningfulMessages } from '@/utils/message-filters'
+import { convertToUnifiedDiff } from '@/utils/diff-formatters'
 import { ConfigService } from '@/services/config'
 import { normalizeChangeIdentifier } from '@/utils/change-id'
 
@@ -85,6 +87,7 @@ export interface GerritApiServiceImpl {
   readonly getGroup: (groupId: string) => Effect.Effect<GroupInfo, ApiError>
   readonly getGroupDetail: (groupId: string) => Effect.Effect<GroupDetailInfo, ApiError>
   readonly getGroupMembers: (groupId: string) => Effect.Effect<readonly AccountInfo[], ApiError>
+  readonly getReviewers: (changeId: string) => Effect.Effect<readonly ReviewerListItem[], ApiError>
   readonly removeReviewer: (
     changeId: string,
     accountId: string,
@@ -93,6 +96,8 @@ export interface GerritApiServiceImpl {
   readonly getTopic: (changeId: string) => Effect.Effect<string | null, ApiError>
   readonly setTopic: (changeId: string, topic: string) => Effect.Effect<string, ApiError>
   readonly deleteTopic: (changeId: string) => Effect.Effect<void, ApiError>
+  readonly setReady: (changeId: string, message?: string) => Effect.Effect<void, ApiError>
+  readonly setWip: (changeId: string, message?: string) => Effect.Effect<void, ApiError>
 }
 
 export const GerritApiService: Context.Tag<GerritApiServiceImpl, GerritApiServiceImpl> =
@@ -224,13 +229,8 @@ export const GerritApiServiceLive: Layer.Layer<GerritApiService, never, ConfigSe
           const { credentials, authHeader } = yield* getCredentialsAndAuth
           let url = `${credentials.host}/a/projects/`
           if (options?.pattern) url += `?p=${encodeURIComponent(options.pattern)}`
-          const projectsRecord = yield* makeRequest(
-            url,
-            authHeader,
-            'GET',
-            undefined,
-            Schema.Record({ key: Schema.String, value: ProjectInfo }),
-          )
+          const schema = Schema.Record({ key: Schema.String, value: ProjectInfo })
+          const projectsRecord = yield* makeRequest(url, authHeader, 'GET', undefined, schema)
           return Object.values(projectsRecord).sort((a, b) => a.name.localeCompare(b.name))
         })
 
@@ -455,39 +455,6 @@ export const GerritApiServiceLive: Layer.Layer<GerritApiService, never, ConfigSe
           return yield* getPatch(changeId, revisionId)
         })
 
-      const convertToUnifiedDiff = (diff: FileDiffContent, filePath: string): string => {
-        const lines: string[] = []
-
-        if (diff.diff_header) {
-          lines.push(...diff.diff_header)
-        } else {
-          lines.push(`--- a/${filePath}`)
-          lines.push(`+++ b/${filePath}`)
-        }
-
-        for (const section of diff.content) {
-          if (section.ab) {
-            for (const line of section.ab) {
-              lines.push(` ${line}`)
-            }
-          }
-
-          if (section.a) {
-            for (const line of section.a) {
-              lines.push(`-${line}`)
-            }
-          }
-
-          if (section.b) {
-            for (const line of section.b) {
-              lines.push(`+${line}`)
-            }
-          }
-        }
-
-        return lines.join('\n')
-      }
-
       const getComments = (changeId: string, revisionId = 'current') =>
         Effect.gen(function* () {
           const { credentials, authHeader } = yield* getCredentialsAndAuth
@@ -611,6 +578,15 @@ export const GerritApiServiceLive: Layer.Layer<GerritApiService, never, ConfigSe
           return yield* makeRequest(url, authHeader, 'GET', undefined, Schema.Array(AccountInfo))
         })
 
+      const getReviewers = (changeId: string) =>
+        Effect.gen(function* () {
+          const { credentials, authHeader } = yield* getCredentialsAndAuth
+          const normalized = yield* normalizeAndValidate(changeId)
+          const url = `${credentials.host}/a/changes/${encodeURIComponent(normalized)}/reviewers`
+          const schema = Schema.Array(ReviewerListItem)
+          return yield* makeRequest(url, authHeader, 'GET', undefined, schema)
+        })
+
       const removeReviewer = (
         changeId: string,
         accountId: string,
@@ -667,6 +643,24 @@ export const GerritApiServiceLive: Layer.Layer<GerritApiService, never, ConfigSe
           yield* makeRequest(getTopicUrl(credentials.host, normalized), authHeader, 'DELETE')
         })
 
+      const setReady = (changeId: string, message?: string) =>
+        Effect.gen(function* () {
+          const { credentials, authHeader } = yield* getCredentialsAndAuth
+          const normalized = yield* normalizeAndValidate(changeId)
+          const url = `${credentials.host}/a/changes/${encodeURIComponent(normalized)}/ready`
+          const body = message ? { message } : {}
+          yield* makeRequest(url, authHeader, 'POST', body)
+        })
+
+      const setWip = (changeId: string, message?: string) =>
+        Effect.gen(function* () {
+          const { credentials, authHeader } = yield* getCredentialsAndAuth
+          const normalized = yield* normalizeAndValidate(changeId)
+          const url = `${credentials.host}/a/changes/${encodeURIComponent(normalized)}/wip`
+          const body = message ? { message } : {}
+          yield* makeRequest(url, authHeader, 'POST', body)
+        })
+
       return {
         getChange,
         listChanges,
@@ -686,6 +680,7 @@ export const GerritApiServiceLive: Layer.Layer<GerritApiService, never, ConfigSe
         getComments,
         getMessages,
         addReviewer,
+        getReviewers,
         listGroups,
         getGroup,
         getGroupDetail,
@@ -694,6 +689,8 @@ export const GerritApiServiceLive: Layer.Layer<GerritApiService, never, ConfigSe
         getTopic,
         setTopic,
         deleteTopic,
+        setReady,
+        setWip,
       }
     }),
   )

package/src/cli/commands/files.ts

@@ -0,0 +1,86 @@
+import { Effect } from 'effect'
+import { type ApiError, GerritApiService } from '@/api/gerrit'
+import { GitError, NoChangeIdError, getChangeIdFromHead } from '@/utils/git-commit'
+import { escapeXML, sanitizeCDATA } from '@/utils/shell-safety'
+
+const MAGIC_FILES = new Set(['/COMMIT_MSG', '/MERGE_LIST', '/PATCHSET_LEVEL'])
+
+interface FilesOptions {
+  xml?: boolean
+  json?: boolean
+}
+
+export const filesCommand = (
+  changeId?: string,
+  options: FilesOptions = {},
+): Effect.Effect<void, never, GerritApiService> =>
+  Effect.gen(function* () {
+    const gerritApi = yield* GerritApiService
+    const resolvedChangeId = changeId || (yield* getChangeIdFromHead())
+
+    const filesRecord = yield* gerritApi.getFiles(resolvedChangeId)
+    const files = Object.entries(filesRecord)
+      .filter(([path]) => !MAGIC_FILES.has(path))
+      .map(([path, info]) => ({
+        path,
+        status: info.status ?? 'M',
+        lines_inserted: info.lines_inserted ?? 0,
+        lines_deleted: info.lines_deleted ?? 0,
+      }))
+
+    if (options.json) {
+      console.log(
+        JSON.stringify(
+          {
+            status: 'success',
+            change_id: resolvedChangeId,
+            files,
+          },
+          null,
+          2,
+        ),
+      )
+    } else if (options.xml) {
+      console.log(`<?xml version="1.0" encoding="UTF-8"?>`)
+      console.log(`<files_result>`)
+      console.log(`  <status>success</status>`)
+      console.log(`  <change_id><![CDATA[${sanitizeCDATA(resolvedChangeId)}]]></change_id>`)
+      console.log(`  <files>`)
+      for (const file of files) {
+        console.log(`    <file>`)
+        console.log(`      <path><![CDATA[${sanitizeCDATA(file.path)}]]></path>`)
+        console.log(`      <status>${escapeXML(file.status)}</status>`)
+        console.log(`      <lines_inserted>${file.lines_inserted}</lines_inserted>`)
+        console.log(`      <lines_deleted>${file.lines_deleted}</lines_deleted>`)
+        console.log(`    </file>`)
+      }
+      console.log(`  </files>`)
+      console.log(`</files_result>`)
+    } else {
+      for (const file of files) {
+        console.log(`${file.status} ${file.path}`)
+      }
+    }
+  }).pipe(
+    Effect.catchAll((error: ApiError | GitError | NoChangeIdError) =>
+      Effect.sync(() => {
+        const errorMessage =
+          error instanceof GitError || error instanceof NoChangeIdError || error instanceof Error
+            ? error.message
+            : String(error)
+
+        if (options.json) {
+          console.log(JSON.stringify({ status: 'error', error: errorMessage }, null, 2))
+        } else if (options.xml) {
+          console.log(`<?xml version="1.0" encoding="UTF-8"?>`)
+          console.log(`<files_result>`)
+          console.log(`  <status>error</status>`)
+          console.log(`  <error><![CDATA[${sanitizeCDATA(errorMessage)}]]></error>`)
+          console.log(`</files_result>`)
+        } else {
+          console.error(`✗ Error: ${errorMessage}`)
+        }
+        process.exit(1)
+      }),
+    ),
+  )

package/src/cli/commands/reviewers.ts

@@ -0,0 +1,95 @@
+import { Effect } from 'effect'
+import { type ApiError, GerritApiService } from '@/api/gerrit'
+import { GitError, NoChangeIdError, getChangeIdFromHead } from '@/utils/git-commit'
+import { sanitizeCDATA } from '@/utils/shell-safety'
+import type { ReviewerListItem } from '@/schemas/reviewer'
+
+interface ReviewersOptions {
+  xml?: boolean
+  json?: boolean
+}
+
+function formatReviewer(r: ReviewerListItem): string {
+  const name =
+    r.name ?? r.username ?? (r._account_id !== undefined ? `#${r._account_id}` : undefined)
+  if (name !== undefined) return r.email ? `${name} <${r.email}>` : name
+  return r.email ?? 'unknown'
+}
+
+export const reviewersCommand = (
+  changeId?: string,
+  options: ReviewersOptions = {},
+): Effect.Effect<void, never, GerritApiService> =>
+  Effect.gen(function* () {
+    const gerritApi = yield* GerritApiService
+    const resolvedChangeId = changeId || (yield* getChangeIdFromHead())
+
+    const reviewers = yield* gerritApi.getReviewers(resolvedChangeId)
+
+    if (options.json) {
+      console.log(
+        JSON.stringify(
+          {
+            status: 'success',
+            change_id: resolvedChangeId,
+            reviewers: reviewers.map((r) => ({
+              ...(r._account_id !== undefined ? { account_id: r._account_id } : {}),
+              name: r.name,
+              email: r.email,
+              username: r.username,
+            })),
+          },
+          null,
+          2,
+        ),
+      )
+    } else if (options.xml) {
+      console.log(`<?xml version="1.0" encoding="UTF-8"?>`)
+      console.log(`<reviewers_result>`)
+      console.log(`  <status>success</status>`)
+      console.log(`  <change_id><![CDATA[${sanitizeCDATA(resolvedChangeId)}]]></change_id>`)
+      console.log(`  <reviewers>`)
+      for (const r of reviewers) {
+        console.log(`    <reviewer>`)
+        if (r._account_id !== undefined)
+          console.log(`      <account_id>${r._account_id}</account_id>`)
+        if (r.name) console.log(`      <name><![CDATA[${sanitizeCDATA(r.name)}]]></name>`)
+        if (r.email) console.log(`      <email><![CDATA[${sanitizeCDATA(r.email)}]]></email>`)
+        if (r.username)
+          console.log(`      <username><![CDATA[${sanitizeCDATA(r.username)}]]></username>`)
+        console.log(`    </reviewer>`)
+      }
+      console.log(`  </reviewers>`)
+      console.log(`</reviewers_result>`)
+    } else {
+      if (reviewers.length === 0) {
+        console.log('No reviewers')
+      } else {
+        for (const r of reviewers) {
+          console.log(formatReviewer(r))
+        }
+      }
+    }
+  }).pipe(
+    Effect.catchAll((error: ApiError | GitError | NoChangeIdError) =>
+      Effect.sync(() => {
+        const errorMessage =
+          error instanceof GitError || error instanceof NoChangeIdError || error instanceof Error
+            ? error.message
+            : String(error)
+
+        if (options.json) {
+          console.log(JSON.stringify({ status: 'error', error: errorMessage }, null, 2))
+        } else if (options.xml) {
+          console.log(`<?xml version="1.0" encoding="UTF-8"?>`)
+          console.log(`<reviewers_result>`)
+          console.log(`  <status>error</status>`)
+          console.log(`  <error><![CDATA[${sanitizeCDATA(errorMessage)}]]></error>`)
+          console.log(`</reviewers_result>`)
+        } else {
+          console.error(`✗ Error: ${errorMessage}`)
+        }
+        process.exit(1)
+      }),
+    ),
+  )